TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
57,740 Commits 2 Branches 0 Tags 294 MiB
ab56c92f3c
Commit Graph

57740 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jeremy Daer
b3749f31d2 Merge pull request #24602 from prathamesh-sonpatki/add-note-about-db-comments-in-release-notes 
Add note about ability to add database comments to release notes [ci skip]
 2016-04-17 22:34:30 -07:00
Andrey Novikov
1bf9fe75a6
Change 1.week to create 1 week durations instead of 7 days durations. 
This is just to remove astonishment from getting `3600 seconds` from typing `1.hour`.
 2016-04-18 08:33:40 +03:00
Jeremy Daer
781271b3b0 Merge pull request #24601 from prathamesh-sonpatki/fix-ar-changelog 
Move CHANGELOG entry about database notices at the top [ci skip]
 2016-04-17 22:30:52 -07:00
Prathamesh Sonpatki
88bba86632
Add note about ability to add database comments to release notes [ci skip] 2016-04-18 10:43:21 +05:30
Prathamesh Sonpatki
dbaef766fb
Move CHANGELOG entry about database notices at the top [ci skip] 2016-04-18 10:37:17 +05:30
Rafael França
847084e046 Merge pull request #24595 from maclover7/jm-cleanup-2 
Specify that behavior will be deprecated in Rails 5.1
 2016-04-17 19:25:51 -03:00
Jeremy Daer
5154701e20 Merge pull request #24551 from bogdanvlviv/notice_for_tasks 
Added notice when a database is successfully created or dropped.
 2016-04-17 15:21:43 -07:00
bogdanvlviv
26861302c9 Added notice when a database is successfully created or dropped. 2016-04-17 23:12:16 +03:00
Jon Moss
bca2e69b78 Specify that behavior will be deprecated in Rails 5.1 2016-04-17 15:04:10 -04:00
Jeremy Daer
2c8e0bba4b Merge pull request #24582 from vipulnsward/stop-passing-unused-payloads-to-instrumentation 
Stop passing unused payloads to instrumentation block in cache
 2016-04-17 11:30:38 -07:00
Richard Schneeman
7365c976a0 Merge pull request #24592 from vipulnsward/properly-verify-expires 
Properly verify that cache accepts and uses `expires` value.
 2016-04-17 13:05:10 -05:00
Vipul A M
3a24247b95 Properly verify that cache accepts and user expires value. 2016-04-17 23:12:04 +05:30
Akira Matsuda
1386d14112 Merge pull request #24591 from vipulnsward/test-partial-name-with-unicode 
Add render allows unicode text name in partials - 🍣
 2016-04-18 01:12:19 +09:00
Vipul A M
519035c909 Add render allows unicode text name in partials - 🍣 2016-04-17 19:18:50 +05:30
Santosh Wadghule
46269effc3 Document consistency [ci skip] 2016-04-17 16:48:00 +05:30
Vipul A M
58fc343eaa Stop passing unused payloads to instrumentation block in cache 2016-04-17 11:23:30 +05:30
Jeremy Daer
3b0a627a94 Merge pull request #22911 from Envek/database_comments 
Add support for specifying comments for tables, columns, and indexes in database itself
 2016-04-16 22:19:47 -07:00
Jeremy Daer
4c4dd06aa6 Merge pull request #24574 from y-yagi/donot_remove_cable.js 
don't remove `cable.js` when a channel is removed
 2016-04-16 16:24:43 -07:00
yui-knk
29e876f775 Raise ArgumentError when an invalid form is passed to Date#to_time 
Before this commit
`NoMethodError: undefined method `form_name' for Time:Class` is raised
when an invalid argument is passed.
It is better to raise `ArgumentError` and show list of valid arguments
to developers.
 2016-04-17 08:23:20 +09:00
Vipul A M
bca1872198 documentation for add_references index option [ci skip] 
documentation for add_references index option [ci skip]
 2016-04-17 02:06:25 +05:30
Alex Handley
d9565811f0
[ci skip] docs for add_references index option 
- Add link for finding the addional options for index.
- Add example for unique index as this is a common requirement.
- Add link in guide for index options.
 2016-04-16 21:32:22 +01:00
Vipul A M
ddb4636d24 Add test to verify named unique index, when creating reference via add_reference 2016-04-16 20:44:08 +05:30
Yasuo Honda
8a4a8b2aca Address ORA-00923 error by quoting a reserved word "SIZE" 2016-04-16 10:02:49 +00:00
Andrey Novikov
c690b9ce39
Add support for specifying comments for tables, columns, and indexes. 
Comments are specified in migrations, stored in database itself (in its schema),
and dumped into db/schema.rb file.

This allows to generate good documentation and explain columns and tables' purpose
to everyone from new developers to database administrators.

For PostgreSQL and MySQL only. SQLite does not support comments at the moment.

See docs for PostgreSQL: http://www.postgresql.org/docs/current/static/sql-comment.html
See docs for MySQL: http://dev.mysql.com/doc/refman/5.7/en/create-table.html
 2016-04-16 10:17:26 +03:00
yuuji.yaginuma
aa757d0c11 don't remove cable.js 
`cable.js` is required for other Channels.
 2016-04-16 15:19:41 +09:00
Edouard CHIN
106ac1016f Small typo on a method name: 
- clear_test_deliviers -> clear_test_deliveries
 2016-04-15 13:27:09 -04:00
Kasper Timm Hansen
39e087cbf5 Merge pull request #24565 from javiervidal/rails_update_task 
Add TIP about app:update task in 'A Guide for Upgrading Ruby on Rails'
 2016-04-15 19:09:41 +02:00
Jeremy Daer
f885587cc7 Merge pull request #24556 from vipulnsward/24542-changelog 
Add changelog for #24542
 2016-04-15 10:02:33 -07:00
Jeremy Daer
92182d0d5b Merge pull request #24559 from vipulnsward/fix-ac-tests 
Fixed ActionCable::Connection::ClientSocketTest test
 2016-04-15 09:51:09 -07:00
Javier Vidal
600a81a9e7 Add a note about how to execute 'rails app:update' on 4.2 and earlier [ci skip] 2016-04-15 18:04:15 +02:00
Sean Griffin
b0d7ac0ff7 Merge pull request #24517 from estolfo/transform-keys-return-type-master 
Restore Hash#transform_keys behavior to always return a Hash instance
 2016-04-15 09:25:02 -06:00
Sean Griffin
94a1edbc02 Filter scalar values when params permit hashes or arrays 
This brings the behavior more inline with other similar cases, such as
receiving a hash when an array of scalars was expected. Prior to this
commit, the key would be present, but the value would be `nil`
 2016-04-15 09:09:50 -06:00
प्रथमेश Sonpatki
b1f4c4bbcf Merge pull request #24560 from javiervidal/20160415 
Fix broken link in 'Ruby on Rails 4.0 Release Notes'
 2016-04-15 17:04:11 +05:30
Javier Vidal
14783cf569 Fix broken link in 'Ruby on Rails 4.0 Release Notes' [ci skip] 2016-04-15 13:15:03 +02:00
Vipul A M
02a31cfdd1 - Fixed ActionCable::Connection::ClientSocketTest that was overriding ActionCable::Connection::StreamTest test name 
- Only add attr_readers for required attributes
 2016-04-15 16:03:21 +05:30
Vipul A M
8ad9670abb Merge pull request #24557 from y-yagi/update_example_to_specify_ac_mount_path 
update example to specify the Action Cable mount path [ci skip]
 2016-04-15 16:00:42 +05:30
yuuji.yaginuma
a2f034335d update example to specify the Action Cable mount path [ci skip] 
Follow up to 8b69f1e
 2016-04-15 19:16:01 +09:00
Vipul A M
65a7e90cc1 Add changelog for #24542 
[ci skip]
 2016-04-15 12:06:56 +05:30
Jeremy Daer
a2de667b2e Merge pull request #24549 from kamipo/fix_quoted_time 
Should keep quoting behaivor of a time column value in sqlite3 adapter
 2016-04-14 21:41:07 -07:00
Ryuta Kamizono
73af7945d5 Should keep quoting behaivor of a time column value in sqlite3 adapter 
Follow up to #24542.

In MySQL and PostgreSQL, a time column value is saved as ignored the
date part of it. But in SQLite3, a time column value is saved as a string.

We should keep previous quoting behavior in sqlite3 adapter.

```
sqlite> CREATE TABLE "foos" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "start" time(0), "finish" time(4));
sqlite> INSERT INTO "foos" ("start", "finish") VALUES ('2000-01-01 12:30:00', '2000-01-01 12:30:00.999900');
sqlite> SELECT "foos".* FROM "foos";
1|2000-01-01 12:30:00|2000-01-01 12:30:00.999900
sqlite> SELECT  "foos".* FROM "foos" WHERE "foos"."start" = '2000-01-01 12:30:00' LIMIT 1;
1|2000-01-01 12:30:00|2000-01-01 12:30:00.999900
sqlite> SELECT  "foos".* FROM "foos" WHERE "foos"."start" = '12:30:00' LIMIT 1;
sqlite>
```
 2016-04-15 03:45:02 +09:00
Sean Griffin
4769fc4b4d Merge pull request #24540 from sgrif/sg-actioncable-callbacks 
Run Action Cable callbacks through the worker pool
 2016-04-14 11:25:08 -06:00
Vipul A M
91798c75bc Merge pull request #24454 from iangilfillan/master 
MariaDB documentation [ci skip]
 2016-04-14 18:36:08 +05:30
iangilfillan
48ef9408bc MariaDB Documentation 2016-04-14 14:06:29 +02:00
Jeremy Daer
53ab1ee565 Merge pull request #24542 from kamipo/add_quoted_time 
Add `quoted_time` for truncating the date part of a time column value
 2016-04-13 22:30:35 -07:00
Ryuta Kamizono
28ec8c4a57 Add quoted_time for truncating the date part of a time column value 
Context #24522.

TIME column on MariaDB doesn't ignore the date part of the string when
it coerces to time.

```
root@localhost [test] > CREATE TABLE `foos` (`id` int AUTO_INCREMENT PRIMARY KEY, `start` time(0), `finish` time(4)) ENGINE=InnoDB;
Query OK, 0 rows affected (0.02 sec)

root@localhost [test] > INSERT INTO `foos` (`start`, `finish`) VALUES ('2000-01-01 12:30:00', '2000-01-01 12:30:00.999900');
Query OK, 1 row affected, 2 warnings (0.00 sec)

Note (Code 1265): Data truncated for column 'start' at row 1
Note (Code 1265): Data truncated for column 'finish' at row 1
root@localhost [test] > SELECT `foos`.* FROM `foos`;
+----+----------+---------------+
| id | start    | finish        |
+----+----------+---------------+
|  1 | 12:30:00 | 12:30:00.9999 |
+----+----------+---------------+
1 row in set (0.00 sec)

root@localhost [test] > SELECT  `foos`.* FROM `foos` WHERE `foos`.`start` = '2000-01-01 12:30:00' LIMIT 1;
Empty set (0.00 sec)

root@localhost [test] > SELECT  `foos`.* FROM `foos` WHERE `foos`.`start` = '12:30:00' LIMIT 1;
+----+----------+---------------+
| id | start    | finish        |
+----+----------+---------------+
|  1 | 12:30:00 | 12:30:00.9999 |
+----+----------+---------------+
1 row in set (0.00 sec)
```
 2016-04-14 14:22:16 +09:00
Jeremy Daer
128923ca14 Merge pull request #24522 from vipulnsward/run-mariadb-on-travis 
Test against MariaDB 10.0
 2016-04-13 22:18:54 -07:00
Richard Schneeman
ad87acf8b2 Merge pull request #24543 from prathamesh-sonpatki/fix-ap-changelog 
[ci skip] Remove extra `so` from the Action Pack CHANGELOG
 2016-04-13 21:08:53 -07:00
Prathamesh Sonpatki
64b115b451
[ci skip] Remove extra so from the Action Pack CHANGELOG 2016-04-14 09:19:34 +05:30
Vipul A M
bbb8f518b5 Include running mariadb on travis 
- Specify we want to run on latest stable ruby for mariadb

- change in runs of builds

Make mariadb? method publicly available
 2016-04-14 04:42:41 +05:30
Sean Griffin
977be6d51e Merge pull request #24533 from vipulnsward/nodoc-version 
:nodoc: version method.
 2016-04-13 15:34:47 -06:00