TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
63,217 Commits 2 Branches 0 Tags 294 MiB
ac717d65a3
Commit Graph

5037 Commits

Author SHA1 Message Date
Lisa Ugray
ec4a836919 Protect from forgery by default 
Rather than protecting from forgery in the generated
ApplicationController, add it to ActionController::Base by config. This
configuration defaults to false to support older versions which have
removed it from their ApplicationController, but is set to true for
Rails 5.2.
 2017-07-10 16:23:47 -04:00
Daniel Castro
4f7b7c9879 [ci skip] Updated language on validations. 2017-07-09 12:15:56 -04:00
Sage Ross
6a8d618b59 Clarify i18n guide for how pluralization rules work by default 
The guide misleadingly indicates that the I18n gem will apply the CLDR pluralization rules for each language. This is not the case; only the English algorithm, with support for :zero, :one, and :other, is available by default. Locale-specific pluralization rules require additional configuration and must be supplied by the application (or by another gem).
 2017-07-07 23:10:23 -07:00
Arun Agrawal
6f2b0eb44a Merge pull request #29668 from y-yagi/add_missing_status_code_and_symbol 
Add missing http status codes [ci skip]
 2017-07-04 09:39:13 +05:30
yuuji.yaginuma
b692955214 Add missing http status codes [ci skip] 
Ref: 5401f776f6,
73e08279d4
 2017-07-04 12:59:05 +09:00
Matthew Draper
87b3e226d6 Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 
This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing
changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
 2017-07-02 02:15:17 +09:30
Matthew Draper
3420a14590 Merge pull request #29540 from kirs/rubocop-frozen-string 
Enforce frozen string in Rubocop
 2017-07-02 01:11:50 +09:30
Eileen M. Uchitelle
6189086c01 Merge pull request #29534 from y-yagi/clear_screenshots_in_tmp_clear_task 
Clear screenshots files in `tmp:clear` task
 2017-07-01 10:15:37 -04:00
Kir Shatrov
cfade1ec7e Enforce frozen string in Rubocop 2017-07-01 02:11:03 +03:00
Sai Prashanth
05602968b9 [ci skip] run migration before looking at schema 2017-06-30 16:27:00 +05:30
Jorge Dias
1f48de101b Specify correct extension for text layouts 
When using render plain the extension for the layout needs to be .text.erb instead of .txt.erb
 2017-06-29 00:16:41 +02:00
James Bush
fd54d8449a Fix grammar for documentation of rails/command.rb [ci skip] 2017-06-28 13:06:57 -04:00
Marc Rendl Ignacio
927e986219 Document ActiveRecord's PostgreSQL-specific support for JSONB datatype in RailsGuides 
[ci skip]
 2017-06-27 17:11:50 +08:00
yuuji.yaginuma
6fbd405a2e Clear screenshots files in tmp:clear task 
If system test fails, it creates screenshot under `tmp/screenshots`.
34fe2a4fc7/actionpack/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb (L45)

But currently, screenshot files is not cleared by `tmp:clear` task.
This patch make clears screenshot files with `tmp:clear` task as well
as other tmp files.
 2017-06-27 07:13:00 +09:00
Yauheni Dakuka
dafe3f82cf Update security.md 2017-06-26 22:17:16 +03:00
Yong Bakos
4d433f8d21 Guides: Clarify partial local variable naming. 
Clarify the partial local variable name as being the same as the name
of the partial, minus the _leading_ underscore.
 2017-06-23 22:44:55 -07:00
Eileen M. Uchitelle
55a443b847 Merge pull request #29524 from y-yagi/do_not_use_private_api_in_bug_report_templates 
Do not use private API in bug report templates
 2017-06-22 08:48:37 -04:00
Abraham Chan
3b308f3321 Fix hash conditions documentation [ci skip] 2017-06-22 14:10:17 +10:00
yuuji.yaginuma
2dafc4be22 Do not use private API in bug report templates 
`ActiveRecord::Migrator` is private API.
bb9d6eb094/activerecord/lib/active_record/migration.rb (L977)

Therefore, it is not good to use it in bug report templates.
Instead, should use the public API `ActiveRecord::Migration#migrate`.
 2017-06-22 08:08:45 +09:00
Akira Matsuda
0f89fdcf25 Shrink image files in the guides using ImageOptim 2017-06-21 01:39:36 +09:00
Prathamesh Sonpatki
f006edeb94
[ci skip] Fixed the attribute name for event.detail 2017-06-20 20:52:25 +05:30
Rafael França
c6d19fc851 Merge pull request #29493 from y-yagi/deprecate_capify 
Deprecate an `capify!` method in generators and templates
 2017-06-19 16:07:10 -04:00
yuuji.yaginuma
e062c961e9 Deprecate an capify! method in generators and templates 
The `capify` command has been removed by Capistrano 3 and became to
`cap install`.
Therefore, the `capify!` method has no meaning in Capistrano 3.
I think that should deprecate.

Ref: 492793916a
 2017-06-18 16:51:03 +09:00
utilum
133236fa0a [ci skip] Update fedora SQLite3 package name 2017-06-17 12:37:42 +02:00
Vipul A M
019c7f92f0 Remove references to deprecared raise_runtime_errors from documentation, which is always enabled now. Ref: 655b93bffc and https://github.com/rails/rails/pull/24070 . Fixes #29483 [ci skip] (#29484) 2017-06-17 03:05:37 +05:30
Dmytro Vasin
0cd957ef45 Updated working with javascript readme to support the behavior of rails-ujs. 2017-06-15 08:18:38 +03:00
Vipul A M
8426978c54 Add brakeman to guides/additional resources. Fixes #29383 [ci skip] (#29427) 2017-06-12 18:40:36 +05:30
Vipul A M
76bb366024 Missing dots [ci skip] (#29414) 2017-06-11 17:51:08 +05:30
Vipul A M
1d2cc1324e Merge pull request #29268 from gsamokovarov/delegate-missing-to-guides 
Document Module#delegate_missing_to in the guides [ci skip]
 2017-06-11 17:40:28 +05:30
Genadi Samokovarov
43512df990 Document Module#delegate_missing_to in the guides 
Added a small section for it in the `Active Support Core Extensions`
guide. [ci skip]
 2017-06-11 14:00:51 +03:00
Yohei Yasukawa
58de07f70d
[ci skip] Add backquote to :counter_cache option 2017-06-10 11:42:21 +09:00
Yauheni Dakuka
da783d9571 [ci skip] Fix link in active_record_postgresql.md 2017-06-09 15:32:42 +03:00
Vipul A M
9d7714f8c4 Merge pull request #29397 from ydakuka/patch-1 
Fix link in active_record_postgresql.md [ci skip]
 2017-06-09 17:29:22 +05:30
Yauheni Dakuka
3910002dea remove the extra comma in association_basics.md 2017-06-09 14:54:28 +03:00
Yauheni Dakuka
7586919572 Fix link in active_record_postgresql.md 2017-06-09 14:45:08 +03:00
edwardmp
f59559d70a Update upgrading guide w.r.t. Parameters to use other example method than slice as this has actually been implemented by Parameters 2017-06-06 23:54:45 +02:00
Robin Dupret
42198c5591 Remove invalid entry from the guides index page 
Commit 1a5d9399 removed the "Profiling Rails Applications" guide
but the YAML entry for this guide wasn't.

[ci skip]
 2017-06-06 17:36:02 +02:00
Robin Dupret
2759a53a54 Tiny documentation fixes [ci skip] 2017-06-06 17:36:02 +02:00
Joe Francis
7892b717a8 Remove deprecated passing of string to :if/:unless (#29357) 
Other examples were removed in 53ff5fc62f9d11b6f60d371df959137f4bf40728

[ci skip]
 2017-06-06 02:04:40 +09:30
Genadi Samokovarov
b6b0c99ff3 Use mattr_accessor default: option throughout the project 2017-06-03 13:52:48 +03:00
Koichi ITO
116b70ca7d Change default application.js included in new Rails app [ci skip] 2017-06-03 17:32:30 +09:00
Eileen M. Uchitelle
35084dbe88 Merge pull request #29101 from ccarruitero/system_guide 
some typos and rephrasing in system test guide [ci skip]
 2017-06-02 14:57:47 -04:00
Eileen M. Uchitelle
e935a6c0be Merge pull request #29315 from mariochavez/driven_by_support_headless_drivers 
SystemTesting::Driver can register capybara-webkit and poltergeist
 2017-06-02 13:30:59 -04:00
Mario Alberto Chávez
9063007538 SystemTesting::Driver can register capybara-webkit and poltergeist 
drivers.

When using `driver_by` with capybara-webkit or poltergeist,
SystemTesting::Driver will register the driver while passing
`screen_size` and `options` parameteres.

`options` could contain any option supported by the underlying driver.
 2017-06-02 11:24:55 -05:00
Dzianis Dashkevich
e42365e129
Replace an outdated mention of jquery_ujs with rails-ujs [ci skip] 2017-06-01 22:07:31 +03:00
Dzianis Dashkevich
d49866a8d0
Fix articles layout in guides by eliminating W3C validator warnings [ci skip] 2017-06-01 20:57:42 +03:00
Sam
6cc153959a Replace therubyracer with mini_racer 2017-05-30 09:14:00 -04:00
Jon Moss
980ac58a51 Grammar fixes 
[ci skip]
 2017-05-29 19:56:22 -04:00
Ryuta Kamizono
e40c703184 Remove extra block for assert_changes [ci skip] 2017-05-30 05:20:58 +09:00
Genadi Samokovarov
9bd7881c20 List assert_{,no_}changes in the testing guide 
This lists the `assert_changes` and `assert_no_changes` methods in the
guides. [ci skip]
 2017-05-29 13:12:48 +03:00