Commit Graph

3604 Commits

Author SHA1 Message Date
Kris Selden
afb786ad8a In PostgreSQLAdapter, switch tables query to use current_schemas function [#918 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-26 17:18:33 -07:00
wycats
197904341f Merge branch 'master' into docrails 2010-03-26 15:10:24 -07:00
José Valim
395d6648ce Move application configuration to the application configuration object, remove railtie_name and engine_name and allow to set the configuration object. 2010-03-26 18:47:55 +01:00
Rizwan Reza
5176b28852 Better MySQL Error message. [#3775 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-03-26 13:25:53 +01:00
chrisfinne
76d2c455c0 Add debugging documentation for _callback_chain to ActiveRecord::Callback
Signed-off-by: Rizwan Reza <rizwanreza@gmail.com>
2010-03-26 14:01:21 +04:30
Jeremy Roman
ffb22bd2be fix habtm documentation to correct typo
Signed-off-by: Rizwan Reza <rizwanreza@gmail.com>
2010-03-26 13:35:56 +04:30
Jeremy Kemper
a8b93d7a05 Bump to arel 0.3.3 to resolve Active Support dep 2010-03-25 11:52:53 -07:00
Emilio Tagua
d06a754fdd Remove unused attributes_with_quotes method. 2010-03-25 15:47:16 -03:00
Emilio Tagua
fc2e25734a Move methods from association to relation finder methods. 2010-03-25 15:47:06 -03:00
Emilio Tagua
90a4709601 Refactor relation merging to create just one relation and then assign values, instead of creating multiple relation objects. 2010-03-25 13:03:30 -03:00
Emilio Tagua
e260d5fbcf Require Arel 0.3.2 2010-03-25 12:37:38 -03:00
Emilio Tagua
e3a2fae05d Add add_limit_offset! to adapters. 2010-03-25 12:37:38 -03:00
Aaron Patterson
ed21f0c502 expand migration paths before requiring them. [#4240 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-23 18:22:46 -07:00
Aaron Patterson
bc48d39e4c do not use unloadable constants in tests [#4260 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-23 18:02:29 -07:00
Sebastian Martinez
10825be40b rake tasks should use the new app generator path [#4257 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-03-23 14:26:27 +01:00
José Valim
b61f6f5980 Load generators from both lib/rails/generators and lib/generators. Using the former since it's less obstrusive. 2010-03-23 13:40:41 +01:00
Emilio Tagua
d289e15af9 From and lock should be defined to be consistent with other ivars. Limit and offset are always defined, no need to test that.
[#4253 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-03-22 11:48:39 -07:00
Evan Phoenix
4f5de7f89a Reset class attribute after changing it 2010-03-22 10:00:04 -07:00
Evan Phoenix
0b608abeb8 Clear the query cache between tests that test the query cache 2010-03-22 10:00:04 -07:00
Evan Phoenix
79b0861624 Remove obsolete use case that was broken in AR::Observers 2010-03-22 10:00:04 -07:00
Evan Phoenix
a307fd6bd3 Don't depend on order of elements in Set 2010-03-22 10:00:03 -07:00
Evan Phoenix
34497c0b36 Remove test ordering bug by using another class 2010-03-22 10:00:03 -07:00
Aaron Patterson
541194f641 switching migrations to use require cleans up many warnings [#4234 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-19 09:56:22 -07:00
Aaron Patterson
587f468282 kill where / having method redefine warnings. [#4225 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-18 13:30:59 -07:00
Aaron Patterson
3911a7c197 squelching more warnings in the AR tests. [#4218 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-18 10:24:16 -07:00
Aaron Patterson
b652aa8121 cleaning up a bunch of method already defined warnings [#4209 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-17 13:56:33 -07:00
Jeremy Kemper
067b350301 Move require closer to home 2010-03-17 10:11:38 -07:00
Aaron Patterson
843255a763 fixing activerecord tests [#4205 state:resolved]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-03-17 10:09:14 -07:00
Aaron Patterson
df735cf5b7 fisting uninitialized ivar warnings. [#4198 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-16 15:11:00 -07:00
Aaron Patterson
8c3e46c093 clean up more warnings, remove unnecessary methods, fix eval line numbers. [#4193 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-16 11:48:34 -07:00
Aaron Patterson
dcf1441c0f removing dead code from activerecord tests. [#4187 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-15 18:36:08 -07:00
Aaron Patterson
1def14309f cleaning up a bunch of parse time warnings in AR [#4186 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-15 18:22:31 -07:00
Jeremy Kemper
1f2738261f Hack to keep column metadata queries out of test query counts 2010-03-15 13:56:19 -07:00
Jeremy Kemper
30f5f95544 Hack to keep column metadata queries out of test query counts 2010-03-15 11:00:25 -07:00
Aaron Patterson
5de3698e2b cleaning up many more warnings in activerecord [#4180 state:resolved]
Signed-off-by: wycats <wycats@gmail.com>
2010-03-15 08:57:41 -07:00
Aaron Patterson
95bd56e3cc speeding up clone_attributes, changing readonly to be initialized in def initialize
Signed-off-by: wycats <wycats@gmail.com>
2010-03-14 17:29:25 -06:00
Aaron Patterson
115230e619 cleaning up some test warnings
Signed-off-by: wycats <wycats@gmail.com>
2010-03-14 17:28:27 -06:00
Xavier Noria
c8f1aac761 restricts a test to < 1.9, and rewrites it using a proper expectation
Signed-off-by: wycats <wycats@gmail.com>
2010-03-13 17:04:08 -06:00
Xavier Noria
89eae2d187 adds coverage for the issue addressed in fe43bbd
[#4166 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-03-12 13:22:47 -08:00
Xavier Noria
fe43bbd8c7 keep AssociationProxy#to_a to avoid warning in Array(post.author), and delegate it to @target in association collections
[#4165 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-03-12 11:53:22 -08:00
Jeremy Kemper
c5ff181480 Use arel 0.3.1, for srs 2010-03-10 14:04:10 -08:00
Jeremy Kemper
275df55106 Bump arel dep to 0.3.0+ 2010-03-10 13:49:11 -08:00
Emilio Tagua
e08c153a08 Arel now fallback to using Arel::Attribute if the table/column doesn't exists.
[#4142 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2010-03-10 13:49:11 -08:00
Aaron Patterson
aad432a9e9 removing spawn from SpawnMethods
Signed-off-by: wycats <wycats@gmail.com>
2010-03-10 13:29:00 -08:00
Pratik Naik
181c414baa Fix scope loading issue when the table doesn't exist 2010-03-10 11:28:04 +00:00
Carlos Antonio da Silva
47d252f992 Fix associations to call :destroy or :delete based on the right :dependent option
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-03-09 00:11:34 +01:00
wycats
39d6f9e112 Make many parts of Rails lazy. In order to facilitate this,
add lazy_load_hooks.rb, which allows us to declare code that
should be run at some later time. For instance, this allows
us to defer requiring ActiveRecord::Base at boot time purely
to apply configuration. Instead, we register a hook that should
apply configuration once ActiveRecord::Base is loaded.

With these changes, brings down total boot time of a
new app to 300ms in production and 400ms in dev.

TODO: rename base_hook
2010-03-07 06:24:30 -08:00
Aaron Patterson
a424f199a9 drying up more code in associations.rb
Signed-off-by: wycats <wycats@gmail.com>
2010-03-06 21:41:13 -08:00
Aaron Patterson
939291e8f2 deleting repeated code
Signed-off-by: wycats <wycats@gmail.com>
2010-03-06 21:33:29 -08:00
Stefan Penner
4bc2cbc3cf Load RAILS_VERSION relative to the gemspec file. 2010-03-06 21:33:28 -08:00