Xavier Noria
b56169c262
moves reopening of core classes to add generic stuff from Action Pack to AS/core_ext and adds tests
...
[#2798 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-06-13 15:01:14 -07:00
Xavier Noria
d32965399c
uses Object#metaclass and Object#class_eval in a few spots
...
[#2797 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-06-12 16:14:06 -07:00
Andrew Kaspick
59c83af18b
allow absolute paths for the asset caches
...
Signed-off-by: Michael Koziarski <michael@koziarski.com>
2009-06-11 16:33:32 +12:00
Yehuda Katz + Carl Lerche
47ff57f6d1
Document and clean up HideActions and Http
2009-06-10 15:27:53 -07:00
Yehuda Katz + Carl Lerche
82a10ce9f6
Removed unnecessary code
2009-06-10 14:43:43 -07:00
Yehuda Katz + Carl Lerche
fbb6b936e9
Document ActionController::Helpers
2009-06-10 14:28:58 -07:00
Yehuda Katz + Carl Lerche
316fab7de6
Cleaned up the #default_helper_module method to make better use of #helper instead of duplicating code.
2009-06-10 14:15:21 -07:00
Yehuda Katz + Carl Lerche
4fc0778123
Simplify helper use of ActiveSupport::Dependencies, and use super better for in #helpers
2009-06-10 12:15:30 -07:00
Yehuda Katz + Carl Lerche
b6fde6b480
Clean up AbstractController::Logger and write documentation
2009-06-09 17:03:02 -07:00
Yehuda Katz + Carl Lerche
f35f47b8c0
Cleaning up and documenting AbstractController::Layouts
2009-06-09 16:47:40 -07:00
Yehuda Katz + Carl Lerche
acb2447785
Write documentation for AbstractController::Helpers
2009-06-09 16:47:39 -07:00
Stephen Anderson
a94e7d7897
Sanitized the id generated by text_area_tag helper method. text_area_tag('item[description]') should return: <textarea id="item_description" name="item[description]"></textarea> instead of: <textarea id="item[description]" name="item[description]"></textarea> The old id was causing HTML validation failures.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com>
2009-06-09 20:36:45 +12:00
David Stevenson
a14df8c9b2
Made label target radio button tags with values. Radio button now respects inherited :index options when generating id.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com>
2009-06-09 20:28:43 +12:00
Michael Koziarski
99803b7cdb
Pull autoload fix from 2-3-stable
2009-06-09 20:10:21 +12:00
nate
f68cc639f5
A test to show that http_authentication needs to fail authentication if the password procedure returns nil. Also includes a fix to validate_digest_response to fail validation if the password procedure returns nil.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com>
2009-06-09 19:47:53 +12:00
Jeremy Kemper
23f3b567e2
Uses Hash#symbolize_keys
2009-06-08 19:37:52 -07:00
Yehuda Katz + Carl Lerche
be371993b7
More documentation work on AbstractController
...
This is still not completely done and there might be pointers to things that don't exist yet.
2009-06-08 17:41:08 -07:00
Yehuda Katz + Carl Lerche
38b608ecab
Writing comments to AbstractController
2009-06-08 16:15:14 -07:00
Yehuda Katz + Carl Lerche
a470bb3612
Remove extraneous response_obj
2009-06-08 16:15:13 -07:00
Jeremy Kemper
d3078b540e
Explicitly qualify constants in BasicObjects
2009-06-08 15:07:52 -07:00
Jeremy Kemper
a6bf6f275c
Use as_json instead of rails_to_json
2009-06-08 14:08:04 -07:00
Yehuda Katz + Carl Lerche
86fc43fd58
ActionPack components should no longer have undeclared dependencies.
...
* Tests can be run in isolation
* Dependencies added
* A few tests modified to avoid depending on AS deps
not depended on my files they were testing
2009-06-08 13:34:07 -07:00
Yehuda Katz
6b4da2ecac
Add explicit requirement in a few cases it was missing.
...
TODO: Come up with the minimal core and remove all of these
2009-06-02 21:43:54 -07:00
Yehuda Katz
1126a85aed
Further cleaning up new callbacks
2009-06-02 21:41:31 -07:00
Yehuda Katz
971e2438d9
Simplify callbacks to use less metaprogramming
2009-06-02 19:00:59 -07:00
Yehuda Katz + Carl Lerche
196f780e30
Get all the callback tests to work on new base
2009-06-01 15:40:40 -07:00
Jeremy Kemper
94911c7af7
Ensure ERB source begins with the encoding comment
2009-06-01 12:34:08 -07:00
Han Kessels
9537fd0e3a
fix for IE incompatibility of :disable_with in submit_tag
...
Signed-off-by: Michael Koziarski <michael@koziarski.com>
2009-06-01 14:03:52 +12:00
Jeremy Kemper
c79551f02b
Depend on Hash#slice and Object#try
2009-05-30 11:59:17 -07:00
Jeremy Kemper
c53057d4fd
html-scanner uses Set and class_inheritable_accessor
2009-05-30 11:59:17 -07:00
Jeremy Kemper
249d9a6606
Depend on Hash#diff extension
2009-05-30 11:59:17 -07:00
Joshua Peek
a1140a1031
Revert "Only save the session if we're actually writing to it [ #2703 state:resolved]"
...
This reverts commit dd98280e38d640f5724887cf8a715b79f0439d2d.
2009-05-30 09:36:08 -05:00
Joshua Peek
669fd84910
AS::Concern redefines "include" to lazy include modules as dependencies
2009-05-29 17:03:23 -05:00
Joshua Peek
c7c35be8fe
AS::Concern includes InstanceMethods module if it exists
2009-05-29 16:28:54 -05:00
Jeremy Kemper
5ec2c7dc29
Ruby 1.9: ERB template encoding using a magic comment at the top of the file
2009-05-28 17:12:48 -05:00
Jeremy Kemper
e23554d79e
Ruby 1.9: flushing the output buffer preserves its encoding
2009-05-28 17:12:48 -05:00
Joshua Peek
4e50a35fa2
Break up DependencyModule's dual function of providing a "depend_on" DSL and "included" block DSL into separate modules. But, unify both approaches under AS::Concern.
2009-05-28 11:35:36 -05:00
Joshua Peek
de203245af
Revert "Revert "Whitespace!""
...
This reverts commit 0cac68d3bed3e6bf8ec2eb994858e4a179046941.
2009-05-28 09:49:02 -05:00
Johan Sörensen
dd98280e38
Only save the session if we're actually writing to it [ #2703 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-05-28 09:35:17 -05:00
Johan Sörensen
72cb6f58be
The FlashHash and friends causes a lot of needless session storing, when we know for a fact that there's no content in the flash. By not storing the empty hash in the session we save a lot of communication with the various session backends, while still keeping the same interface to the flash. [ #2703 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-05-28 09:30:49 -05:00
Olly Legg
0349278f3d
Memoize cookies so that updates to cookies are available in the current request. [ #2733 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-05-28 09:18:27 -05:00
Yehuda Katz + Carl Lerche
f2f58f5355
Fix failing ActionCacheFilter tests due to around filter changes.
2009-05-27 17:31:48 -07:00
Yehuda Katz + Carl Lerche
e70bd6bdfa
Added hook point in new base #send_action which does the actual action method dispatching
2009-05-27 16:16:33 -07:00
Carl Lerche
a5688fa907
Add the ability to prepend filters to new callbacks
2009-05-27 16:15:53 -07:00
Hongli Lai (Phusion)
760cb63339
Make the default 500 Internal Server Error page more friendly. Many people don't know they're supposed to look in the log files. [ #2716 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-05-27 15:01:03 -05:00
Eduard Bondarenko
61c471eebb
Add % to RESERVED_PCHAR [ #2574 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-05-27 14:53:05 -05:00
Niels Ganser
bb8e5843f3
ActionController::Flash::FlashHash.use now returns either the value corresponding to the passed key or itself when no key is passed [ #1792 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-05-27 14:51:33 -05:00
Yehuda Katz
6bbe965ccd
Reduce the cost of using ActionController::Http significantly by:
...
* Removing the dependency on AD::Request and AD::Response
* Moving the logic for the request and response object
into a new module that is included by default.
* Changing Renderer and Redirector to use self.headers,
self.content_type, and self.status, which have very basic
default implementations on AC::Http. When RackConvenience
is included (which it is by default on AC::Base), the full
Request/Response logic is used instead of the simple logic.
2009-05-27 10:40:43 +02:00
Carl Lerche
7211048b2b
Get all template tests passing on new base
2009-05-26 15:19:39 -07:00
Carl Lerche
a1f280e83d
Got all the dispatch tests running on new base
2009-05-26 15:03:09 -07:00