TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
1,869 Commits 2 Branches 0 Tags 294 MiB
b62243a5cc
Commit Graph

275 Commits

Author SHA1 Message Date
David Heinemeier Hansson
b62243a5cc Added :disabled option to all data selects that'll make the elements inaccessible for change #2167, #253 [eigentone] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 05:58:00 +00:00
David Heinemeier Hansson
da7ba91d86 Fixed that TextHelper#auto_link_urls would include punctuation in the links #2166, #1671 [eigentone] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2183 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 05:53:52 +00:00
David Heinemeier Hansson
3cf7a0a460 Added Kernel#silence_warnings and puts it into use throughout the framework 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2179 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 04:58:27 +00:00
David Heinemeier Hansson
afbfde9357 Fixed that number_to_currency(1000, {:precision => 0})) should return "$1,000", instead of "$1,000." #2122 [sd@notso.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2170 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:43:02 +00:00
David Heinemeier Hansson
e3c02d8c66 Fixed that render :partial would fail when :object was a Hash (due to backwards compatibility issues) #2148 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 07:27:44 +00:00
David Heinemeier Hansson
46110aa689 Fixed JavascriptHelper#auto_complete_for to only include unique items #2153 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2159 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 07:25:58 +00:00
David Heinemeier Hansson
079d8f4028 Fixed that onclick would be overridden even when special features werent used 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 17:54:16 +00:00
David Heinemeier Hansson
3c3d936f4d Fixed all AssetHelper methods to work with relative paths, such that javascript_include_tag('stdlib/standard') will look in /javascripts/stdlib/standard instead of '/stdlib/standard/' #1963 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 16:39:06 +00:00
David Heinemeier Hansson
e6428abd23 Fixed a broken test 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2155 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 16:30:13 +00:00
David Heinemeier Hansson
7b235f0213 Use this.href, not unexisting url 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2150 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-07 13:04:09 +00:00
David Heinemeier Hansson
7e3dc807df Added :post option to UrlHelper#link_to that makes it possible to do POST requests through normal ahref links using Javascript 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2149 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-07 12:56:33 +00:00
Nicholas Seckar
3108764367 Fix overwrite params. Closes #1909 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2144 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 22:06:11 +00:00
David Heinemeier Hansson
258bacbf82 Added :popup option to UrlHelper#link_to #1996 [gabriel.gironda@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2129 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-04 00:33:45 +00:00
Jamis Buck
6c44d35268 AbstractRequest#domain returns nil when host is an ip address #2012 [kevin.clark@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2098 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-02 09:10:31 +00:00
Jamis Buck
e758c2e9db Yield @content_for_ variables to templates #2058 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-01 21:51:27 +00:00
Jamis Buck
01af965a3e Make rendering an empty partial collection behave like :nothing => true #2080 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2093 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-01 21:43:38 +00:00
Nicholas Seckar
68c90ab019 Render refactoring; render error reporting fixes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2058 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-26 22:37:36 +00:00
Jamis Buck
211617191e Prevent the benchmark module from blowing up if a non-HTTP/1.1 request is processed 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-23 09:43:36 +00:00
Jamis Buck
82f44f3144 Added :use_short_month option to select_month helper to show month names as abbreviations 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2033 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-22 14:47:16 +00:00
Jamis Buck
c031a01633 Add an :if option to session management, to allow programmatically enabling or disabling the session 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2031 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-17 21:05:31 +00:00
Jamis Buck
8910de6a54 Make link_to escape the javascript in the confirm option #1964 [nicolas.pouillard@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2009 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-14 08:43:07 +00:00
Jamis Buck
50e2474433 Make assert_redirected_to properly check URL's passed as strings #1910 [Scott Barron] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1971 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-06 08:37:25 +00:00
Jamis Buck
a3469cadad Make sure :layout => false is always used when rendering inside a layout 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-05 20:51:03 +00:00
Jamis Buck
44c64a612d Use raise instead of assert_not_nil in Test::Unit::TestCase#process to ensure that the test variables (controller, request, response) have been set 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-01 21:28:17 +00:00
Jamis Buck
08ebab5d20 Make sure assigns are built for every request when testing #1866 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1961 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-31 12:16:21 +00:00
Jamis Buck
020ed6fa1f Allow remote_addr to be queried on TestRequest #1668 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-31 10:31:47 +00:00
David Heinemeier Hansson
3d2f0001ea Fixed bug when a partial render was passing a local with the same name as the partial 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 12:24:14 +00:00
David Heinemeier Hansson
d9033bbb28 Demonstrate breakage better 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1941 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 12:06:19 +00:00
David Heinemeier Hansson
e95dd53a5d Added two failing tests for partials with locals from controller 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1937 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 09:11:00 +00:00
David Heinemeier Hansson
4f40b2d8fb Improved performance of test app req/sec with ~10% refactoring the render method #1823 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-24 16:45:39 +00:00
David Heinemeier Hansson
1ae0a53d86 Fixed regression for content_for #1820 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-24 13:20:29 +00:00
David Heinemeier Hansson
b366dbd952 Improved performance with 5-30% through a series of Action Pack optimizations #1811 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 09:00:05 +00:00
David Heinemeier Hansson
d172592985 Added test for template to layout variable transfer 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 08:43:01 +00:00
Jamis Buck
d76439239d Add unit test to ensure that session management options are inherited and overridable in subclasses 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 10:56:53 +00:00
Jamis Buck
06843f8794 Added support for per-action session management #1763 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1886 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 10:37:09 +00:00
David Heinemeier Hansson
bd558ef98e Improved rendering speed on complicated templates by up to 25% #1234 [Stephan Kaes]. This did necessasitate a change to the internals of ActionView#render_template that now has four parameters. Developers of custom view handlers (like Amrita) need to update for that. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1874 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-21 07:14:35 +00:00
Nicholas Seckar
741316dc71 Fixed construction of get parameters for arrays 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1857 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-18 03:12:45 +00:00
Nicholas Seckar
c0771fe7d8 Fix assert_routing with nested controllers. Closes #1582 and #1386. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1837 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-15 15:00:39 +00:00
David Heinemeier Hansson
7073abe159 Fixed bug with :success/:failure callbacks for the JavaScriptHelper methods #1730 [court3nay/Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1835 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-14 11:38:55 +00:00
Nicholas Seckar
bf0b7588ee Add RouteSet#named_route so that RouteSet instance methods do not shadow available route names 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1834 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-14 10:32:37 +00:00
Nicholas Seckar
6ed16ff602 Provide correct defaults for Named Routes which do not specify :action 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-14 09:09:39 +00:00
David Heinemeier Hansson
16595c93b2 Made pagination faster #1334 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1832 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-14 08:02:01 +00:00
David Heinemeier Hansson
807df4fcf0 Made test_rendering_nothing_on_layout acknowledge the space 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1831 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-14 07:19:26 +00:00
Nicholas Seckar
2bd4ff11f8 Generate URLs for :action => index when :action => nil is supplied. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-14 00:13:06 +00:00
Nicholas Seckar
9314793239 Named routes should not provide nil values to url_for. Includes factoring and extra testcases. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1825 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-13 23:13:15 +00:00
Jamis Buck
847f738cfd Make Request#subdomains handle "foo.foo.com" correctly 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1817 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-12 16:16:13 +00:00
David Heinemeier Hansson
1666977490 Script.aculo.us: latest rev, new autocompleter features, memory leaks fixed #1695 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1810 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-11 05:17:22 +00:00
David Heinemeier Hansson
383b6afd1c Made JavaScriptHelper tests pass regardless of hash order #1656 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1794 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-10 05:11:23 +00:00
Jeremy Kemper
c697be5b69 r2992@asus: jeremy | 2005-07-10 02:43:49 -0700 
Skip ActiveRecordStore tests if neither SQLite 2 nor 3 is available.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1793 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-10 05:05:06 +00:00
David Heinemeier Hansson
2abe3d2cd9 Added that nil options are not included in tags, so tag("p", :ignore => nil) now returns <p /> not <p ignore="" /> but that tag("p", :ignore => "") still includes it #1465 [michael@schuerig.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1789 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-09 17:28:35 +00:00