TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
58,859 Commits 2 Branches 0 Tags 294 MiB
b8d7bcf93e
Commit Graph

306 Commits

Author SHA1 Message Date
Santosh Wadghule
e73b5cf51b Give importance to rails command in the comment section. 2016-07-13 19:13:05 +05:30
Matthew Draper
48e8056d4f Correct changelog layout 
[ci skip]
 2016-07-09 03:17:51 +09:30
Matthew Draper
e995611155 Insert changelog entry for #25615 2016-07-09 02:56:03 +09:30
Matthew Draper
92421ee2d2 Merge pull request #25624 from tinco/actioncable_write_race 
Fix race condition in websocket stream write
 2016-07-09 02:44:15 +09:30
Matthew Draper
08a9074613 Merge pull request #24988 from mwear/action_cable_broadcast_notifications 
Add ActiveSupport::Notifications hook to ActionCable::Server.broadcast
 2016-07-04 08:44:14 +09:30
Matthew Draper
550303c05c Merge pull request #25030 from mmmpa/pull_request 
ActionCable, sometimes add_channel is not called.
 2016-07-04 08:39:02 +09:30
Matthew Draper
a468774cc1 Merge pull request #25293 from y-yagi/remove_needless_comments 
remove needless comments
 2016-07-03 04:08:30 +09:30
Tinco Andringa
3120b51de7 close hijacked i/o socket after use (fixes #25613) 2016-07-01 23:03:30 +02:00
Tinco Andringa
ce5f9bb2a5 fix race condition in websocket stream write 2016-07-01 15:29:29 +02:00
Jeremy Daer
ba9571e1ac
Periodic timers: delegate async instance_exec to the worker pool 2016-06-29 23:37:07 -07:00
Vipul A M
e5c5b6f2ee Merge pull request #24991 from maclover7/actioncable-npm-docs 
Add documentation about Action Cable npm package
 2016-06-29 15:29:59 -07:00
Kasper Timm Hansen
754e5bdf87 Make client test run individually. 
Require our dependency and forgo the core ext version.
 2016-06-28 18:54:30 +02:00
Rafael Mendonça França
e78e0e2a42
Fix Action Cable README [ci skip] 2016-06-26 16:09:36 -03:00
Ryuta Kamizono
e317e5e1e1 Remove conflict line [ci skip] 2016-06-27 02:52:39 +09:00
Vijay Dev
5343626ea8 Merge branch 'master' of github.com:rails/docrails 
Conflicts:
	actioncable/README.md
 2016-06-26 16:34:23 +00:00
Gaurav Sharma
4db92eed3b client test have not using Pathname and hashwithindifferent access 2016-06-26 01:49:54 +05:30
Michael Dever
0a8584456e Allow actioncable connections from any port in development 2016-06-16 21:04:43 +01:00
Vipul A M
b94b04b1d1
Fix and make example generic in README as well [ci skip] 2016-06-15 22:04:56 -07:00
yuuji.yaginuma
8a5f17e55a remove needless comments 
Follow up to #25240.
 2016-06-06 15:09:06 +09:00
Prathamesh Sonpatki
7d4b33257b
Added "Download and Installation" section to Action Cable README [ci skip] 
- Only Action Cable README did not have this section, all of the other
  READMEs have this section.
 2016-06-04 16:06:35 -04:00
Prathamesh Sonpatki
4c192a7fad
Trim Action Cable README [ci skip] 
- Remove "Configuration", "Running the server", "Dependencies" and "Deployment"
  sections from the Action Cable README as they are already duplicated in the
  Action Cable overview guide.
 2016-06-04 16:01:30 -04:00
Matthew Draper
a8df1bc345 Properly support reloading for Action Cable channels 2016-06-02 04:08:48 +09:30
Jeremy Daer
8932c1b9a4
Merge pull request #25170 from maclover7/add-configuration-cable 
[Action Cable] Add `WebSocket` and `logger` configuration options
 2016-05-31 11:19:29 -07:00
Javan Makhmali
410a32ffbd Add helper for testing against a mock WebSocket and server 2016-05-31 13:06:11 -04:00
Jon Moss
fb0f0c7f6e Reorganize MockWebSocket 2016-05-31 13:06:11 -04:00
Jon Moss
66901c1849 Add configuration for WebSocket and logger 
[Javan Makhmali, Jon Moss]
 2016-05-31 13:06:08 -04:00
Jeremy Daer
0419e1b6f3
Merge pull request #25216 from javan/actioncable/tune-sauce-labs-tests 
Action Cable: Tune Sauce Labs tests
 2016-05-31 08:57:19 -07:00
Javan Makhmali
a051e59fb9 Test single latest browser version 
Cuts down the number of concurrent Sauce Labs VMs we need to spin up. Can add specific versions back in to target regressions if need be.
 2016-05-31 10:42:18 -04:00
Rajat Bansal
72a0f5e24c fix grammar 2016-05-31 13:31:18 +05:30
Anubhav Saxena
5983226161 Bash markdown syntax 
Added 'sh' for markdown formatting as bash.
 2016-05-27 08:58:55 +05:30
Jon Moss
1713075a80 Add documentation about Action Cable npm package 
Sorry, forgot to include in my main PR :(

[ci skip]

[Jon Moss, Zach Schneider]
 2016-05-26 22:22:04 -04:00
mmmpa
711d232f93 Add guard to broadcast. 2016-05-26 05:22:56 +09:00
Jon Moss
8cfce058d9
CI: run Action Cable browser tests in Sauce Labs 
Allow failures until test runs are consistently stable, not hanging.

Closes #24943.

Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
 2016-05-25 09:21:28 -07:00
Javan Makhmali
d12209cad2 Remove package:clean task 
Introduced in d6f2000a67cc63aa67414c75ce77de671824ec52 and was only used by Action Cable. Now handled by Action Cable’s assets:compile task.
 2016-05-24 13:11:28 -04:00
Javan Makhmali
11078dddbb Build action_cable.js with Blade 2016-05-24 13:11:10 -04:00
Vipul A M
61483b18bc
Remove Blade gem dependency 
Apps that depend on Action Cable don't need Blade for app development,
so we can remove the gem dependency.

We do need Blade for Action Cable dev, so we bundle it in the Gemfile.

Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
 2016-05-21 12:41:01 -07:00
Sean Griffin
26c0e2cab4 Merge pull request #25076 from jeroenvisser101/keep-to-max-length 
Change comments to not exceed 80 characters
 2016-05-21 14:56:03 -04:00
Jon Moss
c420bedda7 Pass over Action Cable docs 
[ci skip]
 2016-05-21 11:55:04 -04:00
Rafael França
db312a9fb0 Merge pull request #24918 from prathamesh-sonpatki/cable-assets 
Cable: Generate .js or .coffee files while generating channel as per the javascript engine of the application
 2016-05-21 08:52:43 -03:00
Jeroen Visser
ee25897230
Change comments to not exceed 80 characters 
Other generated files do keep to this, but action cable doesn't.
 2016-05-19 15:37:50 +02:00
Roman Pushkin
a3c4d035f0 Improve method description 
Method description improved to reflect little bit more complicated scenario when names are camel-cased.
 2016-05-18 14:12:11 -07:00
Prathamesh Sonpatki
63ac6255ba
Cable: Generate .js or .coffee files while generating channel as per the javascript engine of the application 
- Now we will detect what javascript engine user is using and based on
  that we will generate either `.js` or `.coffee` version of the channel
  file.
- This also needs a change in coffee-rails to override the `js_template`
  method. Related PR https://github.com/rails/coffee-rails/pull/72.
- Currently coffee-rails gem sets
  `config.app_generators.javascript_engine` to `:coffee` and using this
  information we override the `js_template` to set the extension as
  `.coffee` in coffee-rails gem.
- Using this approach, we can keep the `channel.js` and `channel.coffee`
  files in the Rails repository itself.
- Additionally the `js_template` method can act as public interface for
  coffee-rails gem to hook into and change the extension to `.coffee`
  without maintaining the actual asset files.

[Prathamesh Sonpatki, Matthew Draper]
 2016-05-17 18:12:19 +05:30
Vijay Dev
83ecf3fe56 Merge branch 'master' of github.com:rails/docrails 
Conflicts:
	guides/source/configuring.md
 2016-05-14 09:54:23 +00:00
Matthew Wear
f3ba0c1dd3 Add ActiveSupport::Notifications hook to Broadcaster#broadcast 
This addition of this notification hook will give users better visibility
into the messages being sent over the PubSub adapter.
 2016-05-12 10:56:35 -07:00
Jon Moss
548c1d6e8b
Publish Action Cable to NPM when we release. 
Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
 2016-05-11 19:36:27 -07:00
Rafael Mendonça França
8ecc5ab1d8 Start Rails 5.1 development 🎉 2016-05-10 03:46:56 -03:00
Javan Makhmali
71d4066972 Kick off initial JavaScript tests 2016-05-09 09:36:53 -04:00
yuuji.yaginuma
017c7f46e0 change cable.coffee to cable.js [ci skip] 
In #23935, cable file was to be provided by the javascript instead of coffeescript,
doc was also been modified to use javascript.
 2016-05-07 21:15:33 +02:00
Matthew Draper
33f8dac38b Merge commit 'fbdcf5221ad7ea3d40ad09651962fc85d101dd67' 
Preparing for 5.0.0.rc1 release
 2016-05-07 11:50:04 -05:00
Jon Moss
7d55c846f1 http --> https 
[ci skip]
 2016-05-06 17:59:27 -04:00