Sam Stephenson
0886bb391d
Fixed that an instance variable with the same name as a partial should be implicitly passed as the partial :object. Closes #2269 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2522 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-10 20:35:13 +00:00
Sam Stephenson
e3655ef733
Fix Element.toggle logic
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2521 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-10 19:09:40 +00:00
Thomas Fuchs
7d101d5840
Update Prototype to V1.4.0_pre11, script.aculo.us to [2502] and fix the rails generator to include the new .js files [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2503 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-09 16:56:23 +00:00
David Heinemeier Hansson
f13534e65f
Forced newer versions of RedCloth to use hard breaks [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2437 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-02 20:24:53 +00:00
David Heinemeier Hansson
810ebf7c6a
Forced newer versions of RedCloth to use hard breaks [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2436 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-02 20:21:43 +00:00
David Heinemeier Hansson
c69160a90d
Better logging about partials when logger to to debug
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2432 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-01 19:00:06 +00:00
Thomas Fuchs
e7afaf62bd
Added new scriptaculous options for auto_complete_field #2343 [m.stienstra@fngtps.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2431 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-10-01 05:43:53 +00:00
Jamis Buck
1e08d11579
Don't prepend the asset host if the string is already a fully-qualified URL
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2430 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-30 19:10:20 +00:00
David Heinemeier Hansson
562b69829d
Not the avenue we want to go down
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-30 08:13:46 +00:00
David Heinemeier Hansson
438db964ad
Testing should also use a default REQUEST_METHOD
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2408 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-29 08:43:17 +00:00
Thomas Fuchs
4d6ad9c48b
Updated rdoc for javascript_include_tag
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2395 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-28 10:55:57 +00:00
David Heinemeier Hansson
981763e53e
My life for white space
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2393 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-28 09:06:34 +00:00
Thomas Fuchs
516dc2c0f1
Update script.aculo.us to 1.5_rc2, and Prototype to 1.4.0_pre7
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2386 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-28 08:20:47 +00:00
Nicholas Seckar
564077373d
Streamline render process, code cleaning. Closes #2294 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2368 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-27 16:45:39 +00:00
Marcel Molina
b54560600b
Have text helpers use built in Regexp.escape rather than home grown alternative
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-26 20:49:52 +00:00
Jeremy Kemper
9852197f83
r3573@asus: jeremy | 2005-09-26 11:38:44 -0700
...
Ticket 1507 - IE file uploads give the filename as a full Windows path, but Ruby on UNIX doesn't know how to File.basename('C:\\blah\blah.foo').
r3574@asus: jeremy | 2005-09-26 14:32:11 -0700
Get rid of constant redefine warning.
r3575@asus: jeremy | 2005-09-26 14:33:07 -0700
Override the file upload's original_filename singleton method in CGIMethods.get_typed_value.
r3576@asus: jeremy | 2005-09-26 14:33:49 -0700
Unit test overridden original_filename against normal filenames and full Windows paths.
r3577@asus: jeremy | 2005-09-26 14:33:57 -0700
Update change log.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2345 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-26 17:59:46 +00:00
David Heinemeier Hansson
2a31691ee2
Fixed that auto_discovery_link_tag couldn't take a string as the URL
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2296 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-22 11:37:16 +00:00
David Heinemeier Hansson
7f26415d3c
Optimized tag_options to not sort keys, which is no longer necessary when assert_dom_equal and friend is available #1995 [skae]. Added assert_dom_equal and assert_dom_not_equal to compare tags generated by the helpers in an order-indifferent manner #1995 [skae]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2271 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-20 07:54:55 +00:00
Jamis Buck
390280b842
Make the truncate() helper multi-byte safe (assuming $KCODE has been set to something other than "NONE") #2103
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2265 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-19 21:36:36 +00:00
David Heinemeier Hansson
7a4c88157f
Doc fix #2197
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-17 06:39:54 +00:00
David Heinemeier Hansson
9acb1f95c9
Make upload progress not throw JavaScript errors when there is no progress bar #2208 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2252 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-16 08:44:38 +00:00
Jamis Buck
5e3364ef45
More auto-link fixes (to include query strings in autolinked text)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2241 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-14 12:07:05 +00:00
Jamis Buck
b97f4e4597
Fix autolinking to not include trailing tags as part of the URL
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2237 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-13 18:48:34 +00:00
David Heinemeier Hansson
de4cd789ae
Make periodically_call_remote use type="text/javascript" on script tag #2171
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2217 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-12 05:40:27 +00:00
David Heinemeier Hansson
2fe8610673
Added TextHelper#cycle to cycle over an array of values on each hit (useful for alternating row colors etc) #2154 [dave-ml@dribin.org]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2213 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-12 05:26:25 +00:00
David Heinemeier Hansson
b5629c31be
Fixed docs #1884
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2196 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 09:13:05 +00:00
David Heinemeier Hansson
a0ecced15b
Fixed docs #1886
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2195 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 09:12:22 +00:00
David Heinemeier Hansson
2be3c00863
Split macros test into their own suite
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2194 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 08:40:46 +00:00
David Heinemeier Hansson
a15068726f
Added :multipart option to ActiveRecordHelper#form to make it possible to add file input fields #2034 [jstirk@oobleyboo.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2193 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 08:39:23 +00:00
David Heinemeier Hansson
c1007377ba
Added in-place editing support in the spirit of auto complete with ActionController::Base.in_place_edit_for, JavascriptHelper#in_place_editor_field, and Javascript support from script.aculo.us #2038 [Jon Tirsen] Moved auto-completion and in-place editing into the Macros module and their helper counterparts into JavaScriptMacrosHelper
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2191 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 07:52:53 +00:00
David Heinemeier Hansson
b62243a5cc
Added :disabled option to all data selects that'll make the elements inaccessible for change #2167 , #253 [eigentone]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 05:58:00 +00:00
David Heinemeier Hansson
da7ba91d86
Fixed that TextHelper#auto_link_urls would include punctuation in the links #2166 , #1671 [eigentone]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2183 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-11 05:53:52 +00:00
David Heinemeier Hansson
afbfde9357
Fixed that number_to_currency(1000, {:precision => 0})) should return "$1,000", instead of "$1,000." #2122 [sd@notso.net]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2170 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-09 08:43:02 +00:00
David Heinemeier Hansson
7dbf051e54
Fix docs #2136 [coffee2code]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2165 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-09 08:11:53 +00:00
David Heinemeier Hansson
e54b4d3b54
Allow link_to_remote to use any DOM-element as the parent of the form elements to be submitted #2137 [erik@ruby-lang.nl]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2164 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-09 08:10:20 +00:00
David Heinemeier Hansson
e3c02d8c66
Fixed that render :partial would fail when :object was a Hash (due to backwards compatibility issues) #2148 [Sam Stephenson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-09 07:27:44 +00:00
David Heinemeier Hansson
46110aa689
Fixed JavascriptHelper#auto_complete_for to only include unique items #2153 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2159 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-09 07:25:58 +00:00
David Heinemeier Hansson
079d8f4028
Fixed that onclick would be overridden even when special features werent used
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-08 17:54:16 +00:00
David Heinemeier Hansson
3c3d936f4d
Fixed all AssetHelper methods to work with relative paths, such that javascript_include_tag('stdlib/standard') will look in /javascripts/stdlib/standard instead of '/stdlib/standard/' #1963
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-08 16:39:06 +00:00
David Heinemeier Hansson
7b235f0213
Use this.href, not unexisting url
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2150 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-07 13:04:09 +00:00
David Heinemeier Hansson
7e3dc807df
Added :post option to UrlHelper#link_to that makes it possible to do POST requests through normal ahref links using Javascript
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2149 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-07 12:56:33 +00:00
David Heinemeier Hansson
258bacbf82
Added :popup option to UrlHelper#link_to #1996 [gabriel.gironda@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2129 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-04 00:33:45 +00:00
David Heinemeier Hansson
3f14b1e94e
Updated the options_for_select to deal with the fact that Strings now implement :first
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2126 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-03 21:30:54 +00:00
David Heinemeier Hansson
51a1af96d4
Added note about how pre-packaged error functionality can be easier to recreate yourself than attempt to overly tailor #1489
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2112 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-03 07:43:15 +00:00
Jamis Buck
fd9c15e420
Fix observe_field to fall back to event-based observation if frequency <= 0 #1916 [michael@schubert.cx]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2104 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-02 14:06:17 +00:00
Jamis Buck
97adfdaa65
* Allow use of the :with option for submit_to_remote #1936 [jon@instance-design.co.uk]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2103 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-02 13:56:38 +00:00
Jamis Buck
e758c2e9db
Yield @content_for_ variables to templates #2058 [Sam Stephenson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-01 21:51:27 +00:00
Jamis Buck
01af965a3e
Make rendering an empty partial collection behave like :nothing => true #2080 [Sam Stephenson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2093 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-09-01 21:43:38 +00:00
Nicholas Seckar
a8b9fc9f2a
Add dummy ActionView::Base.cache_template_loading accessor -- will be made functional again in short time
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2066 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-29 15:12:48 +00:00
David Heinemeier Hansson
b80f0e2ff3
Made Upload Progress work with Prototype 1.4.0 and add some documentation for it #1847 , #1876 [Thomas Fuchs/Sean Treadway]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2059 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-27 06:30:33 +00:00
Nicholas Seckar
68c90ab019
Render refactoring; render error reporting fixes
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2058 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-26 22:37:36 +00:00
Jamis Buck
82f44f3144
Added :use_short_month option to select_month helper to show month names as abbreviations
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2033 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-22 14:47:16 +00:00
Jamis Buck
8910de6a54
Make link_to escape the javascript in the confirm option #1964 [nicolas.pouillard@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2009 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-08-14 08:43:07 +00:00
David Heinemeier Hansson
9fad3251d3
More fixes, but still broken
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1948 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-27 14:17:47 +00:00
David Heinemeier Hansson
c22ebd909d
Fixing the fix, but not quite
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1946 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-27 13:55:56 +00:00
David Heinemeier Hansson
3d2f0001ea
Fixed bug when a partial render was passing a local with the same name as the partial
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-27 12:24:14 +00:00
David Heinemeier Hansson
11a51648ad
Document the design of the compiled templates approach and tweak the expiration check
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1929 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-26 12:37:21 +00:00
David Heinemeier Hansson
4f40b2d8fb
Improved performance of test app req/sec with ~10% refactoring the render method #1823 [Stefan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-24 16:45:39 +00:00
David Heinemeier Hansson
3ccea931fa
Simplify content_for implementation
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1914 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-24 15:27:47 +00:00
David Heinemeier Hansson
1ae0a53d86
Fixed regression for content_for #1820 [Stefan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-24 13:20:29 +00:00
David Heinemeier Hansson
023c4d68cc
Caching template logging goes DEBUG
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1903 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 06:27:52 +00:00
David Heinemeier Hansson
7fe3fd23b3
Extended template caching to rxml and attempted to fix periodical caching issue [Stephan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1902 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 06:14:10 +00:00
David Heinemeier Hansson
98fb9e5093
Fixed call on inline with new render_template #1808 [Michael Shuerig]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1898 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 20:46:36 +00:00
David Heinemeier Hansson
c19ca5148f
Fixed changing templates in development mode [Stephan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1891 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 15:51:34 +00:00
David Heinemeier Hansson
3835f6ab25
Changed caching/expiration/hit to report using the DEBUG log level and errors to use the ERROR log level instead of both using INFO
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1889 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 11:28:58 +00:00
David Heinemeier Hansson
06160fd3e8
Use debug to report compilation of erb templates
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1885 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 10:11:36 +00:00
David Heinemeier Hansson
95cd46c5ec
Fixed compile of template fails if template name contains non-word character #1802
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1883 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 07:39:48 +00:00
David Heinemeier Hansson
ecb0e39741
Added additional documentation to FormTagHelper #1788 [jon@instance-design.co.uk]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1880 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 06:47:03 +00:00
David Heinemeier Hansson
bd558ef98e
Improved rendering speed on complicated templates by up to 25% #1234 [Stephan Kaes]. This did necessasitate a change to the internals of ActionView#render_template that now has four parameters. Developers of custom view handlers (like Amrita) need to update for that.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1874 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-21 07:14:35 +00:00
David Heinemeier Hansson
80cfa76f7d
Added options hash as third argument to FormHelper#input, so you can do input('person', 'zip', :size=>10) #1719 [jeremye@bsa.ca.gov]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1851 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-17 09:54:01 +00:00
David Heinemeier Hansson
02c1dae551
Docs for JavaScriptHelper#remote_function #1740 [jon@instance-design.co.uk]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1847 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-17 09:23:56 +00:00
David Heinemeier Hansson
4dc2dc1402
Cleaning up of javascript_helper array options, add :only to sortable_element #1761 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1843 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-17 09:15:41 +00:00
David Heinemeier Hansson
45804e2c86
More pagination speed #1334 [Stefan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1839 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-15 20:27:38 +00:00
David Heinemeier Hansson
1708a863a5
Fixed line number reporting for Builder template errors #1753 [piotr]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1838 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-15 20:18:51 +00:00
David Heinemeier Hansson
7073abe159
Fixed bug with :success/:failure callbacks for the JavaScriptHelper methods #1730 [court3nay/Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1835 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 11:38:55 +00:00
David Heinemeier Hansson
16595c93b2
Made pagination faster #1334 [Stefan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1832 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 08:02:01 +00:00
David Heinemeier Hansson
216b0e0fba
Improved documentation for :success/:failure callbacks #1699 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1812 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-11 06:44:10 +00:00
David Heinemeier Hansson
1666977490
Script.aculo.us: latest rev, new autocompleter features, memory leaks fixed #1695 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1810 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-11 05:17:22 +00:00
Sam Stephenson
325c5efdb3
Update to Prototype 1.3.1
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1804 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-11 02:57:59 +00:00
David Heinemeier Hansson
383b6afd1c
Made JavaScriptHelper tests pass regardless of hash order #1656 [Sam Stephenson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1794 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-10 05:11:23 +00:00
David Heinemeier Hansson
2abe3d2cd9
Added that nil options are not included in tags, so tag("p", :ignore => nil) now returns <p /> not <p ignore="" /> but that tag("p", :ignore => "") still includes it #1465 [michael@schuerig.de]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1789 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 17:28:35 +00:00
David Heinemeier Hansson
1d7aa9fe81
Fixed that UrlHelper#link_to_unless/link_to_if used html_escape on the name if no link was to be applied. This is unnecessary and breaks its use with images #1649 [joergd@pobox.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 17:08:23 +00:00
David Heinemeier Hansson
165f82d180
Added even more goodies to script.aculo.us #1677 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1783 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 17:01:12 +00:00
David Heinemeier Hansson
14f06c2cc1
Fixed SQL Server test #1678 [Tom Ward]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 16:59:35 +00:00
David Heinemeier Hansson
b640a64760
Added :handle as an option to sortable_element to restrict the drag handle to a given class #1642 [thejohnny]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1760 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 14:34:26 +00:00
David Heinemeier Hansson
94209e2fb7
Added a bunch of script.aculo.us features: Effect.ScrollTo, to smoothly scroll the page to an element, better Firefox flickering handling on SlideUp/SlideDown, Removed a possible memory leak in IE with draggables, Added support for cancelling dragging my hitting ESC #1644 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1759 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 14:18:16 +00:00
David Heinemeier Hansson
5a9a93d28f
Fixed JavascriptHelper#visual_effect to use camelize such that :blind_up will work #1639 [pelletierm@eastmedia.net]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1754 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 08:46:31 +00:00
David Heinemeier Hansson
853ea55674
Made documentation ready for release (AP)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1731 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 09:32:00 +00:00
David Heinemeier Hansson
2186ed83dd
Make new AJAX helpers aware of more of their options #1622 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1729 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 08:32:04 +00:00
Jeremy Kemper
c9901176be
benchmark helper takes an optional log level, defaults to :info. Chose symbols log levels rather than Logger::FOO constants for simplicity. Added benchmark helper test suite.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1719 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 19:33:25 +00:00
David Heinemeier Hansson
84afbbbc03
Fix syntax error
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1715 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 18:02:02 +00:00
David Heinemeier Hansson
977b4be208
Changed logging of SQL statements to use the DEBUG level instead of INFO. Added logging of the request URI in the benchmark statement (makes it easy to grep for slow actions). Changed the default logging level in config/environment.rb to INFO for production (so SQL statements won't be logged)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1714 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 17:23:41 +00:00
David Heinemeier Hansson
56fa64e995
Fixed transparent background for Safari with auto completer
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1708 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 10:31:28 +00:00
David Heinemeier Hansson
5eee938643
Added javascript_include_tag :defaults shortcut that'll include all the default javascripts included with Action Pack (prototype, effects, controls, dragdrop)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1707 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 10:23:51 +00:00
David Heinemeier Hansson
25c33a99f9
Fixed Prototype bug #1602
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1700 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 07:55:37 +00:00
Sam Stephenson
555072e8e9
Fix failure container logic in Ajax.Updater
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1652 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 05:36:12 +00:00
Sam Stephenson
5bbc24a508
Update Prototype; hopefully the last change before 0.13
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1651 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 05:23:28 +00:00
David Heinemeier Hansson
bf3a0c5391
Improved update_element_function #1597 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1650 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 04:57:15 +00:00
David Heinemeier Hansson
c52edf2319
Added :prompt option to FormOptions#select (and the users of it, like FormOptions#select_country etc) to create "Please select" style descriptors #1181 [Michael Schuerig]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1646 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-03 12:23:16 +00:00
David Heinemeier Hansson
208291391c
Added JavascriptHelper#update_element_function, which returns a Javascript function (or expression) that'll update a DOM element according to the options passed #933 [mortonda@dgrmm.net]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1644 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-03 11:01:43 +00:00
David Heinemeier Hansson
703d18ea52
Added note about render_partial_collection #1557
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1618 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-03 08:05:05 +00:00
David Heinemeier Hansson
481cac9658
AJAX error handling fix, Prototype event handling #1589 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1617 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-03 08:00:38 +00:00
David Heinemeier Hansson
c6ab8f5706
Added :field_name option to DateHelper#select_(year|month|day) to deviate from the year/month/day defaults #1266 [Marcel Molina]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1613 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-02 18:38:22 +00:00
David Heinemeier Hansson
668a0817f7
Auto completer should hide update element by when initializing #1579 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1610 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-02 18:18:55 +00:00
David Heinemeier Hansson
50f0a73624
Added JavascriptHelper#draggable_element and JavascriptHelper#drop_receiving_element to facilitate easy dragging and dropping through the script.aculo.us libraries #1578 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1606 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-02 11:25:21 +00:00
David Heinemeier Hansson
a53372c273
Added that UrlHelper#mail_to will now also encode the default link title #749 [f.svehla@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1601 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-02 06:46:41 +00:00
David Heinemeier Hansson
3553b59d3c
Removed the default option of wrap=virtual on FormHelper#text_area to ensure XHTML compatibility #1300 [thomas@columbus.rr.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1600 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-02 06:39:43 +00:00
David Heinemeier Hansson
bf9b90a908
Adds the ability to include XML CDATA tags using Builder #1563 [Josh Knowles]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1598 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-02 06:21:13 +00:00
David Heinemeier Hansson
2f61c431fa
Added evaluation of <SCRIPT> blocks in content returned to Ajax calls #1577 [Thomas Fuchs/court3nay]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1597 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-02 06:20:05 +00:00
David Heinemeier Hansson
f0e9fd74ae
Make render(:inline) use locals #1556 [Michael Shuerig]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1584 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-01 18:21:29 +00:00
David Heinemeier Hansson
5651a69130
Load models and frequency typo on upoad progress #1555 [Sean Treadway]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1580 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-01 08:31:30 +00:00
David Heinemeier Hansson
cadcd9e714
Fix IE 30-sec timeout bug, make auto_complete_for even more delicious #1572 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1579 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-01 07:25:44 +00:00
David Heinemeier Hansson
bab674c681
File upload progress seems to have problems on a variety of servers, marking as experimental for now and not including it in the docs
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1570 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-30 08:16:57 +00:00
David Heinemeier Hansson
a90598b458
Wrong variable name used in observe_field #1551
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1568 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-30 05:58:40 +00:00
David Heinemeier Hansson
8a145b251a
Give auto_complete_for parameters, fix browser-autocompletion #1550
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1566 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-29 17:08:14 +00:00
David Heinemeier Hansson
2d8679993c
Fix JavaScriptHelper capitalization and make it compatible with Prototype #1545 [Sam Stephenson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1561 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-29 08:09:00 +00:00
David Heinemeier Hansson
0ffcceffac
Script.aculo.us: autocompletion focus fix, setContentZoom fix #1546 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1560 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-29 08:07:55 +00:00
Sam Stephenson
a551ba2c01
Sync Prototype; closes #1539
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1558 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-29 05:20:51 +00:00
David Heinemeier Hansson
beffb77e05
Added support for upload progress indicators in Apache and lighttpd 1.4.x (won't work in WEBrick or lighttpd 1.3.x) #1475 [Sean Treadway]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1553 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-28 17:44:16 +00:00
David Heinemeier Hansson
62ed6950c9
Added support for upload progress indicators in Apache and lighttpd 1.4.x (won't work in WEBrick or lighttpd 1.3.x) #1475 [Sean Treadway]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1552 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-28 17:42:51 +00:00
David Heinemeier Hansson
d763f08ba8
Fix the Event.findElement prototype function. Needed to get autocomplete working with Safari #1528 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1547 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-28 09:47:56 +00:00
David Heinemeier Hansson
938a8fea27
Added support for graceful error handling of Ajax calls #1217 [Jamis Buck/Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1545 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-27 17:40:00 +00:00
Sam Stephenson
05ef7898bd
Make Object.prototype.extend work correctly
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1544 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-27 17:10:52 +00:00
Sam Stephenson
9965993e8b
Work around existing Element and Event objects in Prototype
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1543 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-27 16:05:10 +00:00
David Heinemeier Hansson
9b0bb24fe0
Update script.aculo.us scripts for Prototype 1.3.0 #1522 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1536 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-27 09:24:18 +00:00
Sam Stephenson
0dd2981d2b
Fix a potential bug in Prototype's Ajax.Request involving Mozilla and null POST bodies
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1534 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-27 06:33:09 +00:00
David Heinemeier Hansson
de1f231c32
Added event-based observations when frequency is not set on observe_field/form #1474 [flash@vanklinkenbergsoftware.nl]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1532 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-27 05:29:47 +00:00
Sam Stephenson
264a7e7c46
Update to Prototype 1.3.0; closes #1441 , #1348
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1530 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-27 05:07:48 +00:00
David Heinemeier Hansson
c9f2389c01
Update script.aculo.us scripts to fix some bugs #1515
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1528 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-26 17:23:38 +00:00
David Heinemeier Hansson
b17e178981
Renamed remote_sortable to sortable_element
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1526 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-26 14:34:13 +00:00
David Heinemeier Hansson
521d5fdc72
Added auto_complete_for to controller and text_field_with_auto_complete to view to make it really, really easy to do Google Suggest style interfaces
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1525 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-26 14:23:36 +00:00
David Heinemeier Hansson
7da736f929
Added script.aculo.us Javascripts (controls.js, dragdrop.js, effects.js) (NEEDS MORE DESCRIPTION) #1509 [Thomas Fuchs]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1522 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-26 12:03:43 +00:00
David Heinemeier Hansson
e4ccbf28c8
Fixed prototype to consider all fields it doesn't know as text (such as Safari's search) just like the browser in its serialization #1497 [Sean Treadway]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1503 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-25 10:48:28 +00:00
David Heinemeier Hansson
8e56e09018
Updated documentation for partials #1171
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1474 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 16:59:04 +00:00
David Heinemeier Hansson
c608ebeade
Added TextHelper#word_wrap(text, line_length = 80) #1449 [tuxie@dekadance.se]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1465 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 07:16:11 +00:00
David Heinemeier Hansson
e59bfc8519
Added a fall-through action for form_remote_tag that'll be used in case Javascript is unavailable #1459 [Scott Barron]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1464 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 07:08:13 +00:00
David Heinemeier Hansson
bc6570dfcb
Added tag_options as a third parameter to AssetHelper#auto_discovery_link_tag to control options like the title of the link #1430 [kevin.clark@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1460 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 06:52:05 +00:00
David Heinemeier Hansson
f2a021dc06
Added option to pass in parameters to CaptureHelper#capture, so you can create more advanced view helper methods #1466 [duane.johnson@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1459 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 06:43:14 +00:00
David Heinemeier Hansson
5ba31b3d1d
Changed the default name of the input tag generated by FormTagHelper#submit_tag from "submit" to "commit" so it doesnt clash with form.submit() calls in Javascript #1271
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1456 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 05:26:40 +00:00
Jeremy Kemper
959707bfb6
r1335@iwill: jeremy | 2005-06-17 11:41:50 -0700
...
Ticket 1458 - distance_of_time_in_words
r1336@iwill: jeremy | 2005-06-17 11:44:50 -0700
Update changelog
r1337@iwill: jeremy | 2005-06-17 11:45:44 -0700
Applied patch.
r1361@iwill: jeremy | 2005-06-17 11:48:02 -0700
Merge changelog
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1449 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-17 13:42:23 +00:00
David Heinemeier Hansson
a7a1c4e2cd
Added cuba to country list #1351 [todd]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1440 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:36:09 +00:00
David Heinemeier Hansson
ec6f0a1f51
Fixed radio_button to work with numeric values #1352 [demetrius]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1439 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:34:08 +00:00
David Heinemeier Hansson
665ab93761
Added :extension option to NumberHelper#number_to_phone #1361 [delynnb]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1438 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:33:10 +00:00
David Heinemeier Hansson
43c470fae4
Added button_to as a form-based solution to deal with harmful actions that should be hidden behind POSTs. This makes it just as easy as link_to to create a safe trigger for actions like destroy, although it's limited by being a block element, the fixed look, and a no-no inside other forms. #1371 [tom@moertel.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1437 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:17:51 +00:00
David Heinemeier Hansson
89e06ed4c6
Fixed image_tag so an exception is not thrown just because the image is missing and alt value can't be generated #1395 [Marcel]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:04:23 +00:00
David Heinemeier Hansson
5b3bc3139a
Added a third parameter to TextHelper#auto_link called href_options for specifying additional tag options on the links generated #1401 [tyler.kovacs@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1432 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:00:18 +00:00
David Heinemeier Hansson
691562746f
Fixed TextHelper#highlight to return the text, not nil, if the phrase is blank #1409 [patrick@lenz.sh]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1429 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 05:42:47 +00:00
David Heinemeier Hansson
7b47f150fd
Its Iraq, not Irak #1443 [ivan]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1427 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 05:05:43 +00:00
David Heinemeier Hansson
cc6c48f0a8
Fixed TagHelper such that :name and 'name' keys in the options doesn't result in two attributes #1455 [take_tk]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1426 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 05:04:17 +00:00
Jeremy Kemper
7bb486055e
r1318@iwill: jeremy | 2005-06-15 01:08:22 -0700
...
Ticket 1394 - Helper isolation
r1319@iwill: jeremy | 2005-06-15 01:10:00 -0700
Formulate a test case for helper isolation.
r1331@iwill: jeremy | 2005-06-15 15:21:07 -0700
Update changelog
r1332@iwill: jeremy | 2005-06-15 15:21:30 -0700
Remove superfluous, broken layout_test
r1333@iwill: jeremy | 2005-06-15 15:24:10 -0700
Use an anonymous Module to store helpers per-class instead of tossing them all in template_class. Create a new helper module for subclasses which includes its superclass' helper module. Remove unnecessary ActionView::Base.controller_delegate. Update helper tests.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1425 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-15 17:17:58 +00:00
Jamis Buck
ed7bfc9662
Allow distance_of_time_in_words to work with any value that responds to #to_time (like dates) #969
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1420 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-14 15:19:03 +00:00
Jeremy Kemper
3cb26e9cb3
r2495@sedna: jeremy | 2005-05-27 22:07:18 -0700
...
Branch to have scaffold use new render methods
r2496@sedna: jeremy | 2005-05-28 10:50:51 -0700
axe unused process_request method
r2497@sedna: jeremy | 2005-05-28 10:51:58 -0700
sanity assertions in process method check that @controller, @request, @response are set
r2498@sedna: jeremy | 2005-05-28 10:53:42 -0700
clean up escaping. use instance_variable_get instead of instance_eval. put id in form action instead of hidden input (like the generated scaffolding)
r2499@sedna: jeremy | 2005-05-28 10:54:46 -0700
clean up interpolation, remove tabs from stylesheet
r2500@sedna: jeremy | 2005-05-28 10:56:40 -0700
modernize dynamic scaffolding. use params[:id] instead of @params[id]. use consolidated render method instead of render_action, render_file, etc. use builtin inflections rather than module methods.
r2501@sedna: jeremy | 2005-05-28 11:00:26 -0700
modernize generated scaffolding. use new-style assertions; use params[:id] instead of @params[id]; use consolidated render method instead of render_*
r2542@sedna: jeremy | 2005-06-12 02:24:06 -0700
use :id => model instead of :id => model.id. clean up the form helper method. use flash[:notice] instead of flash['notice'].
r2543@sedna: jeremy | 2005-06-12 02:33:22 -0700
whitespace
r2544@sedna: jeremy | 2005-06-12 02:56:57 -0700
update changelogs
r2545@sedna: jeremy | 2005-06-12 03:26:23 -0700
test dynamic form help when @post is not a new record
r2546@sedna: jeremy | 2005-06-12 03:44:14 -0700
touch up TestCase#process sanity assertions
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-12 05:33:23 +00:00
David Heinemeier Hansson
3162f386dc
Made Action View work with the new render :file/:partial style from the controller
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1379 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-02 20:12:34 +00:00
David Heinemeier Hansson
9bf38dec69
Include flash in the list of attributes with accessors in the view
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1334 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-20 07:04:51 +00:00
David Heinemeier Hansson
7160ab1c18
Fixed escaping of :method option in remote_form_tag #1218 [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1328 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 19:08:16 +00:00
David Heinemeier Hansson
45ee71af3c
Added Serbia and Montenegro to the country_select #1239 [todd@robotcoop.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1323 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 18:30:53 +00:00
David Heinemeier Hansson
473e5bde74
Fixed that compute_public_path should recognize external URLs, so image_tag(" http://www.example.com/images/icon.gif ") is not prefixed with the relative url path #1254 [victor-ronr-trac@carotena.net]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 18:06:12 +00:00
David Heinemeier Hansson
202d5c0751
Added support for descending year values in DateHelper#select_year, like select_year(Date.today, :start_year => 2005, :end_year => 1900), which would count down from 2005 to 1900 instead of the other way #1274 [nwoods@mail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1320 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 17:40:02 +00:00
David Heinemeier Hansson
26022d8d2a
Ajax docing #1282 [Dee.Zsombor@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1318 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 17:29:20 +00:00
David Heinemeier Hansson
496ee0cd1b
Fixed that FormHelper#checkbox should return a checked checkbox if the value is the same as checked_value #1286 [Florian Weber]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1317 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 17:27:08 +00:00
David Heinemeier Hansson
7ec91d4651
Fixed Form.disable in Prototype #1317 [Wintermute]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1311 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 16:45:53 +00:00
David Heinemeier Hansson
aa20834222
Added accessors to logger, params, response, session, and headers from the view, so you can write <% logger.info "stuff" %> instead of <% @logger.info "others" %> -- more consistent with the preferred way of accessing these attributes and collections from the controller
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1307 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 16:00:04 +00:00
David Heinemeier Hansson
86d2b2792a
Added support for POST data in form of YAML or XML, which is controller through the POST_DATA_MARSHAL header
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1304 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-14 08:38:37 +00:00
David Heinemeier Hansson
51f9c931ea
Fixed that render_partial_collection should always return a string (and not sometimes an array, despite <%= %> not caring)
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1302 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-13 16:27:36 +00:00
David Heinemeier Hansson
8983a09752
Go straight to the class for asset_host
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1299 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-09 11:27:39 +00:00
David Heinemeier Hansson
45780be2a7
Added TextHelper#sanitize that can will remove any Javascript handlers, blocks, and forms from an input of HTML. This allows for use of HTML on public sites, but still be free of XSS issues. #1277 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1298 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-09 11:24:18 +00:00
David Heinemeier Hansson
c971c24839
Changed RAILS_ASSET_HOST to become ActionController::Base.asset_host
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1289 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-06 05:10:36 +00:00
David Heinemeier Hansson
dacb61c8ca
Added that both AssetHelper#stylesheet_link_tag and AssetHelper#javascript_include_tag now accept an option hash as the last parameter, so you can do stuff like: stylesheet_link_tag "style", :media => "all"
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1281 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-03 14:39:57 +00:00
David Heinemeier Hansson
d2fb072563
Added FormTagHelper#image_submit_tag for making submit buttons that uses images
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1280 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-03 14:30:53 +00:00
David Heinemeier Hansson
2eebd11e0b
Added the option of specifying a RAILS_ASSET_HOST that will then be used by all the asset helpers. This enables you to easily offload static content like javascripts and images to a separate server tuned just for that.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1279 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-03 10:25:01 +00:00
David Heinemeier Hansson
577a22c47e
Dont benchmark if the logger has been turned off
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1269 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-02 07:05:15 +00:00
David Heinemeier Hansson
90b08c5b92
Fixed documentation #1214
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1254 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:50:10 +00:00
David Heinemeier Hansson
98306bed05
Fixed missing id uniqueness in FormTag#radio_button #1207 [Jarkko]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:46:22 +00:00
David Heinemeier Hansson
fbd86c2017
Added BenchmarkHelper that can measure the execution time of a block in a template and reports the result to the log
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1240 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-27 08:17:25 +00:00
Sam Stephenson
71a616890b
Update to Prototype 1.2.1
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1228 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-19 11:16:50 +00:00
David Heinemeier Hansson
0dd497853a
More documentation #1148 [Alisdair McDiarmid]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1226 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-19 10:59:55 +00:00
David Heinemeier Hansson
865874ab6a
Fixed stringification on all assigned hashes. The sacrifice is that assigns[:person] wont work in testing. Instead assigns["person"] or assigns(:person) must be used. In other words, the keys of assigns stay strings but weve added a method-based accessor to appease the need for symbols.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1223 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-19 10:26:03 +00:00
David Heinemeier Hansson
bceb88ef9c
Fixed that you can now pass an alternative :href option to link_to_function/remote in order to point to somewhere other than # if the javascript fails or is turned off. You can do the same with form_remote_tag by passing in :action. #1113 [Sam Stephenson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1200 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-18 05:15:17 +00:00
Sam Stephenson
d547c3f5ec
Update to Prototype 1.2.0
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1198 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-18 02:16:13 +00:00
David Heinemeier Hansson
dca7efa67e
Deprecated the majority of all the testing assertions and replaced them with a much smaller core and access to all the collections the old assertions relied on. That way the regular test/unit assertions can be used against these. Added documentation about how to use it all.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1189 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 11:38:01 +00:00
David Heinemeier Hansson
8e8bf37aa9
Fixed DateHelper to return values on the option tags such that they'll work properly in IE with form_remote_tag #1024 [rscottmace@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 09:44:28 +00:00
David Heinemeier Hansson
ba96827b3d
Fixed FormTagHelper#check_box to respect checked #1049 [DelynnB]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1183 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 09:39:01 +00:00
David Heinemeier Hansson
c3ca5ab7a8
Added Element.toggle, Element.show, and Element.hide to the prototype javascript library. Toggle.display has been deprecated, but will still work #992 [Lucas Carlson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1181 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 07:52:50 +00:00
David Heinemeier Hansson
ffdd4bc251
Added AssetTagHelper#image_path, AssetTagHelper#javascript_path, and AssetTagHelper#stylesheet_path #1110 [Larry Halff]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1176 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 06:23:27 +00:00
David Heinemeier Hansson
6ee06ebec6
Changed render_partial to take local assigns as the second parameter instead of an explicit object and then the assigns
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1170 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-16 16:08:29 +00:00
David Heinemeier Hansson
82456d9392
Fixed partials handling
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-16 16:06:29 +00:00
David Heinemeier Hansson
f3e5e07982
Added submit_to_remote that allows you to trigger an Ajax form submition at the click of the submission button, which allows for multiple targets in a single form through the use of multiple submit buttons #930 [yrashk@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:44:43 +00:00
David Heinemeier Hansson
2ad8dc6a1f
Added :confirm option to link_to_remote just like link_to has #1082 [yrashk@fp.org.ua]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:21:37 +00:00
David Heinemeier Hansson
c29db9f210
Added minute_step as an option to select_minute (and the helpers that use it) to jump in larger increments than just 1 minute. At 15, it would return 0, 15, 30, 45 options #1085 [ordwaye@evergreen.edu]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:15:41 +00:00
David Heinemeier Hansson
988dc1e862
Improved tests for NumberHelper
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 04:49:01 +00:00
David Heinemeier Hansson
6f5fcc4469
Made error_messages_for take a symbol as object_name
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1148 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-12 17:44:28 +00:00
David Heinemeier Hansson
7140f65355
Moved TextHelper#human_size to NumberHelper#number_to_human_size, but kept an deprecated alias to the old method name
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1147 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-12 08:04:38 +00:00
David Heinemeier Hansson
5cd815addf
Fixed spelling of delimiter #1058
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1134 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 17:30:38 +00:00
David Heinemeier Hansson
ac4b4701c0
Fixed that radio buttons shouldn't have a default size attribute #1074 [hendrik@mans.de] Added ActionView::Helpers::InstanceTag::DEFAULT_RADIO_OPTIONS that contains a hash of default options for radio buttons #1074 [hendrik@mans.de]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1127 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 15:11:15 +00:00
David Heinemeier Hansson
90720a26f6
Fixed syntax error
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1112 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 08:37:26 +00:00
David Heinemeier Hansson
4bdb25da18
Update to the helper to abstract delimeting a number #1015
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1111 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 06:56:49 +00:00
David Heinemeier Hansson
1a22fb59c9
Added JavascriptHelper#periodically_call_remote in order to create areas of a page that update automatically at a set interval #945 [Jon Tirsen]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1108 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 06:43:21 +00:00
David Heinemeier Hansson
480150e5fb
Fixed autolinking to work better in more cases #1013 [Jamis Buck]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1099 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-06 15:22:32 +00:00
David Heinemeier Hansson
a87c1d4dd8
Made it possible to do text_field :account, :name in addition to text_field "account", "name"
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1088 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-04 15:43:17 +00:00
David Heinemeier Hansson
d3a64c04ec
Fixed javascript_include_tag to output type instead of language and conform to XHTML #1018 [Rick Olson]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1081 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-03 16:23:56 +00:00