TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
4,153 Commits 2 Branches 0 Tags 294 MiB
bc85e6ac4c
Commit Graph

638 Commits

Author SHA1 Message Date
Nicholas Seckar
bc85e6ac4c Rename test assertion to prevent shadowing. Closes #6306. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5252 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:20:36 +00:00
Jeremy Kemper
5d1edc55a8 one render per test 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 01:14:38 +00:00
David Heinemeier Hansson
a49e7d5c0c Fixed that NumberHelper#number_to_delimiter should respect precision of higher than two digits (closes #6231) [phallstrom] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5249 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:59:19 +00:00
David Heinemeier Hansson
f9650a23f0 Fixed that caches_action breaks with file extensions (closes #6257) [Catfish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:56:13 +00:00
David Heinemeier Hansson
211ffd3f79 Fixed that FormHelper#radio_button didn't respect an :id being passed in (closes #6266) [evansj] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5247 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:53:59 +00:00
David Heinemeier Hansson
8ff92e2435 Added an html_options hash parameter to javascript_tag() and update_page_tag() helpers #6311 [tzaharia] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:50:11 +00:00
David Heinemeier Hansson
4b3e964a1a Fixed escaping of backslashes in JavaScriptHelper#escape_javascript (closes #6302) [sven@c3d2.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:34:43 +00:00
David Heinemeier Hansson
3c6b7a2191 Fixed that assert_select selects the wrong tag by its contents (closes #6332) [jgarber] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5240 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-09 00:20:31 +00:00
Jeremy Kemper
7ea86773a9 r5515@ks: jeremy | 2006-10-08 13:24:42 -0700 
#6281
 r5516@ks:  jeremy | 2006-10-08 13:29:49 -0700
 respond_to :html doesn't assume .rhtml. Closes #6281.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5232 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-10-08 20:30:24 +00:00
Jeremy Kemper
d15d15b2c2 Deprecate @response 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5207 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 08:26:45 +00:00
Jeremy Kemper
d7b5b44a0e Deprecate @headers 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5206 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 08:12:16 +00:00
Jeremy Kemper
4f3bf6cb23 Deprecate @cookies 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5205 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 08:04:39 +00:00
Jeremy Kemper
643d17ce9e assert_select_rjs decodes escaped unicode chars since the Javascript generators encode them. Closes #6240. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5202 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 07:39:31 +00:00
Jeremy Kemper
d7674637f9 Deprecation: @request will be removed after 1.2. Use the request method instead. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5201 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-29 07:34:02 +00:00
Jamis Buck
c0eccc9aef modify head so that you can specify a bare status code as the first parameter 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5200 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-28 19:32:40 +00:00
Jamis Buck
b2ede64a89 Add ActionController::Base#head for rendering empty responses. Add support for symbolic status codes, as well as for having raw integer statuses expand with their default messages. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5199 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-28 19:13:55 +00:00
Rick Olson
e537de00d8 Fix bug that kept any before_filter except the first one from being able to halt the before_filter chain. [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5196 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-27 04:55:44 +00:00
Jamis Buck
6a8dcc8a5b Make sure map.resources(:things, :new => { :new => :any }) correctly sets /things/new to be accessible by any method rather than creating another resource at /things/new;new 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5195 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-26 22:45:09 +00:00
Jeremy Kemper
c554a9caba strip_links is case-insensitive. Closes #6285. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5191 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-26 16:26:00 +00:00
Nicholas Seckar
8d809e724a Clear the cache of possible controllers whenever Routes are reloaded. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-23 17:25:06 +00:00
Jeremy Kemper
a0c677c8e6 Filters overhaul including meantime filter support for around filters. Closes #5949. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5163 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-22 03:41:03 +00:00
Jeremy Kemper
79821e8bb4 use ActiveRecordTestCase 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5162 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-22 01:59:06 +00:00
Jeremy Kemper
0b61be4666 use :dependent => :destroy rather than :dependent => true 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-22 00:11:33 +00:00
Sam Stephenson
236cf90bf1 Update RJS render tests. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5155 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-20 20:14:12 +00:00
Nicholas Seckar
4ae3db8366 Fix routing to respect user provided requirements and defaults when assigning default routing options (such as :action => 'index'). Closes #5950. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-20 17:45:03 +00:00
Rick Olson
ec030534b1 test default content type for implicit rjs template render 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5143 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-18 16:32:41 +00:00
David Heinemeier Hansson
caa8a00520 Added that respond_to blocks will automatically set the content type to be the same as is requested [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5131 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-17 18:10:25 +00:00
David Heinemeier Hansson
2caf4d5a93 Added proper getters and setters for content type and charset [DHH] Added utf-8 as the default charset for all renders. You can change this default using ActionController::Base.default_charset=(encoding) [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5129 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-17 16:20:32 +00:00
Jeremy Kemper
35ffc1afbe Declare file extensions exempt from layouts. Closes #6219. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5126 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-16 01:31:17 +00:00
Jeremy Kemper
3d3ba58dbb remove implicit primary actions - more pain than gain. test collection actions for other http methods. strip whitespace. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5111 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-14 19:53:04 +00:00
Rick Olson
6dbac689a8 Add chained replace/update support for assert_select_rjs [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5110 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-14 17:50:46 +00:00
David Heinemeier Hansson
73a8d7393f Make sure that formatted routes for all verbs are created. Still needs to resolve two failing tests after this refactoring [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5096 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-13 04:04:19 +00:00
Jeremy Kemper
7661c2b50a Skip params with empty names, such as the &=Save query string from <input type=submit/>. Closes #2569. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-12 20:57:09 +00:00
Jamis Buck
3f0952d9df Fix assert_tag so that :content => "foo" does not match substrings, but only exact strings. Use :content => /foo/ to match substrings. closes #2799 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5086 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-10 02:51:38 +00:00
Jamis Buck
5bf41ed8bc Add test case to test attribute matching by assert_tag 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5082 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-09 22:05:21 +00:00
Thomas Fuchs
8734da9bca Update JavaScriptGenerator#show/hide/toggle/remove to new Prototype syntax for multiple ids, fixes #6068 [petermichaux@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5057 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-07 09:19:35 +00:00
Nicholas Seckar
00685ad8fd Update UrlWriter to support :only_path. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5054 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-06 22:21:36 +00:00
Rick Olson
5360e47431 added passing test for using partials with an xml builder 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5044 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-06 03:51:45 +00:00
David Heinemeier Hansson
83313fccc0 Backed out of locals hash as it caused trouble with Builder, see ticket for more 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5043 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-06 03:38:11 +00:00
David Heinemeier Hansson
8c9ce617c9 Fixed JavaScriptHelper#link_to_function and JavaScriptHelper#button_to_function to have the script argument be optional [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-06 01:31:04 +00:00
David Heinemeier Hansson
1d4d037b0d Added access to nested attributes in RJS (closes #4548) [richcollins@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5004 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-04 20:54:10 +00:00
David Heinemeier Hansson
bf8b101dd6 Fixed that AssetTagHelper#image_tag and others using compute_public_path should not modify the incoming source argument (closes #5102) [eule@space.ch] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5003 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-04 20:43:38 +00:00
David Heinemeier Hansson
c2054c4289 Superseeded by action_caching_test (closes #5173) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5001 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-04 20:39:50 +00:00
David Heinemeier Hansson
9514e4e6ad Deprecated the auto-appending of .png to AssetTagHelper#image_tag calls that doesn't have an extension [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4999 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-04 20:25:43 +00:00
David Heinemeier Hansson
40762a4873 Fixed default routing NoMethodError downcase for nil when default controller provided (closes #5400) [kajism@yahoo.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4998 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-04 20:09:15 +00:00
David Heinemeier Hansson
df70e28e03 Added locals hash to partials, which makes for convenient access of some times available/some times not variables (closes #5491) [wbruce@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4997 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-04 20:01:52 +00:00
David Heinemeier Hansson
d4bb22b220 Fixed TextHelper#simple_format to deal with multiple single returns within a single paragraph (closes #5835) [moriq@moriq.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4994 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-04 19:26:32 +00:00
David Heinemeier Hansson
a693b3beca Fixed TextHelper#pluralize to handle 1 as a string (closes #5905) [rails@bencurtis.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4993 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-04 19:23:07 +00:00
David Heinemeier Hansson
17f7eaa141 Improved resolution of DateHelper#distance_of_time_in_words for better precision (closes #5994) [Bob Silva] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4989 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-04 17:00:37 +00:00
Jeremy Kemper
da8d7a7011 deprecated render assertions 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4977 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-09-04 05:51:48 +00:00