Commit Graph

7161 Commits

Author SHA1 Message Date
Arun Agrawal
bfb84cfb3e Verbose output for tests.
See #3892
2012-02-03 08:01:24 -05:00
Aaron Patterson
2abaa19e77 Merge pull request #4856 from ihid/store_null_bug
Allow store to be a not null column.
2012-02-02 12:07:28 -08:00
Jeremy Walker
58d10e2012 Allow store to be a not null column. 2012-02-02 18:57:15 +00:00
Aaron Patterson
203962d89e *args is already an array. :'( 2012-02-02 10:18:26 -08:00
Rafael Mendonça França
37ce852c51 columns method doesn't have name argument 2012-02-02 16:08:31 -02:00
Aaron Patterson
55686ae5c9 removed whitespace errors 💛💙💜❤️💚 2012-02-02 10:01:11 -08:00
Sebastian Martinez
dcd74eb519 Remove useless argument in #columns. 2012-02-02 10:34:17 -02:00
José Valim
593fe4312f Merge pull request #3892 from arunagw/verbose_rake_test
No Verbose the output for test.
2012-02-02 02:42:28 -08:00
Aaron Patterson
00e192ef1f use the class method to (un)escape binary values 2012-02-01 17:48:28 -08:00
Jon Leighton
66fc1d6ac8 Merge pull request #4543 from jdelStrother/find_or_init
Don't instantiate two objects in collection proxy / find_or_instantiate_by
2012-02-01 15:15:29 -08:00
Rafael Mendonça França
9b1d54e292 Fix typo 2012-02-01 17:14:00 -02:00
Rafael Mendonça França
a73662f3d8 Use human attribute name to show the dependent destroy message 2012-02-01 17:03:15 -02:00
José Valim
403cce77f1 Merge pull request #4828 from railsaholic/fix_error_message
fix has_one, has_many restrict error message
2012-02-01 10:43:40 -08:00
Aaron Patterson
6da8ec14c5 Merge pull request #4806 from KL-7/do-not-serialize-nil
Do not serialize nil in serialized attribute.
2012-02-01 10:39:03 -08:00
Aaron Patterson
78d5d6f868 Merge pull request #4809 from cfeist/feist-sqlite-binary-corruption
Fix for SQLite binary data corrupter (to master branch)
2012-02-01 10:38:26 -08:00
Manoj
907d19343e fix has_one, has_many restrict error message 2012-02-01 23:58:20 +05:30
Vijay Dev
479f3b4054 document the AR none method [ci skip] 2012-02-01 23:31:43 +05:30
Vijay Dev
5850ea0560 fix a typo [ci skip] 2012-02-01 23:31:43 +05:30
Vijay Dev
d2c6400948 Merge branch 'master' of github.com:lifo/docrails 2012-02-01 22:25:52 +05:30
Arun Agrawal
1d3bc506f4 No verbose the output for tests. 2012-02-01 07:21:38 -05:00
Aaron Patterson
d613d60737 Merge pull request #4799 from arunagw/warning_fixed_for_indentations
warning removed: mismatched indentations
2012-01-31 17:36:23 -08:00
Chris Feist
6614668244 Fixed issue with SQLite adapter corrupting binary data 2012-01-31 13:45:00 -06:00
Chris Feist
96359d557d Added test to illustrate bad binary blobs. 2012-01-31 13:45:00 -06:00
Aaron Patterson
c4469e6c39 Revert "Merge pull request #4746 from jenslukowski/issue4718"
This reverts commit 5cad7a0dba652f3e942e58087bc88ba5c5390edc, reversing
changes made to bb842e8d2111e50b21a14b8bd6d89371a4b9cd68.
2012-01-31 11:34:15 -08:00
Jon Leighton
75de1ce131 Merge pull request #4805 from xuanxu/none_and_null_object_pattern
Added `none` query method to return zero records.
2012-01-31 11:17:02 -08:00
Kirill Lashuk
39cb1bedb8 Do not serialize nil in serialized attribute. 2012-01-31 22:07:09 +03:00
Aaron Patterson
d6e41f364a QueryCache will just dup an AR::Result, AR::Result can deep copy 2012-01-31 10:59:50 -08:00
Aaron Patterson
c091ab0207 always return the result set from select_all 2012-01-31 10:58:16 -08:00
Aaron Patterson
40ce682048 made the result set object act more like an array 2012-01-31 10:58:16 -08:00
Aaron Patterson
d9c48626f9 Merge pull request #4742 from petervandenabeele/master
Set the timezone correctly for a test in activerecord/../base_test.rb
2012-01-31 10:55:00 -08:00
Aaron Patterson
5cad7a0dba Merge pull request #4746 from jenslukowski/issue4718
Test and fix for issue 4718
2012-01-31 10:53:16 -08:00
Juanjo Bazán
8270e4a8ce Added none query method to return zero records.
And added NullRelation class implementing the null object pattern for the `Relation` class.
2012-01-31 19:50:09 +01:00
José Valim
3bf859daf6 Merge pull request #4791 from gregolsen/reflection_test_fixed
reflection test fixed
2012-01-31 08:45:01 -08:00
Rafael Mendonça França
f944d528c4 Remove deprecation warnings from tests 2012-01-31 14:22:58 -02:00
Rafael Mendonça França
62c955db79 Put spaces between the words at deprecation warning 2012-01-31 14:22:10 -02:00
Arun Agrawal
ae3b015aa8 warning removed: mismatched indentations 2012-01-31 11:18:55 -05:00
gregolsen
b00a5e6e51 test_get_ids_for_ordered_association fixed 2012-01-31 18:16:48 +02:00
Carlos Antonio da Silva
31fce0192e Improve readonly examples and optimistic locking docs
* Relation#order can receive order attributes as different arguments,
  add example;
* Readonly does not handle deletion of records, only modification;
* locking_version column does not need to default to 0, Rails handles
  nil values;
* Change references from "set_locking_column" to "self.locking_column".
2012-01-31 12:09:09 -02:00
gregolsen
58cd0085a9 reflection test fixed 2012-01-31 15:57:39 +02:00
Jon Leighton
98e1735d1d Merge pull request #4783 from gregolsen/ids_reader_fix
ids_reader method fixed, test added to has_many association (for PostgreSQL)
2012-01-31 05:47:41 -08:00
Jon Leighton
30a2328003 Merge pull request #4727 from railsaholic/dependent_restrict_should_add_error
has_many/has_one, :dependent => :restrict, deprecation added
2012-01-31 05:45:04 -08:00
Arun Agrawal
ae0b4728ea warning removed: shadowing outer local variable - klass 2012-01-31 07:03:44 -05:00
gregolsen
f13a1dd781 ids_reader method fixed, test added to has_many association 2012-01-31 11:52:23 +02:00
Manoj
23074c81a5 suggested fixes for :dependent => :restrict deprecation. 2012-01-31 14:11:14 +05:30
Paco Guzman
3053f52671 Same method for has_many and has_one associations 2012-01-31 14:10:19 +05:30
Paco Guzman
38ffca55ab Easy dependent_restrict error message 2012-01-31 14:09:18 +05:30
Jon Leighton
920030b3d5 Merge pull request #4763 from kennyj/fix_4754
[MySQL] Fix GH #4754. Remove double-quote characters around PK when using sql_mode=ANSI_QUOTES
2012-01-31 00:20:05 -08:00
Jon Leighton
49e69237c4 Merge pull request #4732 from pwim/refactor-dynamic-match
Refactor dynamic match
2012-01-30 23:37:09 -08:00
Paul McMahon
b08bf99792 Use conditional instead of try 2012-01-31 09:32:42 +09:00
Xavier Noria
de161003c3 query cache instrumentation should included the bindings in the payload [closes #4750] 2012-01-30 13:47:42 -08:00