TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
27,757 Commits 2 Branches 0 Tags 294 MiB
c5ebbfaf5b
Commit Graph

8204 Commits

Author SHA1 Message Date
José Valim
e2cc653876 Do not deprecate performed. 2012-01-19 19:52:10 +01:00
Vijay Dev
2c7ded31fb Merge branch 'master' of github.com:lifo/docrails 2012-01-19 22:11:17 +05:30
Rafael Mendonça França
71597f9d51 Extract method_tag 2012-01-19 10:38:08 -03:00
Rafael Mendonça França
047097950f Refactor button_to helper to use token_tag method 2012-01-19 10:37:21 -03:00
Simon Baird
faec7acc24 Fix small typo in mail_to docs in url_helper.rb 2012-01-19 17:33:29 +10:00
Rafael Mendonça França
64a937affa Remove delegation to ActionController::Base 2012-01-18 15:42:08 -03:00
Rafael Mendonça França
5a6ea53514 ActionView now has its own logger 2012-01-18 14:30:33 -03:00
kennyj
38204eb1ce Fix warning: assigned but unused variable - result 2012-01-19 01:43:59 +09:00
Carlos Antonio da Silva
56089ca986 Refactor FormBuilder arguments and default config 
* Do not reopen AV::Base to define default form builder
  Inside the load hook we are already in AV::Base context.

* Do not pass the given block to the form builder
  The block is evaluated in fields_for context using capture, with the
  builder as argument. This means we do not need to give the block to the
  FormBuilder itself.
 2012-01-18 10:22:03 -02:00
José Valim
d4a9ce8ec0 Merge pull request #4509 from rafaelfranca/form_tag-refactor 
Refactor form_for and form_tag
 2012-01-17 23:33:02 -08:00
José Valim
2de2ea8879 Merge pull request #4510 from carlosantoniodasilva/av-content-tag-for 
ActionView content_tag_for refactoring and improvements
 2012-01-17 23:31:43 -08:00
Guillermo Iguaran
226783d1e8 Silent Sprockets logger when config.assets.logger is set to false 2012-01-17 22:05:56 -05:00
Carlos Antonio da Silva
8470fc9902 Fix errors when running entire suite due to class name collision 
The Post class is created everywhere in the test suite, and due to that
when applying the Array() logic to refactor content_tag_for, some other
change to the Post class was breaking record tag tests.

The solution is to rename the class to not collide with others
already defined in the test suite.
 2012-01-18 00:46:01 -02:00
Carlos Antonio da Silva
b64b7d09c0 Cleanup Post model, no need to require fake_models 2012-01-18 00:45:06 -02:00
Carlos Antonio da Silva
dcad385420 Refactor content tag to not detect options Hash always 
Only check for options and prefix arguments order once when running
content_tag_for with a collection.
 2012-01-18 00:45:03 -02:00
Carlos Antonio da Silva
ba77ff3c1b Do not mutate options hash 2012-01-18 00:44:26 -02:00
Carlos Antonio da Silva
22ffc3dcea Cleanup persisted setup for model 2012-01-18 00:44:26 -02:00
Carlos Antonio da Silva
53381be007 Mimic AR models yielding when building new records, avoid using tap 2012-01-18 00:44:25 -02:00
Carlos Antonio da Silva
5c997ccadd No need for concat as well 2012-01-18 00:44:25 -02:00
Carlos Antonio da Silva
69512e1a0e Add test for content tag with prefix and extra html options 2012-01-18 00:44:25 -02:00
Tim Cooper
f4551ca7ac Remove capture. 2012-01-18 00:44:17 -02:00
Tim Cooper
67681cb103 Always treat the object passed to content_tag_for as an array. 2012-01-18 00:43:45 -02:00
Rafael Mendonça França
c65f79deae No need to call html_safe since concat two SaffeBuffers always results in a SafeBuffer 2012-01-17 23:34:17 -03:00
Rafael Mendonça França
014da68634 Use block syntax to avoid code duplication 2012-01-17 23:20:51 -03:00
Rafael Mendonça França
336f973763 No need to create a SafeBuffer since form_tag_html always rerturn a SafeBuffer 2012-01-17 22:54:27 -03:00
Xavier Noria
57aaaa6197 Merge pull request #4488 from rafaelfranca/av-refactor 
ActionView::Helpers::FormHelper refactoring
 2012-01-17 14:08:09 -08:00
Rafael Mendonça França
6f1bf526d7 Extract input_checked? to a module 2012-01-17 18:52:48 -03:00
José Valim
ba154bd76f Merge pull request #4497 from carlosantoniodasilva/action-controller-refactor 
Action controller refactor - remove Compatibility module
 2012-01-17 12:00:05 -08:00
Rafael Mendonça França
8b4c74f77c Do not need of ActionView::Helpers scope since we are inside 
ActionView::Helpers
 2012-01-17 15:07:05 -03:00
Aaron Patterson
ee190b8e6d Merge pull request #4500 from kennyj/should_deprecate_rails_cache 
[Proposal] We should deprecate the RAILS_CACHE constant.
 2012-01-17 09:04:21 -08:00
kennyj
6f8159c421 Deprecate RAILS_CACHE constant. 2012-01-18 01:53:09 +09:00
Rafael Mendonça França
e275817116 Add option to configure Sprockets logger 2012-01-17 13:25:45 -03:00
Carlos Antonio da Silva
96a817fb2c Update changelog 2012-01-17 11:08:51 -02:00
Carlos Antonio da Silva
e5e9a4cc76 Bring back rendering templates that start with / in nested structures 2012-01-17 10:04:39 -02:00
Carlos Antonio da Silva
0b7548fab1 Move protected instance variables definition, kill compatibility module 2012-01-17 10:04:39 -02:00
Carlos Antonio da Silva
cb650a50bf Remove deprecated default_charset= from AC::Base 
This should be set globally as a configuration, using
`config.action_dispatch.default_charset` instead
 2012-01-17 10:04:39 -02:00
Carlos Antonio da Silva
67c96ab024 Move render_to_body logic to return a spaced string to AC::Rendering 
This seems to be required only when calling render :partial with an
empty collection from a controller. This call happens to return no
content, letting the response body empty, which means to Rails that it
should go on and try to find a template to render based on the current
action name, thus failing hard.

Although tests keep all green, we need to check a better way to fix
this.
 2012-01-17 10:04:38 -02:00
Carlos Antonio da Silva
a977b2588e Remove method missing handling when action is not found, use action missing instead 
Do not create a method_missing method to handle not found actions, use
the action_missing method provided by Rails instead.
 2012-01-17 10:04:38 -02:00
Carlos Antonio da Silva
53596d0913 Refactor render nothing/text => nil logic, and move to right place 
Options :nothing and :text => nil should be handled by
ActionController::Rendering instead.
 2012-01-17 10:04:38 -02:00
Carlos Antonio da Silva
6244d16eaf Move render :nothing and :text => nil options to AC::Rendering 2012-01-17 10:04:38 -02:00
Carlos Antonio da Silva
562a12df29 Rename test class and fix tests to keep consistency 
Based on 50d23bc2bd3653b3c66e480c22ae97c5f7fd7f62.
 2012-01-17 10:04:38 -02:00
Carlos Antonio da Silva
bb33e88833 Remove deprecated logic to render templates starting with / 
render :template => "/foo/bar"
 2012-01-17 10:04:38 -02:00
Carlos Antonio da Silva
497004858d Remove relative url root setting from ENV var 
This is already being set by Rails configuration.
 2012-01-17 10:04:37 -02:00
Carlos Antonio da Silva
71566c3573 Remove rescue_action from compatibility module and tests 2012-01-17 10:04:37 -02:00
Carlos Antonio da Silva
1ae9e60b8a Remove other old compatibility constants 2012-01-17 10:04:37 -02:00
Carlos Antonio da Silva
6f8b1e3a85 Remove constant already defined in exceptions module 2012-01-17 10:04:37 -02:00
Carlos Antonio da Silva
bc50cb31d6 Remove old compatibility methods not being used 2012-01-17 10:04:37 -02:00
Rafael Mendonça França
ad44ece292 Remove unused code 2012-01-17 00:05:31 -03:00
Rafael Mendonça França
c048f0ba83 Do not need each here anymore 2012-01-17 00:05:31 -03:00
Rafael Mendonça França
f6fc352927 Extract DatetimeSelect 2012-01-17 00:05:31 -03:00