Jeremy Kemper
fe013ce934
Fix performance regression
2009-01-16 20:36:59 -08:00
Jeremy Kemper
78af271069
Skip respond_to check so rack.input doesn't have to implement it
2009-01-16 20:36:59 -08:00
Mike Gunderloy
1e02d95d60
Make ActioMailer quoting test play nice with Ruby 1.9 [ #1726 state:resolved]
...
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
2009-01-16 17:25:37 +00:00
Josh
7260852187
Fix date_select within fields_for with an index [ #1666 state:resolved] [Josh, Frederick Cheung]
...
Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com>
2009-01-16 17:23:43 +00:00
Brandon Keepers
452cd74d81
Dup keys in OrderedHash to prevent them from being modified [ #1676 state:resolved]
...
Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com>
2009-01-16 17:23:43 +00:00
Carlos Kozuszko
5ed119c005
Fix dirty handling of nullable non-integer numeric columns [ #1692 state:resolved]
...
Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com>
2009-01-16 17:23:35 +00:00
Ben VandenBos
0e92f67073
Make belongs_to :dependent => :destroy destroy self before associated object [ #1079 state:resolved]
...
If foreign key constraints are in place then deleteing the associated object first will cause a foreign key violation
Signed-off-by: Frederick Cheung <frederick.cheung@gmail.com>
2009-01-16 17:23:19 +00:00
Michael Koziarski
f2ee3f20df
Fix the AR json serialization tests to comply with the earlier change to quote keys correctly
2009-01-16 17:57:45 +13:00
Michael Koziarski
0bed5bdb21
Properly quote json keys.
...
According to the RFC and the json.org site all json keys must be strings, and those strings must be quoted with double quotes.
[#1755 state:committed]
2009-01-16 17:40:04 +13:00
Nahum Wild
a53ad5bba3
Added in a local per request cache to MemCacheStore. It acts as a buffer to stop unneccessary requests being sent through to memcache [ #1653 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-01-15 21:29:32 -06:00
Michael Lovitt
7a0e7c7270
Fixed broken after_save callback; was being called when before_create was canceled or before_update was canceled
...
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1735 state:committed]
2009-01-16 10:11:58 +13:00
Carlos Kozuszko
c891d685de
Fixing bug on ActiveRecord::Dirty#field_changed? for nullable numeric columns, NULL gets stored in database for blank (i.e. '') values. Only integer columns were considered.
...
Signed-off-by: Michael Koziarski <michael@koziarski.com>
[#1692 state:committed]
2009-01-16 10:00:39 +13:00
Yehuda Katz
b8fadd708b
Sync 'rails/rails/master'
2009-01-14 16:48:57 -08:00
Hongli Lai (Phusion)
9bcf01b23c
Fix PostgreSQL unit test failures that only occur when using the old 'postgres' driver.
...
[#1748 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-01-13 15:58:50 -08:00
Joshua Peek
b281a6a5b2
Use Rack's MethodOverride lib [ #1699 state:resolved]
2009-01-13 17:26:29 -06:00
Joshua Peek
9775c25824
Update multipart tests to expose (another) bug in Rack's multipart parser
2009-01-13 17:21:45 -06:00
Yehuda Katz
f65333a4cf
Sync 'rails/rails/master'
2009-01-13 14:24:14 -08:00
Joshua Peek
1adc1496f9
Add RewindableInput wrapper to fix issues with middleware that impolitely eat up non-rewindable input
2009-01-13 16:09:51 -06:00
Yehuda Katz
0932b012fa
Sync 'rails/rails/master'
2009-01-13 13:28:28 -08:00
Bryan Ash
5a43908c74
Explicitly read as binary in multipart_body for Windows [ #1065 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-01-13 14:42:43 -06:00
Cody Fauser
d3107ce3b0
Use :key instead of old :session_key in session_store.rb generator and docs [ #1746 state:resovled]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-01-13 14:27:23 -06:00
Cody Fauser
b6a94fc1c6
Remove legacy reloadable? method from ActiveRecord::SessionStore [ #1745 state:resolved]
...
Signed-off-by: Joshua Peek <josh@joshpeek.com>
2009-01-13 13:45:10 -06:00
Pratik Naik
c99ef814b0
Revert "HTTP Digest authentication [ #1230 state:resolved]"
...
This reverts commit 45dee3842d68359a189fe7c0729359bd5a905ea4.
Reasons :
1. The code is not working in it's current state
2. Should not be using exceptions for flow control
2009-01-13 16:13:42 +00:00
Pratik Naik
5339f813be
Change Object#try to raise NoMethodError on private methods and always return nil when Object is nil [Pratik Naik, Lawrence Pit]
2009-01-13 03:28:32 +00:00
Yehuda Katz
6fe739ad75
Sync 'rails/rails/master'
2009-01-11 13:02:44 -08:00
Nicholas Dainty
296ca4da17
TimeWithZone#xmlschema accepts optional fraction_digits argument [ #1725 state:resolved]
2009-01-11 13:56:07 -06:00
Jeremy Kemper
f1fff0a480
Merge branch 'master' of git@github.com:rails/rails
2009-01-10 15:09:08 -08:00
Joshua Peek
18cb0493d1
Refactor request urlencoded params parsing tests
2009-01-10 16:02:03 -06:00
Jeremy Kemper
ab0ce052ba
Introduce transaction_joinable flag to mark that the fixtures transaction can't joined, a new savepoint is required even if :requires_new is not set. Use :requires_new option instead of :nest. Update changelog.
...
[#383 state:committed]
2009-01-10 13:39:37 -08:00
Jeremy Kemper
223a1d9451
Merge branch 'master' into savepoints
2009-01-10 12:14:44 -08:00
Joshua Peek
9fe69b225c
Moved query string parsing tests into the request tests folder
2009-01-10 11:39:57 -06:00
Joshua Peek
92dbf5ba83
Refactor request multipart params parsing tests
2009-01-10 11:32:38 -06:00
Yehuda Katz
e8980ad278
Sync 'rails/rails/master'
2009-01-09 18:58:47 -08:00
Joshua Peek
40a75a5091
Refactor request xml params parsing tests
2009-01-09 16:05:27 -06:00
Joshua Peek
38a723e6ea
Refactor request json params parsing tests
2009-01-09 15:43:32 -06:00
Joshua Peek
ac4bf1180a
Ensure we override Rack::Request's POST method too
2009-01-09 13:12:39 -06:00
Joshua Peek
282c1d6159
Refactor request query string parsing tests
2009-01-09 12:52:59 -06:00
Joshua Peek
e1f73aab8c
Inherit ActionController::Request from Rack::Request
2009-01-09 11:47:44 -06:00
Pratik Naik
e0fa041fce
Process time should be wall time when benchmarking
2009-01-09 16:46:24 +00:00
Jeremy Kemper
bb03719943
Fix test broken by test process changes
2009-01-09 00:14:28 -08:00
Jeremy Kemper
431e696b89
Remove Content-Length header from :no_content responses
2009-01-09 00:14:28 -08:00
Jeremy Kemper
72c9834666
Set assigns for integration tests also
2009-01-09 00:14:28 -08:00
Jeremy Kemper
d99b4ec57f
Take care not to mix in public methods
2009-01-09 00:14:28 -08:00
Jeremy Kemper
e3be52c1dd
Use instance_eval instead of adding an accessor to the class
2009-01-09 00:14:28 -08:00
Jeremy Kemper
cf09fa74f7
Include process methods in ActionController::TestCase only. No need to alias_method_chain :process either.
2009-01-09 00:14:27 -08:00
Jeremy Kemper
c2d23affad
Object#tap for Ruby < 1.8.7
2009-01-09 00:14:27 -08:00
Pratik Naik
b1530545d2
Fix JSON decoder date-converter regexp [ #1662 state:resolved] [Jonathan del Strother]
2009-01-09 00:14:27 -08:00
Michael Koziarski
84e6ad3fb9
Spam people with commit rights on test failures.
2009-01-09 00:14:27 -08:00
Mike Gunderloy
a08bbd6a4c
Update CI configuration to reflect latest gems.
2009-01-09 00:14:27 -08:00
Jeremy Kemper
859e1508be
Fix test broken by test process changes
2009-01-07 16:37:32 -08:00