Dillon Welch
d108288c2f
Turn on performance based cops
...
Use attr_reader/attr_writer instead of methods
method is 12% slower
Use flat_map over map.flatten(1)
flatten is 66% slower
Use hash[]= instead of hash.merge! with single arguments
merge! is 166% slower
See https://github.com/rails/rails/pull/32337 for more conversation
2018-07-23 15:37:06 -07:00
Xavier Noria
96d2c228e3
OS X -> macOS [ Closes #30313 ]
...
[Jon Moss & Xavier Noria]
2018-06-23 08:46:40 +02:00
Daniel Colson
a1ac18671a
Replace assert ! with assert_not
...
This autocorrects the violations after adding a custom cop in
3305c78dcd.
2018-04-19 08:11:33 -04:00
Pat Allan
acea68de02
Adding frozen_string_literal pragma to Railties.
2017-08-14 19:08:09 +02:00
Matthew Draper
87b3e226d6
Revert "Merge pull request #29540 from kirs/rubocop-frozen-string"
...
This reverts commit 3420a14590c0e6915d8b6c242887f74adb4120f9, reversing
changes made to afb66a5a598ce4ac74ad84b125a5abf046dcf5aa.
2017-07-02 02:15:17 +09:30
Kir Shatrov
cfade1ec7e
Enforce frozen string in Rubocop
2017-07-01 02:11:03 +03:00
Rafael Mendonça França
fe1f4b2ad5
Add more rubocop rules about whitespaces
2016-10-29 01:17:49 -02:00
Xavier Noria
783763bde9
applies new string literal convention in railties/test
...
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
2016-08-06 19:16:09 +02:00
Rafael Mendonça França
6b1e67e1a1
Fix file name
...
This is a leftover of #19867
2015-05-27 21:48:01 -03:00
Ryan Bigg
f9640b0900
Remove redundant 'Rails' from Rails::AppRailsLoader constant
2015-05-21 16:50:41 +10:00
