TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
48,832 Commits 2 Branches 0 Tags 294 MiB
cc9b813a82
Commit Graph

48832 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Lucas Caton
93fb7c76b1 Updating guides for Rails 5.0 [ci skip] 2015-01-02 09:05:59 +10:00
Sean Griffin
8b07f18599 Stop explicitly passing nil as the column to type_cast 
So we can change the arity later.
 2015-01-01 11:24:29 -07:00
Sean Griffin
667b3ef873 Stop depending on columns for type information in PG quoting tests 
A few of the tests weren't testing anything of value. The IP Address
tests are testing the type, not behavior of the connection adapter.
There are two CVE regression tests which are important, but don't have a
good place to go, so I've left them alone for now, as they call `quote`
and the focus right now is removing `column` from `type_cast`
 2015-01-01 10:39:14 -07:00
Sean Griffin
d08dc37959 Stop relying on columns for type information in mysql2 casting tests 
The column itself has no actual impact on the return value. These were
actually testing the behavior of the type object, which is sufficiently
covered elsewhere.
 2015-01-01 10:11:33 -07:00
Sean Griffin
45973ac3c7 Stop relying on columns in mysql quoting tests 
The behavior tested by the removed lines is sufficiently covered
elsewhere.
 2015-01-01 10:07:54 -07:00
Sean Griffin
19537ecd0f Stop relying on columns in sqlite quoting tests 
The string encoding test wasn't using the types for anything. The
boolean casting test included logic that should be in the tests for the
types, and the string test was legitimately not testing anything useful.
 2015-01-01 10:00:08 -07:00
Sean Griffin
03f6e235a3 💣 I forgot to commit the arity change 2015-01-01 09:51:48 -07:00
Sean Griffin
cab75da939 Don't rely on the column for type information in uniquness validations 
The validator has access to richer type information
 2015-01-01 09:44:37 -07:00
Sean Griffin
3fd78fc569 Don't load an entire table into memory to copy it on SQLite 
SQL has mechanisms we can use to copy data from one table into another.
 2015-01-01 09:33:03 -07:00
Sean Griffin
c5e5dbed1c Stop using the column for type information in sanitization 
As we move towards removing the types from the column objects, any
remaining places which have access to richer type information should be
using it.
 2015-01-01 09:09:20 -07:00
Sean Griffin
8f8f8058e5 Stop passing the column to the connection adapter when quoting defaults 
The column is no longer used for anything besides type casting, which is
what we're trying to remove from the column entirely.
 2015-01-01 09:00:05 -07:00
Robin Dupret
24637e577c Merge pull request #18271 from arunagw/change-copyright-year 
Update copyright notices to 2015 [ci skip]
 2015-01-01 00:08:17 +01:00
Carlos Antonio da Silva
777c45e6a5 Merge pull request #18275 from robin850/head-status 
Correctly use the response's status code calling head
 2014-12-31 16:52:27 -02:00
Robin Dupret
ae08bef428 Changelog edits [ci skip] 2014-12-31 17:35:41 +01:00
Robin Dupret
f2b31cd6d1 Tiny follow-up to #18260 [ci skip] 
Indent the list content by 4 spaces instead of 2 to match the other
changelog files. Also wrap the lines around 80 chars.

Finally update the documentation example with nit-picky things.
 2014-12-31 17:35:41 +01:00
Arun Agrawal
c7a1f70fdd Merge pull request #18277 from prathamesh-sonpatki/typo-aj-changelog 
Fixed typo in ActiveJob CHANGELOG [ci skip]
 2014-12-31 17:32:44 +01:00
Prathamesh Sonpatki
c8e4d0a0a1 Fixed typo in ActiveJob CHANGELOG [ci skip] 2014-12-31 21:59:37 +05:30
Sean Griffin
4d7c74d293 Merge pull request #18272 from kamipo/fix_warning_assigned_but_unused_variable 
Fix warning: assigned but unused variable - post
 2014-12-31 09:15:36 -07:00
Robin Dupret
7ef7f1cc15 Correctly use the response's status code calling head 
Commit 20fece1 introduced the `_status_code` method to fix calls to
`head :ok`. This method has been added on both ActionController::Metal
and ActionDispatch::Response.

As for the latter, this method is just equivalent to the `response_code`
one so commit aefec3c removed it from the `Reponse` object so call to
the `_status_code` method on an ActionController::Base instance would be
handled by the `Metal` class (which `Base` inherits from) but the status
code is not updated according to the response at this level.

The fix is to actually rely on `response_code` for ActionController::Base
instances but this method doesn't exist for bare Metal controllers so we
need to define it.
 2014-12-31 16:37:35 +01:00
Robin Dupret
5ac4680cd3 Merge pull request #18276 from y-yagi/fix_rake_command 
fix rake command typo in Testing guide [ci skip]
 2014-12-31 14:47:33 +01:00
yuuji.yaginuma
54368bb339 fix rake command typo in Testing guide [ci skip] 2014-12-31 22:36:22 +09:00
Robin Dupret
7d1718f49e Merge pull request #18274 from rajcybage/spell_fix 
Fix spell life cycle on activejob docs [ci skip]
 2014-12-31 11:26:23 +01:00
Rajarshi Das
0f80b9f997 Fix spell life cycle on activejob docs [ ci skip] 2014-12-31 15:51:37 +05:30
Yves Senn
8b2a5990a5 Merge pull request #18269 from cuppincake/getting-started-migration-update 
Update Getting Started guide to reflect foreign key in migration [ci skip]
 2014-12-31 09:17:58 +01:00
Ryuta Kamizono
42b45b1980 Fix warning: assigned but unused variable - post 2014-12-31 17:04:08 +09:00
Arun Agrawal
4de18d0ead Update copyright notices to 2015 [ci skip] 2014-12-31 08:34:14 +01:00
Cristian Bica
ca605fa47a Merge pull request #18270 from prathamesh-sonpatki/activejobs-is-not-actionjob 
ActiveJob is not ActionJob [ci skip] 😄
 2014-12-31 08:01:59 +02:00
Prathamesh Sonpatki
2ecee1034d ActiveJob is not ActionJob [ci skip] 😄 2014-12-31 11:27:32 +05:30
Jennifer Wollesen
0591e852d2 Update Getting Started guide to reflect foreign key in migration [ci skip] 2014-12-30 22:41:54 -07:00
Zachary Scott
070f556c3a Add Profiling guide skeleton [ci skip] 2014-12-30 17:05:10 -08:00
Rafael Mendonça França
1ea6cc1121 Extract the index length validation to a auxiliar method 2014-12-30 21:17:22 -03:00
Rafael Mendonça França
3d51da3964 Merge pull request #18264 from yahonda/rename_index_mysql 
Raise a better exception for renaming long indexes for mysql adapters
 2014-12-30 21:13:39 -03:00
Rafael Mendonça França
0d1ab34915 Merge pull request #18266 from cristianbica/ajfixes 
ActiveJob testing improvements
 2014-12-30 21:05:29 -03:00
Rafael Mendonça França
04852b875e Fix error message when trying to create an associated record 
This error only happens when the foreign key is missing.

Before this fix the following exception was being raised:

    NoMethodError: undefined method `val' for #<Arel::Nodes::BindParam:0x007fc64d19c218>

Now the message is:

    ActiveRecord::UnknownAttributeError: unknown attribute 'foreign_key' for Model.
 2014-12-30 21:02:46 -03:00
David Heinemeier Hansson
a4d5e83560 Merge pull request #18260 from isaacseymour/active-job-delegate-deserialize 
ActiveJob: delegate deserialization to the job class
 2014-12-30 15:39:29 -08:00
Isaac Seymour
65542e2797 ActiveJob: delegate full deserialization to class 2014-12-30 23:33:09 +00:00
Aaron Patterson
4080dd2f24 stop referencing env in url_for 
encapsulate env in the request so that we can eventually move away from
the env hash
 2014-12-30 15:18:20 -08:00
Aaron Patterson
87a7591064 use methods on the request rather than direct hash access 
this will help decouple us from using the rack env hash
 2014-12-30 14:48:10 -08:00
Sean Griffin
77a9486ba6 Merge pull request #18242 from brainopia/has_one_loading_for_new_record 
Load a has_one target for a new record if possible
 2014-12-30 15:47:03 -07:00
Aaron Patterson
6818c2c64d Merge pull request #18219 from jaroslawr/master 
Flatten the call stacks ActiveSupport::Callbacks produces, fix #18011.
 2014-12-30 14:15:39 -08:00
brainopia
7f3b246b99 Share foreign_key_present? implementation in _has_ associations 2014-12-31 00:19:09 +03:00
Yasuo Honda
c96acd18c0 Raise a better exception for renaming long indexes for mysql adapters 2014-12-30 20:34:41 +00:00
Sean Griffin
322750e213 Merge pull request #17680 from larskanis/fix_bytea_change_detection 
PostgreSQL, Fix change detection caused by superfluous bytea unescaping
 2014-12-30 13:33:42 -07:00
Zachary Scott
45280686ed Move Engines guide under Extending Rails [ci skip] 2014-12-30 12:23:41 -08:00
Zachary Scott
a7e9790821 Merge pull request #18262 from benwoody/fix-cycle-doc-missprint 
Fixes simple missprint in docs for #cyle in text_helper [ci skip]
 2014-12-30 12:17:04 -08:00
Zachary Scott
0bf8dba2a3 Merge pull request #18263 from mntj/fix_typo_in_comment 
Fix comment typo in debugger.rb [ci skip]
 2014-12-30 12:16:19 -08:00
Ben Woodall
7b4c6dca43 Fixes simple missprint in docs for #cyle in text_helper 2014-12-30 12:09:47 -08:00
mntj
cb97312801 Fix comment typo in debugger.rb 2014-12-30 15:00:17 -05:00
Zachary Scott
996e646bd8 The Guide to Testing Rails Applications is published! 🎉 🎉 [ci skip] 2014-12-30 11:13:20 -08:00
Zachary Scott
5c35f704d1 Replace exhaustive list of methods with pointer to API docs. [ci skip] 2014-12-30 11:07:38 -08:00