TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
16,174 Commits 2 Branches 0 Tags 294 MiB
ce48b3103a
Commit Graph

3711 Commits

Author SHA1 Message Date
Santiago Pastorino
ce48b3103a Makes validates_acceptance_of to not override database fields [#4460 state:committed] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-04-28 23:12:03 +02:00
Curtis Hawthorne
7e06494e32 Destroy respects optimistic locking. 
Now works with :dependent => :destroy and includes unit tests for that
case.  Also includes better error messages when updating/deleting stale
objects.

[#1966 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-27 21:53:51 -07:00
Andrew White
8ec085bf18 Support fixtures for namespaced models [#2965 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-04-25 16:04:38 +02:00
Jeremy Kemper
bd3cc6bfff Remove quoted_string_prefix entirely since PostgreSQL was the only database adapter relying on it. 2010-04-24 16:27:20 -07:00
Jeremy Kemper
426f93b751 PostgreSQL: always rely on pg driver for escape/unescape and quoting duties 2010-04-24 15:38:36 -07:00
Jeremy Kemper
dac80f779d PostgreSQL: use standard-conforming strings if possible 2010-04-24 15:27:18 -07:00
Jeremy Kemper
2538ef0d09 Use Array.wrap to quiet 1.8.8 deprecation 2010-04-24 13:12:07 -07:00
Jeremy Kemper
70625badcf Drop support for postgres driver. Use pg >= 0.9.0. 2010-04-24 12:27:56 -07:00
Jeremy Kemper
d692e6be30 Restore HWIA#stringify_keys! and update changelog 2010-04-22 10:00:23 -07:00
José Valim
9476daa829 Speed up xml serializer by computing values just once and remove unecessary code duplication. 2010-04-22 12:29:08 +02:00
Santiago Pastorino
961aa70e4a Some require indifferent_access added 
Signed-off-by: Xavier Noria <fxn@ubuntu.(none)>
 2010-04-21 07:45:29 -07:00
Pratik Naik
2ff73039bd Build PredicateBuilder object only when needed 2010-04-21 02:43:52 +01:00
José Valim
2e3d903e1b Move observers initialization to after_config blocks, they are still being initialized to early (before load paths are being set). 2010-04-20 21:19:48 +02:00
Phil Smith
64373937a3 Make the migration generator handle pre-existing migrations with the same timestamp. 
In the event a migration already exists with that number, the new migration's timestamp will be incremented by 1.

[#4412 state:resolved]

Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2010-04-19 14:48:31 +12:00
Santiago Pastorino
c4846c99c5 Missing require added 2010-04-18 00:12:08 -03:00
Aaron Patterson
b7693dc028 working around syck defects by optionally matching a space [#4426 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-04-17 00:50:59 -04:00
Aaron Patterson
d92e3111fe making yaml tests less specific to emitter. [#4425 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-04-17 00:41:10 -04:00
Aaron Patterson
cd6578f6a1 fixing invalid yaml [#4424 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-04-17 00:14:23 -04:00
Mislav Marohnić
2161b8745a improve how ActiveRecord::Observer defines callbacks on observed models 
Instead of using a single `notify_observers` call for every callback type,
each observer now registers a unique callback for itself. Example:

  before_save :_notify_user_observer_for_before_save

  def _notify_user_observer_for_before_save
    observer.update(:before_save, self)
  end

Benefit: "before" callbacks halt when `observer.update` returns false.
This way, ActiveRecord observers can prevent records from saving.

[#4087 state:committed]

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-16 13:12:53 -07:00
Mislav Marohnić
c2ca73c9ee ActiveModel::Observing: stop using Observable Ruby module, re-implement notify_observers 
`Observable#notify_observers` from Ruby always returns false (which halts ActiveRecord
callback chains) and has extra features (like `changed`) that were never used.

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-16 13:09:07 -07:00
Mislav Marohnić
cf616e4876 merge callbacks_observers_test.rb into lifecycle_test.rb where other observers test reside 
Benefits: test able to run independently, subclassing instead of changing the original Comment model

Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-16 13:09:07 -07:00
Aaron Patterson
779723a0b4 fix a failure and some warnings on 1.9.2 [#4417 state:resolved] 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-04-16 09:03:42 -07:00
Michael Koziarski
5aa58cc03f Split the observer railtie into two phases. 
Observers observing models with scopes defined will require the connection to be established.
 2010-04-16 09:49:06 +12:00
Xavier Noria
6be04c4631 i18n -> AS/i18n 2010-04-14 02:30:02 -07:00
Xavier Noria
dd635ec701 adds missing requires for arel and i18n, prevents Arel constant from being autoloaded (which was still seen), though it probably hides an issue related to dependencies 2010-04-14 02:01:55 -07:00
Xavier Noria
9a4fdff0af Merge commit 'docrails/master' 2010-04-14 01:00:03 -07:00
Diego Carrion
e090898c5e fixed typo in RUNNING_UNIT_TESTS 2010-04-14 13:15:51 +10:00
Pratik Naik
2ff5f38abb Ensure not to load the entire association when bulk updating existing records using nested attributes 2010-04-14 01:52:29 +01:00
Xavier Noria
0e274639b4 removes unnecessary assignment and local variable in AR::Base#subclasses, and revises its rdoc 2010-04-13 16:11:36 -07:00
David Heinemeier Hansson
4c8af9bf51 Update changelogs for release 2010-04-13 12:14:54 -07:00
Andrew White
9cea9bc7f0 Refactor compute_type to handle situations where the correct class is already loaded 
Signed-off-by: wycats <wycats@gmail.com>
 2010-04-12 21:31:20 -07:00
Emmanuel Oga
f8eddcc735 make ActiveRecord::Base.subclasses a public method 
Signed-off-by: wycats <wycats@gmail.com>
 2010-04-12 21:20:45 -07:00
Phil Smith
bab1f910c7 table_name_prefix and table_name_suffix are class_attributes instead of cattr_accessors. [#4230] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-04-12 10:59:38 +02:00
Andrew White
788d923893 Generate module file for namespaced models [#4230 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-04-12 10:57:27 +02:00
Aaron Patterson
ecf039fc05 mode postgresql adapters table_exists? method take the schema in to account. [#4341 state:resolved] 
Signed-off-by: wycats <wycats@gmail.com>
 2010-04-11 14:53:24 -07:00
Jeremy Kemper
6d29f9789e Fix evals missing context 2010-04-10 22:39:10 -07:00
Jeremy Kemper
86dda361e2 Avoid deprecated String#to_a by using Array.wrap(...) instead of Array(...) 2010-04-10 22:37:36 -07:00
Aaron Patterson
61355c0e24 clearing up many warnings, removing unnecessary regular expresion comparisons [#4365 state:resolved] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-10 22:13:42 -07:00
mfoster
5850edf104 Made arrays of ActiveRecords, and any classes, with namespaces convert to valid xml. [#3824 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-04-10 18:12:43 +02:00
Aaron Patterson
f46dc9b6b7 clear the rest of the warnings, run with warnings turned on [#4332 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-04-10 13:50:38 +02:00
Aaron Patterson
922e4c57a4 kill warnings on 1.8.7 [#4331 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-04-10 13:50:35 +02:00
José Valim
ee309d506c Update versions (otherwise you install a gem from source as beta3 but internally it's beta2) and update CHANGELOG. 2010-04-10 12:17:34 +02:00
Santiago Pastorino
13e00ce606 fix stack trace lines on class_eval 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-04-09 21:28:49 +02:00
Santiago Pastorino
808847792c db:test:prepare for tasks only if AR is loaded 2010-04-09 16:03:27 +12:00
Michael Koziarski
1e3dce08e1 Revert "When creating database with rake, create schemas in schema_search_path if it doesn't exist." 
This reverts commit 6c2a0675f11a9b5b8e88ed7dbccd65cb51be8029.

Reverting because it breaks the ability to run tests using a non-superuser.

Conflicts:

	activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb
	activerecord/lib/active_record/railties/databases.rake
 2010-04-09 11:30:40 +12:00
Kristopher Murata
36129f21b8 Dirty datetime attributes should be aware of time zone info [#3658 state:resolved] 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-04-08 10:26:16 -07:00
Pratik Naik
2c27e3d336 Some doc updates reflecting the new query API 2010-04-08 16:49:52 +01:00
Pratik Naik
48634bf59a Reset named scope cache whenever the @target is reset 2010-04-07 01:16:45 +01:00
Simon Effenberg
4f1d0f6b7e remove_index now uses quote_table_name() [#4300 state:resolved] 
Signed-off-by: Michael Koziarski <michael@koziarski.com>
 2010-04-06 14:15:57 +12:00
Pratik Naik
1f7b4447a9 Memoize association.named_scope calls 2010-04-05 21:55:24 +01:00