TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
63,859 Commits 2 Branches 0 Tags 294 MiB
d66fadeb67
Commit Graph

63859 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
yuuji.yaginuma
af4cef024b Extract assert_output and available_pty? into ConsoleHelpers module 
We define almost the same method with multiple tests. Therefore, it extract
into module.
 2017-07-25 15:01:33 +09:00
Koichi ITO
601cb79582 Fix test_add_column_with_timestamp_type when using Oracle 2017-07-25 13:04:28 +09:00
George Claghorn
1907f465bc Deep merge 2017-07-24 23:50:20 -04:00
Lisa Ugray
75ccdfed8d Stop creating ApplicationRecord on model generation 
When generating models, we created ApplicationRecord in the default
location if no file existed there.  That was annoying for people who
moved it to somewhere else in the autoload path.  At this point, the
vast majority of apps should have either run the upgrade script or
generated a model since upgrading.  For those that haven't the error
message after generating a new model should be helpful:

   NameError: uninitialized constant ApplicationRecord

To ease friction in that case, this also adds a generator for
ApplicationRecord.
 2017-07-24 21:22:48 -04:00
Rafael França
65f861ee1e Merge pull request #29919 from kirs/actionpack-frozen-friendly 
Make actionpack frozen string friendly
 2017-07-24 21:06:11 -04:00
Rafael França
7d133b23b6 Merge pull request #29924 from y-yagi/fix_ruby_warning 
Fix `warning: ambiguous first argument`
 2017-07-24 20:55:56 -04:00
yuuji.yaginuma
8a0f235fd3 Fix warning: ambiguous first argument 
This fixes the following warning:

```
railties/test/application/rake/dbs_test.rb:265: warning: ambiguous first argument; put parentheses or a space even after `/' operator
```
 2017-07-25 08:19:41 +09:00
Rafael França
9569a0cde8 Merge pull request #29866 from rlue/master 
[API DOCUMENTATION] [MINOR] Correct description of ActionController::Parameters#delete
 2017-07-24 18:09:08 -04:00
Rafael França
39c0362b57 Merge pull request #29921 from xtina-starr/remove-depreciated-assertion 
remove depreciated assertion to eliminate warning
 2017-07-24 17:11:19 -04:00
Rafael França
bd0d1e212a Merge pull request #29898 from deivid-rodriguez/follow_up_to_multiple_location_engine_mounting 
Fix regression introduced by fixing mounting the same engine in multiple locations
 2017-07-24 17:09:38 -04:00
David Heinemeier Hansson
6dd82b84de Did that 2017-07-24 16:00:24 -05:00
David Heinemeier Hansson
3a5372d80c Flesh out the README a bit more 2017-07-24 15:51:25 -05:00
Christina Thompson
65d592842a remove depreciated assertion to eliminate warning 
Signed-off-by: Yuki Nishijima <yk.nishijima@gmail.com>
 2017-07-24 16:48:58 -04:00
Rafael Mendonça França
d9ca57ab0b Merge pull request #29859 from dwightwatson/feature/rack-test 
Update rack-test dependency constraint
 2017-07-24 16:47:56 -04:00
Rafael França
8b67e98a49 Merge pull request #29918 from xtina-starr/suppress-warning-from-actionview-controller-helper 
Suppress warning from actionview controller helper.
 2017-07-24 16:40:32 -04:00
Kir Shatrov
c0e2cfdc3f Make actionpack frozen string friendly 2017-07-24 23:38:04 +03:00
David Heinemeier Hansson
92536c08d5 Document the rest of lib 2017-07-24 15:36:33 -05:00
Christina Thompson
6ac1cf394b Suppress warning from actionview controller helper. 
Explicitly pass a destructed array to the delegate method.

Signed-off-by: Yuki Nishijima <yk.nishijima@gmail.com>
 2017-07-24 16:24:12 -04:00
Mike Gunderloy
87cb006374 Trivial typo fix 
Only one character, but it needs to be done
 2017-07-24 16:20:33 -04:00
Rafael França
9c35bf2a6a Merge pull request #29897 from kirs/frozen-actionview 
Use frozen string literal in actionview/
 2017-07-24 15:54:08 -04:00
David Heinemeier Hansson
3eb8c89c04 Fix blob associations 
cc @javan
 2017-07-24 14:35:36 -05:00
David Heinemeier Hansson
20effee567 Models are autoloaded per engine standards 2017-07-24 14:22:59 -05:00
David Heinemeier Hansson
0e9eb11772 Add standard version setup 2017-07-24 14:20:55 -05:00
David Heinemeier Hansson
ef92cb0f5c Follow the same copyright format as the other Rails frameworks 2017-07-24 14:18:00 -05:00
David Heinemeier Hansson
547737b85b Basic documentation for job 2017-07-24 14:17:01 -05:00
David Heinemeier Hansson
bb3458079e Finish basic documentation for controllers 2017-07-24 14:16:55 -05:00
Rafael França
998ec40f9e Merge pull request #29908 from deivid-rodriguez/fix_warnings_in_railties_tests 
Fix warnings in railties tests
 2017-07-24 14:59:42 -04:00
Rafael França
06dff4d7da Merge pull request #29848 from kamipo/fix_distinct_count_with_order_and_limit 
Fix `COUNT(DISTINCT ...)` with `ORDER BY` and `LIMIT`
 2017-07-24 14:50:14 -04:00
Rafael França
3a4a775732 Merge pull request #29915 from kamipo/fix_warning_assigned_but_unused_variable 
Fix `warning: assigned but unused variable - comment`
 2017-07-24 14:30:49 -04:00
Ryuta Kamizono
36b7f3ae5b Fix warning: assigned but unused variable - comment 
```
% ARCONN=sqlite3 be ruby -w -Itest test/cases/associations/belongs_to_associations_test.rb -n test_multiple_counter_cache_with_after_create_update
test/cases/associations/belongs_to_associations_test.rb:1181: warning: assigned but unused variable - comment
Using sqlite3
Run options: -n test_multiple_counter_cache_with_after_create_update --seed 49644

.

Finished in 0.114266s, 8.7515 runs/s, 17.5030 assertions/s.

1 runs, 2 assertions, 0 failures, 0 errors, 0 skips
```
 2017-07-25 03:25:23 +09:00
Rafael França
ad3aaadce0 Merge pull request #29902 from y-yagi/fix_29880 
Do not show URL in boot info when using Puma
 2017-07-24 13:54:42 -04:00
Rafael França
5c418af937 Merge pull request #29853 from lugray/move_generator_namespacing_to_base 
Move generator namespacing to Base
 2017-07-24 13:39:33 -04:00
Rafael França
6f0729b604 Merge pull request #29792 from lugray/delegate_respond_to 
Delegate respond_to? in ActionView::Helpers::ControllerHelper
 2017-07-24 13:33:17 -04:00
Rafael França
dd58cc2ebb Merge pull request #29765 from lugray/fix_counter_cache 
Fix `counter_cache` double increment
 2017-07-24 13:31:28 -04:00
Rafael França
501941b108 Merge pull request #29912 from rails/revert-29911-schneems/rack-mini-profiler 
Revert "Include rack-mini-profiler by default"
 2017-07-24 13:24:10 -04:00
Rafael França
93f9398de8 Revert "Include rack-mini-profiler by default" 2017-07-24 13:23:59 -04:00
Sean Griffin
f628257010 Merge pull request #29911 from schneems/schneems/rack-mini-profiler 
Include rack-mini-profiler by default
 2017-07-24 13:23:37 -04:00
David Heinemeier Hansson
6de1c0b7b5 Merge branch 'master' of github.com:rails/activestorage 2017-07-24 12:06:25 -05:00
David Heinemeier Hansson
d4f014b927 Start on docs for lib 2017-07-24 12:05:23 -05:00
David Heinemeier Hansson
48d0427ff8 Basic documentation for all the models 2017-07-24 12:05:15 -05:00
George Claghorn
52eed68e39 Verify direct upload checksums 
Closes #74.
 2017-07-24 12:41:34 -04:00
schneems
c4a286eb73 Include rack-mini-profiler by default 
I've used many development related performance tools, but the single most consistently helpful tool is `rack-mini-profiler`. 


The tool provides a lightweight UI element for each page, that shows the server response time. When clicked it expands to show more detail:

![](https://www.dropbox.com/s/0aciw4mk8c059n0/Screenshot%202017-07-24%2010.24.24.png?dl=1)


This can be used to detect expensive queries, N+1 issues and general performance related problems.
 2017-07-24 11:34:12 -05:00
Sean Griffin
846832ae54 Fix test failures when prepared statements are disabled 
This also reverts the change to enable prepared statements by default on
MySQL (though I suspect we could enable them and it'd be great). This
change brings back a collector closer to the old `Bind` collector in
Arel. However, this one lives in AR, since this is an AR specific need.
Additionally, we only use it for statement caching, since the new
substitute collector in Arel is higher performance for most cases.
 2017-07-24 12:28:26 -04:00
David Heinemeier Hansson
d0e90b4a9d Blob/Variant#url -> #service_url to emphasize this URL isn't to be public 2017-07-24 11:14:29 -05:00
Sean Griffin
a698424477 Fix build failures on PG 
Honestly I don't think the tests that are fixed by this change should
have been merged. Passing a range or an array to `where` has a special
meaning. We need to solve the problem more concretely without overriding
the behavior that is present for *every* other type.

However, the damage has been done. These changes were in 5.1, so we need
a deprecation cycle to remove it.
 2017-07-24 10:58:00 -04:00
Sean Griffin
01425d8a71 Merge pull request #29905 from kamipo/remove_duplicated_assertion 
Remove duplicated assertion in `test_count_with_join`
 2017-07-24 10:11:57 -04:00
David Heinemeier Hansson
69922fc715 Everything under app/ is eager loaded, don't want that for service 
Since it references all the specific cloud services that are intended only to be loaded on demand.
 2017-07-24 08:48:42 -05:00
Sean Griffin
2eaa7be638 Fix build failures on MySQL 
There's an actual bug in 213796fb4936dce1da2f0c097a054e1af5c25c2c around
prepared statements being disabled. I'm looking into it, but in the mean
time this gets the build green so it doesn't block other PRs
 2017-07-24 09:31:13 -04:00
David Heinemeier Hansson
b203288819 Merge branch 'master' of github.com:rails/activestorage 2017-07-24 08:12:07 -05:00
David Heinemeier Hansson
d8aec0f9a4 Refer to the yielded app 2017-07-24 08:12:03 -05:00