TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
35,004 Commits 2 Branches 0 Tags 294 MiB
d73cc03010
Commit Graph

9905 Commits

Author SHA1 Message Date
Gosha Arinich
d73cc03010 remove begin-rescue in favor of def-rescue 2013-01-07 04:02:20 +03:00
Rafael Mendonça França
cc24eba544 Fix operators precedence issue 2013-01-06 21:54:46 -03:00
Rafael Mendonça França
dc4b4c46ef Merge pull request #8787 from tank-bohr/master 
masgn and response variable
 2013-01-06 16:00:14 -08:00
Rafael Mendonça França
fb7c093d93 Merge pull request #8785 from goshakkk/refactor-debug-exceptions 
Refactor DebugExceptions
 2013-01-06 15:49:33 -08:00
Gosha Arinich
c445b07612 refactor DebugExceptions by combining two conditionals into one 2013-01-07 02:46:03 +03:00
tank-bohr
f3101fd0fc return multiple assingment and response variable 2013-01-07 03:37:06 +04:00
Akira Matsuda
3c21237c37 Reduce number of Strings a bit 2013-01-07 07:37:23 +09:00
Akira Matsuda
c8e632bd9f Namespace HashWithIndifferentAccess 2013-01-07 07:37:23 +09:00
Rafael Mendonça França
4bfcae0b67 Merge pull request #8783 from goshakkk/refactor-journey-routes 
Refactor Journey::Routes
 2013-01-06 14:30:35 -08:00
Gosha Arinich
2467ec8b5c refactor Journey::Routes 
* prefer do-end for multiline blocks
* prefer or-equals over returns with checks
 2013-01-07 01:24:29 +03:00
tank-bohr
8f18550b0a fix for rbx 
Rubinius returns a boolean after such assingment
response = (_, headers, body = @app.call(env))

see https://github.com/rubinius/rubinius/issues/2117

get rid of a local variable
 2013-01-07 02:00:40 +04:00
Akira Matsuda
2f8e5f627d Needless requires 2013-01-06 23:59:11 +09:00
Akira Matsuda
5fd143ec56 Missing requires 2013-01-06 23:58:48 +09:00
Akira Matsuda
15bd0f60db These are already required through AS/rails 
* core_ext/object/blank
* concern
* core_ext/class/attribute
* deprecation
 2013-01-06 23:57:25 +09:00
Carlos Antonio da Silva
b8d9319e8e Rename route_wrapper partial layout to table 
It is used by the table formatter only, and it's already inside a routes
directory that namespaces it properly, so calling it just "table" seems
simpler.
 2013-01-06 11:22:26 -02:00
Carlos Antonio da Silva
3abb76824b Move table routes formatter class to the inspector and rename it 
It feels more consistent to have this class called "HtmlTableFormatter",
and to have it here with the routes inspector and console formatter,
since it's used for both routing error exceptions and the rails info
page.
 2013-01-06 11:19:30 -02:00
Andrew White
f18078475e Merge pull request #8777 from goshakkk/delegate-class 
Delegate to :class rather than 'self.class'
 2013-01-06 05:00:54 -08:00
Carlos Antonio da Silva
7843e009d2 Refactor the logic that checks whether or not to emit the hidden id field 
By checking for object.persisted? first, we avoid the hash lookups for
new objects.
 2013-01-06 10:54:22 -02:00
Carlos Antonio da Silva
e56e3db6e6 Move the hidden :id field logic to where it belongs to 
When dealing with nested forms, Rails automatically generates a hidden
field with the id value of the current object being generated by
fields_for. This logic was inside the method that's available from the
template object, but we just need it when really dealing with nested
attributes, so moving the code to here makes more sense.
 2013-01-06 10:54:22 -02:00
Carlos Antonio da Silva
04338b9e3b Eliminate the usage of parent_builder option from form_for 
Just use it internally from fields_for until we come up with a better solution.
 2013-01-06 10:54:22 -02:00
Carlos Antonio da Silva
115a37d9c1 Do not call fields_for from form_for, to avoid instantiating two builders 2013-01-06 10:54:21 -02:00
Carlos Antonio da Silva
94ecbb7e7b Refactor to not call path.ast twice 2013-01-06 10:52:36 -02:00
Gosha Arinich
c730bef3d8 refactor Route#ast to use or-equals and block, instead of return with a cond 2013-01-06 15:38:00 +03:00
Gosha Arinich
7a439d23de delegate to :class rather than 'self.class' 2013-01-06 12:43:30 +03:00
Akira Matsuda
70ae89c321 Remove unnecessary begin..rescue..end, use only rescue 2013-01-06 15:41:14 +09:00
Rafael Mendonça França
688dde2d62 Fix documentation to content_tag_for [ci skip] 2013-01-05 16:50:15 -03:00
Andrew White
fa6e995a03 Merge pull request #8766 from jcoglan/session_token_docs 
Remove suggestion that Procs can be used as session secrets.

[ci skip]
 2013-01-05 10:30:30 -08:00
Yves Senn
947e1d5e85 deprecate assert_blank and assert_present. 
They don't add any benefits over `assert object.blank?`
and `assert object.present?`
 2013-01-05 18:04:52 +01:00
Carlos Antonio da Silva
0aadca2d83 Remove warning, remove not used variable, and make methods private 
Warning: "shadowing outer local variable - routes".
 2013-01-05 13:45:44 -02:00
James Coglan
6500d7994e Remove suggestion that Procs can be used as session secrets. 2013-01-05 15:16:18 +00:00
Carlos Antonio da Silva
c1eaff00b7 Close container div tag in routing error page 2013-01-05 12:02:18 -02:00
Carlos Antonio da Silva
60e809cffd Move style to head to make routes page valid html5 2013-01-05 12:01:16 -02:00
Carlos Antonio da Silva
6cc42464fe Action Pack changelog improvements [ci skip] 2013-01-05 11:42:23 -02:00
Yves Senn
80795e02ca display mountable engine routes on RoutingError. 2013-01-05 14:31:03 +01:00
Yves Senn
af5c0fd85f split formatting concerns from RoutesInspector 2013-01-05 13:59:14 +01:00
Rafael Mendonça França
0102c817bf Rename the last occurrence of UnexpectedParameters 2013-01-05 07:04:42 -03:00
Rafael Mendonça França
18ac587cd8 Wrong copy and paste 💣 
[ci skip]
 2013-01-05 07:01:51 -03:00
Rafael Mendonça França
beda9c5bdf Add documentation to raise_on_unpermitted_parameters option 
[ci skip]
 2013-01-05 06:56:24 -03:00
Rafael Mendonça França
1401f96492 Rename the configuration to raise_on_unpermitted_parameters 
Also changed the exception to UnpermittedParameters
 2013-01-05 06:39:51 -03:00
Rafael Mendonça França
58f52677e8 Ensure that raise_on_unexpected_params configuration will work 2013-01-05 06:23:28 -03:00
Rafael Mendonça França
df1f290712 Merge pull request #8752 from thomasfedb/master 
Exception on unexpected params when enabled.
 2013-01-05 00:22:06 -08:00
Thomas Drake-Brockman
08578bb40a Allow developers to enable raising of exception when unexpected params are provided. 2013-01-05 15:46:38 +08:00
Andrew White
add4375a60 Allow use of durations for ActionDispatch::SSL configuration 2013-01-04 16:20:23 +00:00
Ryunosuke SATO
fbb3e8ec13 Remove unnecessary ERB::Util::h 
It is automatically applied when strings is unsafe for html.
 2013-01-05 00:50:06 +09:00
Ryunosuke SATO
0f103679eb Suppress warning about IO#lines in Ruby 2.0 
actionpack/lib/action_dispatch/middleware/exception_wrapper.rb:99: IO#lines is deprecated; use #each_line instead
 2013-01-04 23:30:09 +09:00
Guillermo Iguaran
7019858fcc Merge pull request #8723 from goshakkk/refactor-error-page 
Move error page js into script tag
 2013-01-03 22:50:07 -08:00
Rafael Mendonça França
3be2edd5f7 Add documentation to ActionDispatch::Http::UploadedFile#headers 
[ci skip]
 2013-01-03 18:49:28 -03:00
Gosha Arinich
1a5b5e19fc move error page js into script tag 2013-01-04 00:14:07 +03:00
Robin Dupret
4075be80a2 Remove a useless TODO comment 2013-01-03 19:50:43 +01:00
Guillermo Iguaran
cb2bd4aa61 Merge pull request #8705 from amparo-luna/change_update_attributes_to_update 
Rename update_attributes method to update
 2013-01-03 09:09:59 -08:00