Commit Graph

162 Commits

Author SHA1 Message Date
David Heinemeier Hansson
4f40b2d8fb Improved performance of test app req/sec with ~10% refactoring the render method #1823 [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-24 16:45:39 +00:00
David Heinemeier Hansson
1ae0a53d86 Fixed regression for content_for #1820 [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-24 13:20:29 +00:00
David Heinemeier Hansson
b366dbd952 Improved performance with 5-30% through a series of Action Pack optimizations #1811 [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 09:00:05 +00:00
David Heinemeier Hansson
d172592985 Added test for template to layout variable transfer
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-23 08:43:01 +00:00
Jamis Buck
d76439239d Add unit test to ensure that session management options are inherited and overridable in subclasses
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1888 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 10:56:53 +00:00
Jamis Buck
06843f8794 Added support for per-action session management #1763
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1886 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-22 10:37:09 +00:00
David Heinemeier Hansson
bd558ef98e Improved rendering speed on complicated templates by up to 25% #1234 [Stephan Kaes]. This did necessasitate a change to the internals of ActionView#render_template that now has four parameters. Developers of custom view handlers (like Amrita) need to update for that.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1874 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-21 07:14:35 +00:00
Nicholas Seckar
741316dc71 Fixed construction of get parameters for arrays
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1857 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-18 03:12:45 +00:00
Nicholas Seckar
c0771fe7d8 Fix assert_routing with nested controllers. Closes #1582 and #1386.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1837 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-15 15:00:39 +00:00
Nicholas Seckar
bf0b7588ee Add RouteSet#named_route so that RouteSet instance methods do not shadow available route names
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1834 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 10:32:37 +00:00
Nicholas Seckar
6ed16ff602 Provide correct defaults for Named Routes which do not specify :action
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1833 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 09:09:39 +00:00
David Heinemeier Hansson
16595c93b2 Made pagination faster #1334 [Stefan Kaes]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1832 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 08:02:01 +00:00
David Heinemeier Hansson
807df4fcf0 Made test_rendering_nothing_on_layout acknowledge the space
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1831 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 07:19:26 +00:00
Nicholas Seckar
2bd4ff11f8 Generate URLs for :action => index when :action => nil is supplied.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1826 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-14 00:13:06 +00:00
Nicholas Seckar
9314793239 Named routes should not provide nil values to url_for. Includes factoring and extra testcases.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1825 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-13 23:13:15 +00:00
Jamis Buck
847f738cfd Make Request#subdomains handle "foo.foo.com" correctly
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1817 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-12 16:16:13 +00:00
Jeremy Kemper
c697be5b69 r2992@asus: jeremy | 2005-07-10 02:43:49 -0700
Skip ActiveRecordStore tests if neither SQLite 2 nor 3 is available.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1793 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-10 05:05:06 +00:00
Jamis Buck
8266867881 Improved error message for DoubleRenderError
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1779 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 15:31:06 +00:00
Jeremy Kemper
34df31455a r2948@asus: jeremy | 2005-07-08 16:00:23 -0700
Use save instead of save! in ARStore test also.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 18:13:07 +00:00
Nicholas Seckar
c18961f185 Routes now raise an exception if a path component is misconfigured.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 08:56:24 +00:00
Nicholas Seckar
4a3ec21b62 Fix routes to generate proper URLs when given Fixnum defaults
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1768 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 08:45:51 +00:00
Nicholas Seckar
f4bfacb24f Enable routes to recognize uppercase controller names. Closes #1635
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1765 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 19:51:20 +00:00
Nicholas Seckar
5727dc2f42 Properly unescape recognized path components. Fixes #1651.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1764 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 19:43:03 +00:00
Nicholas Seckar
e3af27c51b Improved testing of functional test setup.
Fixed functional test setup so that :controller and :action
are stored into path_parameters using string keys.

Added with_routing test helper which can be used to dynamically
replace the current set of routes inside a unit test.



git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 19:23:35 +00:00
David Heinemeier Hansson
75157bbf64 Fixed that named routes didn't use the default values for action and possible other parameters #1534 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1758 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 14:16:05 +00:00
Jeremy Kemper
afbf54bc3d Add test for dynamic dispatch based on action_name accessor.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 13:45:31 +00:00
David Heinemeier Hansson
212cc3845a Fixed routing snafu
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1736 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 10:45:14 +00:00
David Heinemeier Hansson
93ec99c246 Partly tuned docs for release (AP)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1728 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-06 08:27:11 +00:00
Jeremy Kemper
063956b93c r2879@asus: jeremy | 2005-07-05 16:15:16 -0700
Rollback changesets for Ticket #1229.
 r2880@asus:  jeremy | 2005-07-05 16:17:08 -0700
 Ticket #1229 does not affect Ticket #1614.  Reinstating the changesets.
 r2881@asus:  jeremy | 2005-07-05 16:24:04 -0700
 @test_unchanged in deprecated render test :partials_list action


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1718 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 18:31:51 +00:00
Jeremy Kemper
8a2fec8d31 r2874@asus: jeremy | 2005-07-05 16:13:39 -0700
Unit test for Ticket #1614.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 18:21:26 +00:00
David Heinemeier Hansson
4fe0248f57 Fixed routing regression on index exception
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1713 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 15:31:51 +00:00
Jamis Buck
3b1d271e02 Routing fix
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1712 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 15:06:09 +00:00
Jeremy Kemper
1e6603e6e7 r2850@asus: jeremy | 2005-07-05 13:08:32 -0700
Don't be strict about the order in which AR store methods are called.  Allow e.g. session close followed by session close.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1710 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 14:50:07 +00:00
Jeremy Kemper
ed12b0cac0 r2836@asus: jeremy | 2005-07-05 00:33:12 -0700
Test sessid backward compatibility.  DRY up the test classes.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1692 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-05 02:29:37 +00:00
Jeremy Kemper
ac412ef1c7 r2822@asus: jeremy | 2005-07-04 21:14:30 -0700
silence warnings re. class redefinitions


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1687 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 23:09:58 +00:00
Jeremy Kemper
79455b6d45 r2821@asus: jeremy | 2005-07-04 21:14:16 -0700
reuse path_to_ar


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1686 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 23:09:54 +00:00
Jeremy Kemper
5ab1df9e37 r2820@asus: jeremy | 2005-07-04 21:13:57 -0700
Bring in-mem SQLite goodness to active_record_assertions_test


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1685 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 23:09:49 +00:00
Jeremy Kemper
7bcaf2b689 r2817@asus: jeremy | 2005-07-04 20:49:12 -0700
active_record_store_test falls back to SQLite2 if 3 is unavailable
 r2818@asus:  jeremy | 2005-07-04 20:52:25 -0700
 update changelog


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1684 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 22:48:01 +00:00
Jeremy Kemper
ddb57d8ab8 r2815@asus: jeremy | 2005-07-04 19:49:35 -0700
Correct SqlBypass test


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1683 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 21:46:01 +00:00
Jeremy Kemper
509bf53889 r2809@asus: jeremy | 2005-07-04 19:29:19 -0700
give CGI::Session options as strings, not symbols


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1681 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 21:26:50 +00:00
Jeremy Kemper
50619549ee r2808@asus: jeremy | 2005-07-04 19:08:48 -0700
test at dbman and at CGI::Session level.  need to merge the test classes since they're the same tests for different backends..


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1680 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 21:26:45 +00:00
David Heinemeier Hansson
128e352614 Fixed that hashes was not working properly when passed by GET to lighttpd #849 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 19:21:48 +00:00
Jeremy Kemper
452442dde8 r2790@asus: jeremy | 2005-07-04 16:30:58 -0700
smart active record session class.  session class is pluggable; a basic SqlBypass class is provided.  set CGI::Session::ActiveRecordStore.session_class = SqlBypass and set SqlBypass.connection = SomeARConnection.  Further tests pending.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1671 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 18:30:27 +00:00
Jeremy Kemper
5900d4ff75 r2788@asus: jeremy | 2005-07-04 16:16:20 -0700
Don't unnecessarily pollute $:.  Use SQLite3 instead of SQLite by default.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1669 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 18:30:17 +00:00
Jamis Buck
6e7e552b03 Fix broken capture test
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1665 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 15:36:22 +00:00
Jamis Buck
fcdcd9b9fa Hashes sent via multipart post should be converted to strings #1032 [me@julik.nl]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1664 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 15:31:37 +00:00
Jamis Buck
cf9c991d4c Fix test broken by [1648]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1663 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-04 15:20:25 +00:00
David Heinemeier Hansson
5524dedc06 Fixed routing bug #1592
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1645 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-03 12:01:06 +00:00
David Heinemeier Hansson
208291391c Added JavascriptHelper#update_element_function, which returns a Javascript function (or expression) that'll update a DOM element according to the options passed #933 [mortonda@dgrmm.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1644 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-03 11:01:43 +00:00
David Heinemeier Hansson
177ed3e681 Added more tests on assert_redirected_to #1581 [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1609 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-02 18:16:38 +00:00