Santiago Pastorino
dfb3ff6698
This or login doesn't make sense
2010-10-18 09:47:21 -02:00
Santiago Pastorino
dc33cd6208
Use unless instead of if nil?
2010-10-18 09:45:37 -02:00
Santiago Pastorino
5f60735194
Add missing require
2010-10-18 08:39:20 -02:00
Andrew White
f7573175de
Reset assert_template instance variables between requests [ #5832 state:resolved]
2010-10-18 09:57:51 +01:00
Krekoten' Marjan
7b2ec381ca
Change def to attr_reader + alias
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-10-18 00:54:58 +02:00
Santiago Pastorino
0d5d70f1a3
parse number only if options[:raise] is provided
2010-10-17 20:44:06 -02:00
Santiago Pastorino
ea7db8ebc1
number_to_phone always return safe
2010-10-17 20:42:13 -02:00
Michael Koziarski
2f9e880431
Rejig the html5 data helper code
...
Avoid allocating an array each pass through and support String subclasses like SafeBuffers
2010-10-18 11:18:43 +13:00
Stephen Celis
5e79094fc1
HTML5 data attribute helpers [ #5825 state:resolved].
2010-10-18 11:18:42 +13:00
Neeraj Singh
ea14396c45
replace if ! with unless
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-10-17 12:26:32 -02:00
Santiago Pastorino
6c8ea83385
extract formats_regexp as a method
2010-10-16 14:12:41 -02:00
Santiago Pastorino
15d3c77bc2
There's no need now to expose lookup_context as an external API
2010-10-16 13:42:19 -02:00
Santiago Pastorino
0d00d65ad2
Delegate freeze_formats to lookup_context
2010-10-16 13:39:11 -02:00
Jeff Kreeftmeijer
b454bb0a98
Remove the :vew attr_reader from ActionView::AbstractRenderer [ #5819 state:resolved]
...
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-10-16 13:02:14 -02:00
Aaron Patterson
1dd266741e
fixing an error in the rdoc
2010-10-15 10:43:53 -07:00
Xavier Noria
21ff8849bb
in regexps, the dot in a character class is not a metacharacter
2010-10-15 16:31:00 +02:00
André Camargo
c42ea2172e
Fix for ActionView::Template#refresh in rails 3.1.0.beta
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-10-15 08:39:10 +02:00
Xavier Noria
13f7f89bda
Merge branch 'master' of git://github.com/lifo/docrails
2010-10-14 23:15:23 +02:00
José Valim
01ab6f961b
Remove :cache => true on lookup templates initialization.
2010-10-14 09:47:49 +02:00
José Valim
aa508c9baf
SReorganize autoloads slightly and move two files to lib/action_view root.
2010-10-14 09:32:53 +02:00
José Valim
37d78028b2
render :once should consider the current controller prefix.
2010-10-14 09:27:18 +02:00
Krekoten' Marjan
0744d36f47
Fix small typo in documentation
2010-10-12 22:55:19 +03:00
Les Hill and Sandro Turriate
dde54f00c6
Show exceptions rescues the original exception
...
[#5784 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-10-12 00:56:07 +02:00
Szymon Nowak
0d33332571
Return a valid empty JSON on successful PUT and DELETE requests. [ #5199 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-10-12 00:56:07 +02:00
Aditya Sanghi
582a088ba7
Fix test helpers to ensure get method forms are properly tested [ #5753 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-10-12 00:56:07 +02:00
Miles Egan
3eff729079
make sure request parameters are accessible after rack throws an exception parsing the query string [ #3030 state:resolved]
...
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-10-12 00:56:07 +02:00
Aaron Patterson
ee7863eaac
removing some load path tomfoolery
2010-10-11 11:30:22 -07:00
Aaron Patterson
333e033064
fixing railties tests
2010-10-11 11:24:00 -07:00
Santiago Pastorino
0c824e3cd7
Refactor a bit this code to add data-confirm and data-disable-with
2010-10-11 15:55:45 -02:00
Paco Guzman
31358d8c3c
data-disable-with in button_to helper
...
[#4993 state:committed]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-10-11 13:24:07 -02:00
Xavier Noria
21a92b8d01
Merge branch 'master' of git://github.com/lifo/docrails
2010-10-11 12:06:21 +02:00
Xavier Noria
e6b45b8111
Revert "Add missing CHANGELOG entry about reset_javascript_include_default"
...
This reverts commit 234a4ca7ddb7794a92f266af48fd38edbdb03003.
Reason: No big deal Ryan, only there's a very strict policy in
docrails which allows public write access on the other hand.
CHANGELOGs can only be edited in master. If this is added I'll
make sure you get the credit for the patch.
2010-10-11 12:00:37 +02:00
Ryan Bigg
234a4ca7dd
Add missing CHANGELOG entry about reset_javascript_include_default
2010-10-11 13:32:40 +11:00
Ryan Bigg
ef74ad8e0c
Remove mention to register_javascript_include_default in documentation
2010-10-11 13:28:50 +11:00
Santiago Pastorino
cb26eee54d
Revert "Make InstanceTagMethods#value_before_type_cast raise if the model don't respond to attr_before_type_cast or attr method"
...
And "Makes form_helper use overriden model accessors"
This reverts commit 3ba8e3100548f10fce0c9784981a4589531476dd and fb0bd8c1092db51888ec4bb72af6c595e13c31fa.
2010-10-10 21:13:12 -02:00
José Valim
5ec27189b8
Do not allow templates coming from Fallback resolvers to store a virtual path.
2010-10-10 23:12:23 +02:00
José Valim
682368d4ba
Use identifiers for template equality.
2010-10-10 23:12:22 +02:00
José Valim
49b6f33f99
Clean up unused methods from AV::Base and pass in the template object on rendering.
2010-10-10 14:47:11 +02:00
José Valim
11aa515735
Add expire! and rerender to the template API. This will be used by SASS template handler.
2010-10-10 13:43:32 +02:00
José Valim
ffa32714bd
Add some unit tests to Template#refresh.
2010-10-10 13:17:04 +02:00
José Valim
cba395dab9
Update CHANGELOG.
2010-10-10 12:43:26 +02:00
José Valim
940b57789f
Add support to render :once.
...
This will be used internally by sprockets to ensure requires are executed just once.
2010-10-10 12:43:26 +02:00
José Valim
b88f4ca93b
Clean up the house before moving in the new furniture.
...
This commit moves all the template rendering logic that was hanging around AV::Base to renderer objects.
2010-10-10 12:43:26 +02:00
David Calavera
ab2f2b22a6
prevent rake test to run the test suite three times when ENV['TEST'] is set [ #3572 state:resolved]
...
Signed-off-by: Xavier Noria <fxn@hashref.com>
2010-10-10 12:22:40 +02:00
wycats
b3cadf338b
Rendering doesn't need RackDelegation
2010-10-10 00:54:11 -07:00
wycats
8cb2cfbf71
Fix a few bugs when trying to use Head standalone
2010-10-10 00:54:11 -07:00
José Valim
38d78f99d5
Resolvers now consider timestamps.
...
Before this patch, every request in development caused the template
to be compiled, regardless if it was updated in the filesystem or not.
This patch now checks the timestamp and only compiles it again if
any change was done.
While this probably won't show any difference for current setups,
but it will be useful for asset template handlers (like SASS), as
compiling their templates is slower than ERb, Haml, etc.
2010-10-10 09:26:53 +02:00
José Valim
c7408a0e40
Deprecate old template handler API. Remove old handlers.
2010-10-10 01:14:50 +02:00
José Valim
64c7f7e392
Add more docs and tests to templates.
2010-10-09 23:56:08 +02:00
Andrea Campi
e695c40e11
Fix example that became outdated after a code change.
...
[#5770 state:resolved]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-10-09 12:57:57 -02:00