Commit Graph

644 Commits

Author SHA1 Message Date
Jeremy Kemper
28012e68fe Fix routes generation for unit tests. #1434
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1497 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-24 17:48:14 +00:00
David Heinemeier Hansson
8e56f5ea3e Improved performance of Routes generation by a factor of 5 #1434 [Nicholas Seckar] Added named routes (NEEDS BETTER DESCRIPTION) #1434 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1496 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-24 16:40:01 +00:00
Jeremy Kemper
540d005ca5 Improved AbstractRequest documentation. Closes #1483.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1494 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-24 14:43:15 +00:00
David Heinemeier Hansson
0c3298f2f2 Added ActionController::Base.allow_concurrency to control whether the application is thread-safe, so multi-threaded servers like WEBrick knows whether to apply a mutex around the performance of each action. Action Pack and Active Record are by default thread-safe, but many applications may not be. Turned off by default.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1487 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-23 06:56:12 +00:00
David Heinemeier Hansson
4e0ffab8b0 Removed the mutex from the WEBrick adapter under the production environment so concurrent requests can be served
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1482 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-22 12:59:36 +00:00
David Heinemeier Hansson
8e56e09018 Updated documentation for partials #1171
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1474 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 16:59:04 +00:00
David Heinemeier Hansson
c608ebeade Added TextHelper#word_wrap(text, line_length = 80) #1449 [tuxie@dekadance.se]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1465 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 07:16:11 +00:00
David Heinemeier Hansson
e59bfc8519 Added a fall-through action for form_remote_tag that'll be used in case Javascript is unavailable #1459 [Scott Barron]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1464 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 07:08:13 +00:00
David Heinemeier Hansson
1e0d9a642f Added :xhr => true/false option to verify so you can ensure that a request is coming from an Ajax call or not #1464 [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1463 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 07:02:30 +00:00
David Heinemeier Hansson
bc6570dfcb Added tag_options as a third parameter to AssetHelper#auto_discovery_link_tag to control options like the title of the link #1430 [kevin.clark@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1460 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 06:52:05 +00:00
David Heinemeier Hansson
f2a021dc06 Added option to pass in parameters to CaptureHelper#capture, so you can create more advanced view helper methods #1466 [duane.johnson@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1459 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 06:43:14 +00:00
David Heinemeier Hansson
5ba31b3d1d Changed the default name of the input tag generated by FormTagHelper#submit_tag from "submit" to "commit" so it doesnt clash with form.submit() calls in Javascript #1271
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1456 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-21 05:26:40 +00:00
David Heinemeier Hansson
92473b8f96 Fixed relative urls support for lighttpd #1048 [Nicholas Seckar/maznawak@nerim.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1450 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-18 05:17:18 +00:00
Jeremy Kemper
959707bfb6 r1335@iwill: jeremy | 2005-06-17 11:41:50 -0700
Ticket 1458 - distance_of_time_in_words
 r1336@iwill:  jeremy | 2005-06-17 11:44:50 -0700
 Update changelog
 r1337@iwill:  jeremy | 2005-06-17 11:45:44 -0700
 Applied patch.
 r1361@iwill:  jeremy | 2005-06-17 11:48:02 -0700
 Merge changelog


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1449 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-17 13:42:23 +00:00
David Heinemeier Hansson
a895be0259 Fixed query parser to deal gracefully with equal signs inside keys and values #1345 [gorou]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1441 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:42:49 +00:00
David Heinemeier Hansson
a7a1c4e2cd Added cuba to country list #1351 [todd]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1440 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:36:09 +00:00
David Heinemeier Hansson
ec6f0a1f51 Fixed radio_button to work with numeric values #1352 [demetrius]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1439 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:34:08 +00:00
David Heinemeier Hansson
665ab93761 Added :extension option to NumberHelper#number_to_phone #1361 [delynnb]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1438 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:33:10 +00:00
David Heinemeier Hansson
43c470fae4 Added button_to as a form-based solution to deal with harmful actions that should be hidden behind POSTs. This makes it just as easy as link_to to create a safe trigger for actions like destroy, although it's limited by being a block element, the fixed look, and a no-no inside other forms. #1371 [tom@moertel.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1437 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:17:51 +00:00
David Heinemeier Hansson
89e06ed4c6 Fixed image_tag so an exception is not thrown just because the image is missing and alt value can't be generated #1395 [Marcel]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1434 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:04:23 +00:00
David Heinemeier Hansson
5b3bc3139a Added a third parameter to TextHelper#auto_link called href_options for specifying additional tag options on the links generated #1401 [tyler.kovacs@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1432 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 06:00:18 +00:00
David Heinemeier Hansson
691562746f Fixed TextHelper#highlight to return the text, not nil, if the phrase is blank #1409 [patrick@lenz.sh]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1429 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 05:42:47 +00:00
David Heinemeier Hansson
7b47f150fd Its Iraq, not Irak #1443 [ivan]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1427 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 05:05:43 +00:00
David Heinemeier Hansson
cc6c48f0a8 Fixed TagHelper such that :name and 'name' keys in the options doesn't result in two attributes #1455 [take_tk]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1426 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-16 05:04:17 +00:00
Jeremy Kemper
7bb486055e r1318@iwill: jeremy | 2005-06-15 01:08:22 -0700
Ticket 1394 - Helper isolation
 r1319@iwill:  jeremy | 2005-06-15 01:10:00 -0700
 Formulate a test case for helper isolation.
 r1331@iwill:  jeremy | 2005-06-15 15:21:07 -0700
 Update changelog
 r1332@iwill:  jeremy | 2005-06-15 15:21:30 -0700
 Remove superfluous, broken layout_test
 r1333@iwill:  jeremy | 2005-06-15 15:24:10 -0700
 Use an anonymous Module to store helpers per-class instead of tossing them all in template_class.  Create a new helper module for subclasses which includes its superclass' helper module.  Remove unnecessary ActionView::Base.controller_delegate.  Update helper tests.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1425 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-15 17:17:58 +00:00
Jamis Buck
14c378cc7f render(:template) applies a layout by default. render("foo/bar") works with a layout again.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-15 13:20:17 +00:00
David Heinemeier Hansson
280c224b43 Reverted changeset #1326 coming off ticket #1230 since it caused stale caches to be shared.. nasty
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1423 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-15 09:16:23 +00:00
David Heinemeier Hansson
cb79118111 Fixed double-singularization on scaffolded pagination call (Address would be turned into Addres) #1216, #1404 [nilsga]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1422 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-15 04:17:45 +00:00
Jamis Buck
ac1fa98bb9 Removed the require hack used in functional tests that worked around an earlier bug in rake.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1421 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-14 16:17:56 +00:00
Jamis Buck
ed7bfc9662 Allow distance_of_time_in_words to work with any value that responds to #to_time (like dates) #969
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1420 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-14 15:19:03 +00:00
Jamis Buck
3cb869eab6 Resync with html-scanner (fix parser bug)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1419 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-14 13:56:46 +00:00
Jamis Buck
75fb0a32a8 Support :render option to :verify #1440 [TobiasLuetke]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1418 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-14 13:23:55 +00:00
Jamis Buck
c23b2a4ad3 Updated vendor copy of html-scanner lib, for bug fixes and optimizations
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1416 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-14 10:30:36 +00:00
David Heinemeier Hansson
bca13f727e Changed test requests to come from 0.0.0.0 instead of 127.0.0.1 such that they don't trigger debugging screens on exceptions, but instead call rescue_action_in_public
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1415 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-14 08:04:49 +00:00
Jeremy Kemper
3cb26e9cb3 r2495@sedna: jeremy | 2005-05-27 22:07:18 -0700
Branch to have scaffold use new render methods
 r2496@sedna:  jeremy | 2005-05-28 10:50:51 -0700
 axe unused process_request method
 r2497@sedna:  jeremy | 2005-05-28 10:51:58 -0700
 sanity assertions in process method check that @controller, @request, @response are set
 r2498@sedna:  jeremy | 2005-05-28 10:53:42 -0700
 clean up escaping.  use instance_variable_get instead of instance_eval.  put id in form action instead of hidden input (like the generated scaffolding)
 r2499@sedna:  jeremy | 2005-05-28 10:54:46 -0700
 clean up interpolation, remove tabs from stylesheet
 r2500@sedna:  jeremy | 2005-05-28 10:56:40 -0700
 modernize dynamic scaffolding.  use params[:id] instead of @params[id].  use consolidated render method instead of render_action, render_file, etc.  use builtin inflections rather than module methods.
 r2501@sedna:  jeremy | 2005-05-28 11:00:26 -0700
 modernize generated scaffolding.  use new-style assertions; use params[:id] instead of @params[id]; use consolidated render method instead of render_*
 r2542@sedna:  jeremy | 2005-06-12 02:24:06 -0700
 use :id => model instead of :id => model.id.  clean up the form helper method.  use flash[:notice] instead of flash['notice'].
 r2543@sedna:  jeremy | 2005-06-12 02:33:22 -0700
 whitespace
 r2544@sedna:  jeremy | 2005-06-12 02:56:57 -0700
 update changelogs
 r2545@sedna:  jeremy | 2005-06-12 03:26:23 -0700
 test dynamic form help when @post is not a new record
 r2546@sedna:  jeremy | 2005-06-12 03:44:14 -0700
 touch up TestCase#process sanity assertions


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1404 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-12 05:33:23 +00:00
Jamis Buck
f6ec9e3d66 Arrays sent via multipart posts are converted to strings #1032 [dj@omelia.org]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1397 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-10 12:21:25 +00:00
David Heinemeier Hansson
5add31eda4 CSS needs "red" not #red
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1388 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-06 09:48:48 +00:00
David Heinemeier Hansson
32c0e895bf Fixed scaffolding to use the latest style
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1380 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-02 20:13:02 +00:00
David Heinemeier Hansson
3162f386dc Made Action View work with the new render :file/:partial style from the controller
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1379 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-02 20:12:34 +00:00
Jamis Buck
e4c047e489 render(:action) and render() are the only two render calls to use a layout by default. All others default to :layout => false. Also, allow :layout => true to be a synonym for :layout => nil.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1378 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-06-01 13:39:58 +00:00
Jamis Buck
6ce58318f5 render(:inline) defaults to :layout => false
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1372 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-30 09:12:12 +00:00
Jamis Buck
f8542a64b3 Make sure the benchmarking render method always returns the result of the render, regardless of whether logging is enabled or not.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1371 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-30 09:00:46 +00:00
Jamis Buck
f57ee365e1 render(:text), render(:partial), and render(:nothing) always default to :layout => false. This also fixes send_file, which was applying a layout if one existed for the current action.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1369 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-30 07:51:02 +00:00
Jamis Buck
613260606b verify with :redirect_to won't redirect if a redirect or render has already been performed #1350
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1367 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-30 07:24:46 +00:00
Jamis Buck
00db6f0faa render(:partial => "...") uses an empty hash for the local assigns #1365. render(:partial => true) is identical to the older render_partial()
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1366 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-30 07:20:37 +00:00
Jamis Buck
b6c13f2d70 Don't die when an attempt to delete a cache fails
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1365 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-30 07:05:52 +00:00
David Heinemeier Hansson
bdd16a75e6 render :nothing shouldnt cause layouts
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1353 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-22 16:57:51 +00:00
David Heinemeier Hansson
060ecf1a24 Set redirected_to proper
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1352 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-22 16:52:54 +00:00
David Heinemeier Hansson
2f7c5f84e4 Cure some ills discovered with the refactoring
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1351 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-22 11:07:09 +00:00
David Heinemeier Hansson
da0c4c5c96 Deprecated all render_* methods in favor of consolidating all rendering behavior in Base#render(options). This enables more natural use of combining options, such as layouts
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-22 08:58:43 +00:00
David Heinemeier Hansson
0367317dd6 Deprecated redirect_to_path and redirect_to_url in favor of letting redirect_to do the right thing when passed either a path or url. Introduced r as a unified method for render (still under construction)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1349 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-22 07:43:05 +00:00
David Heinemeier Hansson
dab360e181 Added DoubleRenderError exception that'll be raised if render* is called twice #518 [Nicholas Seckar]. Fixed exceptions occuring after render has been called #1096 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1348 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-21 18:51:08 +00:00
David Heinemeier Hansson
7159402c6d Fixed use of an integer as return code for renders, so render_text "hello world", 404 now works #1327
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1345 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-21 17:50:57 +00:00
David Heinemeier Hansson
997eb90c90 Made the post_format work with content-type
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1337 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-20 18:39:40 +00:00
David Heinemeier Hansson
24b13acd42 Made the post_format work with content-type
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1336 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-20 18:32:04 +00:00
David Heinemeier Hansson
9bf38dec69 Include flash in the list of attributes with accessors in the view
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1334 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-20 07:04:51 +00:00
David Heinemeier Hansson
d3704f888b Fixed assert_redirect_to to work with redirect_to_path #869 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1332 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 19:19:58 +00:00
David Heinemeier Hansson
7160ab1c18 Fixed escaping of :method option in remote_form_tag #1218 [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1328 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 19:08:16 +00:00
David Heinemeier Hansson
977671c226 Optimize ActionCacheFilter by using url_for less #1230 [skaen]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1326 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 18:59:43 +00:00
David Heinemeier Hansson
caf6ff6a2f Cache relative_url_root and optimize path #1232 [skaen]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1325 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 18:55:50 +00:00
David Heinemeier Hansson
3a057ea4ac Faster action_exempted? #1231 [skaen]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1324 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 18:54:16 +00:00
David Heinemeier Hansson
45ee71af3c Added Serbia and Montenegro to the country_select #1239 [todd@robotcoop.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1323 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 18:30:53 +00:00
David Heinemeier Hansson
dd8c92ea5b Fixed Request#remote_ip in testing #1251 [bitsweat]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1322 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 18:24:52 +00:00
David Heinemeier Hansson
473e5bde74 Fixed that compute_public_path should recognize external URLs, so image_tag("http://www.example.com/images/icon.gif") is not prefixed with the relative url path #1254 [victor-ronr-trac@carotena.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1321 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 18:06:12 +00:00
David Heinemeier Hansson
202d5c0751 Added support for descending year values in DateHelper#select_year, like select_year(Date.today, :start_year => 2005, :end_year => 1900), which would count down from 2005 to 1900 instead of the other way #1274 [nwoods@mail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1320 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 17:40:02 +00:00
David Heinemeier Hansson
26022d8d2a Ajax docing #1282 [Dee.Zsombor@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1318 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 17:29:20 +00:00
David Heinemeier Hansson
496ee0cd1b Fixed that FormHelper#checkbox should return a checked checkbox if the value is the same as checked_value #1286 [Florian Weber]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1317 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 17:27:08 +00:00
David Heinemeier Hansson
9b1fefbf54 Fixed doc #1291
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1315 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 17:14:35 +00:00
David Heinemeier Hansson
7ec91d4651 Fixed Form.disable in Prototype #1317 [Wintermute]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1311 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 16:45:53 +00:00
David Heinemeier Hansson
aa20834222 Added accessors to logger, params, response, session, and headers from the view, so you can write <% logger.info "stuff" %> instead of <% @logger.info "others" %> -- more consistent with the preferred way of accessing these attributes and collections from the controller
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1307 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-19 16:00:04 +00:00
David Heinemeier Hansson
cada2c71d3 Use X-POST_DATA_FORMAT instead of just POST_DATA_FORMAT
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1305 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-14 09:31:35 +00:00
David Heinemeier Hansson
86d2b2792a Added support for POST data in form of YAML or XML, which is controller through the POST_DATA_MARSHAL header
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1304 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-14 08:38:37 +00:00
David Heinemeier Hansson
db11abbfba Added support for POST data in form of YAML or XML, which is controller through the POST_DATA_MARSHAL header
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1303 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-14 08:36:19 +00:00
David Heinemeier Hansson
51f9c931ea Fixed that render_partial_collection should always return a string (and not sometimes an array, despite <%= %> not caring)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1302 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-13 16:27:36 +00:00
David Heinemeier Hansson
8983a09752 Go straight to the class for asset_host
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1299 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-09 11:27:39 +00:00
David Heinemeier Hansson
45780be2a7 Added TextHelper#sanitize that can will remove any Javascript handlers, blocks, and forms from an input of HTML. This allows for use of HTML on public sites, but still be free of XSS issues. #1277 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1298 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-09 11:24:18 +00:00
David Heinemeier Hansson
b167248b21 Fixed the HTML scanner used by assert_tag where a infinite loop could be caused by a stray less-than sign in the input #1270 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1297 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-09 11:20:19 +00:00
David Heinemeier Hansson
8a41ea4588 Only gsub on a string
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1292 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-06 18:10:13 +00:00
David Heinemeier Hansson
409bc0970a Added functionality to assert_tag, so you can now do tests on the siblings of a node, to assert that some element comes before or after the element in question, or just to assert that some element exists as a sibling #1226 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1291 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-06 16:42:01 +00:00
David Heinemeier Hansson
c971c24839 Changed RAILS_ASSET_HOST to become ActionController::Base.asset_host
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1289 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-06 05:10:36 +00:00
David Heinemeier Hansson
358a669390 Added better error handling for regexp caching expiration
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1288 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-06 05:09:01 +00:00
David Heinemeier Hansson
ac44be3494 Treat all request types as upper-case so the switch will work
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1283 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-04 10:46:33 +00:00
David Heinemeier Hansson
8b2598bb64 Made it default to assuming a GET request and reading from command-line only in case of the new CMD method
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1282 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-04 09:39:41 +00:00
David Heinemeier Hansson
dacb61c8ca Added that both AssetHelper#stylesheet_link_tag and AssetHelper#javascript_include_tag now accept an option hash as the last parameter, so you can do stuff like: stylesheet_link_tag "style", :media => "all"
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1281 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-03 14:39:57 +00:00
David Heinemeier Hansson
d2fb072563 Added FormTagHelper#image_submit_tag for making submit buttons that uses images
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1280 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-03 14:30:53 +00:00
David Heinemeier Hansson
2eebd11e0b Added the option of specifying a RAILS_ASSET_HOST that will then be used by all the asset helpers. This enables you to easily offload static content like javascripts and images to a separate server tuned just for that.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1279 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-03 10:25:01 +00:00
David Heinemeier Hansson
1edb807aff Dont expire or read fragments if caching is turned off
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1270 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-02 07:49:55 +00:00
David Heinemeier Hansson
577a22c47e Dont benchmark if the logger has been turned off
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1269 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-05-02 07:05:15 +00:00
David Heinemeier Hansson
e6f3e5d900 Fixed action/fragment caching using the filestore when a directory and a file wanted to to use the same name. Now there's a .cache prefix that sidesteps the conflict #1188 [imbcmdth@hotmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1260 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 15:29:27 +00:00
David Heinemeier Hansson
537efa36d0 Doc fix #1200
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1257 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 13:36:40 +00:00
David Heinemeier Hansson
90b08c5b92 Fixed documentation #1214
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1254 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:50:10 +00:00
David Heinemeier Hansson
98306bed05 Fixed missing id uniqueness in FormTag#radio_button #1207 [Jarkko]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1253 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:46:22 +00:00
David Heinemeier Hansson
b4fe4daa84 Fixed assert_redirected_to to work with :only_path => false #1204 [Alisdair McDiarmid]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1251 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:34:02 +00:00
David Heinemeier Hansson
c29cfe389e Check definition on constant not string
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1250 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:33:25 +00:00
David Heinemeier Hansson
6d0ddd818a Fixed render_partial_collection to output an empty string instead of nil when handed an empty array #1202 [Ryan Carver]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1249 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:29:50 +00:00
David Heinemeier Hansson
5640f76970 Improved the speed of regular expression expirations for caching by a factor of 10 #1221 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1248 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:23:42 +00:00
David Heinemeier Hansson
fe00c275cd Removed dumping of template assigns on the rescue page as it would very easily include a ton of data making page loads take seconds (and the information was rarely helpful) #1222
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1246 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-30 08:19:14 +00:00
David Heinemeier Hansson
61cafca6ea Disregard expire methods when the controller hasnt been set, which essentially makes it such that the record observer callbacks are ignored when the sweeper shouldnt be active
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-27 17:40:51 +00:00
David Heinemeier Hansson
fbd86c2017 Added BenchmarkHelper that can measure the execution time of a block in a template and reports the result to the log
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1240 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-27 08:17:25 +00:00
David Heinemeier Hansson
a2ef9778ce Added ActionController::Caching::Sweeper as an improved an easier to use sweeper. Added that Fragments#expire_fragment now accepts as a regular expression as the name thereby deprecating expire_matched_fragments. Fixed that fragments shouldn't use the current host and the path as part of the key like pages does
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1239 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-27 08:14:53 +00:00
David Heinemeier Hansson
734c69f241 Added conditions to around_filters just like before_filter and after_filter
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1238 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-27 06:42:12 +00:00
David Heinemeier Hansson
77af61be40 Added xml_http_request/xhr method for simulating XMLHttpRequest in functional tests #1151 [Sam Stephenson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1230 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-19 16:34:44 +00:00
Sam Stephenson
71a616890b Update to Prototype 1.2.1
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1228 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-19 11:16:50 +00:00
David Heinemeier Hansson
5462358cd3 Fixed that :get, :post, and the others should take a flash array as the third argument just like process #1144 [rails@cogentdude.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1227 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-19 11:04:38 +00:00
David Heinemeier Hansson
0dd497853a More documentation #1148 [Alisdair McDiarmid]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1226 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-19 10:59:55 +00:00
David Heinemeier Hansson
865874ab6a Fixed stringification on all assigned hashes. The sacrifice is that assigns[:person] wont work in testing. Instead assigns["person"] or assigns(:person) must be used. In other words, the keys of assigns stay strings but weve added a method-based accessor to appease the need for symbols.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1223 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-19 10:26:03 +00:00
David Heinemeier Hansson
aa236c4425 Fixed that rendering a template would require a connection to the database #1146
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1222 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-19 09:57:15 +00:00
David Heinemeier Hansson
420b830b00 Fixed that rendering a template would require a connection to the database #1146
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1221 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-19 09:54:10 +00:00
David Heinemeier Hansson
7d01005514 Fixed documentation and prepared for release of 0.12
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1216 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-18 20:10:11 +00:00
David Heinemeier Hansson
3b9bf64130 Added support for web servers that use PATH_INFO instead of REQUEST_URI like IIS #1014 [BradG/Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1211 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-18 15:43:07 +00:00
David Heinemeier Hansson
e9681eb9c5 Added graceful handling of PUT, DELETE, and OPTIONS requests for a complete coverage of REST functionality #1136 [joshknowles@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1208 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-18 14:15:26 +00:00
David Heinemeier Hansson
bceb88ef9c Fixed that you can now pass an alternative :href option to link_to_function/remote in order to point to somewhere other than # if the javascript fails or is turned off. You can do the same with form_remote_tag by passing in :action. #1113 [Sam Stephenson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1200 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-18 05:15:17 +00:00
Sam Stephenson
d547c3f5ec Update to Prototype 1.2.0
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1198 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-18 02:16:13 +00:00
David Heinemeier Hansson
806cf6d76a Added assert_tag and assert_no_tag as a much improved alternative to the deprecated assert_template_xpath_match #1126 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1195 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 16:43:48 +00:00
David Heinemeier Hansson
95e6c03de7 Added Request#xml_http_request? (and an alias xhr?) to that'll return true when the request came from one of the Javascript helper methods (Ajax). This can be used to give one behavior for modern browsers supporting Ajax, another to old browsers #1127 [Sam Stephenson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1194 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 16:40:53 +00:00
David Heinemeier Hansson
7cda49248b Fixed page caching for non-vhost applications living underneath the root #1004 [Ben Schumacher]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1193 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 14:10:24 +00:00
David Heinemeier Hansson
72c51356c5 Hide the deprecated methods from the docs
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1190 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 11:47:54 +00:00
David Heinemeier Hansson
dca7efa67e Deprecated the majority of all the testing assertions and replaced them with a much smaller core and access to all the collections the old assertions relied on. That way the regular test/unit assertions can be used against these. Added documentation about how to use it all.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1189 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 11:38:01 +00:00
David Heinemeier Hansson
8e8bf37aa9 Fixed DateHelper to return values on the option tags such that they'll work properly in IE with form_remote_tag #1024 [rscottmace@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 09:44:28 +00:00
David Heinemeier Hansson
ba96827b3d Fixed FormTagHelper#check_box to respect checked #1049 [DelynnB]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1183 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 09:39:01 +00:00
David Heinemeier Hansson
e5b3d08a0a Added that render_partial called from a controller will use the action name as default #828 [Dan Peterson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1182 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 09:25:54 +00:00
David Heinemeier Hansson
c3ca5ab7a8 Added Element.toggle, Element.show, and Element.hide to the prototype javascript library. Toggle.display has been deprecated, but will still work #992 [Lucas Carlson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1181 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 07:52:50 +00:00
David Heinemeier Hansson
6acda705dc Added that deleting a cookie should not just set it to an empty string but also instantly expire it #1118 [todd@robotcoop.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1180 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 07:18:39 +00:00
David Heinemeier Hansson
ffdd4bc251 Added AssetTagHelper#image_path, AssetTagHelper#javascript_path, and AssetTagHelper#stylesheet_path #1110 [Larry Halff]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1176 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 06:23:27 +00:00
David Heinemeier Hansson
5e3b8b36fa Fixed url_for(nil) in functional tests #1116 [Alisdair McDiarmid]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1175 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 06:18:33 +00:00
David Heinemeier Hansson
db16349bc1 Fixed error handling of broken layouts #1115 [Michael Schubert]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1173 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-17 06:11:58 +00:00
David Heinemeier Hansson
6ee06ebec6 Changed render_partial to take local assigns as the second parameter instead of an explicit object and then the assigns
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1170 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-16 16:08:29 +00:00
David Heinemeier Hansson
82456d9392 Fixed partials handling
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-16 16:06:29 +00:00
David Heinemeier Hansson
f3e5e07982 Added submit_to_remote that allows you to trigger an Ajax form submition at the click of the submission button, which allows for multiple targets in a single form through the use of multiple submit buttons #930 [yrashk@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:44:43 +00:00
David Heinemeier Hansson
ad24c6d756 Fixed pagination to work with joins #1034 [scott@sigkill.org]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1159 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:40:22 +00:00
David Heinemeier Hansson
7f558cbd05 Fixed that *rest parameter in map.connect couldn't accept an empty list #1037 [Dee.Zsombor@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:35:51 +00:00
David Heinemeier Hansson
2ad8dc6a1f Added :confirm option to link_to_remote just like link_to has #1082 [yrashk@fp.org.ua]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:21:37 +00:00
David Heinemeier Hansson
c29db9f210 Added minute_step as an option to select_minute (and the helpers that use it) to jump in larger increments than just 1 minute. At 15, it would return 0, 15, 30, 45 options #1085 [ordwaye@evergreen.edu]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 05:15:41 +00:00
David Heinemeier Hansson
bf1bcff2bd Fixed that an exception would be thrown when an empty form was submitted #1090 [jan@ulbrich-boerwang.de]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 04:50:54 +00:00
David Heinemeier Hansson
988dc1e862 Improved tests for NumberHelper
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-13 04:49:01 +00:00
David Heinemeier Hansson
6f5fcc4469 Made error_messages_for take a symbol as object_name
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1148 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-12 17:44:28 +00:00
David Heinemeier Hansson
7140f65355 Moved TextHelper#human_size to NumberHelper#number_to_human_size, but kept an deprecated alias to the old method name
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1147 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-12 08:04:38 +00:00
David Heinemeier Hansson
a0403bd732 Fixed #1030
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1139 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 17:42:17 +00:00
David Heinemeier Hansson
5cd815addf Fixed spelling of delimiter #1058
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1134 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 17:30:38 +00:00
David Heinemeier Hansson
2119e0699a Fixed that the content-type for some browsers could include an additional \r which made wonky things happen #1067 [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1130 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 15:22:32 +00:00
David Heinemeier Hansson
ac4b4701c0 Fixed that radio buttons shouldn't have a default size attribute #1074 [hendrik@mans.de] Added ActionView::Helpers::InstanceTag::DEFAULT_RADIO_OPTIONS that contains a hash of default options for radio buttons #1074 [hendrik@mans.de]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1127 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 15:11:15 +00:00
David Heinemeier Hansson
87bed3af47 Fixed that in some circumstances controllers outside of modules may have hidden ones inside modules. For example, admin/content might have been hidden by /content. #1075 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1125 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-10 15:01:35 +00:00
David Heinemeier Hansson
90720a26f6 Fixed syntax error
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1112 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 08:37:26 +00:00
David Heinemeier Hansson
4bdb25da18 Update to the helper to abstract delimeting a number #1015
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1111 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 06:56:49 +00:00
David Heinemeier Hansson
1a22fb59c9 Added JavascriptHelper#periodically_call_remote in order to create areas of a page that update automatically at a set interval #945 [Jon Tirsen]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1108 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 06:43:21 +00:00
David Heinemeier Hansson
aefb36a688 Fixed Cache#expire_matched_fragments that couldn't recognize the difference between string and url_for options #1030 [skaes@web.de]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1106 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 06:35:27 +00:00
David Heinemeier Hansson
4ab40059b7 Added simulation of @request.request_uri in functional tests #1038 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1103 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-07 06:22:19 +00:00
David Heinemeier Hansson
480150e5fb Fixed autolinking to work better in more cases #1013 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1099 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-06 15:22:32 +00:00
David Heinemeier Hansson
a87c1d4dd8 Made it possible to do text_field :account, :name in addition to text_field "account", "name"
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1088 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-04 15:43:17 +00:00
David Heinemeier Hansson
d3a64c04ec Fixed javascript_include_tag to output type instead of language and conform to XHTML #1018 [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1081 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-03 16:23:56 +00:00
David Heinemeier Hansson
aa09c770e9 Added NumberHelper for common string representations like phone number, currency, and percentage #1015 [DeLynn]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1071 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 15:14:57 +00:00
David Heinemeier Hansson
91834e0c3f Fixed that benchmarking times for rendering included db runtimes #987 [skaes@web.de]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1070 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 09:31:58 +00:00
David Heinemeier Hansson
7c8d2f28e1 Removed broken attempt to DRY module ClassMethod #970
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1069 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 09:29:43 +00:00
David Heinemeier Hansson
c788bcb416 Automatically extend the class which gets a module included with the ClassMethods module if it exists #970 [Lucas Carlson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1068 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 09:14:19 +00:00
David Heinemeier Hansson
3532455404 Added pagination for scaffolding (10 items per page) #964 [mortonda@dgrmm.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1067 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 09:11:17 +00:00
David Heinemeier Hansson
ce96c5b30b Added assert_no_cookie and fixed assert_cookie_equal to deal with non-existing cookies #979 [bitsweat]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1065 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:54:25 +00:00
David Heinemeier Hansson
5d42774b62 Fixed :overwrite_param so it doesn't delete but reject elements from @request.parameters #982 [raphinou@yahoo.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1061 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:35:04 +00:00
David Heinemeier Hansson
00121b2ca2 Added :method option to verify for ensuring that either GET, POST, etc is allowed #984 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1060 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:33:30 +00:00
David Heinemeier Hansson
f7c61b629e Added options to set cc, bcc, subject, and body for UrlHelper#mail_to #966 [DeLynn]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1056 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 08:16:57 +00:00
David Heinemeier Hansson
7d09b8d723 Fixed include_blank for select_hour/minute/second #527 [edward@debian.org]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1055 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-04-02 07:54:01 +00:00
David Heinemeier Hansson
998ab50974 Improved the message display on the exception handler pages #963 [Johan Sorensen]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1048 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-31 14:46:11 +00:00
David Heinemeier Hansson
8499c24770 Added Effect.Puff and Effect.Appear #990, #996
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1046 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-31 11:53:06 +00:00
David Heinemeier Hansson
93e361e58a Fixed that on very rare occasions, webrick would raise a NoMethodError: private method 'split' called for nil #1001 [Flurin Egger]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1045 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-31 11:46:50 +00:00
David Heinemeier Hansson
ea3016f5d9 Renamed DateHelper#distance_of_time_in_words_to_now to DateHelper#time_ago_in_words (old method name is still available as a deprecated alias)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1038 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-30 13:06:19 +00:00
David Heinemeier Hansson
c73a414a9a Fixed references to element
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1034 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-28 23:57:43 +00:00
David Heinemeier Hansson
ce2fe88d53 Added Effect.Scale for smoothly scaling images or text up and down #972 [thomas@fesch.at] Added Effect.Squish for scaling down an element and making it disappear at the end #972 [thomas@fesch.at]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1033 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-28 23:32:24 +00:00
David Heinemeier Hansson
b0c0c9c2ef Added Effect.Fade which smoothly turns opacity from 100 to 0 and then hides the element #960 [thomas@fesch.at]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1032 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-28 10:22:44 +00:00
David Heinemeier Hansson
439a216dcb Fixed problem with page caching #958 [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1029 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-27 21:52:48 +00:00
David Heinemeier Hansson
dfadbfd3dc Added ActionController::Base.page_cache_extension for setting the page cache file extension (the default is .html) #903 [Andreas]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1019 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-27 00:30:35 +00:00
David Heinemeier Hansson
216b1b7897 Fixed "bad environment variable value" exception caused by Safari, Apache, and Ajax calls #918
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1018 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-27 00:10:53 +00:00
David Heinemeier Hansson
ad6798f965 Fixed that pagination_helper would ignore :params #947 [Sebastian Kanthak]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1017 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-27 00:04:07 +00:00
David Heinemeier Hansson
d3e1e03056 Added :owerwrite_params back to url_for and friends -- it was AWL since the introduction of Routes #921 [raphinou]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1016 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-27 00:01:56 +00:00
David Heinemeier Hansson
92088a920b Effects can just be used through the callbacks
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1014 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 23:43:29 +00:00
David Heinemeier Hansson
f7b89667ac Fixed a couple of more js issues
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1013 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 23:41:04 +00:00
David Heinemeier Hansson
4c3d52ad66 Updated to prototype.js 1.1.0
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1012 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 23:16:55 +00:00
David Heinemeier Hansson
5d6bedb383 Whitespace flicker
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1011 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 22:39:46 +00:00
David Heinemeier Hansson
520dae295b Added include_seconds option as the third parameter to distance_of_time_in_words which will render "less than a minute" in higher resolution ("less than 10 seconds" etc) #944 [thomas@fesch.at]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1010 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 22:00:23 +00:00
David Heinemeier Hansson
9fb6a54a16 Added fourth option to process in test cases to specify the content of the flash #949 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1009 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 21:43:25 +00:00
David Heinemeier Hansson
f569a14318 Added Verifications that allows you to specify preconditions to actions in form of statements like <tt>verify :only => :update_post, :params => "admin_privileges", :redirect_to => { :action => "settings" }</tt>, which ensure that the update_post action is only called if admin_privileges is available as a parameter -- otherwise the user is redirected to settings. #897 [Jamis Buck]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1008 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 21:41:10 +00:00
David Heinemeier Hansson
48b4d28d81 Fixing JS bugs, renamed :position values
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1007 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 20:27:04 +00:00
David Heinemeier Hansson
8e76a5920e Added other DOM manipulation positions than just replace
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1006 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 15:35:06 +00:00
David Heinemeier Hansson
e79801d7f2 Fixed highlight effect
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1005 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 15:22:18 +00:00
David Heinemeier Hansson
ae5f3c7488 Added :highlight effect to do YFT automatically
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1004 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 15:01:11 +00:00
David Heinemeier Hansson
9ca9f95aee Fixed Form.Serialize for the JavascriptHelper to also seriliaze password fields #934 [dweitzman@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1003 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 14:07:08 +00:00
David Heinemeier Hansson
3fe9d8ac35 Added JavascriptHelper#escape_javascript as a public method (was private) and made it escape both single and double quotes and new lines #940 [mortonda@dgrmm.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1002 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 14:03:55 +00:00
David Heinemeier Hansson
7a6a923f98 Added trailing_slash option to url_for, so you can generate urls ending in a slash. Note that is currently not recommended unless you need it for special reasons since it breaks caching #937 [stian@grytoyr.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1001 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 13:38:21 +00:00
David Heinemeier Hansson
cef57e0cc2 Added documentation on models in sessions #929 [c.r.mcgrath@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1000 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 13:35:22 +00:00
David Heinemeier Hansson
a5b55c6b9f Removed old UrlWriter methods that are no longer in use after Routes #942
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@999 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 13:31:01 +00:00
David Heinemeier Hansson
df7a4d498c Added expire_matched_fragments(regular_expression) to clear out a lot of fragment caches at once #927 [technoweenie@gmail.com] Fixed the problems with : and ? in file names for fragment caches on Windows #927 [technoweenie@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@996 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 13:09:56 +00:00
David Heinemeier Hansson
b0d69b170f Added TextHelper#human_size for formatting file sizes, like human_size(1234567) => 1.2 MB #943 [thomas@fesch.at]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@995 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 12:26:32 +00:00
David Heinemeier Hansson
4b3bb3d2b2 Fixed link_to :confirm #936 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@994 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-26 11:37:08 +00:00
David Heinemeier Hansson
771244a58c Made getElementsByClassName actually work
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@991 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-25 17:28:49 +00:00
David Heinemeier Hansson
45137795e8 Fixed that MissingSourceFile's wasn't properly detected in production mode #925 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@990 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-25 09:07:01 +00:00
David Heinemeier Hansson
3306813be1 Tweaked the rescue with breakpoint, still not perfect
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@986 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-23 12:03:30 +00:00
David Heinemeier Hansson
3697df1dd2 Improved error reporting especially around never shallowing exceptions. Debugging helpers should be much easier now #980 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@984 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-23 11:48:10 +00:00
David Heinemeier Hansson
546f30fc10 Fixed Toggle.display in prototype.js #902 [Lucas Carlson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@980 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-23 00:53:46 +00:00
David Heinemeier Hansson
daaa5251c9 Fixed documentation and prepared for 0.11.0 release
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@976 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-22 13:09:44 +00:00
David Heinemeier Hansson
6ad1b895f4 Updated more documentation
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@975 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-22 12:41:34 +00:00
David Heinemeier Hansson
4e60fe3ef3 Added documentation and fixed an ajax bug
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@974 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-22 12:33:47 +00:00
David Heinemeier Hansson
e1ce18020e Last-minute ajax fixes #898
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@973 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-03-22 12:13:36 +00:00