TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
79,696 Commits 2 Branches 0 Tags 294 MiB
f046617853
Commit Graph

567 Commits

Author SHA1 Message Date
Petrik
85c20074f0 Upgrade sdoc to 2.1.0 
Sdoc 2.1.0 works better on mobile and has improvements for SEO and
Lighthouse.

Changelog:
* #154 Make panel responsive for mobile.
* #153 Add viewport metatag to views for improved Lighthouse score.
* #150 Use semantic headers for better SEO.
 2021-03-31 12:51:01 +02:00
George Claghorn
526d630793 Upgrade to Marcel 1.0.0 2021-03-26 14:21:28 -04:00
George Claghorn
62ac25a364 Replace mimemagic with mini_mime 2021-03-26 14:20:40 -04:00
Rafael Mendonça França
d5ee11933f
Make sure the version of rake used in Rails apps work 
Since 68a3f679d93a22160cca9a8bd9a869b8c766f860, we are requiring rake
0.13, so we need to specify that is the version we want.
 2021-03-15 20:48:38 +00:00
Kasper Timm Hansen
a822923fd5
Merge pull request #41550 from p8/sdoc-2.0.4 
Update SDOC to 2.0.4
 2021-02-25 18:37:04 +01:00
Petrik
0dfb6a606a Update SDOC to 2.0.4 
This version has two layout fixes:
* Using HTML5 doctype accross all HTML files. @MikeRogers0
* Fix overflow CSS property of panel elements. @cveneziani
 2021-02-25 17:47:30 +01:00
Ryuta Kamizono
2994c4ba00 Use released redis-namespace instead of master branch 
https://rubygems.org/gems/redis-namespace/versions/1.8.1
 2021-02-22 18:49:24 +09:00
Rafael Mendonça França
1b455e2e9d
Rails 6.2 is now Rails 7.0 
We have big plans for the next version of Rails and that
require big versions.
 2021-02-04 16:47:16 +00:00
Rafael Mendonça França
1993496d7f
Upgrade all the gems to make sure we are testing with the latest versions locally 2021-01-21 21:22:41 +00:00
eileencodes
48f3c3e201
Update platforms in Gemfile.lock 
This keeps popping up after bundle on my local machine. We can
just add this to the lock file so there's no diff after bunding.
 2021-01-13 15:12:23 -05:00
utilum
1f3083bf5e Update minitest to comply with Ruby trunk 
8e55b9b07b
 2021-01-06 10:01:21 +01:00
Ryuta Kamizono
858b57574c Avoid nokogiri v1.11.0 to make our CI green 
https://buildkite.com/rails/rails/builds/73847#8a8b56c0-ebdf-4a34-8072-62b688412970/986-995

I think it is definitely an issue for nokogiri, so I'll avoid the
version to make our CI green.
 2021-01-05 21:59:37 +09:00
Rafael Mendonça França
03156c829d
Support selenium-webdriver 4 
* Use public API to add argument to the selenium driver.

  While `args` is also public API it doesn't know how to handle if no
  argument is being set yet in Selenium 4.

* Fix assertions to match return on Selenium 4
 2020-12-29 02:36:01 +00:00
Yasuo Honda
3bfeb2b186 Ruby 3 does not have webrick by default 
Railties CI against Ruby 3.0.0-dev has been failing
since https://buildkite.com/rails/rails/builds/73338#51165eef-b631-4f9c-8e98-fc210e71e6d1

This pull request addresses the following error.

```ruby
$ ruby -v
ruby 3.0.0dev (2020-12-13T04:39:57Z master c7530f0d56) [x86_64-linux]
$ ruby -Itest -Ilib -I../activesupport/lib -I../actionpack/lib -I../actionview/lib -I../activemodel/lib test/commands/server_test.rb
... snip ...
Run options: --seed 54404

.E

Error:
Rails::Command::ServerCommandTest#test_served_url:
LoadError: cannot load such file -- webrick
    test/commands/server_test.rb:292:in `test_served_url'

rails test test/commands/server_test.rb:289

........................

Finished in 0.303746s, 85.5977 runs/s, 177.7799 assertions/s.
26 runs, 54 assertions, 0 failures, 1 errors, 0 skips
$
```

Related to
https://github.com/ruby/ruby/pull/3729
https://bugs.ruby-lang.org/issues/17303
 2020-12-13 16:50:20 +09:00
Petrik
4860a6ee42 Update sdoc to latest version 
This fixes the title tag on the index page.
 2020-12-11 12:46:08 +01:00
Rafael Mendonça França
59f7f5889e
Start Rails 6.2 development 🎉 2020-12-03 01:35:29 +00:00
Dan Puttick
e87e6700ce Move unused build gems from ActionCable group 
- blade and sprockets-export are only used by ActionView
- blade-sauce_labs_plugin is no longer used, removed in #34440
 2020-11-26 18:58:17 -05:00
Dan Puttick
f6c9bdda19 Use thin 1.8.0 2020-11-26 17:21:39 -05:00
Akira Matsuda
7a02fed011 CI against erubi 1.10.0 2020-11-14 14:31:58 +09:00
Jonathan Hefner
9e16bb274a Update listen gem to v3.3 
Version 3.3 fixes memory leaks that occur when stopping individual
listeners (see guard/listen#476).
 2020-11-10 10:06:48 -06:00
Petrik
cfd4c85b7e Upgrade sdoc to 2.0.2 
Changes compared to 2.0.0:
* Fix arrow icons for selected panel items
* Always use only one metatag for keywords
* Use h2 instead of h1 for banner head
 2020-11-09 21:19:44 +01:00
Rafael Mendonça França
fc73becc3c
Upgrade all the gems 2020-11-04 06:39:41 +00:00
Rafael Mendonça França
8389f9902c
Preparing for 6.1.0.rc1 release 2020-11-02 21:12:47 +00:00
Petrik
f9ae061bfd Use official sdoc gem instead of fork [skip ci] 2020-11-02 20:58:37 +01:00
Nate Berkopec
b8af0fd2d7
Upgrade Puma to 5.x 2020-11-01 14:50:27 -07:00
Ryuta Kamizono
92ff708476 Re-enable Layout/SpaceAroundOperators cop 
We prefer space around operators, but `Layout/SpaceAroundOperators` cop
was temporarily disabled in #36943 since that cop changed to check
alignment strictly somehow.

In RuboCop 1.0.0, that is fixed by https://github.com/rubocop-hq/rubocop/pull/8906.

Related https://github.com/rails/rails/pull/38034#discussion_r359845661,
https://github.com/rails/rails/pull/39770#discussion_r448829561.
 2020-10-23 16:12:15 +09:00
Petrik
edff55987a Replace frames-based api docs with css implementation and Turbolinks 
The current Rails documentation has a frames based implementation. This
prevents deep linking to documentation and removes navigation if the page
is opened without frames.

We can keep the same layout with a css based implementation.

Turbolinks is used to persisted the navigation/search bar across
requests.
 2020-10-16 12:24:09 +02:00
Eugene Kenny
2bd1ae22c6 Update sprockets-rails to fix tests on Ruby master 
Without this, railties/test/application/rake_test.rb fails with:

    ActionView::Template::Error: wrong number of arguments (given 2, expected 1)
 2020-10-03 22:43:39 +01:00
Eugene Kenny
206e9bb79a Update sidekiq to fix warnings in Active Job tests 
`Redis#exists(key)` will return an Integer in redis-rb 4.3, if you want to keep the old behavior, use `exists?` instead. To opt-in to the new behavior now you can set Redis.exists_returns_integer = true. (/Users/eugene/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/sidekiq-6.0.4/lib/sidekiq/launcher.rb:134:in `block (2 levels) in ❤')
 2020-10-03 22:27:05 +01:00
Rafael Mendonça França
f624ed09ab
Don't make rexml an dependency of activesupport 
rexml is only used in the xml_mini backend and it should be the users
choice if they want to use that feature or not. If they do we will warn
them that installing rexml is needed like we do with all backends.
 2020-09-24 22:41:04 +00:00
Ryuta Kamizono
c23533ee0b rexml is no longer default gem in Ruby 3.0 
https://bugs.ruby-lang.org/issues/16485
https://github.com/ruby/ruby/pull/2832

Unless adding `s.add_dependency "rexml"` in the gemspec,
`ActiveSupport::XmlMini` with default engine (REXML) won't work.

```ruby
# frozen_string_literal: true

require "bundler/inline"

gemfile(true) do
  source "https://rubygems.org"

  git_source(:github) { |repo| "https://github.com/#{repo}.git" }

  gem "activesupport", github: "rails/rails"
end

require "active_support"
require "active_support/xml_mini"
require "minitest/autorun"

class BugTest < Minitest::Test
  def test_stuff
    xml_string = "<root></root>"
    assert_equal({ "root" => {} }, ActiveSupport::XmlMini.parse(xml_string))
  end
end
```

```
% ruby xml_mini.rb
Fetching gem metadata from https://rubygems.org/.......
Fetching gem metadata from https://rubygems.org/............
Fetching gem metadata from https://rubygems.org/............
Resolving dependencies...
Using bundler 2.2.0.dev
Using concurrent-ruby 1.1.7
Using minitest 5.14.2
Using zeitwerk 2.4.0
Using i18n 1.8.5
Using tzinfo 2.0.2
Using activesupport 6.1.0.alpha from source at `..`
Run options: --seed 20428

# Running:

E

Finished in 0.002034s, 491.6421 runs/s, 0.0000 assertions/s.

  1) Error:
BugTest#test_stuff:
LoadError: cannot load such file -- rexml/document
    /Users/kamipo/src/github.com/rails/rails/activesupport/lib/active_support/xml_mini/rexml.rb:28:in `require'
    /Users/kamipo/src/github.com/rails/rails/activesupport/lib/active_support/xml_mini/rexml.rb:28:in `block in parse'
    /Users/kamipo/src/github.com/rails/rails/activesupport/lib/active_support/core_ext/kernel/reporting.rb:15:in `block in silence_warnings'
    /Users/kamipo/src/github.com/rails/rails/activesupport/lib/active_support/core_ext/kernel/reporting.rb:28:in `with_warnings'
    /Users/kamipo/src/github.com/rails/rails/activesupport/lib/active_support/core_ext/kernel/reporting.rb:15:in `silence_warnings'
    /Users/kamipo/src/github.com/rails/rails/activesupport/lib/active_support/xml_mini/rexml.rb:28:in `parse'
    /Users/kamipo/src/github.com/rails/rails/activesupport/lib/active_support/xml_mini.rb:94:in `parse'
    xml_mini.rb:23:in `test_stuff'

1 runs, 0 assertions, 0 failures, 1 errors, 0 skips
```

Follow up of 0399be70766d7c6bf46d727ef2e337ff40f242b4.
 2020-09-24 16:07:16 +09:00
Ryuta Kamizono
94ea7281b8 Use master branch for listen and redis-namespace 
To fix CI build in Ruby 3.0 for the time being.
 2020-09-24 15:24:26 +09:00
Rafael Mendonça França
5ec51b9577
Use mysql2 from git to fix warnings with Ruby 2.7 
Closes #40272.
 2020-09-22 19:49:12 +00:00
George Claghorn
a185ff86c0
Set default variant format from blob content type 2020-09-22 13:03:53 -04:00
utilum
1541e5bee3
Update w3c_validtors for Ruby 3 compatibility (#40227) 
* Update w3c_validtors for Ruby 3 compatibility

* Update google-api-client for Ruby 3 compatibility
 2020-09-21 14:19:59 +09:00
utilum
cac50764b8 Update Minitest to allow installation with Ruby 3. 
9713c55362
 2020-09-10 11:18:57 +02:00
Jonathan Hefner
8d121409dd Update Gemfile.lock with rubocop-packaging 
Follow-up to #40185.
 2020-09-06 14:46:11 -05:00
Utkarsh Gupta
cd9ab098c4 Update RuboCop to v0.90 
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
 2020-09-06 06:37:04 +05:30
Ryuta Kamizono
49f1f64c10 Update Gemfile.lock 2020-08-18 18:14:00 +09:00
Petrik
f6bcd1496e Use Rouge for guides code highlighting [ci skip] 
Replace javascript highlighting using Prism with the Rouge markdown
highlighter. Uses the github theme.
 2020-07-08 09:05:08 +02:00
Ryuta Kamizono
37c19f7ebc Fix Active Support failure for redis 4.2.0 with Ruby 2.8.0-dev 2020-06-10 09:25:03 +09:00
Ryuta Kamizono
c07dff7227 Auto-correct for delete_prefix/delete_suffix 
Follow up to #39409.
 2020-06-05 12:40:39 +09:00
Ryuta Kamizono
60bfed90ce Revert "Lock benchmark-ips version "< 2.8"" 
This reverts commit c1b8833edbc55cdbea34b572e8759a92ed9a4660.

Revert "Lock benchmark-ips version < 2.8"

This reverts commit 62bfa50ff2db093508575b442ac50b125dd0850b.

LoadError is fixed in benchmark-ips 2.8.2.

https://github.com/evanphx/benchmark-ips/pull/101
 2020-06-05 10:22:27 +09:00
Eugene Kenny
c4dc01363c Fix minitest version constraints in Gemfile.lock 
Followup to e803ab6e80e2fc0b772e2135ce85111cdce23e2f.

The dependencies of each entry are alphasorted, and minitest-server's
version constraint is still pessimistic.
 2020-06-01 11:59:27 +01:00
David Heinemeier Hansson
e803ab6e80 Reflect the permissive float in the lock file 2020-05-31 16:45:37 -07:00
fatkodima
e24d6ecbfd Update rubocop-performance gem and enable Performance/DeletePrefix and Performance/DeleteSuffix cops 2020-05-24 12:51:35 +03:00
Ricardo Trindade
b7e3a13cbe
Updates to nokogiri 1.10.9 2020-05-20 19:30:53 +01:00
Xavier Noria
cf71309684 Depend on Zeitwerk 2.3 
Let's bump Zeitwerk in preparation for Rails 6.1.

With Zeitwerk 2.3, applications can enable reloading and eager loading
at the same time. As of this writing, Rails does not implement that
logic, but if we do we know the dependency is in place to support it.

Zeitwerk minor releases are backwards compatible, should be a seamlessly
upgrade.
 2020-05-02 11:53:30 +02:00
Ryuta Kamizono
62bfa50ff2 Lock benchmark-ips version < 2.8 
Looks like "File does not exist: benchmark/ips/stats/stats_metric" is
caused by benchmark-ips 2.8.0.

https://buildkite.com/rails/rails/builds/68586#d77847d6-b3f5-4fd9-af9e-45f465c9d801/940-965
https://buildkite.com/rails/rails/builds/68586#e2037c59-a695-41ff-9040-c8ee74fa7c16/940-965
 2020-05-02 06:36:07 +09:00
Ryuta Kamizono
592358e182 Update pg gem required version to 1.1 
This is required for #39063 to use `PG::TextDecoder::Numeric`.

Ref https://github.com/ged/ruby-pg/pull/25.

The pg gem 1.1.0 was released at August 24, 2018, so I think it is good
timing to bump the required version for improving and cleaning up the
code base.

https://rubygems.org/gems/pg/versions
 2020-04-27 16:27:40 +09:00