TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
64,742 Commits 2 Branches 0 Tags 294 MiB
f6b3d34a1c
Commit Graph

5163 Commits

Author SHA1 Message Date
Kasper Timm Hansen
f6b3d34a1c Merge pull request #30593 from BigChief45/guides/action-mailer-parameterized 
Update Action Mailer Basics [ci skip]
 2017-09-24 18:38:14 +02:00
Ryuta Kamizono
6aa56460d5 Merge pull request #30668 from yhirano55/fix_api_guide 
Fix rails middleware list in api_app guide [ci skip]
 2017-09-24 13:47:26 +09:00
Yoshiyuki Hirano
5d8945fd49 Fix email in Active Support Instrumentation [ci skip] 
* `s/ddh/dhh/`
 2017-09-24 11:25:15 +09:00
Jaime Alvarez
50bc497a9f Update Action Mailer Basics [skip ci] 2017-09-24 00:56:44 +00:00
Yoshiyuki Hirano
6b12d02e15 Fix rails middleware list in api_app guide [ci skip] 
* `MyApi::Application::Routes` is not middleware.
 2017-09-24 05:55:50 +09:00
Yoshiyuki Hirano
9b917789fa Update link in The Asset Pipeline guide [ci skip] 2017-09-21 08:08:04 +09:00
Anton Chumakov
8c2ca4d4fc Update Rails Guides about :autosave option 2017-09-20 22:37:19 +03:00
Sean Griffin
eddb9baf39 Merge pull request #30624 from bogdanvlviv/deprecate_Module_reachable 
Deprecate `Module#reachable?` method
 2017-09-20 13:11:34 -06:00
Eileen M. Uchitelle
057de4f7c9 Merge pull request #30616 from yhirano55/update_layouts_and_rendering 
Update Layouts and Rendering in Rails [ci skip]
 2017-09-20 13:01:31 -04:00
Javan Makhmali
30767f980f Merge pull request #30623 from manojmj92/manojmj92-oo-key-patch 
make documentation consistent with  KeyError message
 2017-09-20 07:29:12 -04:00
Manoj M J
80f46653e2 Fix error message documentation 2017-09-20 13:08:00 +05:30
Claudio B
2f8ecdb21d Use credentials, not secrets, for Active Storage (#30650) 
According to #30067:

> This PR will deprecate secrets.yml* and instead adopt
> config/credentials.yml.enc to signify what these secrets are specifically
> for: Keeping API keys, database passwords, and any other integration
> credentials in one place.

[ci skip] since only comments are being edited.
 2017-09-19 17:08:32 -05:00
Yauheni Dakuka
fe15175039 Update action_controller_overview.md [ci skip] 2017-09-19 11:42:19 +03:00
Yoshiyuki Hirano
9291a81369 Use ApplicationJob instead of ActiveJob::Base in guide [ci skip] 2017-09-18 22:15:46 +09:00
Gerard Cahill
5c13e8c98e add section to guides for discarding and retrying active jobs [ci skip] 2017-09-18 13:54:46 +01:00
Ryuta Kamizono
00cc168f75 Merge pull request #30642 from ydakuka/quotes 
Fix quotes [ci skip]
 2017-09-18 15:53:06 +09:00
Yauheni Dakuka
c9527652c7 Fix quotes [ci skip] 2017-09-18 09:38:47 +03:00
Yauheni Dakuka
62d547c6a4 Upcase js [ci skip] 2017-09-18 09:15:33 +03:00
Yauheni Dakuka
76d373bc41 Remove "the" [ci skip] 2017-09-18 08:15:02 +03:00
Ryuta Kamizono
db844d9fb3 Merge pull request #30637 from bogdanvlviv/add_round_bracket_in_5_1_release_notes 
Add missing round bracket in "Ruby on Rails 5.1 Release Notes" guide [ci skip]
 2017-09-18 03:07:36 +09:00
bogdanvlviv
846990b488
Add missing round bracket in "Ruby on Rails 5.1 Release Notes" guide 
[ci skip]
 2017-09-17 20:41:22 +03:00
Yauheni Dakuka
e484a2d109 Update plugins.md [ci skip] 2017-09-17 15:40:11 +03:00
bogdanvlviv
275065355c
Remove mentions about Module#reachable? in "Active Support Core Extensions" guide 2017-09-17 02:32:32 +03:00
Yoshiyuki Hirano
a52e2bed86 Update Layouts and Rendering in Rails [ci skip] 
* The example code on this page are similar to ones generated
  by scaffold generator, but some points are different.

* Of course, it is no reason to be as same as scaffolding codes.
  But this is the guide for beginners, I thought it's better
  to be almost same as scaffolding codes.
 2017-09-17 07:40:58 +09:00
Ryuta Kamizono
34956f7422 Merge pull request #30618 from y-yagi/fix_credentails 
Fix typo: `credentails` -> `credentials` [ci skip]
 2017-09-16 16:11:32 +09:00
yuuji.yaginuma
8a3cf5340c Fix typo: credentails -> credentials [ci skip] 
Follow up of ca18922ac23be2cde6963fae9b193c9111bec6f8
 2017-09-16 16:06:04 +09:00
Yoshiyuki Hirano
0e573a5fb8 Update Getting Started with Rails [ci skip] 2017-09-15 14:25:25 +09:00
Ryuta Kamizono
f904700ba4 Merge pull request #30598 from yhirano55/update_activejob_basics 
Update Active Job Basics [ci skip]
 2017-09-14 09:35:16 +09:00
Yoshiyuki Hirano
3e055671a1 Update Active Job Basics [ci skip] 
* Add Sneakers link to documentation list.
 2017-09-14 09:30:56 +09:00
Kasper Timm Hansen
ca18922ac2
[ci skip] Prefer credentials to secrets in docs. 
Removes most mentions of secrets.secret_key_base and explains
credentials instead.

Also removes some very stale upgrade notices about Rails 3/4.
 2017-09-13 21:28:11 +02:00
Yoshiyuki Hirano
6afb3dbf89 Update Getting Started with Rails [ci skip] 2017-09-14 02:38:11 +09:00
Yauheni Dakuka
70bb0cc2ec Fix created_at [ci skip] 2017-09-13 09:36:53 +03:00
yuuji.yaginuma
ad80cef22d Remove not used gems by default [ci skip] 
`rack-mount` switched to journey with 5f0b37c.
Also, `rack-cache` will not be used unless you explicitly specify it.

Ref:
037e50ec39
1fc7954685
 2017-09-11 07:42:08 +09:00
Yauheni Dakuka
56ac13e8e4 fix type fully qualified [ci skip] 2017-09-06 15:49:04 +03:00
Matthew Draper
2e6658ae51 Clarify intentions around method redefinitions 
Don't use remove_method or remove_possible_method just before a new
definition: at best the purpose is unclear, and at worst it creates a
race condition.

Instead, prefer redefine_method when practical, and
silence_redefinition_of_method otherwise.
 2017-09-01 14:27:13 +09:30
Luke Persola
fd416c4336 In Action View Overview guide, remove reference to custom helpers 
[ci skip]
 2017-08-30 19:21:13 -07:00
Eileen M. Uchitelle
86389b4143 Merge pull request #29964 from gwincr11/cg-partial-caching 
Add documentation about template partial caching
 2017-08-30 08:38:53 -04:00
Cory Gwin @gwincr11
49f6c47e41 Add documentation about template partial caching 
Motivation:
  - #29423 surfaced some confusion about how template caching works when
  using partials across files with different mime types. This doc
  attempts to explain how this can be accomplished.
 2017-08-30 08:36:58 -04:00
Ryuta Kamizono
9a66a22102 Use YAML syntax highlight for config/locales/en.yml [ci skip] 2017-08-29 20:49:39 +09:00
Ryuta Kamizono
c4e576fc7f It should be "the resulting cache key", not "the resulting cache-key" [ci skip] 
This is a partial revert of 07402aa1307a4ff71b4ef6581f95b8612238a6af.

I also changed "cache-key" to "cache key" because "cache-key" appears
only once in the repo.

```
% git grep '\bcache-key\b' | wc -l
1

% git grep '\bcache key\b' | wc -l
28
```
 2017-08-29 20:44:04 +09:00
Eileen M. Uchitelle
07402aa130 Merge pull request #30447 from yhirano55/update_caching_with_rails 
Update Caching with Rails guide [ci skip]
 2017-08-29 07:23:50 -04:00
Yoshiyuki Hirano
ddc8f433a9 Update Caching with Rails guide [ci skip] 2017-08-29 06:42:36 +09:00
Yoshiyuki Hirano
0cc49a57d2 Update Rails I18n API guide [ci skip] 2017-08-29 06:23:48 +09:00
Vipul A M
62647ce417 Merge pull request #30435 from yhirano55/fix_grammer_in_guide_for_javascript 
Fix grammar in JavaScript in Rails [ci skip]
 2017-08-27 22:42:20 +05:30
Yoshiyuki Hirano
1243ccc371 Fix grammar in guide [ci skip] 
* I've fixed grammar problems in the guide about JavaScript in Rails.
 2017-08-28 00:57:09 +09:00
Ryuta Kamizono
4b3ee155f9 Remove trailing spaces [ci skip] 2017-08-27 22:29:56 +09:00
Daniel Steele
48aa94693c Correct wording and adding info [ci skip] 
I had to do some I was unsure what kind of caching it was performing, and had to do some Googling. Also improves the wording.
 2017-08-26 11:49:13 +01:00
Ryuta Kamizono
906c1d8f59 Merge pull request #30394 from ydakuka/fixing-indentation 
Fix indentation [ci skip]
 2017-08-24 19:19:56 +09:00
Yauheni Dakuka
566a056115 Fix indentation [ci skip] 2017-08-24 13:10:53 +03:00
Yauheni Dakuka
344b0f6e64 Update active_support_core_extensions.md [ci skip] 2017-08-24 10:47:34 +03:00