Commit Graph

3100 Commits

Author SHA1 Message Date
Jamis Buck
519e7e5e12 Fix problem with unloaded ARStore sessions being loaded when they are garbage collected, causing problems if there were AR objects in the session.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3817 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-08 16:53:34 +00:00
Tobias Lütke
8b4729a0eb reverted #to_sentence to use red, green, and blue style
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3816 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-08 16:13:13 +00:00
Rick Olson
e320f28945 Make the 3rd arg optional for #failsafe_response
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3815 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-08 14:33:07 +00:00
Rick Olson
043bee3338 Re-added mixed-in helper methods for the JavascriptGenerator. Moved JavascriptGenerators methods to a module that is mixed in after the helpers are added. Also fixed that variables set in the enumeration methods like #collect are set correctly. Documentation added for the enumeration methods [Rick Olson].
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3814 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-08 05:21:27 +00:00
Rick Olson
3c78d0b1eb remove explicit Builder require
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3813 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-08 03:28:25 +00:00
David Heinemeier Hansson
cd989472a5 Added Hash#to_xml and Array#to_xml that makes it much easier to produce XML from basic structures [DHH] Moved Jim Weirich's wonderful Builder from Action Pack to Active Support (it's simply too useful to be stuck in AP) [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3812 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-08 02:56:25 +00:00
Jamis Buck
24fca9d92e make integration testing not interfere with command-line regex test filters
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3811 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-07 22:04:23 +00:00
Jamis Buck
4d4f0e6490 Make IntegrationTest refer to superclass properties using copy-on-write
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3810 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-07 17:58:34 +00:00
Rick Olson
31a499ac27 Added a backtrace to the evil WSOD (White Screen of Death). Closes #4073. TODO: Clearer exceptions [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3809 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-07 07:27:54 +00:00
David Heinemeier Hansson
6fd737b76b Proper options for XmlSimple
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3808 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-07 04:52:49 +00:00
Jamis Buck
0fbe6837b1 more integration tweaks
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3807 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-07 04:42:24 +00:00
David Heinemeier Hansson
dc4b5cff39 XmlSimple _should_ be the default since XmlNode is not compatible with regular parameters -- also known as Why Did My Etech Demo Not Work? [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3806 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-07 04:42:13 +00:00
Jamis Buck
1c0163e50c A few minor tweaks to the integration testing stuff
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3805 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-07 01:07:54 +00:00
Rick Olson
2383a60443 Allow set_fixture_class to take Classes instead of strings for a class in a module. Raise FixtureClassNotFound if a fixture can't load. [Rick Olson] closes #4095
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3804 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-06 23:03:35 +00:00
Tobias Lütke
0332d882b6 forgot to commit the fixed test case! (yea right)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3803 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-06 22:51:24 +00:00
Tobias Lütke
66386df3d9 changed default of Array#to_sentence to use one, two and three notation ( skip_last_comma => true )
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3802 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-06 22:36:37 +00:00
David Heinemeier Hansson
08967ead78 Allow method chaining in RJS elements [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3801 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-06 19:45:02 +00:00
Sam Stephenson
382741f289 Update Prototype for beta gems
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3795 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-06 17:33:25 +00:00
Rick Olson
7c4b7affdb Fix quoting of inheritance column for STI eager loading #4098 [Jonathan Viney <jonathan@bluewire.net.nz>]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3790 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-06 16:00:46 +00:00
Rick Olson
c58dff1c9c slight change to eager associations table aliasing: use class_reflection, like 'post_comments' or 'tree_children'
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3788 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-06 04:47:58 +00:00
Rick Olson
5a7722de98 added assert_queries for the AR test suite
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3784 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 23:41:17 +00:00
David Heinemeier Hansson
2f9442c1d4 Added tracking of database and framework versions in script/about #4088 [charles.gerungan@gmail.com/Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3783 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 21:38:51 +00:00
David Heinemeier Hansson
c450a36f16 Doc fixes
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 21:37:12 +00:00
Jamis Buck
b8134000c4 Silence the migration messages when importing the schema for tests
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3781 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 20:11:08 +00:00
David Heinemeier Hansson
ccfcd9fe22 Doc fixes
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3780 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 20:00:04 +00:00
David Heinemeier Hansson
3c756f85be Dont mkdir for each framework now that theyre checked out in their entirety
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3779 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 19:29:40 +00:00
Tobias Lütke
0635f633cc ActionController::Base.param_parsers now accept symbols. currently supported are :xml_node, :xml_simple and :yaml
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3778 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 19:16:55 +00:00
Tobias Lütke
03d37a2d68 Added new infrastructure support for REST webservices.
By default application/xml posts are handled by creating a XmlNode object with the same name as the root element of the submitted xml. M$

 ActionController::Base.param_parsers['application/atom+xml'] = Proc.new do |data|
    node = REXML::Document.new(post)
   { node.root.name => node.root }
 end

 XmlSimple and Yaml web services were retired, ActionController::Base.param_parsers carries an example which shows how to get this functio$
 request.[formatted_post?, xml_post?, yaml_post? and post_format] were all deprecated in favor of request.content_type [Tobias Luetke]

Closes #4081


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3777 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 18:59:58 +00:00
David Heinemeier Hansson
4f00c70580 Fixed eager loading problems with single-table inheritance [Rick Olson] Added smarter table aliasing for eager associations for multiple self joins [Rick Olson] (closes #3580)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3776 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 18:43:56 +00:00
David Heinemeier Hansson
84b8920a11 Dont generate migration when doing scaffolding
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3775 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 17:17:27 +00:00
David Heinemeier Hansson
2d491bddf7 Fixed tests (closes #4087) [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3774 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 16:41:04 +00:00
David Heinemeier Hansson
5f724b516c Fixed tests (closes #4087) [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 16:35:27 +00:00
David Heinemeier Hansson
16b9409a9c allow RJS enum values to be passed to visual_effect() and other scriptaculous helpers #4080 [Rick Olson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3772 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 06:42:58 +00:00
David Heinemeier Hansson
5afbffdd95 Migrations created alongside models should be called CreateModels not AddModels for consistency with the create/drop notion of tables [Dave Thomas]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3771 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-05 00:45:19 +00:00
David Heinemeier Hansson
045f5fd02e Added public/javascripts/application.js as a sample since it'll automatically be included in javascript_include_tag :defaults [DHH] (backed out of -a/--with-assets, not worth it)
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3770 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 23:53:41 +00:00
David Heinemeier Hansson
55854c4195 Added cascading eager loading that allows for queries like Author.find(:all, :include=> { :posts=> :comments }), which will fetch all authors, their posts, and the comments belonging to those posts in a single query (using LEFT OUTER JOIN) #3913 [anna@wota.jp]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 23:33:10 +00:00
David Heinemeier Hansson
30caefdfc7 Backed out of that. PStore doesnt support suffix :(
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3768 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 22:49:52 +00:00
David Heinemeier Hansson
a1d70a5329 Backed out of that. PStore doesnt support suffix :(
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3767 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 22:41:59 +00:00
David Heinemeier Hansson
56b75a7e04 CHANGED DEFAILT: File-based sessions now have a suffix of ".rails_session" instead of a prefix called "ruby_sess." [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3766 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 22:31:50 +00:00
David Heinemeier Hansson
fc7e06f3e0 Words of caution
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3765 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 21:34:59 +00:00
David Heinemeier Hansson
b339170271 Added -a/--with-assets option to rails generator that will include default assets for application layout, javascript, and stylesheet [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3764 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 21:30:14 +00:00
David Heinemeier Hansson
b059ceb94f Migrations should use symbols now that the schema dumper is switching to that as well [Suggested by Robby Russel]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 20:08:01 +00:00
Jamis Buck
ff881c7f8b Make counter cache work when replacing an association (closes #3245). Thanks for the patch!
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3762 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 19:42:41 +00:00
David Heinemeier Hansson
eb01d35109 Added socket cleanup for lighttpd, both before and after [DHH] Added automatic creation of tmp/ when running script/server [DHH] Added silence_stream that'll work on both STDERR or STDOUT or any other stream and deprecated silence_stderr in the process [DHH]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3761 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 19:39:26 +00:00
Jamis Buck
c0fb67c0f8 Make migrations verbose
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3760 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 18:46:51 +00:00
David Heinemeier Hansson
bfaf71cbc2 We need to silence_stderr on the call to svn in order not to get errors when svn is not available or the app is not checked in
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3759 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 18:04:55 +00:00
David Heinemeier Hansson
3dcf7fe4e9 Fixed that Date was in incorrect format in tasks.yml (closes #4072) [mlaster@metavillage.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3758 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 17:17:43 +00:00
David Heinemeier Hansson
e3bfd08cbc Fixed Effect.Appear in effects.js to work with floats in Safari (closes #3524, #3813, #3044) [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 17:12:03 +00:00
Jamis Buck
964b67dd0e Make counter_cache work with polymorphic belongs_to
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3756 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-04 15:11:17 +00:00
Jamis Buck
c0d2477886 remove explicit dependency mechanism setting in console_app
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3755 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-03-03 21:24:39 +00:00