TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
40,788 Commits 2 Branches 0 Tags 294 MiB
fc32b7f99b
Commit Graph

10684 Commits

Author SHA1 Message Date
Kuldeep Aggarwal
fc32b7f99b skiping => skipping 2013-11-19 03:08:08 +05:30
Carlos Antonio da Silva
81475534ed Merge pull request #12898 from chocoby/fix/changelog_comment 
Fix CHANGELOG typo [ci skip]
 2013-11-15 05:33:38 -08:00
Carlos Antonio da Silva
00adce4ff0 Avoid hash lookups for building an array of required defaults 
Only set the value once after it's calculated.
 2013-11-15 11:29:32 -02:00
Carlos Antonio da Silva
3f2bf0dbe9 Get rid of useless temp variable 2013-11-15 11:29:31 -02:00
Carlos Antonio da Silva
5f00f13724 Set values instead of building hashes with single values for merging 2013-11-15 11:29:31 -02:00
chocoby
04907b64ac Fix CHANGELOG typo [ci skip] 2013-11-15 22:22:49 +09:00
Andrey Ognevsky
d04c4fac3b Take Hash with options inside Array in #url_for 2013-11-15 15:50:42 +04:00
David Heinemeier Hansson
07996ebc50 Revert "Used Yield instead of block.call" -- this causes all of atom_feed_helper_test.rb to fail with "SystemStackError: stack level too deep". 
This reverts commit d3a1ce1cdc60d593de1682c5f4e3230c8db9a0fd.
 2013-11-14 15:31:27 -08:00
Rafael Mendonça França
d4587bab24 Merge pull request #12892 from akshay-vishnoi/refactor 
avoiding next statements
 2013-11-14 12:32:23 -08:00
Akshay Vishnoi
dbcd085013 avoiding next statements 2013-11-15 01:37:33 +05:30
Rafael Mendonça França
84961dc5df Merge pull request #12889 from kuldeepaggarwal/speed_ups 
Used Yield instead of block.call
 2013-11-14 11:29:28 -08:00
Kuldeep Aggarwal
d3a1ce1cdc Used Yield instead of block.call 2013-11-15 00:53:57 +05:30
Akshay Vishnoi
fdf36d8110 class methods moved to already defined class<<self block 2013-11-15 00:23:35 +05:30
Akshay Vishnoi
1529e61036 #presence used 2013-11-14 16:08:43 +05:30
Guillermo Iguaran
b72304f41e Merge pull request #12838 from strzalek/remove_mime_type_order_var 
Remove @order attribute from collector
 2013-11-10 21:31:37 -08:00
Lukasz Strzalkowski
83f75a97e2 Remove order attribute from collector 
Ruby 1.8 legacy. Since 1.9 hash preserves insertion order. No need for additional array to achieve this
 2013-11-10 21:30:43 -08:00
Rafael Mendonça França
4a344c50a1 Merge pull request #12740 from gaurish/patch-1 
Improve Errors when Controller Name or Action isn't specfied
 2013-11-10 17:32:56 -08:00
Gaurish Sharma
5122bbb3c2 Skip test which is broken on jruby 
This test is broken from quite a while & is expected to remain broken as
encoding issues are hardest to fix in JRuby. so lets skip this test for
now
 2013-11-09 02:36:24 +05:30
Aaron Patterson
267e5c84f9 calculate the ivars to remove in advance as a set and cache them in a 
constant.

`view_assigns` can use the precalculated sets and remove instance
variables without allocating any extra arrays
 2013-11-06 14:21:40 -08:00
Aaron Patterson
c8b566d54d use a set and reject to avoid array allocations 2013-11-06 14:11:37 -08:00
Aaron Patterson
779cd6ec61 each_with_object on the view_assigns hash 2013-11-06 13:54:15 -08:00
Aaron Patterson
9a4adb4b05 use slice to avoid range allocation 2013-11-06 13:53:52 -08:00
Aaron Patterson
697acc4025 these variables are also private 2013-11-06 13:37:24 -08:00
Aaron Patterson
32e94a488f instance_variables returns symbols, so we should use symbols in our list 2013-11-06 13:24:00 -08:00
Godfrey Chan
ff1192fea4 Eliminate JSON.{parse,load,generate,dump} and def to_json 
JSON.{dump,generate} offered by the JSON gem is not compatiable with
Rails at the moment and can cause a lot of subtle bugs when passed
certain data structures. This changed all direct usage of the JSON gem
in internal Rails code to always go through AS::JSON.{decode,encode}.

We also shouldn't be implementing `to_json` most of the time, and
these occurances are replaced with an equivilent `as_json`
implementation to avoid problems down the road.

See [1] for all the juicy details.

[1]: intridea/multi_json#138 (comment)
 2013-11-05 22:26:45 -08:00
Gaurish Sharma
834eb80b59 Improve Errors when Controller Name or Action isn't specfied 
These errors occur when, there routes are wrongly defined.

example, the following line would cause a missing :action error

    root "welcomeindex"

Mostly beginners are expected to hit these errors, so lets improve the error message a bit to make their learning experience bit better.
 2013-11-05 19:58:07 +05:30
Carlos Antonio da Silva
91d72fe652 ✂️ [ci skip] 2013-11-04 13:01:57 -02:00
David Heinemeier Hansson
50b7d21ed7 Code style for privacy indention 2013-11-03 08:39:48 -08:00
David Heinemeier Hansson
00b9a446de Ensure backwards compability after the #deep_munge extraction 2013-11-03 08:38:41 -08:00
Guillermo Iguaran
e3e7786b0f Improve wording in AC::ParameterMissing error message 2013-11-02 14:41:35 -05:00
Guillermo Iguaran
f886fe2d8c Revert "Merge pull request #9660 from sebasoga/change_strong_parameters_require_behaviour" 
This reverts commit c2b5a8e61ba0f35015e6ac949a5c8fce2042a1f2, reversing
changes made to 1918b12c0429caec2a6134ac5e5b42ade103fe90.

See: https://github.com/rails/rails/pull/9660#issuecomment-27627493
 2013-11-02 14:30:03 -05:00
Guillermo Iguaran
c2b5a8e61b Merge pull request #9660 from sebasoga/change_strong_parameters_require_behaviour 
Change ActionController::Parameters#require behavior when value is empty
 2013-11-01 17:28:05 -07:00
Lin Reid
56d3862541 Fix typo in method description in Responder class 
Fixes a typo in the description for the call class method in Responder.
 2013-11-01 10:58:25 -04:00
Arun Agrawal
816126862e Warnings removed for ruby trunk 
Same as 4d4ff531b8807ee88a3fc46875c7e76f613956fb
 2013-11-01 09:49:57 +01:00
Damien Mathieu
38f8872aa5 session#fetch doesn't behave exactly like Hash#fetch. 
Mention it in the changelog and add a test checking for regressions.

Hash#fetch isn't adding the defaultly returned value.
However, in the session, saving it is the behavior we should expect.

See discussion in #12692
 2013-10-30 15:04:22 +01:00
Damien Mathieu
84c9f4164b add the fetch method to sessions 2013-10-29 20:37:15 +01:00
Robin Dupret
cbb32ec244 Add a changelog entry for #12656 [ci skip] 2013-10-27 16:03:38 +01:00
Doug Cole
7171111d3a don't mutate hash with fetch 2013-10-26 19:22:31 -07:00
Prem Sichanugrist
0f0630aaae Remove surprise if from show_exception middleware 
This increase the readability within the rescue block.
 2013-10-27 00:55:22 +07:00
Rafael Mendonça França
6c570648ad Merge pull request #10471 from andyw8/button_to_params 
Add params option for button_to

Conflicts:
	actionpack/CHANGELOG.md
 2013-10-24 18:02:19 -02:00
Rafael Mendonça França
6ac677fd87 Improve the CHANGELOG entry [ci skip] 2013-10-24 14:43:07 -02:00
Tima Maslyuchenko
1ea072f88c update CHANGELOG 2013-10-24 10:46:57 +03:00
Tima Maslyuchenko
719f1d68e4 pass app config to controller helper proxy 
After this fix application config become available when calling helper outisde of view

config/application.rb

    #...
    config.asset_host = 'http://mycdn.com'
    #...

Somewhere else

    ActionController::Base.helpers.asset_path('fallback.png')
    # => http://mycdn.com/assets/fallback.png
 2013-10-24 08:03:31 +03:00
Josh Symonds
cb81a535e0 Correct error in Utils.normalize_path that changed paths improperly 2013-10-23 16:44:23 -05:00
Thiago Pradi
25b0076eba Removing unused fake models from actionpack tests 2013-10-16 00:51:57 -03:00
Andrew White
9dbd208562 Respect SCRIPT_NAME when using redirect with a relative path 
Example:
    # application routes.rb
    mount BlogEngine => '/blog'

    # engine routes.rb
    get '/admin' => redirect('admin/dashboard')

This now redirects to the path `/blog/admin/dashboard`, whereas before it
would've generated an invalid url because there would be no slash between
the host name and the path. It also allows redirects to work where the
application is deployed to a subdirectory of a website.

Fixes #7977
 2013-10-10 13:03:26 +01:00
Arun Agrawal
a6bb8f4e3a Typo fix [ci skip] 
Fixing the typo which is formed a not required link.  Check
here http://api.rubyonrails.org/classes/ActionController/Base.html
under paramters section
keeping it under tt tag

gets reverted here ec8ef1e1055c4e1598da13f49d30261f07f4a9b4
 2013-10-09 14:27:36 +02:00
Yves Senn
2b21bddc9e add dots after Fixes #YYYYY in actionpack CHANGELOG. [ci skip] 2013-10-09 11:49:12 +02:00
BlueHotDog
8642c2aadc Fixing repond_with working directly on the options hash 
This fixes an issue where the respond_with worked directly with the given
options hash, so that if a user relied on it after calling respond_with,
the hash wouldn't be the same.

Fixes #12029
 2013-10-09 12:36:26 +03:00
Andrew White
28b4ffc379 Add changlog entry for #10844 2013-09-30 12:51:37 +01:00