TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
1,840 Commits 2 Branches 0 Tags 294 MiB
febc24dee7
Commit Graph

454 Commits

Author SHA1 Message Date
David Heinemeier Hansson
febc24dee7 An explicit include ClassInheritableAttributes is no longer needed #1948 [Caleb Tennis] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 16:28:10 +00:00
Nicholas Seckar
bf92aacf40 Avoid extending view instance with helper modules each request. Closes #1979 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 12:08:24 +00:00
Nicholas Seckar
689cca132a Performance improvements to CGI methods. Closes #1980 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 11:28:54 +00:00
Nicholas Seckar
2f66e873b0 Symbolize the keys of overwritten parameters. Really closes #1909. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2147 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-07 08:59:33 +00:00
Nicholas Seckar
3108764367 Fix overwrite params. Closes #1909 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2144 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 22:06:11 +00:00
David Heinemeier Hansson
f86276b305 Fix fragment benchmark calls and limit timings to 5 decimals 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 17:33:11 +00:00
David Heinemeier Hansson
291c667d66 Only do benchmarking if log level matches and log caching 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2141 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 17:07:08 +00:00
David Heinemeier Hansson
5e8e8d6564 Added use_silence parameter to ActiveRecord::Base.benchmark that can be passed false to include all logging statements during the benchmark block. Added ActionController::Base.benchmark and ActionController::Base.silence to allow for easy benchmarking and turning off the log 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2140 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 16:48:18 +00:00
Jamis Buck
bfdb437508 Updated vendor copy of html-scanner to support better xml parsing 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2131 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-05 09:44:22 +00:00
Jamis Buck
89550ee7e9 Use chop! instead of chop! for efficiency 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2109 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-02 18:01:26 +00:00
Jamis Buck
62ec1a5373 Drop trailing \000 if present on RAW_POST_DATA (works around bug in Safari Ajax implementation) #918 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2106 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-02 14:40:33 +00:00
Jamis Buck
6c44d35268 AbstractRequest#domain returns nil when host is an ip address #2012 [kevin.clark@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2098 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-02 09:10:31 +00:00
Jamis Buck
46c4fd4177 ActionController documentation update #2051 [fbeausoleil@ftml.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2095 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-01 21:54:29 +00:00
Nicholas Seckar
87b6800282 Add option to specify the singular name used by pagination. Closes #1960 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2078 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-31 00:13:10 +00:00
Nicholas Seckar
34e795ff0e Use string key to set action_name for controllers. Closes #1968 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2077 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-30 23:52:53 +00:00
David Heinemeier Hansson
b80f0e2ff3 Made Upload Progress work with Prototype 1.4.0 and add some documentation for it #1847, #1876 [Thomas Fuchs/Sean Treadway] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2059 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-27 06:30:33 +00:00
Nicholas Seckar
1cbd1f9698 Fix routing to handle :some_param => nil better 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2054 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-26 10:57:43 +00:00
Jamis Buck
c5ff810572 Add support for :include with pagination (subject to existing constraints for :include with :limit and :offset) #1478 [michael@schubert.cx] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2041 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-23 14:24:15 +00:00
Jamis Buck
211617191e Prevent the benchmark module from blowing up if a non-HTTP/1.1 request is processed 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-23 09:43:36 +00:00
Jamis Buck
c031a01633 Add an :if option to session management, to allow programmatically enabling or disabling the session 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2031 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-17 21:05:31 +00:00
Jamis Buck
50e2474433 Make assert_redirected_to properly check URL's passed as strings #1910 [Scott Barron] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1971 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-06 08:37:25 +00:00
Jamis Buck
a3469cadad Make sure :layout => false is always used when rendering inside a layout 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-05 20:51:03 +00:00
Jamis Buck
44c64a612d Use raise instead of assert_not_nil in Test::Unit::TestCase#process to ensure that the test variables (controller, request, response) have been set 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-01 21:28:17 +00:00
Jamis Buck
08ebab5d20 Make sure assigns are built for every request when testing #1866 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1961 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-31 12:16:21 +00:00
Jamis Buck
020ed6fa1f Allow remote_addr to be queried on TestRequest #1668 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-31 10:31:47 +00:00
David Heinemeier Hansson
0ea1375d75 Really fix the syntax error issue 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1952 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-28 17:41:19 +00:00
David Heinemeier Hansson
9fad3251d3 More fixes, but still broken 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1948 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 14:17:47 +00:00
David Heinemeier Hansson
5b52b716b7 Fixing the fix, but not quite 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1945 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 13:55:39 +00:00
David Heinemeier Hansson
eec7cc004b Fixed dynamic scaffolding [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1940 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 11:44:18 +00:00
David Heinemeier Hansson
d876daf51f Fixed #1774 again 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1936 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 08:02:26 +00:00
David Heinemeier Hansson
4b8d156ca5 Removed unused statement 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-26 18:39:05 +00:00
David Heinemeier Hansson
d440cf6483 Fixed snag in status reporting 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1933 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-26 18:35:38 +00:00
David Heinemeier Hansson
65e4e5e337 Only log status if there is one different from 200 set 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1930 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-26 12:38:50 +00:00
David Heinemeier Hansson
36fee9c02e Fixed broken error handling #1827 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1920 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-25 09:39:57 +00:00
David Heinemeier Hansson
e9cfe955cc Add a catch-all eraser 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1918 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-25 08:49:19 +00:00
David Heinemeier Hansson
4f40b2d8fb Improved performance of test app req/sec with ~10% refactoring the render method #1823 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-24 16:45:39 +00:00
David Heinemeier Hansson
eddd7c453b Fix that env_qs might be nil 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1907 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 09:18:16 +00:00
David Heinemeier Hansson
d554227411 Fix that env_qs might be nil 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1906 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 09:16:35 +00:00
David Heinemeier Hansson
b366dbd952 Improved performance with 5-30% through a series of Action Pack optimizations #1811 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 09:00:05 +00:00
David Heinemeier Hansson
d172592985 Added test for template to layout variable transfer 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 08:43:01 +00:00
David Heinemeier Hansson
0223565a4d Expiring a cache that doesnt exist is bliss not bad 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1895 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 20:08:29 +00:00
David Heinemeier Hansson
3835f6ab25 Changed caching/expiration/hit to report using the DEBUG log level and errors to use the ERROR log level instead of both using INFO 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1889 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 11:28:58 +00:00
Jamis Buck
06843f8794 Added support for per-action session management #1763 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1886 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 10:37:09 +00:00
David Heinemeier Hansson
1aab0e2c30 Doc fixes #1775, #1776 [jon@instance-design.co.uk] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1878 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-22 06:27:07 +00:00
David Heinemeier Hansson
bd558ef98e Improved rendering speed on complicated templates by up to 25% #1234 [Stephan Kaes]. This did necessasitate a change to the internals of ActionView#render_template that now has four parameters. Developers of custom view handlers (like Amrita) need to update for that. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1874 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-21 07:14:35 +00:00
Nicholas Seckar
2e175d35cd Fix last changeset to pass unittests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1858 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-18 03:25:53 +00:00
Nicholas Seckar
741316dc71 Fixed construction of get parameters for arrays 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1857 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-18 03:12:45 +00:00
David Heinemeier Hansson
e51221871c Fix doc typos #1734 [moriq@moriq.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1853 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-17 10:03:47 +00:00
David Heinemeier Hansson
e69924ecdc Log if filters return false and halt execution #1735 [Michael Koziarski] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1848 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-17 09:25:24 +00:00
David Heinemeier Hansson
d2d38f6700 Added Base#expires_in(seconds)/Base#expires_now to control HTTP content cache headers #1755 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1845 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-17 09:20:20 +00:00