TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
2bbcca004c
rails/guides/source
History
@schneems and @sgrif 2bbcca004c Deprecate *_path methods in mailers 
Email does not support relative links since there is no implicit host. Therefore all links inside of emails must be fully qualified URLs. All path helpers are now deprecated. When removed, the error will give early indication to developers to use `*_url` methods instead.

Currently if a developer uses a `*_path` helper, their tests and `mail_view` will not catch the mistake. The only way to see the error is by sending emails in production. Preventing sending out emails with non-working path's is the desired end goal of this PR.

Currently path helpers are mixed-in to controllers (the ActionMailer::Base acts as a controller). All `*_url` and `*_path` helpers are made available through the same module. This PR separates this behavior into two modules so we can extend the `*_path` methods to add a Deprecation to them. Once deprecated we can use this same area to raise a NoMethodError and add an informative message directing the developer to use `*_url` instead.

The module with warnings is only mixed in when a controller returns false from the newly added `supports_relative_path?`.

Paired @sgrif & @schneems
2014-07-30 12:01:45 -05:00
..
kindle delete obsolete KINDLE.md. Closes #13037. [ci skip]. 2013-11-28 17:49:29 +01:00
_license.html.erb [ci skip] Update guides license to CC BY-SA 4.0 International. 2014-05-02 18:49:37 +08:00
_welcome.html.erb Update Rails versions [ci skip] 2014-07-07 14:22:25 +02:00
2_2_release_notes.md Typo and grammatical fixes [ci skip] 2013-12-02 19:35:02 +05:30
2_3_release_notes.md remove rubyforge.org that was shut down [ci skip] 2014-06-06 22:26:56 +05:30
3_0_release_notes.md copy edits [ci skip] 2014-06-07 10:53:25 +00:00
3_1_release_notes.md [ci skip] Fix capitalization 2014-06-07 14:23:27 +05:30
3_2_release_notes.md [ci skip] Fix Compiler's Github link 2014-05-27 15:32:38 +05:30
4_0_release_notes.md minor doc reword. Upgrade Rails itself not to Rails. [ci skip] 2013-12-17 11:21:11 +01:00
4_1_release_notes.md link directory to ActionMailer Previews documentation 2014-07-03 18:25:55 -04:00
4_2_release_notes.md Format pass on 4.2 release notes [ci skip] 2014-07-13 17:23:32 -07:00
action_controller_overview.md Add warning for rescue_from Exception and rescue_from StandardError 2014-06-19 18:31:11 -07:00
action_mailer_basics.md Deprecate *_path methods in mailers 2014-07-30 12:01:45 -05:00
action_view_overview.md Rename Posts to Articles in Guides, continuation of 2d446e77 / #13774 [ci skip] 2014-05-21 23:01:45 -04:00
active_model_basics.md Deprecate reset_#{attribute} in favor of restore_#{attribute}. 2014-07-15 18:09:38 -03:00
active_record_basics.md create return an active record object with erros instead of false when validation fails. [skip ci] 2014-07-23 16:31:55 +08:00
active_record_callbacks.md correct markdown usage [ci skip] 2014-07-09 01:32:44 +05:30
active_record_migrations.md Tiny follow-up to 1a69112 2014-06-27 15:09:10 +02:00
active_record_postgresql.md pg guide, use the term database views to be specific. [ci skip] 2014-06-14 11:20:58 +02:00
active_record_querying.md fix mismatched example call [ci skip] 2014-07-12 10:21:00 +00:00
active_record_validations.md [Guides] Sentence break for clarity [ci-skip] 2014-07-11 09:07:34 -04:00
active_support_core_extensions.md Merge pull request #16097 from nishantmodak/correct_md 2014-07-08 14:57:44 -07:00
active_support_instrumentation.md Fix typo guides/source/active_support_instrumentation.md 2014-05-22 00:00:55 +04:00
api_documentation_guidelines.md correct markdown usage [ci skip] 2014-07-09 01:32:44 +05:30
asset_pipeline.md Calling require_self twice in css raises Sprockets::ArgumentError exception [ci skip] 2014-07-24 11:39:41 +05:30
association_basics.md adding indexes on tables in migration scripts 2014-07-24 19:18:00 -02:30
caching_with_rails.md correct markdown usage [ci skip] 2014-07-09 01:32:44 +05:30
command_line.md Remove "profile and benchmark" line from command line guide 2014-07-17 09:07:08 -04:00
configuring.md Rename preview_enabled option to show_previews 2014-07-01 13:09:24 -03:00
contributing_to_ruby_on_rails.md docs, add example for running a single test against core adapters. 2014-07-22 08:41:25 +02:00
credits.html.erb Change links to 37signals and svn blog to point to new destinations. [ci skip] 2014-04-12 12:46:04 +05:30
debugging_rails_applications.md Update Rails versions [ci skip] 2014-07-07 14:22:25 +02:00
development_dependencies_install.md Reorganize ActiveRecord tasks [Arun Agrawal & Abd ar-Rahman Hamidi] 2014-05-16 23:09:05 +02:00
documents.yaml [ci skip] Rename: Rails Database Migration to Active Record Migration. 2014-06-10 15:41:15 +08:00
engines.md [ci skip] Changes some wording to better foreshadow what is coming up later. 2014-07-02 09:54:42 -07:00
form_helpers.md Fix indentation from 1b4b26f [ci skip] 2014-05-28 15:56:38 -07:00
generators.md Generator guide grammatical error fixed [ci skip] 2014-07-21 17:39:20 +05:30
getting_started.md Fixes #16255 [ci skip] 2014-07-22 19:19:32 +05:30
i18n.md Merge pull request #16097 from nishantmodak/correct_md 2014-07-08 14:57:44 -07:00
index.html.erb Guides: output valid HTML5 2014-05-05 17:42:04 -04:00
initialization.md Tiny documentation fixes [ci skip] 2014-06-29 20:15:28 +02:00
layout.html.erb remove ecosystem link that is broken 2014-05-18 19:17:09 +05:30
layouts_and_rendering.md Small typo 2014-06-23 23:15:58 +06:00
maintenance_policy.md Change the version schema to reflect how deprecations are handled 2014-05-30 11:44:55 -03:00
nested_model_forms.md [ci skip] Improve doc, fix grammatical issue 2014-04-13 21:20:31 +05:30
plugins.md Use generated binstubs in guides examples. 2014-05-20 13:29:18 +02:00
rails_application_templates.md Use generated binstubs in guides examples. 2014-05-20 13:29:18 +02:00
rails_on_rack.md remove rubyforge.org that was shut down [ci skip] 2014-06-06 22:26:56 +05:30
routing.md 💅 from #16329 [ci skip] 2014-07-29 10:28:56 -07:00
ruby_on_rails_guides_guidelines.md [ci skip] Update GFM link in guides guidelines. 2014-05-25 23:36:02 +08:00
security.md correct markdown usage [ci skip] 2014-07-09 01:32:44 +05:30
testing.md link minitest assertions documentation. 2014-07-16 12:34:03 +02:00
upgrading_ruby_on_rails.md Document the change in nil handling for serialized attributes 2014-07-15 09:08:31 -07:00
working_with_javascript_in_rails.md Rename Posts to Articles in Guides, continuation of 2d446e77 / #13774 [ci skip] 2014-05-21 23:01:45 -04:00