rails/actionpack/test/journey/route/definition/scanner_test.rb
Nicolas Cavigneaux 3041bb2a94 Improve Journey compliance to RFC 3986
The scanner in Journey fails to recognize routes that use literals
from the sub-delims section of RFC 3986.

This commit enhance the compatibility of Journey with the RFC by
adding support of authorized delimiters to the scanner.

Fix #17212
2014-10-14 16:42:50 +02:00

70 lines
2.5 KiB
Ruby

require 'abstract_unit'
module ActionDispatch
module Journey
module Definition
class TestScanner < ActiveSupport::TestCase
def setup
@scanner = Scanner.new
end
# /page/:id(/:action)(.:format)
def test_tokens
[
['/', [[:SLASH, '/']]],
['*omg', [[:STAR, '*omg']]],
['/page', [[:SLASH, '/'], [:LITERAL, 'page']]],
['/page!', [[:SLASH, '/'], [:LITERAL, 'page!']]],
['/page$', [[:SLASH, '/'], [:LITERAL, 'page$']]],
['/page&', [[:SLASH, '/'], [:LITERAL, 'page&']]],
["/page'", [[:SLASH, '/'], [:LITERAL, "page'"]]],
['/page*', [[:SLASH, '/'], [:LITERAL, 'page*']]],
['/page+', [[:SLASH, '/'], [:LITERAL, 'page+']]],
['/page,', [[:SLASH, '/'], [:LITERAL, 'page,']]],
['/page;', [[:SLASH, '/'], [:LITERAL, 'page;']]],
['/page=', [[:SLASH, '/'], [:LITERAL, 'page=']]],
['/page@', [[:SLASH, '/'], [:LITERAL, 'page@']]],
['/page\:', [[:SLASH, '/'], [:LITERAL, 'page:']]],
['/page\(', [[:SLASH, '/'], [:LITERAL, 'page(']]],
['/page\)', [[:SLASH, '/'], [:LITERAL, 'page)']]],
['/~page', [[:SLASH, '/'], [:LITERAL, '~page']]],
['/pa-ge', [[:SLASH, '/'], [:LITERAL, 'pa-ge']]],
['/:page', [[:SLASH, '/'], [:SYMBOL, ':page']]],
['/(:page)', [
[:SLASH, '/'],
[:LPAREN, '('],
[:SYMBOL, ':page'],
[:RPAREN, ')'],
]],
['(/:action)', [
[:LPAREN, '('],
[:SLASH, '/'],
[:SYMBOL, ':action'],
[:RPAREN, ')'],
]],
['(())', [[:LPAREN, '('],
[:LPAREN, '('], [:RPAREN, ')'], [:RPAREN, ')']]],
['(.:format)', [
[:LPAREN, '('],
[:DOT, '.'],
[:SYMBOL, ':format'],
[:RPAREN, ')'],
]],
].each do |str, expected|
@scanner.scan_setup str
assert_tokens expected, @scanner
end
end
def assert_tokens tokens, scanner
toks = []
while tok = scanner.next_token
toks << tok
end
assert_equal tokens, toks
end
end
end
end
end