TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
447b6a4e67
rails/activesupport/test
History
Xavier Noria 447b6a4e67 removes usage of Object#in? from the code base (the method remains defined by Active Support) 
Selecting which key extensions to include in active_support/rails
made apparent the systematic usage of Object#in? in the code base.
After some discussion in

    5ea6b0df9a

we decided to remove it and use plain Ruby, which seems enough
for this particular idiom.

In this commit the refactor has been made case by case. Sometimes
include? is the natural alternative, others a simple || is the
way you actually spell the condition in your head, others a case
statement seems more appropriate. I have chosen the one I liked
the most in each case.
2012-08-06 00:30:02 +02:00
..
autoloading_fixtures Deletes trailing whitespaces (over text files only find * -type f -exec sed 's/[ \t]*$//' -i {} \;) 2010-08-14 04:12:33 -03:00
core_ext html_escape should escape single quotes 2012-07-31 22:26:52 -03:00
dependencies Checkin failing test case related to load once paths 2006-12-24 14:41:29 +00:00
deprecation use AS::TestCase as the base class 2012-01-05 17:12:46 -08:00
fixtures deOMGifying Railties, Active Support, and Action Pack 2010-01-31 09:46:30 -08:00
json Remove deprecated ActiveSupport::JSON::Variable. 2012-05-30 14:39:00 -05:00
notifications oops, forgot to commit the tests! 💣 2012-03-23 11:47:42 -07:00
testing Eliminate dependency on Rails::VERSION::STRING 2012-06-05 20:43:41 +01:00
xml_mini use AS::TestCase as the base class 2012-01-05 17:12:46 -08:00
abstract_unit.rb remove duplicate requires of mocha. 2012-07-03 14:28:29 -07:00
autoload.rb Reorganize autoloads: 2009-12-02 20:01:08 -08:00
benchmarkable_test.rb * BufferedLogger is deprecated. Use ActiveSupport::Logger, or the logger 2011-12-19 18:41:37 -08:00
broadcast_logger_test.rb pushed broadcasting down to a module 2012-01-20 14:18:29 -08:00
caching_test.rb Merge pull request #5125 from winston/log_exception_when_cache_read_fails 2012-05-21 19:02:48 -07:00
callback_inheritance_test.rb AS::Callbacks#run_callbacks remove key argument 2012-05-10 02:21:03 -05:00
callbacks_test.rb AS::Callbacks#run_callbacks remove key argument 2012-05-10 02:21:03 -05:00
class_cache_test.rb Rely solely on active_model_serializer and remove the fancy constant lookup. 2011-11-23 23:45:27 +00:00
clean_backtrace_test.rb Remove extra test case. 2012-06-19 11:56:16 -06:00
clean_logger_test.rb use AS::TestCase as the base class 2012-01-05 17:12:46 -08:00
concern_test.rb use AS::TestCase as the base class 2012-01-05 17:12:46 -08:00
configurable_test.rb add instance_accessor option to ActiveSupport::Configurable#config_accessor 2012-06-05 10:50:48 -05:00
constantize_test_cases.rb Handle case where ancestor is not the end of the chain 2012-05-19 15:47:35 +01:00
dependencies_test.rb raise the same exception in order to keep path info 2012-06-12 16:19:51 -07:00
deprecation_test.rb Add test for default silence and stderr deprecation behaviors 2012-04-28 18:25:35 -03:00
descendants_tracker_test_cases.rb Refactored AS::DescendantsTracker test cases so they can be tested without AS::Dependencies. 2011-03-13 17:04:01 +01:00
descendants_tracker_with_autoloading_test.rb removing unnecessary requires 2012-01-06 14:43:04 -08:00
descendants_tracker_without_autoloading_test.rb removing unnecessary requires 2012-01-06 14:43:04 -08:00
empty_bool.rb avoid method redefined; discarding old empty? warning [#4302 state:committed] 2010-03-30 16:59:48 -07:00
file_update_checker_test.rb Fix failing test in file update checker 2012-06-29 15:08:08 -03:00
gzip_test.rb use AS::TestCase as the base class 2012-01-05 17:12:46 -08:00
i18n_test.rb Ensure Array#to_sentence does not modify given hash 2012-06-26 22:05:56 -03:00
inflector_test_cases.rb Adds missing inflector tests to ensure idempotency 2012-06-21 02:16:48 -07:00
inflector_test.rb Make ActiveSupport::Inflector locale aware and multilingual 2012-07-30 21:49:18 -07:00
lazy_load_hooks_test.rb Ensure load hooks can be called more than once with different contexts. 2012-03-06 22:05:07 +01:00
load_paths_test.rb use AS::TestCase as the base class 2012-01-05 17:12:46 -08:00
log_subscriber_test.rb Ensure blocks given to subscriber are properly yield 2012-05-17 08:52:40 +02:00
logger_test.rb no more deprecation required. 2012-03-31 23:00:13 +05:30
message_encryptor_test.rb remove ActiveSupport::Base64 in favor of ::Base64 2012-01-02 22:48:15 +03:00
message_verifier_test.rb Remove deprecations from Active Support. 2011-12-20 15:18:42 +01:00
multibyte_chars_test.rb Fix class_eval without __FILE__ and __LINE__. 2012-07-18 01:16:55 +09:00
multibyte_conformance.rb use AS::TestCase as the base class 2012-01-05 17:12:46 -08:00
multibyte_test_helpers.rb remove checks for encodings availability 2011-12-25 14:34:58 +03:00
multibyte_unicode_database_test.rb use AS::TestCase as the base class 2012-01-05 17:12:46 -08:00
notifications_test.rb make events not use date and time to determine parent_of. fixes #5932 2012-06-18 16:34:23 -07:00
number_helper_i18n_test.rb Get rid of the clear_i18n hack by using a different locale 2012-06-24 19:30:06 -03:00
number_helper_test.rb Fix handling of negative zero in number_to_currency 2012-05-28 04:42:53 -04:00
option_merger_test.rb use AS::TestCase as the base class 2012-01-05 17:12:46 -08:00
ordered_hash_test.rb Don't test language-level exception messages 2012-07-27 12:51:12 -07:00
ordered_options_test.rb Use respond_to_missing? for OrderedOptions 2012-05-05 02:43:41 -04:00
rescuable_test.rb use AS::TestCase as the base class 2012-01-05 17:12:46 -08:00
safe_buffer_test.rb Ensure [] respects the status of the buffer. 2012-02-29 16:09:02 -08:00
string_inquirer_test.rb use AS::TestCase as the base class 2012-01-05 17:12:46 -08:00
tagged_logging_test.rb Revert "Merge pull request #7084 from LTe/logger_default_separator" 2012-07-18 13:32:21 -07:00
test_case_test.rb Exceptions like Interrupt should not be rescued. 2012-05-28 22:44:28 +01:00
test_test.rb Proc always respond_to :binding 2012-06-12 01:43:28 +09:00
time_zone_test.rb [#5559] Do not black out the system timezone DST jump hour if Time.zone differs from that. 2012-03-24 20:15:00 +02:00
transliterate_test.rb removes usage of Object#in? from the code base (the method remains defined by Active Support) 2012-08-06 00:30:02 +02:00
ts_isolated.rb Don't use assert_block method. It will be deprecated. 2012-05-20 00:14:40 +09:00
xml_mini_test.rb use AS::TestCase as the base class 2012-01-05 17:12:46 -08:00