rails/activesupport/test/current_attributes_test.rb
Jonathan Hefner aa98bc3c71 Prevent CurrentAttributes defaults from leaking
Follow-up to #50677.

Prior to this commit, all `ActiveSupport::CurrentAttributes` subclasses
stored their default values in the same `Hash`, causing default values
to leak between classes.  This commit ensures each subclass maintains a
separate `Hash`.

This commit also simplifies the resolution of default values, replacing
the `merge_defaults!` method with `resolve_defaults`.
2024-01-11 12:40:14 -06:00

258 lines
7.1 KiB
Ruby

# frozen_string_literal: true
require_relative "abstract_unit"
require "active_support/current_attributes/test_helper"
class CurrentAttributesTest < ActiveSupport::TestCase
# CurrentAttributes is automatically reset in Rails app via executor hooks set in railtie
# But not in Active Support's own test suite.
include ActiveSupport::CurrentAttributes::TestHelper
Person = Struct.new(:id, :name, :time_zone)
class Current < ActiveSupport::CurrentAttributes
attribute :counter_integer, default: 0
attribute :counter_callable, default: -> { 0 }
attribute :world, :account, :person, :request
delegate :time_zone, to: :person
before_reset { Session.previous = person&.id }
resets do
Session.current = nil
end
resets :clear_time_zone
def account=(account)
super
self.person = Person.new(1, "#{account}'s person")
end
def person=(person)
super
Time.zone = person&.time_zone
Session.current = person&.id
end
def set_world_and_account(world:, account:)
self.world = world
self.account = account
end
def get_world_and_account(hash)
hash[:world] = world
hash[:account] = account
hash
end
def respond_to_test; end
def request
"#{super} something"
end
def intro
"#{person.name}, in #{time_zone}"
end
private
def clear_time_zone
Time.zone = "UTC"
end
end
class Session < ActiveSupport::CurrentAttributes
attribute :current, :previous
end
# Eagerly set-up `instance`s by reference.
[ Current.instance, Session.instance ]
# Use library specific minitest hook to catch Time.zone before reset is called via TestHelper
def before_setup
@original_time_zone = Time.zone
super
end
# Use library specific minitest hook to set Time.zone after reset is called via TestHelper
def after_teardown
super
Time.zone = @original_time_zone
end
setup { assert_nil Session.previous, "Expected Session to not have leaked state" }
test "read and write attribute" do
Current.world = "world/1"
assert_equal "world/1", Current.world
end
test "read and write attribute with default value" do
assert_equal 0, Current.counter_integer
Current.counter_integer += 1
assert_equal 1, Current.counter_integer
Current.reset
assert_equal 0, Current.counter_integer
end
test "read attribute with default callable" do
assert_equal 0, Current.counter_callable
Current.counter_callable += 1
assert_equal 1, Current.counter_callable
Current.reset
assert_equal 0, Current.counter_callable
end
test "read overwritten attribute method" do
Current.request = "request/1"
assert_equal "request/1 something", Current.request
end
test "set attribute via overwritten method" do
Current.account = "account/1"
assert_equal "account/1", Current.account
assert_equal "account/1's person", Current.person.name
end
test "set auxiliary class via overwritten method" do
Current.person = Person.new(42, "David", "Central Time (US & Canada)")
assert_equal "Central Time (US & Canada)", Time.zone.name
assert_equal 42, Session.current
end
test "resets auxiliary classes via callback" do
Current.person = Person.new(42, "David", "Central Time (US & Canada)")
assert_equal "Central Time (US & Canada)", Time.zone.name
Current.reset
assert_equal "UTC", Time.zone.name
assert_equal 42, Session.previous
assert_nil Session.current
end
test "set auxiliary class based on current attributes via before callback" do
Current.person = Person.new(42, "David", "Central Time (US & Canada)")
assert_nil Session.previous
assert_equal 42, Session.current
Current.reset
assert_equal 42, Session.previous
assert_nil Session.current
end
test "set attribute only via scope" do
Current.world = "world/1"
Current.set(world: "world/2") do
assert_equal "world/2", Current.world
end
assert_equal "world/1", Current.world
end
test "set multiple attributes" do
Current.world = "world/1"
Current.account = "account/1"
Current.set(world: "world/2", account: "account/2") do
assert_equal "world/2", Current.world
assert_equal "account/2", Current.account
end
assert_equal "world/1", Current.world
assert_equal "account/1", Current.account
hash = { world: "world/2", account: "account/2" }
Current.set(hash) do
assert_equal "world/2", Current.world
assert_equal "account/2", Current.account
end
end
test "using keyword arguments" do
Current.set_world_and_account(world: "world/1", account: "account/1")
assert_equal "world/1", Current.world
assert_equal "account/1", Current.account
hash = {}
assert_same hash, Current.get_world_and_account(hash)
assert_equal "world/1", hash[:world]
assert_equal "account/1", hash[:account]
end
setup { @testing_teardown = false }
teardown { assert_equal 42, Session.current if @testing_teardown }
test "accessing attributes in teardown" do
Session.current = 42
@testing_teardown = true
end
test "delegation" do
Current.person = Person.new(42, "David", "Central Time (US & Canada)")
assert_equal "Central Time (US & Canada)", Current.time_zone
assert_equal "Central Time (US & Canada)", Current.instance.time_zone
end
test "all methods forward to the instance" do
Current.person = Person.new(42, "David", "Central Time (US & Canada)")
assert_equal "David, in Central Time (US & Canada)", Current.intro
assert_equal "David, in Central Time (US & Canada)", Current.instance.intro
end
test "respond_to? for methods that have not been called" do
assert_equal true, Current.respond_to?("respond_to_test")
end
test "CurrentAttributes defaults do not leak between classes" do
Class.new(ActiveSupport::CurrentAttributes) { attribute :counter_integer, default: 100 }
Current.reset
assert_equal 0, Current.counter_integer
end
test "CurrentAttributes use fiber-local variables" do
previous_level = ActiveSupport::IsolatedExecutionState.isolation_level
ActiveSupport::IsolatedExecutionState.isolation_level = :fiber
Session.current = 42
enumerator = Enumerator.new do |yielder|
yielder.yield Session.current
end
assert_nil enumerator.next
ensure
ActiveSupport::IsolatedExecutionState.isolation_level = previous_level
end
test "CurrentAttributes can use thread-local variables" do
previous_level = ActiveSupport::IsolatedExecutionState.isolation_level
ActiveSupport::IsolatedExecutionState.isolation_level = :thread
Session.current = 42
enumerator = Enumerator.new do |yielder|
yielder.yield Session.current
end
assert_equal 42, enumerator.next
ensure
ActiveSupport::IsolatedExecutionState.isolation_level = previous_level
end
test "CurrentAttributes restricted attribute names" do
assert_raises ArgumentError, match: /Restricted attribute names: reset, set/ do
class InvalidAttributeNames < ActiveSupport::CurrentAttributes
attribute :reset, :foo, :set
end
end
end
end