831e2c8d1b
Fixes #23757. Before this commit, even if `reject` was called in the `subscribe` method for an Action Cable channel, all actions on that channel could still be invoked. This calls a `return` if a rejected connection tries to invoke any actions on the channel.
40 lines
1.3 KiB
Ruby
40 lines
1.3 KiB
Ruby
require "test_helper"
|
|
require "stubs/test_connection"
|
|
require "stubs/room"
|
|
|
|
class ActionCable::Channel::RejectionTest < ActiveSupport::TestCase
|
|
class SecretChannel < ActionCable::Channel::Base
|
|
def subscribed
|
|
reject if params[:id] > 0
|
|
end
|
|
|
|
def secret_action
|
|
end
|
|
end
|
|
|
|
setup do
|
|
@user = User.new "lifo"
|
|
@connection = TestConnection.new(@user)
|
|
end
|
|
|
|
test "subscription rejection" do
|
|
@connection.expects(:subscriptions).returns mock().tap { |m| m.expects(:remove_subscription).with instance_of(SecretChannel) }
|
|
@channel = SecretChannel.new @connection, "{id: 1}", id: 1
|
|
|
|
expected = { "identifier" => "{id: 1}", "type" => "reject_subscription" }
|
|
assert_equal expected, @connection.last_transmission
|
|
end
|
|
|
|
test "does not execute action if subscription is rejected" do
|
|
@connection.expects(:subscriptions).returns mock().tap { |m| m.expects(:remove_subscription).with instance_of(SecretChannel) }
|
|
@channel = SecretChannel.new @connection, "{id: 1}", id: 1
|
|
|
|
expected = { "identifier" => "{id: 1}", "type" => "reject_subscription" }
|
|
assert_equal expected, @connection.last_transmission
|
|
assert_equal 1, @connection.transmissions.size
|
|
|
|
@channel.perform_action("action" => :secret_action)
|
|
assert_equal 1, @connection.transmissions.size
|
|
end
|
|
end
|