TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
9d0cf52096
rails/activesupport/test
History
bogdanvlviv 9d0cf52096
assert_called_with should require args argument 
There are two main reasons why `assert_called_with` should require
`args` argument:

1) If we want to assert that some method should be called and we don't
   need to check with which arguments it should be called then we should use
   `assert_called`.

2) `assert_called_with` without `args` argument doesn't assert anything!
   ```ruby
   assert_called_with(@object, :increment) do
      @object.decrement
   end
   ```
   It causes false assertions in tests that could cause regressions in the project.

I found this bug by working on
[minitest-mock_expectations](https://github.com/bogdanvlviv/minitest-mock_expectations) gem.
This gem is an extension for minitest that provides almost the same method call
assertions.
I was wondering whether you would consider adding "minitest-mock_expectations"
to `rails/rails` instead of private `ActiveSupport::Testing::MethodCallAssertions` module.
If yes, I'll send a patch - a970ecc42c
2018-10-25 21:29:39 +03:00
..
autoloading_fixtures [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
cache assert_called_with should require args argument 2018-10-25 21:29:39 +03:00
concurrency Prevent deadlocks with load interlock and DB lock. 2017-11-09 10:46:01 -05:00
core_ext Fix issue where duration where always rounded up to a second: 2018-10-12 13:27:13 -04:00
dependencies [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
deprecation A regression in deprecate_methods was introduced in a982a42: 2018-07-30 18:12:56 -04:00
file_fixtures introduce ActiveSupport::Testing::FileFixtures. 2015-01-28 12:29:34 +01:00
fixtures [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
json Test that nested structs to_json works as expected 2018-10-11 15:28:52 -04:00
messages Fix RotationConfiguration test and remove nil-kind rotates. 2017-09-24 22:58:17 +02:00
metadata Remove redundant travel_back 2018-08-31 16:19:58 +09:00
notifications Use assert_empty and assert_not_empty 2018-01-25 23:32:59 -05:00
testing assert_called_with should require args argument 2018-10-25 21:29:39 +03:00
xml_mini Add Style/RedundantFreeze to remove redudant .freeze 2018-09-29 07:18:44 +00:00
abstract_unit.rb Remove private def 2018-09-23 21:27:44 +05:30
array_inquirer_test.rb Use assert_predicate and assert_not_predicate 2018-01-25 23:32:59 -05:00
autoload_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
benchmarkable_test.rb Change the empty block style to have space inside of the block 2018-09-25 13:19:35 -04:00
broadcast_logger_test.rb Merge pull request #34055 from Edouard-chin/ec-logger-fix 2018-10-03 16:45:53 -04:00
callback_inheritance_test.rb Define callbacks on descendants. 2018-02-06 16:05:39 -05:00
callbacks_test.rb Change the empty block style to have space inside of the block 2018-09-25 13:19:35 -04:00
class_cache_test.rb Replace assert ! with assert_not 2018-04-19 08:11:33 -04:00
clean_backtrace_test.rb Use backtrace cleaner to clean up backtrace for verbose query logs 2018-08-14 09:15:28 +10:00
clean_logger_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
concern_test.rb Use respond_to test helpers 2018-01-25 23:32:58 -05:00
configurable_test.rb Use respond_to test helpers 2018-01-25 23:32:58 -05:00
constantize_test_cases.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
current_attributes_test.rb Merge remote-tracking branch 'origin/master' into unlock-minitest 2017-08-01 17:34:14 -04:00
dependencies_test_helpers.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
dependencies_test.rb Change the empty block style to have space inside of the block 2018-09-25 13:19:35 -04:00
deprecation_test.rb Raise a better exception when a invalid depreation behavior is set 2018-05-18 13:35:09 -04:00
descendants_tracker_test_cases.rb Use assert_empty and assert_not_empty 2018-01-25 23:32:59 -05:00
descendants_tracker_with_autoloading_test.rb Use assert_empty and assert_not_empty 2018-01-25 23:32:59 -05:00
descendants_tracker_without_autoloading_test.rb Replace assert ! with assert_not 2018-04-19 08:11:33 -04:00
digest_test.rb Don't include ellipsis in truncated digest output 2017-12-17 00:49:02 +00:00
encrypted_configuration_test.rb Bugfix: ActiveSupport::EncryptedConfiguration reading of comment-only encrypted files (#34014) 2018-10-05 08:06:33 +09:00
encrypted_file_test.rb Raise an error only when require_master_key is specified 2017-12-18 08:04:15 +09:00
evented_file_update_checker_test.rb Change the empty block style to have space inside of the block 2018-09-25 13:19:35 -04:00
executor_test.rb Change the empty block style to have space inside of the block 2018-09-25 13:19:35 -04:00
file_update_checker_shared_tests.rb Allow rubocop check more files 2018-04-19 23:25:39 +03:00
file_update_checker_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
gzip_test.rb Fix CustomCops/AssertNot to allow it to have failure message 2018-05-13 11:32:47 +09:00
hash_with_indifferent_access_test.rb Fix HashWithIndifferentAccess#without bug 2018-09-28 18:28:56 +10:00
i18n_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
inflector_test_cases.rb Fixed typo in test for activesupport parameterize 2017-11-01 10:27:29 +00:00
inflector_test.rb Use assert_empty and assert_not_empty 2018-01-25 23:32:59 -05:00
key_generator_test.rb Remove unused requires 2018-08-17 12:51:14 +09:00
lazy_load_hooks_test.rb Use class_eval or instance_eval when triggering lazy load hooks: 2018-07-03 23:29:43 -04:00
log_subscriber_test.rb cpu_time and allocations are 0 when JRuby is used 2018-07-30 15:10:30 +00:00
logger_test.rb Enable Performance/UnfreezeString cop 2018-09-23 08:56:55 +09:00
message_encryptor_test.rb Fix minor CodeClimate issue 2017-09-25 14:00:07 +02:00
message_verifier_test.rb Replace assert ! with assert_not 2018-04-19 08:11:33 -04:00
multibyte_chars_test.rb Use String#truncate_bytes inside Multibyte::Chars#limit 2018-10-20 12:00:37 -07:00
multibyte_conformance_test.rb Deprecate Unicode#normalize and Chars#normalize (#34202) 2018-10-12 08:40:29 -07:00
multibyte_grapheme_break_conformance_test.rb Deprecate Unicode's #pack_graphemes and #unpack_graphemes methods 2018-10-18 14:10:30 -07:00
multibyte_normalization_conformance_test.rb Deprecate Unicode#normalize and Chars#normalize (#34202) 2018-10-12 08:40:29 -07:00
multibyte_proxy_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
multibyte_test_helpers.rb Add Style/RedundantFreeze to remove redudant .freeze 2018-09-29 07:18:44 +00:00
notifications_test.rb Change the empty block style to have space inside of the block 2018-09-25 13:19:35 -04:00
number_helper_i18n_test.rb Enable Layout/LeadingCommentSpace to not allow cosmetic changes in the future 2017-12-14 17:30:54 +09:00
number_helper_test.rb Enable Layout/LeadingCommentSpace to not allow cosmetic changes in the future 2017-12-14 17:30:54 +09:00
option_merger_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
ordered_hash_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
ordered_options_test.rb Replace assert ! with assert_not 2018-04-19 08:11:33 -04:00
parameter_filter_test.rb Deprecate ActionDispatch::Http::ParameterFilter in favor of ActiveSupport::ParameterFilter 2018-10-08 08:05:40 +09:00
reloader_test.rb Change the empty block style to have space inside of the block 2018-09-25 13:19:35 -04:00
rescuable_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
safe_buffer_test.rb Handle more unsafe String methods (#33990) 2018-09-27 20:50:21 -04:00
security_utils_test.rb Replace assert ! with assert_not 2018-04-19 08:11:33 -04:00
share_lock_test.rb Change the empty block style to have space inside of the block 2018-09-25 13:19:35 -04:00
silence_logger_test.rb Don't use deprecated LoggerSilence 2018-10-04 08:23:49 +09:00
string_inquirer_test.rb Use assert_predicate and assert_not_predicate 2018-01-25 23:32:59 -05:00
subscriber_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
tagged_logging_test.rb Merge pull request #27792 from tjoyal/sandbox-tagged-logging 2018-09-11 19:33:59 -04:00
test_case_test.rb added tests for assert_no_difference with multiple expressions 2018-07-08 15:15:16 +02:00
time_travel_test.rb Add #unfreeze_time to ActiveSupport::Testing::TimeHelpers 2018-09-10 22:32:41 +01:00
time_zone_test_helpers.rb Fix exception in AS::Timezone.all when any tzinfo data is missing 2018-04-18 21:45:13 +02:00
time_zone_test.rb Allow Time.zone.at to receive a second argument 2018-05-30 13:47:39 +01:00
transliterate_test.rb [Active Support] rubocop -a --only Layout/EmptyLineAfterMagicComment 2017-07-11 13:12:32 +09:00
xml_mini_test.rb Suppress warning: BigDecimal.new is deprecated 2017-12-15 01:19:57 +00:00