d917896f45
We recently let a few very easy to avoid warnings get merged. The root cause is that locally the test suite doesn't run in verbose mode unless you explictly pass `-w`. On CI warnings are enabled, but there is no reason to look at the build output unless something is failing. And even if one wanted to do that, that would be particularly work intensive since warnings may be specific to a Ruby version etc. Because of this I believe we should: - Always run the test suite with warnings enabled. - Raise an error if a warning is unexpected. We've been using this pattern for a long time at Shopify both in private and public repositories.
42 lines
1.1 KiB
Ruby
42 lines
1.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "active_support/testing/strict_warnings"
|
|
require "action_cable"
|
|
require "active_support/testing/autorun"
|
|
require "active_support/testing/method_call_assertions"
|
|
|
|
require "puma"
|
|
require "rack/mock"
|
|
|
|
# Require all the stubs and models
|
|
Dir[File.expand_path("stubs/*.rb", __dir__)].each { |file| require file }
|
|
|
|
# Set test adapter and logger
|
|
ActionCable.server.config.cable = { "adapter" => "test" }
|
|
ActionCable.server.config.logger = Logger.new(nil)
|
|
|
|
class ActionCable::TestCase < ActiveSupport::TestCase
|
|
include ActiveSupport::Testing::MethodCallAssertions
|
|
|
|
def wait_for_async
|
|
wait_for_executor Concurrent.global_io_executor
|
|
end
|
|
|
|
def run_in_eventmachine
|
|
yield
|
|
wait_for_async
|
|
end
|
|
|
|
def wait_for_executor(executor)
|
|
# do not wait forever, wait 2s
|
|
timeout = 2
|
|
until executor.completed_task_count == executor.scheduled_task_count
|
|
sleep 0.1
|
|
timeout -= 0.1
|
|
raise "Executor could not complete all tasks in 2 seconds" unless timeout > 0
|
|
end
|
|
end
|
|
end
|
|
|
|
require_relative "../../tools/test_common"
|