4dcb630c6e
Currently, namespaced scaffold generator will generate an incorrect path
and the generated file will not work properly.
```
$ ./bin/rails g scaffold admin/user
$ ./bin/rails db:migrate
$ ./bin/rails t test/controllers
# Running:
E
Error:
Admin::UsersControllerTest#test_should_create_admin_user:
NameError: undefined local variable or method `admin_admin_users_url' for #<Admin::UsersControllerTest:0x000055a59f25ff68>
Did you mean? admin_users
test/controllers/admin/users_controller_test.rb:20:in `block (2 levels) in <class:UsersControllerTest>'
test/controllers/admin/users_controller_test.rb:19:in `block in <class:UsersControllerTest>'
bin/rails test test/controllers/admin/users_controller_test.rb:18
```
This is because combine `controller_class_path` and `singular_table_name`
to generate route.
360698aa24/railties/lib/rails/generators/named_base.rb (L172)
Normally, if using namspaced generator, table name already contains
namespace. Therefore, adding `controller_class_path` adds extra namespace.
Since it is special only when explicitly specifying `model-name`, it is
modified to change the value only when `model-name`is specified.
Follow up of #30729
177 lines
6.5 KiB
Ruby
177 lines
6.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "generators/generators_test_helper"
|
|
require "rails/generators/rails/scaffold_controller/scaffold_controller_generator"
|
|
|
|
class NamedBaseTest < Rails::Generators::TestCase
|
|
include GeneratorsTestHelper
|
|
tests Rails::Generators::ScaffoldControllerGenerator
|
|
|
|
def test_named_generator_with_underscore
|
|
g = generator ["line_item"]
|
|
assert_name g, "line_item", :name
|
|
assert_name g, %w(), :class_path
|
|
assert_name g, "LineItem", :class_name
|
|
assert_name g, "line_item", :file_path
|
|
assert_name g, "line_item", :file_name
|
|
assert_name g, "Line item", :human_name
|
|
assert_name g, "line_item", :singular_name
|
|
assert_name g, "line_items", :plural_name
|
|
assert_name g, "line_item", :i18n_scope
|
|
assert_name g, "line_items", :table_name
|
|
end
|
|
|
|
def test_named_generator_attributes
|
|
g = generator ["admin/foo"]
|
|
assert_name g, "admin/foo", :name
|
|
assert_name g, %w(admin), :class_path
|
|
assert_name g, "Admin::Foo", :class_name
|
|
assert_name g, "admin/foo", :file_path
|
|
assert_name g, "foo", :file_name
|
|
assert_name g, "Foo", :human_name
|
|
assert_name g, "foo", :singular_name
|
|
assert_name g, "foos", :plural_name
|
|
assert_name g, "admin.foo", :i18n_scope
|
|
assert_name g, "admin_foos", :table_name
|
|
assert_name g, "admin/foos", :controller_name
|
|
assert_name g, %w(admin), :controller_class_path
|
|
assert_name g, "Admin::Foos", :controller_class_name
|
|
assert_name g, "admin/foos", :controller_file_path
|
|
assert_name g, "foos", :controller_file_name
|
|
assert_name g, "admin.foos", :controller_i18n_scope
|
|
assert_name g, "admin_foo", :singular_route_name
|
|
assert_name g, "admin_foos", :plural_route_name
|
|
assert_name g, "@admin_foo", :redirect_resource_name
|
|
assert_name g, "admin_foo", :model_resource_name
|
|
assert_name g, "admin_foos", :index_helper
|
|
end
|
|
|
|
def test_named_generator_attributes_as_ruby
|
|
g = generator ["Admin::Foo"]
|
|
assert_name g, "Admin::Foo", :name
|
|
assert_name g, %w(admin), :class_path
|
|
assert_name g, "Admin::Foo", :class_name
|
|
assert_name g, "admin/foo", :file_path
|
|
assert_name g, "foo", :file_name
|
|
assert_name g, "foo", :singular_name
|
|
assert_name g, "Foo", :human_name
|
|
assert_name g, "foos", :plural_name
|
|
assert_name g, "admin.foo", :i18n_scope
|
|
assert_name g, "admin_foos", :table_name
|
|
assert_name g, "Admin::Foos", :controller_name
|
|
assert_name g, %w(admin), :controller_class_path
|
|
assert_name g, "Admin::Foos", :controller_class_name
|
|
assert_name g, "admin/foos", :controller_file_path
|
|
assert_name g, "foos", :controller_file_name
|
|
assert_name g, "admin.foos", :controller_i18n_scope
|
|
assert_name g, "admin_foo", :singular_route_name
|
|
assert_name g, "admin_foos", :plural_route_name
|
|
assert_name g, "@admin_foo", :redirect_resource_name
|
|
assert_name g, "admin_foo", :model_resource_name
|
|
assert_name g, "admin_foos", :index_helper
|
|
end
|
|
|
|
def test_named_generator_attributes_without_pluralized
|
|
original_pluralize_table_names = ActiveRecord::Base.pluralize_table_names
|
|
ActiveRecord::Base.pluralize_table_names = false
|
|
|
|
g = generator ["admin/foo"]
|
|
assert_name g, "admin_foo", :table_name
|
|
ensure
|
|
ActiveRecord::Base.pluralize_table_names = original_pluralize_table_names
|
|
end
|
|
|
|
def test_namespaced_scaffold_plural_names
|
|
g = generator ["admin/foo"]
|
|
assert_name g, "admin/foos", :controller_name
|
|
assert_name g, %w(admin), :controller_class_path
|
|
assert_name g, "Admin::Foos", :controller_class_name
|
|
assert_name g, "admin/foos", :controller_file_path
|
|
assert_name g, "foos", :controller_file_name
|
|
assert_name g, "admin.foos", :controller_i18n_scope
|
|
end
|
|
|
|
def test_namespaced_scaffold_plural_names_as_ruby
|
|
g = generator ["Admin::Foo"]
|
|
assert_name g, "Admin::Foos", :controller_name
|
|
assert_name g, %w(admin), :controller_class_path
|
|
assert_name g, "Admin::Foos", :controller_class_name
|
|
assert_name g, "admin/foos", :controller_file_path
|
|
assert_name g, "foos", :controller_file_name
|
|
assert_name g, "admin.foos", :controller_i18n_scope
|
|
end
|
|
|
|
def test_application_name
|
|
g = generator ["Admin::Foo"]
|
|
Rails.stub(:application, Object.new) do
|
|
assert_name g, "object", :application_name
|
|
end
|
|
|
|
Rails.stub(:application, nil) do
|
|
assert_name g, "application", :application_name
|
|
end
|
|
end
|
|
|
|
def test_index_helper
|
|
g = generator ["Post"]
|
|
assert_name g, "posts", :index_helper
|
|
end
|
|
|
|
def test_index_helper_to_pluralize_once
|
|
g = generator ["Stadium"]
|
|
assert_name g, "stadia", :index_helper
|
|
end
|
|
|
|
def test_index_helper_with_uncountable
|
|
g = generator ["Sheep"]
|
|
assert_name g, "sheep_index", :index_helper
|
|
end
|
|
|
|
def test_hide_namespace
|
|
g = generator ["Hidden"]
|
|
g.class.stub(:namespace, "hidden") do
|
|
assert_not_includes Rails::Generators.hidden_namespaces, "hidden"
|
|
g.class.hide!
|
|
assert_includes Rails::Generators.hidden_namespaces, "hidden"
|
|
end
|
|
end
|
|
|
|
def test_scaffold_plural_names_with_model_name_option
|
|
g = generator ["Admin::Foo"], model_name: "User"
|
|
assert_name g, "user", :singular_name
|
|
assert_name g, "User", :name
|
|
assert_name g, "user", :file_path
|
|
assert_name g, "User", :class_name
|
|
assert_name g, "user", :file_name
|
|
assert_name g, "User", :human_name
|
|
assert_name g, "users", :plural_name
|
|
assert_name g, "user", :i18n_scope
|
|
assert_name g, "users", :table_name
|
|
assert_name g, "Admin::Foos", :controller_name
|
|
assert_name g, %w(admin), :controller_class_path
|
|
assert_name g, "Admin::Foos", :controller_class_name
|
|
assert_name g, "admin/foos", :controller_file_path
|
|
assert_name g, "foos", :controller_file_name
|
|
assert_name g, "admin.foos", :controller_i18n_scope
|
|
assert_name g, "admin_user", :singular_route_name
|
|
assert_name g, "admin_users", :plural_route_name
|
|
assert_name g, "[:admin, @user]", :redirect_resource_name
|
|
assert_name g, "[:admin, user]", :model_resource_name
|
|
assert_name g, "admin_users", :index_helper
|
|
end
|
|
|
|
def test_scaffold_plural_names
|
|
g = generator ["User"]
|
|
assert_name g, "@user", :redirect_resource_name
|
|
assert_name g, "user", :model_resource_name
|
|
assert_name g, "user", :singular_route_name
|
|
assert_name g, "users", :plural_route_name
|
|
end
|
|
|
|
private
|
|
|
|
def assert_name(generator, value, method)
|
|
assert_equal value, generator.send(method)
|
|
end
|
|
end
|