7bb486055e
Ticket 1394 - Helper isolation r1319@iwill: jeremy | 2005-06-15 01:10:00 -0700 Formulate a test case for helper isolation. r1331@iwill: jeremy | 2005-06-15 15:21:07 -0700 Update changelog r1332@iwill: jeremy | 2005-06-15 15:21:30 -0700 Remove superfluous, broken layout_test r1333@iwill: jeremy | 2005-06-15 15:24:10 -0700 Use an anonymous Module to store helpers per-class instead of tossing them all in template_class. Create a new helper module for subclasses which includes its superclass' helper module. Remove unnecessary ActionView::Base.controller_delegate. Update helper tests. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1425 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
174 lines
4.4 KiB
Ruby
174 lines
4.4 KiB
Ruby
require File.dirname(__FILE__) + '/../abstract_unit'
|
|
|
|
class TestController < ActionController::Base
|
|
attr_accessor :delegate_attr
|
|
def delegate_method() end
|
|
def rescue_action(e) raise end
|
|
end
|
|
|
|
module Fun
|
|
class GamesController < ActionController::Base
|
|
def render_hello_world
|
|
render :inline => "hello: <%= stratego %>"
|
|
end
|
|
|
|
def rescue_action(e) raise end
|
|
end
|
|
end
|
|
|
|
module LocalAbcHelper
|
|
def a() end
|
|
def b() end
|
|
def c() end
|
|
end
|
|
|
|
class HelperTest < Test::Unit::TestCase
|
|
def setup
|
|
# Increment symbol counter.
|
|
@symbol = (@@counter ||= 'A0').succ!.dup
|
|
|
|
# Generate new controller class.
|
|
controller_class_name = "Helper#{@symbol}Controller"
|
|
eval("class #{controller_class_name} < TestController; end")
|
|
@controller_class = self.class.const_get(controller_class_name)
|
|
|
|
# Generate new template class and assign to controller.
|
|
template_class_name = "Test#{@symbol}View"
|
|
eval("class #{template_class_name} < ActionView::Base; end")
|
|
@template_class = self.class.const_get(template_class_name)
|
|
@controller_class.template_class = @template_class
|
|
|
|
# Set default test helper.
|
|
self.test_helper = LocalAbcHelper
|
|
end
|
|
|
|
def teardown
|
|
# Reset template class.
|
|
#ActionController::Base.template_class = ActionView::Base
|
|
end
|
|
|
|
|
|
def test_deprecated_helper
|
|
assert_equal expected_helper_methods, missing_methods
|
|
assert_nothing_raised { @controller_class.helper TestHelper }
|
|
assert_equal [], missing_methods
|
|
end
|
|
|
|
def test_declare_helper
|
|
require 'abc_helper'
|
|
self.test_helper = AbcHelper
|
|
assert_equal expected_helper_methods, missing_methods
|
|
assert_nothing_raised { @controller_class.helper :abc }
|
|
assert_equal [], missing_methods
|
|
end
|
|
|
|
def test_declare_missing_helper
|
|
assert_equal expected_helper_methods, missing_methods
|
|
assert_raise(MissingSourceFile) { @controller_class.helper :missing }
|
|
end
|
|
|
|
def test_declare_missing_file_from_helper
|
|
require 'broken_helper'
|
|
rescue LoadError => e
|
|
assert_nil /\bbroken_helper\b/.match(e.to_s)[1]
|
|
end
|
|
|
|
def test_helper_block
|
|
assert_nothing_raised {
|
|
@controller_class.helper { def block_helper_method; end }
|
|
}
|
|
assert master_helper_methods.include?('block_helper_method')
|
|
end
|
|
|
|
def test_helper_block_include
|
|
assert_equal expected_helper_methods, missing_methods
|
|
assert_nothing_raised {
|
|
@controller_class.helper { include TestHelper }
|
|
}
|
|
assert [], missing_methods
|
|
end
|
|
|
|
def test_helper_method
|
|
assert_nothing_raised { @controller_class.helper_method :delegate_method }
|
|
assert master_helper_methods.include?('delegate_method')
|
|
end
|
|
|
|
def test_helper_attr
|
|
assert_nothing_raised { @controller_class.helper_attr :delegate_attr }
|
|
assert master_helper_methods.include?('delegate_attr')
|
|
assert master_helper_methods.include?('delegate_attr=')
|
|
end
|
|
|
|
def test_helper_for_nested_controller
|
|
@request = ActionController::TestRequest.new
|
|
@response = ActionController::TestResponse.new
|
|
@request.action = "render_hello_world"
|
|
|
|
assert_equal "hello: Iz guuut!", Fun::GamesController.process(@request, @response).body
|
|
end
|
|
|
|
private
|
|
def expected_helper_methods
|
|
TestHelper.instance_methods
|
|
end
|
|
|
|
def master_helper_methods
|
|
@controller_class.master_helper_module.instance_methods
|
|
end
|
|
|
|
def missing_methods
|
|
expected_helper_methods - master_helper_methods
|
|
end
|
|
|
|
def test_helper=(helper_module)
|
|
old_verbose, $VERBOSE = $VERBOSE, nil
|
|
self.class.const_set('TestHelper', helper_module)
|
|
$VERBOSE = old_verbose
|
|
end
|
|
end
|
|
|
|
|
|
class IsolatedHelpersTest < Test::Unit::TestCase
|
|
class A < ActionController::Base
|
|
def index
|
|
render :inline => '<%= shout %>'
|
|
end
|
|
|
|
def rescue_action(e) raise end
|
|
end
|
|
|
|
class B < A
|
|
helper { def shout; 'B' end }
|
|
|
|
def index
|
|
render :inline => '<%= shout %>'
|
|
end
|
|
end
|
|
|
|
class C < A
|
|
helper { def shout; 'C' end }
|
|
|
|
def index
|
|
render :inline => '<%= shout %>'
|
|
end
|
|
end
|
|
|
|
def setup
|
|
@request = ActionController::TestRequest.new
|
|
@response = ActionController::TestResponse.new
|
|
@request.action = 'index'
|
|
end
|
|
|
|
def test_helper_in_a
|
|
assert_raise(NameError) { A.process(@request, @response) }
|
|
end
|
|
|
|
def test_helper_in_b
|
|
assert_equal 'B', B.process(@request, @response).body
|
|
end
|
|
|
|
def test_helper_in_c
|
|
assert_equal 'C', C.process(@request, @response).body
|
|
end
|
|
end
|