db5f1a46f2
- `secrets.secret_token` is now used in all places `config.secret_token` was
- `secrets.secret_token`, when not present in `config/secrets.yml`,
now falls back to the value of `config.secret_token`
- when `secrets.secret_token` is set, it over-writes
`config.secret_token` so they are the same (for backwards-compatibility)
- Update docs to reference app.secrets in all places
- Remove references to `config.secret_token`, `config.secret_key_base`
- Warn that missing secret_key_base is deprecated
- Add tests for secret_token, key_generator, and message_verifier
- the legacy key generator is used with the message verifier when
secrets.secret_key_base is blank and secret_token is set
- app.key_generator raises when neither secrets.secret_key_base nor
secret_token are set
- app.env_config raises when neither secrets.secret_key_base nor
secret_token are set
- Add changelog
Run focused tests via
ruby -w -Itest test/application/configuration_test.rb -n '/secret_|key_/'
48 lines
991 B
Ruby
48 lines
991 B
Ruby
# Activate the gem you are reporting the issue against.
|
|
gem 'rails', '4.0.0'
|
|
|
|
require 'rails'
|
|
require 'action_controller/railtie'
|
|
|
|
class TestApp < Rails::Application
|
|
config.root = File.dirname(__FILE__)
|
|
config.session_store :cookie_store, key: 'cookie_store_key'
|
|
secrets.secret_token = 'secret_token'
|
|
secrets.secret_key_base = 'secret_key_base'
|
|
|
|
config.logger = Logger.new($stdout)
|
|
Rails.logger = config.logger
|
|
|
|
routes.draw do
|
|
get '/' => 'test#index'
|
|
end
|
|
end
|
|
|
|
class TestController < ActionController::Base
|
|
include Rails.application.routes.url_helpers
|
|
|
|
def index
|
|
render text: 'Home'
|
|
end
|
|
end
|
|
|
|
require 'minitest/autorun'
|
|
require 'rack/test'
|
|
|
|
# Ensure backward compatibility with Minitest 4
|
|
Minitest::Test = MiniTest::Unit::TestCase unless defined?(Minitest::Test)
|
|
|
|
class BugTest < Minitest::Test
|
|
include Rack::Test::Methods
|
|
|
|
def test_returns_success
|
|
get '/'
|
|
assert last_response.ok?
|
|
end
|
|
|
|
private
|
|
def app
|
|
Rails.application
|
|
end
|
|
end
|