bartvdbraak/blender
1
0
Fork 4
Code Issues 4 Pull Requests 1 Actions 1 Packages Projects Releases Wiki Activity

Sculpting: initialise uninitialised variable

Browse Source 
Initialise `sum = 0.0f` before adding to it. Otherwise it'll get not just
a compiler warning, but also undefined behaviour.
This commit is contained in:
Sybren A. Stüvel 2024-07-04 11:04:00 +02:00
parent 84cbf33b38
commit 13276e1f1e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source/blender/editors/sculpt_paint/brushes/draw_face_sets.cc
View File

@ -329,7 +329,7 @@ BLI_NOINLINE static void fill_factor_from_hide_and_mask(const BMesh &bm,
const BMLoop *l_iter = f->l_first = BM_FACE_FIRST_LOOP(f);
int total_verts = 0;
float sum;
float sum = 0.0f;
do {
BMVert *vert = l_iter->v;
sum += BM_ELEM_CD_GET_FLOAT(vert, mask_offset);