bartvdbraak/blender
1
0
Fork 4
Code Issues 4 Pull Requests 1 Actions 1 Packages Projects Releases Wiki Activity

DRW: Move buffer & temp textures & framebuffer management to DrawManager

Browse Source 
This is a necessary step for EEVEE's new arch. This moves more data
to the draw manager. This makes it easier to have the render or draw
engines manage their own data.

This makes more sense and cleans-up what the GPUViewport holds

Also rewrites the Texture pool manager to be in C++.

This also move the DefaultFramebuffer/TextureList and the engine related
data to a new `DRWViewData` struct. This struct manages the per view
(as in stereo view) engine data.

There is a bit of cleanup in the way the draw manager is setup.
We now use a temporary DRWData instead of creating a dummy viewport.

Development: fclem, jbakker

Differential Revision: https://developer.blender.org/D11966
This commit is contained in:
Clément Foucault 2021-10-05 09:36:11 +02:00 committed by Jeroen Bakker
parent 08511b1c3d
commit 1d49293b80
19 changed files with 1117 additions and 1068 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.clang-format
View File

@ -180,6 +180,7 @@ ForEachMacros:
- CTX_DATA_BEGIN_WITH_ID
- DEG_OBJECT_ITER_BEGIN
- DEG_OBJECT_ITER_FOR_RENDER_ENGINE_BEGIN
- DRW_ENABLED_ENGINE_ITER
- DRIVER_TARGETS_LOOPER_BEGIN
- DRIVER_TARGETS_USED_LOOPER_BEGIN
- FOREACH_BASE_IN_EDIT_MODE_BEGIN

5
source/blender/draw/CMakeLists.txt
View File

@ -94,6 +94,7 @@ set(SRC
intern/draw_color_management.cc
intern/draw_common.c
intern/draw_debug.c
intern/draw_view_data.cc
intern/draw_fluid.c
intern/draw_hair.c
intern/draw_instance_data.c
@ -105,6 +106,7 @@ set(SRC
intern/draw_manager_text.c
intern/draw_manager_texture.c
intern/draw_select_buffer.c
intern/draw_texture_pool.cc
intern/draw_shader.c
intern/draw_view.c
engines/basic/basic_engine.c
@ -188,7 +190,6 @@ set(SRC
engines/overlay/overlay_wireframe.c
DRW_engine.h
DRW_engine_types.h
DRW_select_buffer.h
intern/DRW_render.h
intern/draw_cache.h
@ -198,12 +199,14 @@ set(SRC
intern/draw_color_management.h
intern/draw_common.h
intern/draw_debug.h
intern/draw_view_data.h
intern/draw_hair_private.h
intern/draw_instance_data.h
intern/draw_manager.h
intern/draw_manager_profiling.h
intern/draw_manager_testing.h
intern/draw_manager_text.h
intern/draw_texture_pool.h
intern/draw_shader.h
intern/draw_view.h
intern/mesh_extractors/extract_mesh.h

8
source/blender/draw/DRW_engine.h
View File

@ -26,13 +26,12 @@
#include "DNA_object_enums.h"
#include "DRW_engine_types.h"
#ifdef __cplusplus
extern "C" {
#endif
struct ARegion;
struct DRWData;
struct DRWInstanceDataList;
struct Depsgraph;
struct DrawEngineType;
@ -57,8 +56,6 @@ void DRW_engines_free(void);
bool DRW_engine_render_support(struct DrawEngineType *draw_engine_type);
void DRW_engine_register(struct DrawEngineType *draw_engine_type);
void DRW_engine_viewport_data_size_get(
const void *engine_type, int *r_fbl_len, int *r_txl_len, int *r_psl_len, int *r_stl_len);
typedef struct DRWUpdateContext {
struct Main *bmain;
@ -176,6 +173,9 @@ void DRW_deferred_shader_remove(struct GPUMaterial *mat);
struct DrawDataList *DRW_drawdatalist_from_id(struct ID *id);
void DRW_drawdata_free(struct ID *id);
struct DRWData *DRW_viewport_data_create(void);
void DRW_viewport_data_free(struct DRWData *drw_data);
bool DRW_opengl_context_release(void);
void DRW_opengl_context_activate(bool drw_state);

3
source/blender/draw/intern/DRW_render.h
View File

@ -24,8 +24,6 @@
#pragma once
#include "DRW_engine_types.h"
#include "BLI_listbase.h"
#include "BLI_math_matrix.h"
#include "BLI_math_vector.h"
@ -56,6 +54,7 @@
#include "draw_debug.h"
#include "draw_manager_profiling.h"
#include "draw_view_data.h"
#include "MEM_guardedalloc.h"

2
source/blender/draw/intern/draw_instance_data.c
View File

@ -364,6 +364,8 @@ void DRW_instance_data_list_free(DRWInstanceDataList *idatalist)
BLI_memblock_destroy(idatalist->pool_batching, (MemblockValFreeFP)temp_batch_free);
BLI_remlink(&g_idatalists, idatalist);
MEM_freeN(idatalist);
}
void DRW_instance_data_list_reset(DRWInstanceDataList *idatalist)

759
source/blender/draw/intern/draw_manager.c
View File

File diff suppressed because it is too large Load Diff

59
source/blender/draw/intern/draw_manager.h
View File

@ -97,6 +97,17 @@ struct Object;
#endif /* USE_PROFILE */
/* ------------ Data Structure --------------- */
/**
* Data structure to for registered draw engines that can store draw manager
* specific data.
*/
typedef struct DRWRegisteredDrawEngine {
void /*DRWRegisteredDrawEngine*/ *next, *prev;
DrawEngineType *draw_engine;
/** Index of the type in the lists. Index is used for dupli data. */
int index;
} DRWRegisteredDrawEngine;
/**
* Data structure containing all drawcalls organized by passes and materials.
* DRWPass > DRWShadingGroup > DRWCall > DRWCallState
@ -495,6 +506,35 @@ typedef struct DRWDebugSphere {
float color[4];
} DRWDebugSphere;
/* ------------- Memory Pools ------------ */
/* Contains memory pools information */
typedef struct DRWData {
/** Instance data. */
DRWInstanceDataList *idatalist;
/** Mempools for drawcalls. */
struct BLI_memblock *commands;
struct BLI_memblock *commands_small;
struct BLI_memblock *callbuffers;
struct BLI_memblock *obmats;
struct BLI_memblock *obinfos;
struct BLI_memblock *cullstates;
struct BLI_memblock *shgroups;
struct BLI_memblock *uniforms;
struct BLI_memblock *views;
struct BLI_memblock *passes;
struct BLI_memblock *images;
struct GPUUniformBuf **matrices_ubo;
struct GPUUniformBuf **obinfos_ubo;
struct GHash *obattrs_ubo_pool;
uint ubo_len;
/** Texture pool to reuse temp texture across engines. */
/* TODO(fclem) the pool could be shared even between viewports. */
struct DRWTexturePool *texture_pool;
/** Per stereo view data. Contains engine data and default framebuffers. */
struct DRWViewData *view_data[2];
} DRWData;
/* ------------- DRAW MANAGER ------------ */
typedef struct DupliKey {
@ -509,8 +549,10 @@ typedef struct DupliKey {
typedef struct DRWManager {
/* TODO: clean up this struct a bit. */
/* Cache generation */
ViewportMemoryPool *vmempool;
DRWInstanceDataList *idatalist;
/* TODO(fclem) Rename to data. */
DRWData *vmempool;
/** Active view data structure for one of the 2 stereo view. Not related to DRWView. */
struct DRWViewData *view_data_active;
/* State of the object being evaluated if already allocated. */
DRWResourceHandle ob_handle;
/** True if current DST.ob_state has its matching DRWObjectInfos init. */
@ -567,10 +609,6 @@ typedef struct DRWManager {
/* Convenience pointer to text_store owned by the viewport */
struct DRWTextStore **text_store_p;
ListBase enabled_engines; /* RenderEngineType */
void **vedata_array; /* ViewportEngineData */
int enabled_engine_count; /* Length of enabled_engines list. */
bool buffer_finish_called; /* Avoid bad usage of DRW_render_instance_buffer_finish */
DRWView *view_default;
@ -627,7 +665,7 @@ void drw_batch_cache_validate(Object *ob);
void drw_batch_cache_generate_requested(struct Object *ob);
void drw_batch_cache_generate_requested_delayed(Object *ob);
void drw_resource_buffer_finish(ViewportMemoryPool *vmempool);
void drw_resource_buffer_finish(DRWData *vmempool);
/* Procedural Drawing */
GPUBatch *drw_cache_procedural_points_get(void);
@ -641,6 +679,13 @@ void drw_uniform_attrs_pool_update(struct GHash *table,
struct Object *dupli_parent,
struct DupliObject *dupli_source);
double *drw_engine_data_cache_time_get(GPUViewport *viewport);
void *drw_engine_data_engine_data_create(GPUViewport *viewport, void *engine_type);
void *drw_engine_data_engine_data_get(GPUViewport *viewport, void *engine_handle);
bool drw_engine_data_engines_data_validate(GPUViewport *viewport, void **engine_handle_array);
void drw_engine_data_cache_release(GPUViewport *viewport);
void drw_engine_data_free(GPUViewport *viewport);
#ifdef __cplusplus
}
#endif

18
source/blender/draw/intern/draw_manager_data.c
View File

@ -87,7 +87,7 @@ static void draw_call_sort(DRWCommand *array, DRWCommand *array_tmp, int array_l
memcpy(array, array_tmp, sizeof(*array) * array_len);
}
void drw_resource_buffer_finish(ViewportMemoryPool *vmempool)
void drw_resource_buffer_finish(DRWData *vmempool)
{
int chunk_id = DRW_handle_chunk_get(&DST.resource_handle);
int elem_id = DRW_handle_id_get(&DST.resource_handle);
@ -908,7 +908,8 @@ void DRW_shgroup_call_instances_with_attrs(DRWShadingGroup *shgroup,
drw_command_set_select_id(shgroup, NULL, DST.select_id);
}
DRWResourceHandle handle = drw_resource_handle(shgroup, ob ? ob->obmat : NULL, ob);
GPUBatch *batch = DRW_temp_batch_instance_request(DST.idatalist, NULL, inst_attributes, geom);
GPUBatch *batch = DRW_temp_batch_instance_request(
DST.vmempool->idatalist, NULL, inst_attributes, geom);
drw_command_draw_instance(shgroup, batch, handle, 0, true);
}
@ -1128,7 +1129,7 @@ DRWCallBuffer *DRW_shgroup_call_buffer(DRWShadingGroup *shgroup,
BLI_assert(format != NULL);
DRWCallBuffer *callbuf = BLI_memblock_alloc(DST.vmempool->callbuffers);
callbuf->buf = DRW_temp_buffer_request(DST.idatalist, format, &callbuf->count);
callbuf->buf = DRW_temp_buffer_request(DST.vmempool->idatalist, format, &callbuf->count);
callbuf->buf_select = NULL;
callbuf->count = 0;
@ -1138,12 +1139,12 @@ DRWCallBuffer *DRW_shgroup_call_buffer(DRWShadingGroup *shgroup,
GPU_vertformat_attr_add(&inst_select_format, "selectId", GPU_COMP_I32, 1, GPU_FETCH_INT);
}
callbuf->buf_select = DRW_temp_buffer_request(
DST.idatalist, &inst_select_format, &callbuf->count);
DST.vmempool->idatalist, &inst_select_format, &callbuf->count);
drw_command_set_select_id(shgroup, callbuf->buf_select, -1);
}
DRWResourceHandle handle = drw_resource_handle(shgroup, NULL, NULL);
GPUBatch *batch = DRW_temp_batch_request(DST.idatalist, callbuf->buf, prim_type);
GPUBatch *batch = DRW_temp_batch_request(DST.vmempool->idatalist, callbuf->buf, prim_type);
drw_command_draw(shgroup, batch, handle);
return callbuf;
@ -1157,7 +1158,7 @@ DRWCallBuffer *DRW_shgroup_call_buffer_instance(DRWShadingGroup *shgroup,
BLI_assert(format != NULL);
DRWCallBuffer *callbuf = BLI_memblock_alloc(DST.vmempool->callbuffers);
callbuf->buf = DRW_temp_buffer_request(DST.idatalist, format, &callbuf->count);
callbuf->buf = DRW_temp_buffer_request(DST.vmempool->idatalist, format, &callbuf->count);
callbuf->buf_select = NULL;
callbuf->count = 0;
@ -1167,12 +1168,13 @@ DRWCallBuffer *DRW_shgroup_call_buffer_instance(DRWShadingGroup *shgroup,
GPU_vertformat_attr_add(&inst_select_format, "selectId", GPU_COMP_I32, 1, GPU_FETCH_INT);
}
callbuf->buf_select = DRW_temp_buffer_request(
DST.idatalist, &inst_select_format, &callbuf->count);
DST.vmempool->idatalist, &inst_select_format, &callbuf->count);
drw_command_set_select_id(shgroup, callbuf->buf_select, -1);
}
DRWResourceHandle handle = drw_resource_handle(shgroup, NULL, NULL);
GPUBatch *batch = DRW_temp_batch_instance_request(DST.idatalist, callbuf->buf, NULL, geom);
GPUBatch *batch = DRW_temp_batch_instance_request(
DST.vmempool->idatalist, callbuf->buf, NULL, geom);
drw_command_draw(shgroup, batch, handle);
return callbuf;

7
source/blender/draw/intern/draw_manager_profiling.c
View File

@ -257,10 +257,9 @@ void DRW_stats_draw(const rcti *rect)
/* Engines rows */
char time_to_txt[16];
LISTBASE_FOREACH (LinkData *, link, &DST.enabled_engines) {
DRW_ENABLED_ENGINE_ITER(DST.view_data_active, engine, data)
{
u = 0;
DrawEngineType *engine = link->data;
ViewportEngineData *data = drw_viewport_engine_data_ensure(engine);
draw_stat_5row(rect, u++, v, engine->idname, sizeof(engine->idname));
@ -297,7 +296,7 @@ void DRW_stats_draw(const rcti *rect)
v += 2;
u = 0;
double *cache_time = GPU_viewport_cache_time_get(DST.viewport);
double *cache_time = DRW_view_data_cache_time_get(DST.view_data_active);
sprintf(col_label, "Cache Time");
draw_stat_5row(rect, u++, v, col_label, sizeof(col_label));
sprintf(time_to_txt, "%.2fms", *cache_time);

8
source/blender/draw/intern/draw_manager_text.h
View File

@ -22,6 +22,10 @@
#pragma once
#ifdef __cplusplus
extern "C" {
#endif
struct ARegion;
struct DRWTextStore;
struct Object;
@ -57,3 +61,7 @@ enum {
/* draw_manager.c */
struct DRWTextStore *DRW_text_cache_ensure(void);
#ifdef __cplusplus
}
#endif

3
source/blender/draw/intern/draw_manager_texture.c
View File

@ -21,6 +21,7 @@
*/
#include "draw_manager.h"
#include "draw_texture_pool.h"
#ifndef NDEBUG
/* Maybe gpu_texture.c is a better place for this. */
@ -147,7 +148,7 @@ GPUTexture *DRW_texture_pool_query_2d(int w,
DrawEngineType *engine_type)
{
BLI_assert(drw_texture_format_supports_framebuffer(format));
GPUTexture *tex = GPU_viewport_texture_pool_query(DST.viewport, engine_type, w, h, format);
GPUTexture *tex = DRW_texture_pool_query(DST.vmempool->texture_pool, w, h, format, engine_type);
return tex;
}

140
source/blender/draw/intern/draw_texture_pool.cc Normal file
View File

@ -0,0 +1,140 @@
/*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
* Copyright 2021, Blender Foundation.
*/
/** \file
* \ingroup draw
*/
#include "BKE_global.h"
#include "BLI_vector.hh"
#include "draw_texture_pool.h"
using namespace blender;
typedef struct DRWTexturePoolHandle {
uint64_t users_bits;
GPUTexture *texture;
} DRWTexturePoolHandle;
struct DRWTexturePool {
Vector<void *, 16> users;
Vector<DRWTexturePoolHandle> handles;
/* Cache last result to avoid linear search each time. */
int last_user_id = -1;
};
DRWTexturePool *DRW_texture_pool_create(void)
{
return new DRWTexturePool();
}
void DRW_texture_pool_free(DRWTexturePool *pool)
{
/* Reseting the pool twice will effectively free all textures. */
DRW_texture_pool_reset(pool);
DRW_texture_pool_reset(pool);
delete pool;
}
/**
* Try to find a texture corresponding to params into the texture pool.
* If no texture was found, create one and add it to the pool.
*/
GPUTexture *DRW_texture_pool_query(
DRWTexturePool *pool, int width, int height, eGPUTextureFormat format, void *user)
{
int user_id = pool->last_user_id;
/* Try cached value. */
if (user_id != -1) {
if (pool->users[user_id] != user) {
user_id = -1;
}
}
/* Try to find inside previous users. */
if (user_id == -1) {
user_id = pool->users.first_index_of_try(user);
}
/* No chance, needs to add it to the user list. */
if (user_id == -1) {
user_id = pool->users.size();
pool->users.append(user);
/* If there is more than 63 users, better refactor this system. */
BLI_assert(user_id < 64);
}
pool->last_user_id = user_id;
uint64_t user_bit = 1llu << user_id;
for (DRWTexturePoolHandle &handle : pool->handles) {
/* Skip if the user is already using this texture. */
if (user_bit & handle.users_bits) {
continue;
}
/* If everthing matches reuse the texture. */
if ((GPU_texture_format(handle.texture) == format) &&
(GPU_texture_width(handle.texture) == width) &&
(GPU_texture_height(handle.texture) == height)) {
handle.users_bits |= user_bit;
return handle.texture;
}
}
char name[16] = "DRW_tex_pool";
if (G.debug & G_DEBUG_GPU) {
int texture_id = pool->handles.size();
SNPRINTF(name, "DRW_tex_pool_%d", texture_id);
}
DRWTexturePoolHandle handle;
handle.users_bits = user_bit;
handle.texture = GPU_texture_create_2d(name, width, height, 1, format, nullptr);
pool->handles.append(handle);
/* Doing filtering for depth does not make sense when not doing shadow mapping,
* and enabling texture filtering on integer texture make them unreadable. */
bool do_filter = !GPU_texture_depth(handle.texture) && !GPU_texture_integer(handle.texture);
GPU_texture_filter_mode(handle.texture, do_filter);
return handle.texture;
}
/* Resets the user bits for each texture in the pool and delete unused ones. */
void DRW_texture_pool_reset(DRWTexturePool *pool)
{
pool->last_user_id = -1;
for (auto it = pool->handles.rbegin(); it != pool->handles.rend(); ++it) {
DRWTexturePoolHandle &handle = *it;
if (handle.users_bits == 0) {
if (handle.texture) {
GPU_texture_free(handle.texture);
handle.texture = nullptr;
}
}
else {
handle.users_bits = 0;
}
}
/* Reverse iteration to make sure we only reorder with known good handles. */
for (int i = pool->handles.size() - 1; i >= 0; i--) {
if (!pool->handles[i].texture) {
pool->handles.remove_and_reorder(i);
}
}
}

34
source/blender/draw/DRW_engine_types.h → source/blender/draw/intern/draw_texture_pool.h
View File

@ -13,38 +13,34 @@
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
* Copyright 2016, Blender Foundation.
* Copyright 2021, Blender Foundation.
*/
/** \file
* \ingroup draw
*
* Texture pool
* A pool that gives temporary render targets that can be reused through other parts of the
* render pipeline.
* Expect texture data is garbage when acquiring it.
*/
#pragma once
#include "GPU_texture.h"
typedef struct DRWTexturePool DRWTexturePool;
#ifdef __cplusplus
extern "C" {
#endif
/* Buffer and textures used by the viewport by default */
typedef struct DefaultFramebufferList {
struct GPUFrameBuffer *default_fb;
struct GPUFrameBuffer *overlay_fb;
struct GPUFrameBuffer *in_front_fb;
struct GPUFrameBuffer *color_only_fb;
struct GPUFrameBuffer *depth_only_fb;
struct GPUFrameBuffer *overlay_only_fb;
struct GPUFrameBuffer *stereo_comp_fb;
} DefaultFramebufferList;
DRWTexturePool *DRW_texture_pool_create(void);
void DRW_texture_pool_free(DRWTexturePool *pool);
typedef struct DefaultTextureList {
struct GPUTexture *color;
struct GPUTexture *color_overlay;
struct GPUTexture *color_stereo;
struct GPUTexture *color_overlay_stereo;
struct GPUTexture *depth;
struct GPUTexture *depth_in_front;
} DefaultTextureList;
GPUTexture *DRW_texture_pool_query(
DRWTexturePool *pool, int width, int height, eGPUTextureFormat format, void *user);
void DRW_texture_pool_reset(DRWTexturePool *pool);
#ifdef __cplusplus
}

243
source/blender/draw/intern/draw_view_data.cc Normal file
View File

@ -0,0 +1,243 @@
/*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
* Copyright 2021, Blender Foundation.
*/
/** \file
* \ingroup draw
*/
#include "BLI_vector.hh"
#include "GPU_viewport.h"
#include "DRW_render.h"
#include "draw_instance_data.h"
#include "draw_manager_text.h"
#include "draw_manager.h"
#include "draw_view_data.h"
using namespace blender;
struct DRWViewData {
DefaultFramebufferList dfbl = {};
DefaultTextureList dtxl = {};
/** True indicates the textures inside dtxl are from the viewport and should not be freed. */
bool from_viewport = false;
/** Common size for texture in the engines texture list.
* We free all texture lists if it changes. */
int texture_list_size[2] = {0, 0};
double cache_time = 0.0;
Vector<ViewportEngineData> engines;
Vector<ViewportEngineData *> enabled_engines;
};
/**
* Creates a view data with all possible engines type for this view.
*
* `engine_types` contains `DRWRegisteredDrawEngine`.
* */
DRWViewData *DRW_view_data_create(ListBase *engine_types)
{
DRWViewData *view_data = new DRWViewData();
LISTBASE_FOREACH (DRWRegisteredDrawEngine *, type, engine_types) {
ViewportEngineData engine = {};
engine.engine_type = type;
view_data->engines.append(engine);
}
return view_data;
}
void DRW_view_data_default_lists_from_viewport(DRWViewData *view_data, GPUViewport *viewport)
{
int active_view = GPU_viewport_active_view_get(viewport);
view_data->from_viewport = true;
DefaultFramebufferList *dfbl = &view_data->dfbl;
DefaultTextureList *dtxl = &view_data->dtxl;
/* Depth texture is shared between both stereo views. */
dtxl->depth = GPU_viewport_depth_texture(viewport);
dtxl->color = GPU_viewport_color_texture(viewport, active_view);
dtxl->color_overlay = GPU_viewport_overlay_texture(viewport, active_view);
GPU_framebuffer_ensure_config(&dfbl->default_fb,
{
GPU_ATTACHMENT_TEXTURE(dtxl->depth),
GPU_ATTACHMENT_TEXTURE(dtxl->color),
});
GPU_framebuffer_ensure_config(&dfbl->overlay_fb,
{
GPU_ATTACHMENT_TEXTURE(dtxl->depth),
GPU_ATTACHMENT_TEXTURE(dtxl->color_overlay),
});
GPU_framebuffer_ensure_config(&dfbl->depth_only_fb,
{
GPU_ATTACHMENT_TEXTURE(dtxl->depth),
GPU_ATTACHMENT_NONE,
});
GPU_framebuffer_ensure_config(&dfbl->color_only_fb,
{
GPU_ATTACHMENT_NONE,
GPU_ATTACHMENT_TEXTURE(dtxl->color),
});
GPU_framebuffer_ensure_config(&dfbl->overlay_only_fb,
{
GPU_ATTACHMENT_NONE,
GPU_ATTACHMENT_TEXTURE(dtxl->color_overlay),
});
}
static void draw_viewport_engines_data_clear(ViewportEngineData *data)
{
DrawEngineType *engine_type = data->engine_type->draw_engine;
const DrawEngineDataSize *data_size = engine_type->vedata_size;
for (int i = 0; data->fbl && i < data_size->fbl_len; i++) {
GPU_FRAMEBUFFER_FREE_SAFE(data->fbl->framebuffers[i]);
}
for (int i = 0; data->txl && i < data_size->txl_len; i++) {
GPU_TEXTURE_FREE_SAFE(data->txl->textures[i]);
}
for (int i = 0; data->stl && i < data_size->stl_len; i++) {
MEM_SAFE_FREE(data->stl->storage[i]);
}
MEM_SAFE_FREE(data->fbl);
MEM_SAFE_FREE(data->txl);
MEM_SAFE_FREE(data->psl);
MEM_SAFE_FREE(data->stl);
if (data->text_draw_cache) {
DRW_text_cache_destroy(data->text_draw_cache);
data->text_draw_cache = nullptr;
}
}
static void draw_view_data_clear(DRWViewData *view_data)
{
GPU_FRAMEBUFFER_FREE_SAFE(view_data->dfbl.default_fb);
GPU_FRAMEBUFFER_FREE_SAFE(view_data->dfbl.overlay_fb);
GPU_FRAMEBUFFER_FREE_SAFE(view_data->dfbl.in_front_fb);
GPU_FRAMEBUFFER_FREE_SAFE(view_data->dfbl.color_only_fb);
GPU_FRAMEBUFFER_FREE_SAFE(view_data->dfbl.depth_only_fb);
GPU_FRAMEBUFFER_FREE_SAFE(view_data->dfbl.overlay_only_fb);
if (!view_data->from_viewport) {
GPU_TEXTURE_FREE_SAFE(view_data->dtxl.color);
GPU_TEXTURE_FREE_SAFE(view_data->dtxl.color_overlay);
GPU_TEXTURE_FREE_SAFE(view_data->dtxl.depth);
}
GPU_TEXTURE_FREE_SAFE(view_data->dtxl.depth_in_front);
for (ViewportEngineData &engine : view_data->engines) {
draw_viewport_engines_data_clear(&engine);
}
view_data->texture_list_size[0] = view_data->texture_list_size[1] = 0;
view_data->cache_time = 0.0f;
}
void DRW_view_data_free(DRWViewData *view_data)
{
draw_view_data_clear(view_data);
delete view_data;
}
void DRW_view_data_texture_list_size_validate(DRWViewData *view_data, const int size[2])
{
if (!equals_v2v2_int(view_data->texture_list_size, size)) {
draw_view_data_clear(view_data);
copy_v2_v2_int(view_data->texture_list_size, size);
}
}
ViewportEngineData *DRW_view_data_engine_data_get_ensure(DRWViewData *view_data,
DrawEngineType *engine_type)
{
for (ViewportEngineData &engine : view_data->engines) {
if (engine.engine_type->draw_engine == engine_type) {
if (engine.fbl == nullptr) {
const DrawEngineDataSize *data_size = engine_type->vedata_size;
engine.fbl = (FramebufferList *)MEM_calloc_arrayN(
data_size->fbl_len, sizeof(GPUFrameBuffer *), "FramebufferList");
engine.txl = (TextureList *)MEM_calloc_arrayN(
data_size->txl_len, sizeof(GPUTexture *), "TextureList");
engine.psl = (PassList *)MEM_calloc_arrayN(
data_size->psl_len, sizeof(DRWPass *), "PassList");
engine.stl = (StorageList *)MEM_calloc_arrayN(
data_size->stl_len, sizeof(void *), "StorageList");
}
return &engine;
}
}
return nullptr;
}
void DRW_view_data_use_engine(DRWViewData *view_data, DrawEngineType *engine_type)
{
ViewportEngineData *engine = DRW_view_data_engine_data_get_ensure(view_data, engine_type);
view_data->enabled_engines.append(engine);
}
void DRW_view_data_reset(DRWViewData *view_data)
{
view_data->enabled_engines.clear();
}
void DRW_view_data_free_unused(DRWViewData *view_data)
{
for (ViewportEngineData &engine : view_data->engines) {
if (view_data->enabled_engines.first_index_of_try(&engine) == -1) {
draw_viewport_engines_data_clear(&engine);
}
}
}
double *DRW_view_data_cache_time_get(DRWViewData *view_data)
{
return &view_data->cache_time;
}
DefaultFramebufferList *DRW_view_data_default_framebuffer_list_get(DRWViewData *view_data)
{
return &view_data->dfbl;
}
DefaultTextureList *DRW_view_data_default_texture_list_get(DRWViewData *view_data)
{
return &view_data->dtxl;
}
void DRW_view_data_enabled_engine_iter_begin(DRWEngineIterator *iterator, DRWViewData *view_data)
{
iterator->id = 0;
iterator->end = view_data->enabled_engines.size();
iterator->engines = view_data->enabled_engines.data();
}
ViewportEngineData *DRW_view_data_enabled_engine_iter_step(DRWEngineIterator *iterator)
{
if (iterator->id >= iterator->end) {
return nullptr;
}
ViewportEngineData *engine = iterator->engines[iterator->id++];
return engine;
}

139
source/blender/draw/intern/draw_view_data.h Normal file
View File

@ -0,0 +1,139 @@
/*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software Foundation,
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
* Copyright 2021, Blender Foundation.
*/
/** \file
* \ingroup draw
*
* Engine data
* Structure containing each draw engine instance data.
*/
#pragma once
#define GPU_INFO_SIZE 512 /* IMA_MAX_RENDER_TEXT */
#ifdef __cplusplus
extern "C" {
#endif
struct GPUViewport;
struct DrawEngineType;
struct DRWRegisteredDrawEngine;
/* NOTE these structs are only here for reading the actual lists from the engine.
* The actual length of them is stored in a ViewportEngineData_Info.
* The length of 1 is just here to avoid compiler warning. */
typedef struct FramebufferList {
struct GPUFrameBuffer *framebuffers[1];
} FramebufferList;
typedef struct TextureList {
struct GPUTexture *textures[1];
} TextureList;
typedef struct PassList {
struct DRWPass *passes[1];
} PassList;
/* Stores custom structs from the engine that have been MEM_(m/c)allocN'ed. */
typedef struct StorageList {
void *storage[1];
} StorageList;
typedef struct ViewportEngineData {
/* Not owning pointer to the draw engine. */
struct DRWRegisteredDrawEngine *engine_type;
FramebufferList *fbl;
TextureList *txl;
PassList *psl;
StorageList *stl;
char info[GPU_INFO_SIZE];
/* we may want to put this elsewhere */
struct DRWTextStore *text_draw_cache;
/* Profiling data */
double init_time;
double render_time;
double background_time;
} ViewportEngineData;
typedef struct ViewportEngineData_Info {
int fbl_len;
int txl_len;
int psl_len;
int stl_len;
} ViewportEngineData_Info;
/* Buffer and textures used by the viewport by default */
typedef struct DefaultFramebufferList {
struct GPUFrameBuffer *default_fb;
struct GPUFrameBuffer *overlay_fb;
struct GPUFrameBuffer *in_front_fb;
struct GPUFrameBuffer *color_only_fb;
struct GPUFrameBuffer *depth_only_fb;
struct GPUFrameBuffer *overlay_only_fb;
} DefaultFramebufferList;
typedef struct DefaultTextureList {
struct GPUTexture *color;
struct GPUTexture *color_overlay;
struct GPUTexture *depth;
struct GPUTexture *depth_in_front;
} DefaultTextureList;
typedef struct DRWViewData DRWViewData;
DRWViewData *DRW_view_data_create(ListBase *engine_types);
void DRW_view_data_free(DRWViewData *view_data);
void DRW_view_data_default_lists_from_viewport(DRWViewData *view_data,
struct GPUViewport *viewport);
void DRW_view_data_texture_list_size_validate(DRWViewData *view_data, const int size[2]);
ViewportEngineData *DRW_view_data_engine_data_get_ensure(DRWViewData *view_data,
struct DrawEngineType *engine_type_);
void DRW_view_data_use_engine(DRWViewData *view_data, struct DrawEngineType *engine_type);
void DRW_view_data_reset(DRWViewData *view_data);
void DRW_view_data_free_unused(DRWViewData *view_data);
double *DRW_view_data_cache_time_get(DRWViewData *view_data);
DefaultFramebufferList *DRW_view_data_default_framebuffer_list_get(DRWViewData *view_data);
DefaultTextureList *DRW_view_data_default_texture_list_get(DRWViewData *view_data);
typedef struct DRWEngineIterator {
int id, end;
ViewportEngineData **engines;
} DRWEngineIterator;
/* Iterate over used engines of this view_data. */
void DRW_view_data_enabled_engine_iter_begin(DRWEngineIterator *iterator, DRWViewData *view_data);
ViewportEngineData *DRW_view_data_enabled_engine_iter_step(DRWEngineIterator *iterator);
#define DRW_ENABLED_ENGINE_ITER(view_data_, engine_, data_) \
DRWEngineIterator iterator; \
ViewportEngineData *data_; \
struct DrawEngineType *engine_; \
DRW_view_data_enabled_engine_iter_begin(&iterator, view_data_); \
/* WATCH Comma operator trickery ahead! This tests engine_ == NULL. */ \
while ((data_ = DRW_view_data_enabled_engine_iter_step(&iterator), \
engine_ = (data_ != NULL) ? (struct DrawEngineType *)data_->engine_type->draw_engine : \
NULL))
#ifdef __cplusplus
}
#endif

21
source/blender/editors/space_view3d/view3d_draw.c
View File

@ -2180,13 +2180,17 @@ static void validate_object_select_id(struct Depsgraph *depsgraph,
* Calling this function should be avoided during interactive drawing. */
static void view3d_opengl_read_Z_pixels(GPUViewport *viewport, rcti *rect, void *data)
{
DefaultTextureList *dtxl = (DefaultTextureList *)GPU_viewport_texture_list_get(viewport);
GPUTexture *depth_tx = GPU_viewport_depth_texture(viewport);
GPUFrameBuffer *tmp_fb = GPU_framebuffer_create(__func__);
GPU_framebuffer_texture_attach(tmp_fb, dtxl->depth, 0, 0);
GPU_framebuffer_bind(tmp_fb);
GPUFrameBuffer *depth_read_fb = NULL;
GPU_framebuffer_ensure_config(&depth_read_fb,
{
GPU_ATTACHMENT_TEXTURE(depth_tx),
GPU_ATTACHMENT_NONE,
});
GPU_framebuffer_read_depth(tmp_fb,
GPU_framebuffer_bind(depth_read_fb);
GPU_framebuffer_read_depth(depth_read_fb,
rect->xmin,
rect->ymin,
BLI_rcti_size_x(rect),
@ -2195,7 +2199,7 @@ static void view3d_opengl_read_Z_pixels(GPUViewport *viewport, rcti *rect, void
data);
GPU_framebuffer_restore();
GPU_framebuffer_free(tmp_fb);
GPU_framebuffer_free(depth_read_fb);
}
void ED_view3d_select_id_validate(ViewContext *vc)
@ -2265,12 +2269,11 @@ static ViewDepths *view3d_depths_create(ARegion *region)
ViewDepths *d = MEM_callocN(sizeof(ViewDepths), "ViewDepths");
d->w = region->winx;
d->h = region->winy;
d->depths = MEM_mallocN(sizeof(float) * d->w * d->h, "View depths");
{
GPUViewport *viewport = WM_draw_region_get_viewport(region);
DefaultFramebufferList *fbl = GPU_viewport_framebuffer_list_get(viewport);
GPU_framebuffer_read_depth(fbl->depth_only_fb, 0, 0, d->w, d->h, GPU_DATA_FLOAT, d->depths);
GPUTexture *depth_tx = GPU_viewport_depth_texture(viewport);
d->depths = GPU_texture_read(depth_tx, GPU_DATA_FLOAT, 0);
/* Assumed to be this as they are never changed. */
d->depth_range[0] = 0.0;

8
source/blender/gpu/GPU_texture.h
View File

@ -52,6 +52,14 @@ typedef enum eGPUSamplerState {
GPU_SAMPLER_REPEAT = (GPU_SAMPLER_REPEAT_S | GPU_SAMPLER_REPEAT_T | GPU_SAMPLER_REPEAT_R),
} eGPUSamplerState;
#define GPU_TEXTURE_FREE_SAFE(texture) \
do { \
if (texture != NULL) { \
GPU_texture_free(texture); \
texture = NULL; \
} \
} while (0)
/* `GPU_SAMPLER_MAX` is not a valid enum value, but only a limit.
* It also creates a bad mask for the `NOT` operator in `ENUM_OPERATORS`.
*/

95
source/blender/gpu/GPU_viewport.h
View File

@ -35,76 +35,15 @@
extern "C" {
#endif
#define GPU_INFO_SIZE 512 /* IMA_MAX_RENDER_TEXT */
#define GLA_PIXEL_OFS 0.375f
typedef struct GHash GHash;
typedef struct GPUViewport GPUViewport;
struct GPUFrameBuffer;
/* Contains memory pools information. */
typedef struct ViewportMemoryPool {
struct BLI_memblock *commands;
struct BLI_memblock *commands_small;
struct BLI_memblock *callbuffers;
struct BLI_memblock *obmats;
struct BLI_memblock *obinfos;
struct BLI_memblock *cullstates;
struct BLI_memblock *shgroups;
struct BLI_memblock *uniforms;
struct BLI_memblock *views;
struct BLI_memblock *passes;
struct BLI_memblock *images;
struct GPUUniformBuf **matrices_ubo;
struct GPUUniformBuf **obinfos_ubo;
struct GHash *obattrs_ubo_pool;
uint ubo_len;
} ViewportMemoryPool;
/* All FramebufferLists are just the same pointers with different names. */
typedef struct FramebufferList {
struct GPUFrameBuffer *framebuffers[1];
} FramebufferList;
typedef struct TextureList {
struct GPUTexture *textures[1];
} TextureList;
typedef struct PassList {
struct DRWPass *passes[1];
} PassList;
typedef struct StorageList {
void *storage[1]; /* Custom structs from the engine. */
} StorageList;
typedef struct ViewportEngineData {
void *engine_type;
FramebufferList *fbl;
TextureList *txl;
PassList *psl;
StorageList *stl;
char info[GPU_INFO_SIZE];
TextureList *txl_stereo;
StorageList *stl_stereo;
/* We may want to put this elsewhere. */
struct DRWTextStore *text_draw_cache;
/* Profiling data. */
double init_time;
double render_time;
double background_time;
} ViewportEngineData;
typedef struct ViewportEngineData_Info {
int fbl_len;
int txl_len;
int psl_len;
int stl_len;
} ViewportEngineData_Info;
struct DefaultFramebufferList;
struct DefaultTextureList;
struct DRWData;
GPUViewport *GPU_viewport_create(void);
GPUViewport *GPU_viewport_stereo_create(void);
@ -129,35 +68,21 @@ void GPU_viewport_unbind_from_offscreen(GPUViewport *viewport,
bool display_colorspace,
bool do_overlay_merge);
ViewportMemoryPool *GPU_viewport_mempool_get(GPUViewport *viewport);
struct DRWInstanceDataList *GPU_viewport_instance_data_list_get(GPUViewport *viewport);
struct DRWData **GPU_viewport_data_get(GPUViewport *viewport);
void *GPU_viewport_engine_data_create(GPUViewport *viewport, void *engine_type);
void *GPU_viewport_engine_data_get(GPUViewport *viewport, void *engine_handle);
void *GPU_viewport_framebuffer_list_get(GPUViewport *viewport);
void GPU_viewport_stereo_composite(GPUViewport *viewport, Stereo3dFormat *stereo_format);
void *GPU_viewport_texture_list_get(GPUViewport *viewport);
void GPU_viewport_size_get(const GPUViewport *viewport, int size[2]);
void GPU_viewport_size_set(GPUViewport *viewport, const int size[2]);
void GPU_viewport_active_view_set(GPUViewport *viewport, int view);
/* Profiling. */
double *GPU_viewport_cache_time_get(GPUViewport *viewport);
void GPU_viewport_tag_update(GPUViewport *viewport);
bool GPU_viewport_do_update(GPUViewport *viewport);
int GPU_viewport_active_view_get(GPUViewport *viewport);
bool GPU_viewport_is_stereo_get(GPUViewport *viewport);
GPUTexture *GPU_viewport_color_texture(GPUViewport *viewport, int view);
GPUTexture *GPU_viewport_overlay_texture(GPUViewport *viewport, int view);
GPUTexture *GPU_viewport_depth_texture(GPUViewport *viewport);
/* Texture pool. */
GPUTexture *GPU_viewport_texture_pool_query(
GPUViewport *viewport, void *engine, int width, int height, int format);
bool GPU_viewport_engines_data_validate(GPUViewport *viewport, void **engine_handle_array);
void GPU_viewport_cache_release(GPUViewport *viewport);
struct GPUFrameBuffer *GPU_viewport_framebuffer_default_get(GPUViewport *viewport);
struct GPUFrameBuffer *GPU_viewport_framebuffer_overlay_get(GPUViewport *viewport);
GPUFrameBuffer *GPU_viewport_framebuffer_overlay_get(GPUViewport *viewport);
#ifdef __cplusplus
}

632
source/blender/gpu/intern/gpu_viewport.c
View File

@ -48,22 +48,6 @@
#include "MEM_guardedalloc.h"
static const int default_fbl_len = (sizeof(DefaultFramebufferList)) / sizeof(void *);
static const int default_txl_len = (sizeof(DefaultTextureList)) / sizeof(void *);
#define MAX_ENABLE_ENGINE 8
/* Maximum number of simultaneous engine enabled at the same time.
* Setting it lower than the real number will do lead to
* higher VRAM usage due to sub-efficient buffer reuse. */
#define MAX_ENGINE_BUFFER_SHARING 5
typedef struct ViewportTempTexture {
struct ViewportTempTexture *next, *prev;
void *user[MAX_ENGINE_BUFFER_SHARING];
GPUTexture *texture;
} ViewportTempTexture;
/* Struct storing a viewport specific GPUBatch.
* The end-goal is to have a single batch shared across viewport and use a model matrix to place
* the batch. Due to OCIO and Image/UV editor we are not able to use an model matrix yet. */
@ -89,23 +73,17 @@ struct GPUViewport {
/* Set the active view (for stereoscopic viewport rendering). */
int active_view;
/* If engine_handles mismatch we free all #ViewportEngineData in this viewport. */
struct {
void *handle;
ViewportEngineData *data;
} engine_data[MAX_ENABLE_ENGINE];
DefaultFramebufferList *fbl;
DefaultTextureList *txl;
ViewportMemoryPool vmempool; /* Used for rendering data structure. */
struct DRWInstanceDataList *idatalist; /* Used for rendering data structure. */
ListBase
tex_pool; /* ViewportTempTexture list : Temporary textures shared across draw engines. */
/* Profiling data. */
double cache_time;
/* Viewport Resources. */
struct DRWData *draw_data;
/** Color buffers, one for each stereo view. Only one if not stereo viewport. */
GPUTexture *color_render_tx[2];
GPUTexture *color_overlay_tx[2];
/** Depth buffer. Can be shared with GPUOffscreen. */
GPUTexture *depth_tx;
/** Compositing framebuffer for stereo viewport. */
GPUFrameBuffer *stereo_comp_fb;
/** Overlay framebuffer for drawing outside of DRW module. */
GPUFrameBuffer *overlay_fb;
/* Color management. */
ColorManagedViewSettings view_settings;
@ -123,12 +101,6 @@ enum {
GPU_VIEWPORT_STEREO = (1 << 1),
};
static void gpu_viewport_buffers_free(
FramebufferList *fbl, int fbl_len, TextureList *txl, TextureList *txl_stereo, int txl_len);
static void gpu_viewport_storage_free(StorageList *stl, int stl_len);
static void gpu_viewport_passes_free(PassList *psl, int psl_len);
static void gpu_viewport_texture_pool_free(GPUViewport *viewport);
void GPU_viewport_tag_update(GPUViewport *viewport)
{
viewport->flag |= DO_UPDATE;
@ -144,12 +116,9 @@ bool GPU_viewport_do_update(GPUViewport *viewport)
GPUViewport *GPU_viewport_create(void)
{
GPUViewport *viewport = MEM_callocN(sizeof(GPUViewport), "GPUViewport");
viewport->fbl = MEM_callocN(sizeof(DefaultFramebufferList), "FramebufferList");
viewport->txl = MEM_callocN(sizeof(DefaultTextureList), "TextureList");
viewport->idatalist = DRW_instance_data_list_create();
viewport->do_color_management = false;
viewport->size[0] = viewport->size[1] = -1;
viewport->active_view = -1;
viewport->active_view = 0;
return viewport;
}
@ -160,343 +129,55 @@ GPUViewport *GPU_viewport_stereo_create(void)
return viewport;
}
static void gpu_viewport_framebuffer_view_set(GPUViewport *viewport, int view)
struct DRWData **GPU_viewport_data_get(GPUViewport *viewport)
{
/* Early check if the view is the latest requested. */
if (viewport->active_view == view) {
return;
}
DefaultFramebufferList *dfbl = viewport->fbl;
DefaultTextureList *dtxl = viewport->txl;
/* Only swap the texture when this is a Stereo Viewport. */
if (((viewport->flag & GPU_VIEWPORT_STEREO) != 0)) {
SWAP(GPUTexture *, dtxl->color, dtxl->color_stereo);
SWAP(GPUTexture *, dtxl->color_overlay, dtxl->color_overlay_stereo);
for (int i = 0; i < MAX_ENABLE_ENGINE; i++) {
if (viewport->engine_data[i].handle != NULL) {
ViewportEngineData *data = viewport->engine_data[i].data;
SWAP(StorageList *, data->stl, data->stl_stereo);
SWAP(TextureList *, data->txl, data->txl_stereo);
}
else {
break;
}
}
}
GPU_framebuffer_ensure_config(&dfbl->default_fb,
{
GPU_ATTACHMENT_TEXTURE(dtxl->depth),
GPU_ATTACHMENT_TEXTURE(dtxl->color),
});
GPU_framebuffer_ensure_config(&dfbl->overlay_fb,
{
GPU_ATTACHMENT_TEXTURE(dtxl->depth),
GPU_ATTACHMENT_TEXTURE(dtxl->color_overlay),
});
GPU_framebuffer_ensure_config(&dfbl->depth_only_fb,
{
GPU_ATTACHMENT_TEXTURE(dtxl->depth),
GPU_ATTACHMENT_NONE,
});
GPU_framebuffer_ensure_config(&dfbl->color_only_fb,
{
GPU_ATTACHMENT_NONE,
GPU_ATTACHMENT_TEXTURE(dtxl->color),
});
GPU_framebuffer_ensure_config(&dfbl->overlay_only_fb,
{
GPU_ATTACHMENT_NONE,
GPU_ATTACHMENT_TEXTURE(dtxl->color_overlay),
});
viewport->active_view = view;
return &viewport->draw_data;
}
void *GPU_viewport_engine_data_create(GPUViewport *viewport, void *engine_type)
static void gpu_viewport_textures_create(GPUViewport *viewport)
{
ViewportEngineData *data = MEM_callocN(sizeof(ViewportEngineData), "ViewportEngineData");
int fbl_len, txl_len, psl_len, stl_len;
DRW_engine_viewport_data_size_get(engine_type, &fbl_len, &txl_len, &psl_len, &stl_len);
data->engine_type = engine_type;
data->fbl = MEM_callocN((sizeof(void *) * fbl_len) + sizeof(FramebufferList), "FramebufferList");
data->txl = MEM_callocN((sizeof(void *) * txl_len) + sizeof(TextureList), "TextureList");
data->psl = MEM_callocN((sizeof(void *) * psl_len) + sizeof(PassList), "PassList");
data->stl = MEM_callocN((sizeof(void *) * stl_len) + sizeof(StorageList), "StorageList");
if ((viewport->flag & GPU_VIEWPORT_STEREO) != 0) {
data->txl_stereo = MEM_callocN((sizeof(void *) * txl_len) + sizeof(TextureList),
"TextureList");
data->stl_stereo = MEM_callocN((sizeof(void *) * stl_len) + sizeof(StorageList),
"StorageList");
}
for (int i = 0; i < MAX_ENABLE_ENGINE; i++) {
if (viewport->engine_data[i].handle == NULL) {
viewport->engine_data[i].handle = engine_type;
viewport->engine_data[i].data = data;
return data;
}
}
BLI_assert_msg(0, "Too many draw engines enabled at the same time");
return NULL;
}
static void gpu_viewport_engines_data_free(GPUViewport *viewport)
{
int fbl_len, txl_len, psl_len, stl_len;
for (int i = 0; i < MAX_ENABLE_ENGINE && viewport->engine_data[i].handle; i++) {
ViewportEngineData *data = viewport->engine_data[i].data;
DRW_engine_viewport_data_size_get(data->engine_type, &fbl_len, &txl_len, &psl_len, &stl_len);
gpu_viewport_buffers_free(data->fbl, fbl_len, data->txl, data->txl_stereo, txl_len);
gpu_viewport_passes_free(data->psl, psl_len);
gpu_viewport_storage_free(data->stl, stl_len);
MEM_freeN(data->fbl);
MEM_freeN(data->txl);
MEM_freeN(data->psl);
MEM_freeN(data->stl);
if ((viewport->flag & GPU_VIEWPORT_STEREO) != 0) {
gpu_viewport_storage_free(data->stl_stereo, stl_len);
MEM_freeN(data->txl_stereo);
MEM_freeN(data->stl_stereo);
}
/* We could handle this in the DRW module */
if (data->text_draw_cache) {
extern void DRW_text_cache_destroy(struct DRWTextStore * dt);
DRW_text_cache_destroy(data->text_draw_cache);
data->text_draw_cache = NULL;
}
MEM_freeN(data);
/* Mark as unused. */
viewport->engine_data[i].handle = NULL;
}
gpu_viewport_texture_pool_free(viewport);
}
void *GPU_viewport_engine_data_get(GPUViewport *viewport, void *engine_handle)
{
BLI_assert(engine_handle != NULL);
for (int i = 0; i < MAX_ENABLE_ENGINE; i++) {
if (viewport->engine_data[i].handle == engine_handle) {
return viewport->engine_data[i].data;
}
}
return NULL;
}
ViewportMemoryPool *GPU_viewport_mempool_get(GPUViewport *viewport)
{
return &viewport->vmempool;
}
struct DRWInstanceDataList *GPU_viewport_instance_data_list_get(GPUViewport *viewport)
{
return viewport->idatalist;
}
/* Note this function is only allowed to be called from `DRW_notify_view_update`. The rest
* should bind the correct viewport.
*
* The reason is that DRW_notify_view_update can be called from a different thread, but needs
* access to the engine data. */
void GPU_viewport_active_view_set(GPUViewport *viewport, int view)
{
gpu_viewport_framebuffer_view_set(viewport, view);
}
void *GPU_viewport_framebuffer_list_get(GPUViewport *viewport)
{
return viewport->fbl;
}
void *GPU_viewport_texture_list_get(GPUViewport *viewport)
{
return viewport->txl;
}
void GPU_viewport_size_get(const GPUViewport *viewport, int size[2])
{
copy_v2_v2_int(size, viewport->size);
}
/**
* Special case, this is needed for when we have a viewport without a frame-buffer output
* (occlusion queries for eg)
* but still need to set the size since it may be used for other calculations.
*/
void GPU_viewport_size_set(GPUViewport *viewport, const int size[2])
{
copy_v2_v2_int(viewport->size, size);
}
double *GPU_viewport_cache_time_get(GPUViewport *viewport)
{
return &viewport->cache_time;
}
/**
* Try to find a texture corresponding to params into the texture pool.
* If no texture was found, create one and add it to the pool.
*/
GPUTexture *GPU_viewport_texture_pool_query(
GPUViewport *viewport, void *engine, int width, int height, int format)
{
GPUTexture *tex;
LISTBASE_FOREACH (ViewportTempTexture *, tmp_tex, &viewport->tex_pool) {
if ((GPU_texture_format(tmp_tex->texture) == format) &&
(GPU_texture_width(tmp_tex->texture) == width) &&
(GPU_texture_height(tmp_tex->texture) == height)) {
/* Search if the engine is not already using this texture */
for (int i = 0; i < MAX_ENGINE_BUFFER_SHARING; i++) {
if (tmp_tex->user[i] == engine) {
break;
}
if (tmp_tex->user[i] == NULL) {
tmp_tex->user[i] = engine;
return tmp_tex->texture;
}
}
}
}
tex = GPU_texture_create_2d("temp_from_pool", width, height, 1, format, NULL);
/* Doing filtering for depth does not make sense when not doing shadow mapping,
* and enabling texture filtering on integer texture make them unreadable. */
bool do_filter = !GPU_texture_depth(tex) && !GPU_texture_integer(tex);
GPU_texture_filter_mode(tex, do_filter);
ViewportTempTexture *tmp_tex = MEM_callocN(sizeof(ViewportTempTexture), "ViewportTempTexture");
tmp_tex->texture = tex;
tmp_tex->user[0] = engine;
BLI_addtail(&viewport->tex_pool, tmp_tex);
return tex;
}
static void gpu_viewport_texture_pool_clear_users(GPUViewport *viewport)
{
ViewportTempTexture *tmp_tex_next;
for (ViewportTempTexture *tmp_tex = viewport->tex_pool.first; tmp_tex; tmp_tex = tmp_tex_next) {
tmp_tex_next = tmp_tex->next;
bool no_user = true;
for (int i = 0; i < MAX_ENGINE_BUFFER_SHARING; i++) {
if (tmp_tex->user[i] != NULL) {
tmp_tex->user[i] = NULL;
no_user = false;
}
}
if (no_user) {
GPU_texture_free(tmp_tex->texture);
BLI_freelinkN(&viewport->tex_pool, tmp_tex);
}
}
}
static void gpu_viewport_texture_pool_free(GPUViewport *viewport)
{
LISTBASE_FOREACH (ViewportTempTexture *, tmp_tex, &viewport->tex_pool) {
GPU_texture_free(tmp_tex->texture);
}
BLI_freelistN(&viewport->tex_pool);
}
/* Takes an NULL terminated array of engine_handle. Returns true is data is still valid. */
bool GPU_viewport_engines_data_validate(GPUViewport *viewport, void **engine_handle_array)
{
for (int i = 0; i < MAX_ENABLE_ENGINE && engine_handle_array[i]; i++) {
if (viewport->engine_data[i].handle != engine_handle_array[i]) {
gpu_viewport_engines_data_free(viewport);
return false;
}
}
return true;
}
void GPU_viewport_cache_release(GPUViewport *viewport)
{
for (int i = 0; i < MAX_ENABLE_ENGINE && viewport->engine_data[i].handle; i++) {
ViewportEngineData *data = viewport->engine_data[i].data;
int psl_len;
DRW_engine_viewport_data_size_get(data->engine_type, NULL, NULL, &psl_len, NULL);
gpu_viewport_passes_free(data->psl, psl_len);
}
}
static void gpu_viewport_default_fb_create(GPUViewport *viewport)
{
DefaultFramebufferList *dfbl = viewport->fbl;
DefaultTextureList *dtxl = viewport->txl;
int *size = viewport->size;
bool ok = true;
dtxl->color = GPU_texture_create_2d("dtxl_color", UNPACK2(size), 1, GPU_RGBA16F, NULL);
dtxl->color_overlay = GPU_texture_create_2d(
"dtxl_color_overlay", UNPACK2(size), 1, GPU_SRGB8_A8, NULL);
if (viewport->color_render_tx[0] == NULL) {
viewport->color_render_tx[0] = GPU_texture_create_2d(
"dtxl_color", UNPACK2(size), 1, GPU_RGBA16F, NULL);
viewport->color_overlay_tx[0] = GPU_texture_create_2d(
"dtxl_color_overlay", UNPACK2(size), 1, GPU_SRGB8_A8, NULL);
}
if (viewport->flag & GPU_VIEWPORT_STEREO) {
dtxl->color_stereo = GPU_texture_create_2d(
if ((viewport->flag & GPU_VIEWPORT_STEREO) != 0 && viewport->color_render_tx[1] == NULL) {
viewport->color_render_tx[1] = GPU_texture_create_2d(
"dtxl_color_stereo", UNPACK2(size), 1, GPU_RGBA16F, NULL);
dtxl->color_overlay_stereo = GPU_texture_create_2d(
viewport->color_overlay_tx[1] = GPU_texture_create_2d(
"dtxl_color_overlay_stereo", UNPACK2(size), 1, GPU_SRGB8_A8, NULL);
}
/* Can be shared with GPUOffscreen. */
if (dtxl->depth == NULL) {
dtxl->depth = GPU_texture_create_2d(
if (viewport->depth_tx == NULL) {
viewport->depth_tx = GPU_texture_create_2d(
"dtxl_depth", UNPACK2(size), 1, GPU_DEPTH24_STENCIL8, NULL);
}
if (!dtxl->depth || !dtxl->color) {
ok = false;
goto cleanup;
}
gpu_viewport_framebuffer_view_set(viewport, 0);
ok = ok && GPU_framebuffer_check_valid(dfbl->default_fb, NULL);
ok = ok && GPU_framebuffer_check_valid(dfbl->overlay_fb, NULL);
ok = ok && GPU_framebuffer_check_valid(dfbl->color_only_fb, NULL);
ok = ok && GPU_framebuffer_check_valid(dfbl->depth_only_fb, NULL);
ok = ok && GPU_framebuffer_check_valid(dfbl->overlay_only_fb, NULL);
cleanup:
if (!ok) {
if (!viewport->depth_tx || !viewport->color_render_tx[0] || !viewport->color_overlay_tx[0]) {
GPU_viewport_free(viewport);
DRW_opengl_context_disable();
return;
}
}
static void gpu_viewport_textures_free(GPUViewport *viewport)
{
GPU_FRAMEBUFFER_FREE_SAFE(viewport->stereo_comp_fb);
GPU_FRAMEBUFFER_FREE_SAFE(viewport->overlay_fb);
for (int i = 0; i < 2; i++) {
GPU_TEXTURE_FREE_SAFE(viewport->color_render_tx[i]);
GPU_TEXTURE_FREE_SAFE(viewport->color_overlay_tx[i]);
}
GPU_framebuffer_restore();
GPU_TEXTURE_FREE_SAFE(viewport->depth_tx);
}
void GPU_viewport_bind(GPUViewport *viewport, int view, const rcti *rect)
{
DefaultFramebufferList *dfbl = viewport->fbl;
int fbl_len, txl_len;
int rect_size[2];
/* add one pixel because of scissor test */
rect_size[0] = BLI_rcti_size_x(rect) + 1;
@ -504,39 +185,18 @@ void GPU_viewport_bind(GPUViewport *viewport, int view, const rcti *rect)
DRW_opengl_context_enable();
if (dfbl->default_fb) {
if (!equals_v2v2_int(viewport->size, rect_size)) {
gpu_viewport_buffers_free((FramebufferList *)viewport->fbl,
default_fbl_len,
(TextureList *)viewport->txl,
NULL,
default_txl_len);
for (int i = 0; i < MAX_ENABLE_ENGINE && viewport->engine_data[i].handle; i++) {
ViewportEngineData *data = viewport->engine_data[i].data;
DRW_engine_viewport_data_size_get(data->engine_type, &fbl_len, &txl_len, NULL, NULL);
gpu_viewport_buffers_free(data->fbl, fbl_len, data->txl, data->txl_stereo, txl_len);
}
gpu_viewport_texture_pool_free(viewport);
viewport->active_view = -1;
}
if (!equals_v2v2_int(viewport->size, rect_size)) {
copy_v2_v2_int(viewport->size, rect_size);
gpu_viewport_textures_free(viewport);
gpu_viewport_textures_create(viewport);
}
copy_v2_v2_int(viewport->size, rect_size);
gpu_viewport_texture_pool_clear_users(viewport);
if (!dfbl->default_fb) {
gpu_viewport_default_fb_create(viewport);
}
gpu_viewport_framebuffer_view_set(viewport, view);
viewport->active_view = view;
}
/* Should be called from DRW after DRW_opengl_context_enable. */
void GPU_viewport_bind_from_offscreen(GPUViewport *viewport, struct GPUOffScreen *ofs)
{
DefaultFramebufferList *dfbl = viewport->fbl;
DefaultTextureList *dtxl = viewport->txl;
GPUTexture *color, *depth;
GPUFrameBuffer *fb;
viewport->size[0] = GPU_offscreen_width(ofs);
@ -544,14 +204,12 @@ void GPU_viewport_bind_from_offscreen(GPUViewport *viewport, struct GPUOffScreen
GPU_offscreen_viewport_data_get(ofs, &fb, &color, &depth);
gpu_viewport_textures_free(viewport);
/* This is the only texture we can share. */
dtxl->depth = depth;
viewport->depth_tx = depth;
gpu_viewport_texture_pool_clear_users(viewport);
if (!dfbl->default_fb) {
gpu_viewport_default_fb_create(viewport);
}
gpu_viewport_textures_create(viewport);
}
void GPU_viewport_colorspace_set(GPUViewport *viewport,
@ -608,21 +266,17 @@ void GPU_viewport_stereo_composite(GPUViewport *viewport, Stereo3dFormat *stereo
* done from a single viewport. See `wm_stereo.c` */
return;
}
gpu_viewport_framebuffer_view_set(viewport, 0);
DefaultTextureList *dtxl = viewport->txl;
DefaultFramebufferList *dfbl = viewport->fbl;
/* The composite framebuffer object needs to be created in the window context. */
GPU_framebuffer_ensure_config(&dfbl->stereo_comp_fb,
GPU_framebuffer_ensure_config(&viewport->stereo_comp_fb,
{
GPU_ATTACHMENT_NONE,
GPU_ATTACHMENT_TEXTURE(dtxl->color_overlay),
GPU_ATTACHMENT_TEXTURE(dtxl->color),
GPU_ATTACHMENT_TEXTURE(viewport->color_overlay_tx[0]),
GPU_ATTACHMENT_TEXTURE(viewport->color_render_tx[0]),
});
GPUVertFormat *vert_format = immVertexFormat();
uint pos = GPU_vertformat_attr_add(vert_format, "pos", GPU_COMP_F32, 2, GPU_FETCH_FLOAT);
GPU_framebuffer_bind(dfbl->stereo_comp_fb);
GPU_framebuffer_bind(viewport->stereo_comp_fb);
GPU_matrix_push();
GPU_matrix_push_projection();
GPU_matrix_identity_set();
@ -650,8 +304,8 @@ void GPU_viewport_stereo_composite(GPUViewport *viewport, Stereo3dFormat *stereo
}
immUniform1i("stereoDisplaySettings", settings);
GPU_texture_bind(dtxl->color_stereo, 0);
GPU_texture_bind(dtxl->color_overlay_stereo, 1);
GPU_texture_bind(viewport->color_render_tx[1], 0);
GPU_texture_bind(viewport->color_overlay_tx[1], 1);
immBegin(GPU_PRIM_TRI_STRIP, 4);
@ -662,8 +316,8 @@ void GPU_viewport_stereo_composite(GPUViewport *viewport, Stereo3dFormat *stereo
immEnd();
GPU_texture_unbind(dtxl->color_stereo);
GPU_texture_unbind(dtxl->color_overlay_stereo);
GPU_texture_unbind(viewport->color_render_tx[1]);
GPU_texture_unbind(viewport->color_overlay_tx[1]);
immUnbindProgram();
GPU_matrix_pop_projection();
@ -747,14 +401,14 @@ static void gpu_viewport_batch_free(GPUViewport *viewport)
/** \} */
static void gpu_viewport_draw_colormanaged(GPUViewport *viewport,
int view,
const rctf *rect_pos,
const rctf *rect_uv,
bool display_colorspace,
bool do_overlay_merge)
{
DefaultTextureList *dtxl = viewport->txl;
GPUTexture *color = dtxl->color;
GPUTexture *color_overlay = dtxl->color_overlay;
GPUTexture *color = viewport->color_render_tx[view];
GPUTexture *color_overlay = viewport->color_overlay_tx[view];
bool use_ocio = false;
@ -808,12 +462,9 @@ void GPU_viewport_draw_to_screen_ex(GPUViewport *viewport,
bool display_colorspace,
bool do_overlay_merge)
{
gpu_viewport_framebuffer_view_set(viewport, view);
DefaultFramebufferList *dfbl = viewport->fbl;
DefaultTextureList *dtxl = viewport->txl;
GPUTexture *color = dtxl->color;
GPUTexture *color = viewport->color_render_tx[view];
if (dfbl->default_fb == NULL) {
if (color == NULL) {
return;
}
@ -854,7 +505,7 @@ void GPU_viewport_draw_to_screen_ex(GPUViewport *viewport,
}
gpu_viewport_draw_colormanaged(
viewport, &pos_rect, &uv_rect, display_colorspace, do_overlay_merge);
viewport, view, &pos_rect, &uv_rect, display_colorspace, do_overlay_merge);
}
/**
@ -877,10 +528,7 @@ void GPU_viewport_unbind_from_offscreen(GPUViewport *viewport,
bool display_colorspace,
bool do_overlay_merge)
{
DefaultFramebufferList *dfbl = viewport->fbl;
DefaultTextureList *dtxl = viewport->txl;
if (dfbl->default_fb == NULL) {
if (viewport->color_render_tx == NULL) {
return;
}
@ -902,10 +550,10 @@ void GPU_viewport_unbind_from_offscreen(GPUViewport *viewport,
};
gpu_viewport_draw_colormanaged(
viewport, &pos_rect, &uv_rect, display_colorspace, do_overlay_merge);
viewport, 0, &pos_rect, &uv_rect, display_colorspace, do_overlay_merge);
/* This one is from the offscreen. Don't free it with the viewport. */
dtxl->depth = NULL;
viewport->depth_tx = NULL;
}
void GPU_viewport_unbind(GPUViewport *UNUSED(viewport))
@ -914,149 +562,53 @@ void GPU_viewport_unbind(GPUViewport *UNUSED(viewport))
DRW_opengl_context_disable();
}
int GPU_viewport_active_view_get(GPUViewport *viewport)
{
return viewport->active_view;
}
bool GPU_viewport_is_stereo_get(GPUViewport *viewport)
{
return (viewport->flag & GPU_VIEWPORT_STEREO) != 0;
}
GPUTexture *GPU_viewport_color_texture(GPUViewport *viewport, int view)
{
DefaultFramebufferList *dfbl = viewport->fbl;
if (dfbl->default_fb) {
DefaultTextureList *dtxl = viewport->txl;
if (viewport->active_view == view) {
return dtxl->color;
}
return dtxl->color_stereo;
}
return NULL;
return viewport->color_render_tx[view];
}
static void gpu_viewport_buffers_free(
FramebufferList *fbl, int fbl_len, TextureList *txl, TextureList *txl_stereo, int txl_len)
GPUTexture *GPU_viewport_overlay_texture(GPUViewport *viewport, int view)
{
for (int i = 0; i < fbl_len; i++) {
GPUFrameBuffer *fb = fbl->framebuffers[i];
if (fb) {
GPU_framebuffer_free(fb);
fbl->framebuffers[i] = NULL;
}
}
for (int i = 0; i < txl_len; i++) {
GPUTexture *tex = txl->textures[i];
if (tex) {
GPU_texture_free(tex);
txl->textures[i] = NULL;
}
}
if (txl_stereo != NULL) {
for (int i = 0; i < txl_len; i++) {
GPUTexture *tex = txl_stereo->textures[i];
if (tex) {
GPU_texture_free(tex);
txl_stereo->textures[i] = NULL;
}
}
}
return viewport->color_overlay_tx[view];
}
static void gpu_viewport_storage_free(StorageList *stl, int stl_len)
GPUTexture *GPU_viewport_depth_texture(GPUViewport *viewport)
{
for (int i = 0; i < stl_len; i++) {
void *storage = stl->storage[i];
if (storage) {
MEM_freeN(storage);
stl->storage[i] = NULL;
}
}
return viewport->depth_tx;
}
static void gpu_viewport_passes_free(PassList *psl, int psl_len)
/* Overlay framebuffer for drawing outside of DRW module. */
GPUFrameBuffer *GPU_viewport_framebuffer_overlay_get(GPUViewport *viewport)
{
memset(psl->passes, 0, sizeof(*psl->passes) * psl_len);
GPU_framebuffer_ensure_config(&viewport->overlay_fb,
{
GPU_ATTACHMENT_TEXTURE(viewport->depth_tx),
GPU_ATTACHMENT_TEXTURE(viewport->color_overlay_tx[0]),
});
return viewport->overlay_fb;
}
/* Must be executed inside Draw-manager OpenGL Context. */
void GPU_viewport_free(GPUViewport *viewport)
{
gpu_viewport_engines_data_free(viewport);
gpu_viewport_buffers_free((FramebufferList *)viewport->fbl,
default_fbl_len,
(TextureList *)viewport->txl,
NULL,
default_txl_len);
gpu_viewport_texture_pool_free(viewport);
MEM_freeN(viewport->fbl);
MEM_freeN(viewport->txl);
if (viewport->vmempool.commands != NULL) {
BLI_memblock_destroy(viewport->vmempool.commands, NULL);
}
if (viewport->vmempool.commands_small != NULL) {
BLI_memblock_destroy(viewport->vmempool.commands_small, NULL);
}
if (viewport->vmempool.callbuffers != NULL) {
BLI_memblock_destroy(viewport->vmempool.callbuffers, NULL);
}
if (viewport->vmempool.obmats != NULL) {
BLI_memblock_destroy(viewport->vmempool.obmats, NULL);
}
if (viewport->vmempool.obinfos != NULL) {
BLI_memblock_destroy(viewport->vmempool.obinfos, NULL);
}
if (viewport->vmempool.cullstates != NULL) {
BLI_memblock_destroy(viewport->vmempool.cullstates, NULL);
}
if (viewport->vmempool.shgroups != NULL) {
BLI_memblock_destroy(viewport->vmempool.shgroups, NULL);
}
if (viewport->vmempool.uniforms != NULL) {
BLI_memblock_destroy(viewport->vmempool.uniforms, NULL);
}
if (viewport->vmempool.views != NULL) {
BLI_memblock_destroy(viewport->vmempool.views, NULL);
}
if (viewport->vmempool.passes != NULL) {
BLI_memblock_destroy(viewport->vmempool.passes, NULL);
}
if (viewport->vmempool.images != NULL) {
BLI_memblock_iter iter;
GPUTexture **tex;
BLI_memblock_iternew(viewport->vmempool.images, &iter);
while ((tex = BLI_memblock_iterstep(&iter))) {
GPU_texture_free(*tex);
}
BLI_memblock_destroy(viewport->vmempool.images, NULL);
}
if (viewport->vmempool.obattrs_ubo_pool != NULL) {
DRW_uniform_attrs_pool_free(viewport->vmempool.obattrs_ubo_pool);
if (viewport->draw_data) {
DRW_viewport_data_free(viewport->draw_data);
}
for (int i = 0; i < viewport->vmempool.ubo_len; i++) {
GPU_uniformbuf_free(viewport->vmempool.matrices_ubo[i]);
GPU_uniformbuf_free(viewport->vmempool.obinfos_ubo[i]);
}
MEM_SAFE_FREE(viewport->vmempool.matrices_ubo);
MEM_SAFE_FREE(viewport->vmempool.obinfos_ubo);
DRW_instance_data_list_free(viewport->idatalist);
MEM_freeN(viewport->idatalist);
gpu_viewport_textures_free(viewport);
BKE_color_managed_view_settings_free(&viewport->view_settings);
gpu_viewport_batch_free(viewport);
MEM_freeN(viewport);
}
GPUFrameBuffer *GPU_viewport_framebuffer_default_get(GPUViewport *viewport)
{
DefaultFramebufferList *fbl = GPU_viewport_framebuffer_list_get(viewport);
return fbl->default_fb;
}
GPUFrameBuffer *GPU_viewport_framebuffer_overlay_get(GPUViewport *viewport)
{
DefaultFramebufferList *fbl = GPU_viewport_framebuffer_list_get(viewport);
return fbl->overlay_fb;
}