bartvdbraak/blender
1
0
Fork 4
Code Issues 4 Pull Requests 1 Actions 1 Packages Projects Releases Wiki Activity

Cleanup: Return early in BKE_pose_minmax

Browse Source 
Reduce cognitive complexity by returning early in `BKE_pose_minmax()`.

Also rename `changed` to `found_pchan`, as that explains better what's
being tracked.

No functional changes.
This commit is contained in:
Sybren A. Stüvel 2024-05-13 14:39:40 +02:00
parent b4cc9329e5
commit 81d73881ca
1 changed files with 23 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
source/blender/blenkernel/intern/armature.cc
View File

@ -3090,29 +3090,31 @@ void BKE_pchan_minmax(const Object *ob,
bool BKE_pose_minmax(const Object *ob, float r_min[3], float r_max[3], bool use_select)
{
bool changed = false;
if (ob->pose) {
const bArmature *arm = static_cast<const bArmature *>(ob->data);
LISTBASE_FOREACH (const bPoseChannel *, pchan, &ob->pose->chanbase) {
/* XXX pchan->bone may be nullptr for duplicated bones, see duplicateEditBoneObjects()
* comment (editarmature.c:2592)... Skip in this case too! */
if (!pchan->bone) {
continue;
}
if (!PBONE_VISIBLE(arm, pchan->bone)) {
continue;
}
if (use_select && !(pchan->bone->flag & BONE_SELECTED)) {
continue;
}
BKE_pchan_minmax(ob, pchan, false, r_min, r_max);
changed = true;
}
if (!ob->pose) {
return false;
}
return changed;
BLI_assert(ob->type == OB_ARMATURE);
const bArmature *arm = static_cast<const bArmature *>(ob->data);
bool found_pchan = false;
LISTBASE_FOREACH (const bPoseChannel *, pchan, &ob->pose->chanbase) {
/* XXX pchan->bone may be nullptr for duplicated bones, see duplicateEditBoneObjects()
* comment (editarmature.c:2592)... Skip in this case too! */
if (!pchan->bone) {
continue;
}
if (!PBONE_VISIBLE(arm, pchan->bone)) {
continue;
}
if (use_select && !(pchan->bone->flag & BONE_SELECTED)) {
continue;
}
BKE_pchan_minmax(ob, pchan, false, r_min, r_max);
found_pchan = true;
}
return found_pchan;
}
/** \} */