bartvdbraak/blender
1
0
Fork 4
Code Issues 4 Pull Requests 1 Actions 1 Packages Projects Releases Wiki Activity

Fix #120763: Fix memory leak in itasc cache

Browse Source 
`Cache::addChannel` would return early when new cache entry insertion
isn't success, but the newly created cache entry isn't deleted upon
return, this patch fixes this.

Pull Request: https://projects.blender.org/blender/blender/pulls/120766
This commit is contained in:
YimingWu 2024-04-24 09:35:04 +02:00 committed by YimingWu
parent 7f2c0311fc
commit ab72da8b5c
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
intern/itasc/Cache.cpp
View File

@ -214,8 +214,10 @@ int Cache::addChannel(const void *device, const char *name, unsigned int maxItem
entry = new CacheEntry();
if (entry == NULL)
return -1;
if (!m_cache.insert(CacheMap::value_type(device,entry)).second)
if (!m_cache.insert(CacheMap::value_type(device,entry)).second) {
delete entry;
return -1;
}
} else {
entry = it->second;
}