bartvdbraak/blender
1
0
Fork 4
Code Issues 4 Pull Requests 1 Actions 1 Packages Projects Releases Wiki Activity

Fix for fix for the bugfix :)

Browse Source 
Just cleaned the code/order here and added comments why this works.
I should have known it... thanks Andrea for quick action!
This commit is contained in:
Ton Roosendaal 2011-04-21 09:43:38 +00:00
parent 20d3022076
commit c605091b09
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
source/blender/windowmanager/intern/wm_event_system.c
View File

@ -1537,15 +1537,11 @@ static int wm_handlers_do(bContext *C, wmEvent *event, ListBase *handlers)
}
}
/* modal ui handler can be tagged to be freed */
/* XXX TODO - handler was free'd in wm_handler_ui_call
and memory could be written to in BLI_remlink.
As temporary solution preventing this by
making sure handler is still in the list.
*/
/* XXX code this for all modal ops, and ensure free only happens here */
if(handler->flag & WM_HANDLER_DO_FREE) {
if (BLI_findindex(handlers, handler) >= 0) {
/* modal ui handler can be tagged to be freed */
if(BLI_findindex(handlers, handler) != -1) { /* could be free'd already by regular modal ops */
if(handler->flag & WM_HANDLER_DO_FREE) {
BLI_remlink(handlers, handler);
wm_event_free_handler(handler);
}