bartvdbraak/blender
1
0
Fork 4
Code Issues 4 Pull Requests 1 Actions 1 Packages Projects Releases Wiki Activity

Curves: add toggle cyclic edit mode operator

Browse Source 
This operator also exists in legacy edit mode and allows changing
whether the curve is cyclic. If all curves are non-cyclic, the attribute
is removed because it does not contain any useful information.

Pull Request: https://projects.blender.org/blender/blender/pulls/120266
This commit is contained in:
Jacques Lucke 2024-04-04 19:39:14 +02:00
parent 68d948efb9
commit d315a6a793
3 changed files with 47 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
scripts/presets/keyconfig/keymap_data/blender_default.py
View File

@ -6142,6 +6142,7 @@ def km_edit_curves(params):
(op_tool_cycle, "builtin.tilt"), params),
("transform.transform", {"type": 'S', "value": 'PRESS', "alt": True},
{"properties": [("mode", 'CURVE_SHRINKFATTEN')]}),
("curves.cyclic_toggle", {"type": 'C', "value": 'PRESS', "alt": True}, None),
])
return keymap

1
scripts/startup/bl_ui/space_view3d.py
View File

@ -5911,6 +5911,7 @@ class VIEW3D_MT_edit_curves(Menu):
layout.separator()
layout.operator("curves.attribute_set")
layout.operator("curves.delete")
layout.operator("curves.cyclic_toggle")
layout.template_node_operator_asset_menu_items(catalog_path=self.bl_label)

45
source/blender/editors/curves/intern/curves_ops.cc
View File

@ -1339,6 +1339,50 @@ static void CURVES_OT_tilt_clear(wmOperatorType *ot)
ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
}
namespace cyclic_toggle {
static int exec(bContext *C, wmOperator * /*op*/)
{
for (Curves *curves_id : get_unique_editable_curves(*C)) {
bke::CurvesGeometry &curves = curves_id->geometry.wrap();
IndexMaskMemory memory;
const IndexMask selection = retrieve_selected_curves(*curves_id, memory);
if (selection.is_empty()) {
continue;
}
bke::MutableAttributeAccessor attributes = curves.attributes_for_write();
bke::SpanAttributeWriter<bool> cyclic = attributes.lookup_or_add_for_write_span<bool>(
"cyclic", bke::AttrDomain::Curve);
selection.foreach_index(GrainSize(4096),
[&](const int i) { cyclic.span[i] = !cyclic.span[i]; });
cyclic.finish();
if (!cyclic.span.as_span().contains(true)) {
attributes.remove("cyclic");
}
DEG_id_tag_update(&curves_id->id, ID_RECALC_GEOMETRY);
WM_event_add_notifier(C, NC_GEOM | ND_DATA, curves_id);
}
return OPERATOR_FINISHED;
}
} // namespace cyclic_toggle
static void CURVES_OT_cyclic_toggle(wmOperatorType *ot)
{
ot->name = "Toggle Cyclic";
ot->idname = __func__;
ot->description = "Make active curve closed/opened loop";
ot->exec = cyclic_toggle::exec;
ot->poll = editable_curves_in_edit_mode_poll;
ot->flag = OPTYPE_REGISTER | OPTYPE_UNDO;
}
void operatortypes_curves()
{
WM_operatortype_append(CURVES_OT_attribute_set);
@ -1358,6 +1402,7 @@ void operatortypes_curves()
WM_operatortype_append(CURVES_OT_delete);
WM_operatortype_append(CURVES_OT_duplicate);
WM_operatortype_append(CURVES_OT_tilt_clear);
WM_operatortype_append(CURVES_OT_cyclic_toggle);
}
void operatormacros_curves()