68a76c3c77
The issue was caused by an integer overflow in the `FFMPEGReader::seek`, which lead to different results depending on an exact compiler version and platform. The overflow happened in the equation which calculates `m_position`, in its `packet.pts - st_time` part, which is effectively `int64_t - uint64_t` which is expected to result in `uint64_t` due to the way how upcasting works in C++. With the values `packet.pts=0` and `st_time=353600` from the test file the calculation resulted in a negative value, which then wrapped around due to the unsigned nature of the type, resulting in very big value on arm64. The value was wrong, but it did not manifest itself as an error, since the seek code believed it found the place. However, when built on x86 platform, the result value was very large negative value. It is possible that the type upcasting went different, due to the multiplication with a double value later in the formula. And this large negative value lead to the seeking code to read the entire file, trying to make it so the `m_position` is not less than the requested position. Fortunately, the `AVStream::start_time` is `int64_t`, which leads to a simple fix which avoids signed/unsigned cast, making the seeking code to properly calculate `m_position` on both arm64 and x64 platforms, regardless of the compiler. Pull Request: https://projects.blender.org/blender/blender/pulls/122149 |
||
|---|---|---|
| .. | ||
| audaspace | ||
| binreloc | ||
| bullet2 | ||
| ceres | ||
| cuew | ||
| curve_fit_nd | ||
| draco | ||
| Eigen3 | ||
| fast_float | ||
| fmtlib | ||
| gflags | ||
| glew-es/include/GL | ||
| glog | ||
| gmock | ||
| gtest | ||
| hipew | ||
| json | ||
| lzma | ||
| lzo | ||
| mantaflow | ||
| nanosvg | ||
| quadriflow | ||
| rangetree | ||
| renderdoc | ||
| sdlew | ||
| tinygltf | ||
| vulkan_memory_allocator | ||
| wcwidth | ||
| xdnd | ||
| xxhash | ||
| .clang-format | ||
| CMakeLists.txt | ||
| README | ||
When updating a library remember to: * Update the README.blender with the corresponding version.