drsybren/Flamenco
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Manager: disable GZip middleware, as it causes some issues

Browse Source 
Apparently a "204 No Content" response will still get GZip-compressed.
This commit is contained in:
Sybren A. Stüvel 2022-03-25 16:09:31 +01:00
parent 6c827ffc52
commit 2f0b77f45b
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
cmd/flamenco-manager/main.go
View File

@ -158,7 +158,18 @@ func buildWebService(
// Ensure panics when serving a web request won't bring down the server.
e.Use(middleware.Recover())
e.Use(middleware.Gzip())
// Disabled, as it causes issues with "204 No Content" responses.
// TODO: investigate & file a bug report. Adding the check on an empty slice
// seems to fix it:
//
// func (w *gzipResponseWriter) Write(b []byte) (int, error) {
// if len(b) == 0 {
// return 0, nil
// }
// ... original code of the function ...
// }
// e.Use(middleware.Gzip())
// Load the API definition and enable validation & authentication checks.
swagger, err := api.GetSwagger()