drsybren/Flamenco
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Web: document cohesion of JobsTable and JobDetails components

Browse Source
This commit is contained in:
Sybren A. Stüvel 2022-04-12 15:42:37 +02:00
parent 316ba6953b
commit 48acf55d6b
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
web/app/src/components/JobDetails.vue
View File

@ -72,7 +72,10 @@ export default {
jobSummary(newSummary, oldSummary) {
console.log("Updating job details:", JSON.parse(JSON.stringify(newSummary)));
this.jobData = newSummary;
// TODO: Fetch the rest of the job.
// TODO later: Fetch the rest of the job. This isn't necessary now,
// because the jobs table already performs the fetch and the "summary" is
// actually the entire job. If this changes, this is the place to trigger
// an actual fetch.
},
},
methods: {

5
web/app/src/components/JobsTable.vue
View File

@ -88,7 +88,10 @@ export default {
},
processNewJob(jobUpdate) {
console.log("processNewJob:", jobUpdate);
// The update doesn't have all the info we need, so just fetch the job via an API call.
// The update doesn't have all the info we need, so just fetch the job via
// an API call. If this is ever changed, and the jobUpdate does have
// everything needed for this table, JobDetails.vue also needs to be
// adjusted for this.
const jobsApi = new JobsApi(this.apiClient);
jobsApi.fetchJob(jobUpdate.id).then((job) => {
console.log('API called successfully. Returned data: ' + job);