emansije/kube-metrics-adapter
1
0
Fork 0
forked from yusheng-guo/kube-metrics-adapter
Code Pull Requests Activity

Reverted error check to errors.Is(), implemented Is() method for PluginNotFoundError

Browse Source 
Signed-off-by: Anatolii Dutchak <adutchak-x@tunein.com>
This commit is contained in:
Anatolii Dutchak
2021-04-12 21:45:16 +03:00
parent a8ff0ed6f0
commit 188cc91574
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/collector/collector.go
View File

@ -61,6 +61,12 @@ func (p *PluginNotFoundError) Error() string {
return fmt.Sprintf("no plugin found for %s", p.metricTypeName)
}
func (p *PluginNotFoundError) Is(target error) bool {
t, ok := target.(*PluginNotFoundError)
_ = t
return ok
}
func (c *CollectorFactory) RegisterPodsCollector(metricCollector string, plugin CollectorPlugin) error {
if metricCollector == "" {
c.podsPlugins.Any = plugin

6
pkg/provider/hpa.go
View File

@ -161,10 +161,8 @@ func (p *HPAProvider) updateHPAs() error {
c, err := p.collectorFactory.NewCollector(&hpa, config, interval)
if err != nil {
// Only log when it's not a PluginNotFoundError AND flag disregardIncompatibleHPAs is true
var pluginNotFoundError *collector.PluginNotFoundError
if !(errors.As(err, &pluginNotFoundError) && p.disregardIncompatibleHPAs) {
// Only log when it's not a PluginNotFoundError AND flag disregardIncompatibleHPAs is true
if !(errors.Is(err, &collector.PluginNotFoundError{}) && p.disregardIncompatibleHPAs) {
p.recorder.Eventf(&hpa, apiv1.EventTypeWarning, "CreateNewMetricsCollector", "Failed to create new metrics collector: %v", err)
}