mirror of
https://github.com/conan-io/conan-center-index.git
synced 2025-08-10 00:11:44 +00:00
7b1f1a25c8
* linter: do not accept version attribute Signed-off-by: Uilian Ries <uilianries@gmail.com> * Fix error number Signed-off-by: Uilian Ries <uilianries@gmail.com> * allow system version Signed-off-by: Uilian Ries <uilianries@gmail.com> * Add better doc Signed-off-by: Uilian Ries <uilianries@gmail.com> --------- Signed-off-by: Uilian Ries <uilianries@gmail.com>
34 lines
1.2 KiB
Python
34 lines
1.2 KiB
Python
from pylint.checkers import BaseChecker
|
|
from pylint.interfaces import IAstroidChecker
|
|
from astroid import nodes, Const, AssignName
|
|
|
|
|
|
class VersionAttribute(BaseChecker):
|
|
"""
|
|
All packages should not enforce a specific version in the recipe
|
|
"""
|
|
|
|
__implements__ = IAstroidChecker
|
|
|
|
name = "conan-attr-version"
|
|
msgs = {
|
|
"E9014": (
|
|
"Recipe should not contain version attribute",
|
|
"conan-forced-version",
|
|
"Do not enforce a specific version in your recipe. Keep it generic for any version."
|
|
),
|
|
}
|
|
|
|
def visit_classdef(self, node: nodes) -> None:
|
|
if node.basenames == ['ConanFile']:
|
|
for attr in node.body:
|
|
children = list(attr.get_children())
|
|
if len(children) == 2 and \
|
|
isinstance(children[0], AssignName) and \
|
|
children[0].name == "version" and \
|
|
isinstance(children[1], Const):
|
|
value = children[1].as_string().replace('"', "").replace("'", "")
|
|
if value and value != "system":
|
|
self.add_message("conan-forced-version", node=attr, line=attr.lineno)
|
|
return
|