hiifong/act_runner
1
0 Fork 0
Code Issues 183 Pull Requests 10 Actions Packages Projects Releases 22 Wiki Activity

refactor(register): refactor registration functions and improve logging #288

Merged
appleboy merged 1 commits from refs/pull/288/head into main 2023-07-12 14:12:18 +00:00
Conversation 2 Commits 1 Files Changed 1
+468 -801
appleboy commented 2023-07-12 14:10:49 +00:00 (Migrated from gitea.com)
Copy link
Copy source
  • Remove the else clause in the registerInteractive function, and unconditionally log "Runner registered successfully."
  • Change the return value in the doRegister function from nil to ctx.Err().

Signed-off-by: Bo-Yi Wu appleboy.tw@gmail.com

- Remove the else clause in the `registerInteractive` function, and unconditionally log "Runner registered successfully." - Change the return value in the `doRegister` function from `nil` to `ctx.Err()`. Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
lunny (Migrated from gitea.com) reviewed 2023-07-12 14:11:14 +00:00
lunny (Migrated from gitea.com) approved these changes 2023-07-12 14:11:59 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
lunny
Labels
Clear labels
kind/bug
Something is not working
 kind/build
kind/compatible
kind/dependencies
kind/docs
kind/enhancement
New feature
 kind/feature
kind/help wanted
Need some help
 kind/proposal
kind/refactor
related/act
Related to act.
 related/environment
Related to the environment.
 related/exec
related/gitea
Related to Gitea.
 related/workflow
Related to the workflow file or actions scripts.
 reviewed/confirmed
confirmed issue
 reviewed/duplicate
This issue or pull request already exists
 reviewed/invalid
Something is wrong
 reviewed/needs feedback
reviewed/wontfix
This won't be fixed
 reviewed/workaround
No labels kind/refactor
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
hiifong
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: hiifong/act_runner#288