Add CLI flag for specifying the Docker image to use. #83

Merged
telackey merged 3 commits from refs/pull/83/head into main 2023-03-29 01:42:53 +00:00
telackey commented 2023-03-27 18:04:09 +00:00 (Migrated from gitea.com)

Since the exec command does not use labels from .runner, there is no existing way to specify which Docker image to use for task execution.

This adds an --image flag for specifying it manually. The default remains node:16-bullseye.

Since the `exec` command does not use labels from `.runner`, there is no existing way to specify which Docker image to use for task execution. This adds an `--image` flag for specifying it manually. The default remains `node:16-bullseye`.
lunny commented 2023-03-28 00:13:24 +00:00 (Migrated from gitea.com)

Oh, maybe we should still have labels containers mapping?

Oh, maybe we should still have labels containers mapping?
wolfogre commented 2023-03-28 03:46:43 +00:00 (Migrated from gitea.com)

Oh, maybe we should still have labels containers mapping?

I don't think so, unlike daemon, a flag is enough for exec. The user may want to test the same job on different images, so it will be convenient to use a single flag.

> Oh, maybe we should still have labels containers mapping? I don't think so, unlike `daemon`, a flag is enough for `exec`. The user may want to test the same job on different images, so it will be convenient to use a single flag.
wolfogre (Migrated from gitea.com) approved these changes 2023-03-28 03:47:12 +00:00
lunny (Migrated from gitea.com) approved these changes 2023-03-28 15:29:02 +00:00
telackey commented 2023-03-29 01:12:55 +00:00 (Migrated from gitea.com)

I do not have the approval to merge, but if someone else would like to do it, sounds good to me.

I do not have the approval to merge, but if someone else would like to do it, sounds good to me.
Sign in to join this conversation.