forked from phoedos/pmd
[java] ImmutableField: False positive with lombok (fixes #4254)
This commit is contained in:
@ -32,7 +32,7 @@ import net.sourceforge.pmd.util.CollectionUtil;
|
|||||||
public class ImmutableFieldRule extends AbstractJavaRulechainRule {
|
public class ImmutableFieldRule extends AbstractJavaRulechainRule {
|
||||||
|
|
||||||
private static final PropertyDescriptor<List<String>> IGNORED_ANNOTS =
|
private static final PropertyDescriptor<List<String>> IGNORED_ANNOTS =
|
||||||
JavaPropertyUtil.ignoredAnnotationsDescriptor();
|
JavaPropertyUtil.ignoredAnnotationsDescriptor("lombok.Getter", "lombok.Setter");
|
||||||
|
|
||||||
private static final Set<String> INVALIDATING_CLASS_ANNOT =
|
private static final Set<String> INVALIDATING_CLASS_ANNOT =
|
||||||
setOf(
|
setOf(
|
||||||
|
@ -415,7 +415,7 @@ public class CombinersTest {
|
|||||||
</test-code>
|
</test-code>
|
||||||
|
|
||||||
<test-code>
|
<test-code>
|
||||||
<description>#410 [java] ImmutableField: False positive with lombok</description>
|
<description>#410 [java] ImmutableField: False positive with lombok on class</description>
|
||||||
<expected-problems>0</expected-problems>
|
<expected-problems>0</expected-problems>
|
||||||
<code><![CDATA[
|
<code><![CDATA[
|
||||||
import lombok.Getter;
|
import lombok.Getter;
|
||||||
@ -433,6 +433,25 @@ public class Foo {
|
|||||||
]]></code>
|
]]></code>
|
||||||
</test-code>
|
</test-code>
|
||||||
|
|
||||||
|
<test-code>
|
||||||
|
<description>#410 [java] ImmutableField: False positive with lombok on field</description>
|
||||||
|
<expected-problems>0</expected-problems>
|
||||||
|
<code><![CDATA[
|
||||||
|
import lombok.Getter;
|
||||||
|
import lombok.Setter;
|
||||||
|
|
||||||
|
public class Foo {
|
||||||
|
@Getter
|
||||||
|
@Setter
|
||||||
|
private String id;
|
||||||
|
|
||||||
|
public Foo(String id) {
|
||||||
|
this.id = id;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
]]></code>
|
||||||
|
</test-code>
|
||||||
|
|
||||||
<test-code>
|
<test-code>
|
||||||
<description>#855 [java] ImmutableField: False positive within lambda</description>
|
<description>#855 [java] ImmutableField: False positive within lambda</description>
|
||||||
<expected-problems>0</expected-problems>
|
<expected-problems>0</expected-problems>
|
||||||
|
Reference in New Issue
Block a user