hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

[java] ImmutableField: False positive with lombok (fixes #4254)

Browse Source
This commit is contained in:
Pim van der Loos
2023-04-15 14:21:29 +02:00
parent 175d4498d8
commit 0a99c28bef
2 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/design/ImmutableFieldRule.java
View File

@ -32,7 +32,7 @@ import net.sourceforge.pmd.util.CollectionUtil;
public class ImmutableFieldRule extends AbstractJavaRulechainRule {
private static final PropertyDescriptor<List<String>> IGNORED_ANNOTS =
JavaPropertyUtil.ignoredAnnotationsDescriptor();
JavaPropertyUtil.ignoredAnnotationsDescriptor("lombok.Getter", "lombok.Setter");
private static final Set<String> INVALIDATING_CLASS_ANNOT =
setOf(

21
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/design/xml/ImmutableField.xml
View File

@ -415,7 +415,7 @@ public class CombinersTest {
</test-code>
<test-code>
<description>#410 [java] ImmutableField: False positive with lombok</description>
<description>#410 [java] ImmutableField: False positive with lombok on class</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
import lombok.Getter;
@ -433,6 +433,25 @@ public class Foo {
]]></code>
</test-code>
<test-code>
<description>#410 [java] ImmutableField: False positive with lombok on field</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
import lombok.Getter;
import lombok.Setter;
public class Foo {
@Getter
@Setter
private String id;
public Foo(String id) {
this.id = id;
}
}
]]></code>
</test-code>
<test-code>
<description>#855 [java] ImmutableField: False positive within lambda</description>
<expected-problems>0</expected-problems>