hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

making field private and adding missing @Override

Browse Source 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/branches/pmd/4.2.x@6979 51baf565-9d33-0410-a72c-fc3788e3496d
This commit is contained in:
Romain Pelisse 2009-08-15 17:19:47 +00:00
parent 73ebf2603a
commit 0b60a2d6ff
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pmd/src/net/sourceforge/pmd/rules/DoubleCheckedLocking.java
View File

@ -47,8 +47,9 @@ import net.sourceforge.pmd.ast.Node;
*/
public class DoubleCheckedLocking extends AbstractJavaRule {
List<String> volatileFields;
private List<String> volatileFields;
@Override
public Object visit(ASTCompilationUnit compilationUnit, Object data) {
if ( volatileFields == null ) {
volatileFields = new ArrayList<String>(0);
@ -58,6 +59,7 @@ public class DoubleCheckedLocking extends AbstractJavaRule {
return super.visit(compilationUnit, data);
}
@Override
public Object visit(ASTClassOrInterfaceDeclaration node, Object data) {
if (node.isInterface()) {
return data;
@ -65,6 +67,7 @@ public class DoubleCheckedLocking extends AbstractJavaRule {
return super.visit(node, data);
}
@Override
public Object visit(ASTFieldDeclaration fieldDeclaration, Object data) {
if ( fieldDeclaration.isVolatile() ) {
List<ASTVariableDeclaratorId> declarators = fieldDeclaration.findChildrenOfType(ASTVariableDeclaratorId.class);
@ -75,6 +78,7 @@ public class DoubleCheckedLocking extends AbstractJavaRule {
return super.visit(fieldDeclaration, data);
}
@Override
public Object visit(ASTMethodDeclaration node, Object data) {
if (node.getResultType().isVoid()) {
return super.visit(node, data);